From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 363C82C2F
 for <dev@dpdk.org>; Tue, 24 Apr 2018 21:53:41 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id ABCA4219AA;
 Tue, 24 Apr 2018 15:53:40 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Tue, 24 Apr 2018 15:53:40 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=CN3UrP7qQ8C/oY3364ZNqIhGMu
 vLsByrPaLX4TU5I4w=; b=sbDDKXCoFal4c4Uip5WRmlOKnr4U7ug7b/94H6o/N/
 BboMJqd9o81UYphSv0anWT++uvR3q2tkBJK3It+uXf30YoFxbWHjmGtwbPBk60C6
 qA2klpi2uKjOw6hPrbweB07DFXnHTSg5kQlHBOtgkNC5q3taEY7QRKHxrAbxNMDY
 c=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=CN3UrP
 7qQ8C/oY3364ZNqIhGMuvLsByrPaLX4TU5I4w=; b=Q6VZ6Jjj6AIW8FgpRneq1q
 m5yl4s9ne0lO9QkQpJU5DYiScUzZpmrQ5tBbnFa0gK736y3nW1ESAc5SqfvhdX2O
 VK/LBw1tnrtELqx9s41U7+KSn2GGL1nPy9kNw0DE5ZgNA7auV2NF0NC3Oq8opnQh
 vOT/xKkbQ5U3bv7kqf1Y7cJRbeaiid+fGgA8B9ubNBD7ktAXB7DPgOuesCfKeGYH
 zHetULwle9xWhLQerUpHQAeSNueAfwfkeQLxFUrU6hNq/G+6KlULrZKqB3enfWqh
 DouuP1DQE7FfMjbvXPjW+qZqH/f2ooAV9R/6MSpAD9iKzzkzZPXgcHY/oMc8iFbQ
 ==
X-ME-Sender: <xms:RIvfWs40xHv93GnegK4VT-gHpjxsEDpNCu4EP1pEDDUmyf9wS6gpGg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id B1558E4B94;
 Tue, 24 Apr 2018 15:53:39 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Declan Doherty <declan.doherty@intel.com>,
 Remy Horton <remy.horton@intel.com>
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>, Shahaf Shuler <shahafs@mellanox.com>
Date: Tue, 24 Apr 2018 21:53:38 +0200
Message-ID: <1794949.DGStqB9iLD@xps>
In-Reply-To: <20180416130605.6509-7-declan.doherty@intel.com>
References: <20180328135433.20203-1-declan.doherty@intel.com>
 <20180416130605.6509-1-declan.doherty@intel.com>
 <20180416130605.6509-7-declan.doherty@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v7 6/9] ethdev: add common devargs parser
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Apr 2018 19:53:41 -0000

16/04/2018 15:06, Declan Doherty:
> From: Remy Horton <remy.horton@intel.com>
> 
> Introduces a new structure, rte_eth_devargs, to support generic
> ethdev arguments common across NET PMDs, with a new API
> rte_eth_devargs_parse API to support PMD parsing these arguments.

Most of the parsing functions should be removed when the new devargs
framework will be ready.
So I won't look specifically at this code.

But I would like to review the devargs you are standardizing.
Unfortunately, I cannot find a documentation about it.
How users are supposed to use it?
Can you, at least, describe the syntax in the commit log, please?