From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E2D243BA0; Fri, 23 Feb 2024 10:29:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4A944068A; Fri, 23 Feb 2024 10:29:17 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2085.outbound.protection.outlook.com [40.107.243.85]) by mails.dpdk.org (Postfix) with ESMTP id E0E91402ED for ; Fri, 23 Feb 2024 10:29:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WXD+bfF9b2vU1ID6qVimf8xGbqWzlC2f5zqBoKK/9qTrFAMLW36Z41CXoW+Jki2RpFi1HMdCyXr6+GjZcOn+3BXyr+z2nc2wBS3+7HxWK5Ckm6RGROqN3yDakBapzppuPzpa4l93DS/T73TZN0vsYzgNhD8VCuGX2Ebqd+c5by2CX48CzOVJddJ/TL4QuYVr5Z9zb/H1RCxmjagS0BBf1cuG7j9tdZwhdz6s7bmDuxXlNf162SGkvNp71HWpim/Jp1+U5rOdxScz515LzRCvyiOBB+LX0e9fD/WtZcxpk/itCacJGcNQNrhXAfgTW3P7rDSdzHq6Q8sv8eLoJf63wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=699etkBHgHEFeYSs4bC9QpZcmvIgtP6Tvkg26Mms/cc=; b=dUYBzYyj/ePwyewJPBaov3YS4ZdLClLEfcu/ycKHWtaQ+K6mZkaGUXlErqgFKld7AdTfeYMVpahwhDpIiYQcwvDsmwa1gofb46msYzrw0KJiqqgMi6QVyfEfITjsAWX8GmrnB9Swy/lXIQnn1zTahsz7joVgMAiWnMc8eKZ8+Bi/tFbbaklkQlYX9BchFg8O4vPcy20vFOYUUZa9pMCw5/WUDQrb/mS6OUMEPfbgGVzbDk+tWFX+87kuCAOveDHttnwTRVovBuunzuQ9taPwkMFKI+dzs5ow3VMgvhFJ6t6yPlsrmUxcUJvc80vCqvyIerOQewucSwIYvJTfVSER5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=699etkBHgHEFeYSs4bC9QpZcmvIgtP6Tvkg26Mms/cc=; b=EhuxwEryYm7ybSPHLyrhFXIU2GnxVlgY9LSVenBMsuI7iwVI4L7Qmh5CE6Fus0Adeqjwd2QbshVQEwBev8Em/83vlVGqJ32LTZxbssefNNhg9P+SWhzov4FaWsLcsl04Tit4kf0iel4z7oijUFCudmuoRRiMZY7QQKGWsbQhBQE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB7115.namprd12.prod.outlook.com (2603:10b6:510:1ee::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.29; Fri, 23 Feb 2024 09:29:15 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7316.018; Fri, 23 Feb 2024 09:29:14 +0000 Message-ID: <17958b3f-0fa4-408d-af01-1f934a0bfc55@amd.com> Date: Fri, 23 Feb 2024 09:29:10 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] ethdev: add function to check representor port Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, Long Wu , Peng Zhang References: <20240210104214.1248772-1-chaoyong.he@corigine.com> <20240223024217.3052031-1-chaoyong.he@corigine.com> <20240223024217.3052031-2-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240223024217.3052031-2-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0294.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB7115:EE_ X-MS-Office365-Filtering-Correlation-Id: 3984e253-c0da-463e-aa17-08dc3451e6ab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uMO/MJ687W/BLn4pW3RSf6iemzGItbAe/dxXA1ASBuXvVq7W55SAQSVhUp8sza0fNWOa2VN+vw8HfNZtHrvsr7UpE0PT9BQgMYvfh9WRaSg19wRZV0C5NPtRMnQuc8dwI8w2aXOZPkLq69PfUSW+qXN3pO9UBz+npkRSPyPY5ETuRrlL2gblTRksT18K40wz2U2GgnMkHUZmQU5K6AhI/Ff7go1YRSt25mIBSNak330U6vuN48oHIwfrjfTbEPUUyA1TsRFvI3BnVlWVgbvOoosEBGajcORurgZROS53dmmlV8ezSfM7hqib0bqOROa9XvuRFEoWe5pTscxwCBVuFfOvZjwnsjX63fMwtxxYeQf/ICgIV0tTE9JKIvkf71hvt5lpPTHdbwXRoXyLuyLvphmYb5MS+c/WQNswrX8Kfz5yaiqqV3pq1dMhlni1sTdvCOaoxizZEnuZniFAT6f1KtbDjP40lcUftuGYlSPvjye2oK2kpTeAGJarVq14m9ojbMFHc9HwF43o6jvaL4Aj6A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmRCN3hSd0NYb2hMMEdhODNJYTlBdjgwamhJZmpZVUlqZ0tzcDVEKzNUUVJC?= =?utf-8?B?eStqV1U0QlBXUTh1b3RKb2dEU292WkxwOEhma09jTk93RW5Cc1piZXZUUmlR?= =?utf-8?B?c24vREpxU0IwSlpoc0s0Nk45aE9OQ2pxZ3ZNaGNpRHpxRm11bmNiaDhISUdR?= =?utf-8?B?UUJ2WUMzZmt4WnFwTHRqQXUxWDhVMk44N2tXMTVMZzBTZEk2SWh0M3Y0elU2?= =?utf-8?B?eUxGS013anNwdE15TWRlaVdqTzFnQlplMllyRG44RVdlS3JQelFJZ0p3Q0NU?= =?utf-8?B?UW5oZTQ2M1htam5lejQ4L0dici9Yb3JxVWU1K01rOHBDZG1oWVNyUFRaUHJQ?= =?utf-8?B?SXN4VTh0YzJrQ0dRUzRNcjVTRThyem43VDZpK0MzOGJRclpFUWpjRWNwUmha?= =?utf-8?B?OXQ4cUQvcjB3b01oVVlYOXRaUWs1MmEwelBFekdiSkx5Si8zZ2E0Q1NCTGJi?= =?utf-8?B?L3VrUlpwVUtXWCsyQ2xodFE2SHJ5TlUwWWd6bm9pQlZtakZyTVZtRUh2RmlN?= =?utf-8?B?NGFrV3FzaW5hTUxvL3IxakxibVB2clBZY0NOcGNYczUzaVphK2tiL1AvYk1K?= =?utf-8?B?ZUlad1ZRQlFvbzIxelpuTXd5K1lhT3AwWkxtaGljczF4OWQ3Z0dxNUVyeWpI?= =?utf-8?B?QWVteFMwa1M4T0dmUFF3WW5icTMxdDlBejVrTHFPUGszRFFWVUcwZmVTYjNk?= =?utf-8?B?TUJaaEE3cnRHL1VBWkNsbWhjQnVubUhaYUlTTFZmUXlDYmZyYlZqTnhFS1hN?= =?utf-8?B?NTNISDVOTm9VMEVja1N5b2VXSTJ4VXhvVTFKWk5vNmVlUUtGRXV5aEFhZlZk?= =?utf-8?B?YnVkbktRakRZWFJrclVVbXpXOE5EdDBmSWNpTUZkZTR5d2NpVUVPQjA1Y1Jm?= =?utf-8?B?WkFKbThXenhiSTZBb08rYnh0MGpPODdlVEFIeUNWOXpPajljdlhmWlJMKy9Q?= =?utf-8?B?dnV1L09QTVNFQXVPc2dyLzQ5bkdVa1hvN1BTYTVZaEhuY2pDMnBrb0pEZjhu?= =?utf-8?B?aHNWT0o2RVRZR0VhYW5hdzZnUllVRVJxZUQ2WFBWY056QVpxV0lYNzJ5WFp4?= =?utf-8?B?SG4vNW5KLzhhbE5mMzZiV2ZhNDVjSFVqYm83UVFTTUc2SmMwYWhnVlNLb1Fk?= =?utf-8?B?M1ZlZkVPY1FNYnNqWmg3RjlYZU1SYjU5YzFieFFlRXpVRUo2VFdBMm1vbk5u?= =?utf-8?B?S2VodFYrK0lleWxIK1JhcG43Y0svc3laWWNUbVUzaU5OcklGNXAzdmNlOHgz?= =?utf-8?B?b2hROW9sM0dPd1VJaUlsM2ZhZm5qY0FLNzVvOStNWVdGZkhucUx4TnIvU1RR?= =?utf-8?B?Y29XcDd5RFR5ZnI2SzJKMXdOUFQyTTdOTkxRQ2RHOGhGa2Nia1VmYThHRzRE?= =?utf-8?B?VGZqWlVycmNPbHJZMG4zbkRqd3ZQS2RYNFNQL09IOFdnVkRWT2ZmMVQ1cWFZ?= =?utf-8?B?Ti9uSGNpajJWSUtOZkhGa2xhQWxuRDB6WXpjZmM1RWd0MDRDMnJVRmlLTFh1?= =?utf-8?B?amJVQ1M0SHEyZXVjS3NORkRZMFBuaHUzMW9PdGE2c2p1Y1YwZStVZm1PUlM4?= =?utf-8?B?RkxycFZoRzhZYnBBTFVwTThydFJ1U29KWFVYOUNLRTdtcEVxbGVWTUpNWncy?= =?utf-8?B?UnE3VGhvRHFaRzI4dGN6a2tCOVA1UDNaUDFhdncybUZsb1UyVUR0eHlpTnFI?= =?utf-8?B?dTBXZWw1cHNPVDFtUlZkTEd4Qk5tdjQ2RGhuRDRCYnNISkVpU2RkUkswZ2dB?= =?utf-8?B?UzZVbWVuYU1va0s0QXJiNlIvbVdNOU9iQ1M0Qk4xbkRZNXdZNGNoQzBxNmNM?= =?utf-8?B?WWtscldFcjN3WE9pWHhBa081N05leGVWeTZ0MHdEZ3dONFdNcTNiZVZkMmxP?= =?utf-8?B?RzhzekRxTnNFYnM1NVU1RXgzQ1dla1Q0bCtXUy9neWRUcUF0S1FVU3k5Nld6?= =?utf-8?B?NjVuWVJkN0xiNldmZ25ZUXNmdW9WRjRmT3B3ZXhtVzA0QTliNkV3anpUdmU5?= =?utf-8?B?TWZpdzVaWFdBemo0d05Oc2xaVW80UmNVTlJDMjMvRkNZelVyYWJvS0NYalpO?= =?utf-8?B?Qmxyb0ZiS09zd0t2UCs2ZFZzNXpJL3BKQUJ4UzZrK2tESTJjWTdIc0ZyeHZX?= =?utf-8?Q?dEx1I4+i5iz6OlbjKADfLjZ7n?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3984e253-c0da-463e-aa17-08dc3451e6ab X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 09:29:14.8890 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rTdk6jWcFqkV6plfFio3BLtXWIZ+k4Pd30XoMgzvnTbNZPuX1QZMgJ7kK/05ZzmA X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7115 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/23/2024 2:42 AM, Chaoyong He wrote: > From: Long Wu > > Add a function to check if a device is representor port, also > modified the related codes for PMDs. > Thanks Long for the patch. > Signed-off-by: Long Wu > Reviewed-by: Chaoyong He > Reviewed-by: Peng Zhang > --- > doc/guides/rel_notes/release_24_03.rst | 3 +++ > drivers/net/bnxt/bnxt.h | 3 --- > drivers/net/bnxt/bnxt_ethdev.c | 4 ++-- > drivers/net/bnxt/tf_ulp/bnxt_tf_pmd_shim.c | 12 ++++++------ > drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 4 ++-- > drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 4 ++-- > drivers/net/cpfl/cpfl_representor.c | 2 +- > drivers/net/enic/enic.h | 5 ----- > drivers/net/enic/enic_ethdev.c | 2 +- > drivers/net/enic/enic_fm_flow.c | 20 ++++++++++---------- > drivers/net/enic/enic_main.c | 4 ++-- > drivers/net/i40e/i40e_ethdev.c | 2 +- > drivers/net/ice/ice_dcf_ethdev.c | 2 +- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- > drivers/net/nfp/flower/nfp_flower_flow.c | 2 +- > drivers/net/nfp/nfp_mtr.c | 2 +- > drivers/net/nfp/nfp_net_common.c | 4 ++-- > drivers/net/nfp/nfp_net_flow.c | 2 +- > lib/ethdev/ethdev_driver.h | 17 +++++++++++++++++ > 19 files changed, 54 insertions(+), 42 deletions(-) > There are two more instance in 'rte_class_eth.c' > diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst > index 879bb4944c..8178417b98 100644 > --- a/doc/guides/rel_notes/release_24_03.rst > +++ b/doc/guides/rel_notes/release_24_03.rst > @@ -185,6 +185,9 @@ API Changes > * ethdev: Renamed structure ``rte_flow_action_modify_data`` to be > ``rte_flow_field_data`` for more generic usage. > > +* ethdev: Add new function ``rte_eth_dev_is_repr()`` to check if a device is > + representor port. > + > This is not user facing API, no need to update the release notes. <...> > +/** > + * @internal > + * Check if the ethdev is a representor port. > + * > + * @param dev > + * Pointer to struct rte_eth_dev. > + * > + * @return > + * false the ethdev is not a representor port. > + * true the ethdev is a representor port. > + */ > +static inline bool > +rte_eth_dev_is_repr(const struct rte_eth_dev *dev) > +{ > + return ((dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) != 0); > +} > + There is a 'rte_eth_representor_id_get()' API above, can you move this new one below it to group them together?