From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EFD5A04DB; Wed, 14 Oct 2020 22:13:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 618DE1DA55; Wed, 14 Oct 2020 22:13:52 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 851FB1BDC3 for ; Wed, 14 Oct 2020 22:13:50 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id D78895C0100; Wed, 14 Oct 2020 16:13:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 14 Oct 2020 16:13:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= t3TN6Ml/HFILX070MbO1w608nkMTf6CenMx+wMAaO00=; b=VDZIBbZboPwHCfbm JLBtuCj2R1QBX+pB2gmGfaAjTFJSN5xm/bx/tqTmdta1WyfP0ks0ihFvuPdV+dDq QE4HXVu+lNur9kCKptp+i7z+y0Tx6NYWtInQv8hYuI+Q35Algp/WQKI7IM/EIUPd y+3LZFvMUjhURlGPzRYG0bV1vTXFSqGFCwb9lzRgcRds3mw3nJWsOX3WWfp1x1YI 5PRtZtQszhmoDONL9K1lbA/gEGtRrqHApmE4zYaEaqJxx3ThuZGR5GT1uikW6q1s ZcDDU2vcIEfCCknBxrPA84wd2ghS5RJT6YAaevAF5vC2gqmbiiKCdAnAn+twkQgv HalwCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=t3TN6Ml/HFILX070MbO1w608nkMTf6CenMx+wMAaO 00=; b=naf67gU4i3cdGtgdoFRpxOxGKZGe72lCMZuCoCKSF+bO9RDS5CiDJ7rTK DjZcxYWXIeOx6czsIxRsx9J0lOCosv+xEexRM9WpllemzodPf059WVYWoXPW3Ka3 cVXQ8T65F6GC8jjmygbDfvgDNK6lvpPqUMSMrTmaSqhGybu8E9KCIWWJSMj/e8hm U99xV2Fy8xZZGEatst/4NnzlniSn7Qbo+9N5ahTCqARoBkq6xHBHtvtpw8AlKioY gr3AT2FAvcnIyGDDjErFbAU5fCdoj1D6ZNs/Tj90TJ2b7mGIm/15URpJvJVyiMSR fPaDTilHFJX4kPgXPWNiRAuwrorVA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedriedugddugeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BD3213064683; Wed, 14 Oct 2020 16:13:45 -0400 (EDT) From: Thomas Monjalon To: Dekel Peled Cc: orika@nvidia.com, wenzhuo.lu@intel.com, beilei.xing@intel.com, bernard.iremonger@intel.com, mdr@ashroe.eu, nhorman@tuxdriver.com, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org Date: Wed, 14 Oct 2020 22:13:44 +0200 Message-ID: <1795930.58YeoAtlNX@thomas> In-Reply-To: <6363b9417eea68914d23bbd636567977e5b0eda8.1602700693.git.dekelp@nvidia.com> References: <209f5087596180d7866a43f0a0f12c9a032eb7ce.1601577847.git.dekelp@nvidia.com> <6363b9417eea68914d23bbd636567977e5b0eda8.1602700693.git.dekelp@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/2] ethdev: add VLAN attributes to ETH and VLAN items X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/10/2020 20:53, Dekel Peled: > @@ -292,6 +292,13 @@ API Changes > > * vhost: Moved vDPA APIs from experimental to stable. > > +* ethdev: Added new field ``has_vlan`` to structure ``rte_flow_item_eth``, > + indicating that packet header contains at least one VLAN. > + > +* ethdev: Added new field ``has_more_vlan`` to structure > + ``rte_flow_item_vlan``, indicating that packet header contains at least one > + more VLAN, after this VLAN. > + The ethdev changes should be grouped with others above vhost one. [...] > - * If the @p ETH item is the only item in the pattern, and the @p type field > - * is not specified, then both tagged and untagged packets will match the > - * pattern. > + * The field @p has_vlan can be used to match specific packet types, instead > + * of using the @p type field. > + * This can be used to match any type of tagged packets. If I understand well, these two sentences could be merged in one: The field @p has_vlan can be used to match tagged packets, instead of using the @p type field. > + * If the @p type and @p has_vlan fields are not specified, then both tagged > + * and untagged packets will match the pattern. OK [...] > + * The field @p has_more_vlan can be used to match specific packet types, > + * instead of using the @p inner_type field. > + * This can be used to match any type of tagged packets. Here as well, "specific" can be replaced with "QinQ" or "inner tagged". > + * If the @p inner_type and @p has_more_vlan fields are not specified, > + * then any tagged packets will match the pattern. OK