From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F0C5A00E6 for ; Wed, 10 Jul 2019 23:21:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5466B532C; Wed, 10 Jul 2019 23:21:04 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id C3D0A322C; Wed, 10 Jul 2019 23:21:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 33DE63250; Wed, 10 Jul 2019 17:20:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 10 Jul 2019 17:20:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=PrSs9GAPUuQGQhENKBVM3IwpRKiF8ORMzx6Kr0Fv1dA=; b=Qz86IbvqwtWB khI//L7AhUlgGGGt5XlBQMQHvqbLHfXPI8siauYTgE0YyO9Kn0uvmpyCUMHAerHL wlux4R3DTh+nCRI4QjkGiMYXH3giUQpxRaUPhAOGmhVbDwloaik8Dz74S0jlhnFG l4QdQHAW9q1eT2SgpV8TTcHWZUkho2M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=PrSs9GAPUuQGQhENKBVM3IwpRKiF8ORMzx6Kr0Fv1 dA=; b=IqfVmbayoqxNDCNWPt3RMOHEfOz8YOIrjPYKI8N1Tcx+goV4gxoJOkqq9 U8vuZxpn2rHJGrI7q5E5o6KIIHQJ1oXfocBzOEJVIVXd6YZEcVl0prE/HBzWj8u8 9yPn6POcLoAKwnOCXLJsFe77roZn6qPiseNuPXi0j+LCjzOp6k23FPExvywpRFtl vKBiK2QF3ic+Zy7QXsQVaR9xEIZCuWdip568tfk0m53lMK2y0cRR25+5n1LGIrOw 12T0i0ZUSU1d8pCLzb3zcZMK3Gtdvl2wAG3D0IiUDFPGyDKYrjkp8217To2WnH4+ uqPmFNZu1SgQCxNHgBKe0RVQDWYfQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrgeeigdduieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehrvgguhhgrthdrtghomhenucfkphepjeejrddufeegrddvtdefrddukeeg necurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvg htnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D9A4C80061; Wed, 10 Jul 2019 17:20:52 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, anatoly.burakov@intel.com, alex.williamson@redhat.com, maxime.coquelin@redhat.com, stephen@networkplumber.org, igor.russkikh@aquantia.com, pavel.belous@aquantia.com, allain.legacy@windriver.com, matt.peters@windriver.com, ravi1.kumar@amd.com, rmody@marvell.com, shshaikh@marvell.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, hemant.agrawal@nxp.com, shreyansh.jain@nxp.com, wenzhuo.lu@intel.com, mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com, johndale@cisco.com, hyonkim@cisco.com, qi.z.zhang@intel.com, xiao.w.wang@intel.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, beilei.xing@intel.com, jingjing.wu@intel.com, qiming.yang@intel.com, konstantin.ananyev@intel.com, alejandro.lucero@netronome.com, arybchenko@solarflare.com, tiwei.bie@intel.com, zhihong.wang@intel.com, yongwang@vmware.com, stable@dpdk.org Date: Wed, 10 Jul 2019 23:20:51 +0200 Message-ID: <1796500.5oFe8j95cd@xps> In-Reply-To: <1562762020-8259-1-git-send-email-david.marchand@redhat.com> References: <1562071706-11009-1-git-send-email-david.marchand@redhat.com> <1562762020-8259-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] vfio: fix interrupts race condition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/07/2019 14:33, David Marchand: > Populating the eventfd in rte_intr_enable in each request to vfio > triggers a reconfiguration of the interrupt handler on the kernel side. > The problem is that rte_intr_enable is often used to re-enable masked > interrupts from drivers interrupt handlers. > > This reconfiguration leaves a window during which a device could send > an interrupt and then the kernel logs this (unsolicited from the kernel > point of view) interrupt: > [158764.159833] do_IRQ: 9.34 No irq handler for vector > > VFIO api makes it possible to set the fd at setup time. > Make use of this and then we only need to ask for masking/unmasking > legacy interrupts and we have nothing to do for MSI/MSIX. > > "rxtx" interrupts are left untouched but are most likely subject to the > same issue. > > Fixes: 5c782b3928b8 ("vfio: interrupts") > Cc: stable@dpdk.org > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1654824 > Signed-off-by: David Marchand > Tested-by: Shahed Shaikh This is a real bug which should be fixed in this release. As the patch is quite big and needs a strong validation, I prefer merging it quickly to give a lot of time before releasing 19.08-rc2. The maintainers of all concerned PMDs are Cc. Please make sure the interrupts are still working well with VFIO. Applied, thanks