From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 508BCA0C52; Wed, 24 Nov 2021 16:59:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2083C40DF5; Wed, 24 Nov 2021 16:59:52 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 078FA40040 for ; Wed, 24 Nov 2021 16:59:50 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 69CE85C0193; Wed, 24 Nov 2021 10:59:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 24 Nov 2021 10:59:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= PADczg1CVqu6xHXaiJUu4ekMq9v3IyR1Ms1qHUgt/uc=; b=ItJDpzTjyIGSu5KJ wpyBWbWxIV3zpjl5XXJMzfZ8HW8tC0dfCZPkzHr1YlKTN5/5mslF8oTNssu1+z/i qpurq8s8UbGUBYl0hf2yZLOBbq8WpQi+DLy7kR1eP4DLSkhsADna34g9en1NsDuX FSETMMRJfsiZaH2r1UdgJRUKrS8lVtg+FudwJEiu2VhHfxmoOO3Zc2Pz5gpaASGa 521319kK+s8NLr+vGeXc5JezAyMxMc7okaPK82Vl0wIMVZpYFjl7dugbR7IFiMdO L+cYD8lHhOQzhczV83U+XXPdVOWmOacWcGasnBintoOGeyEjxBJ2kqhQromSuXSk jOGR0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=PADczg1CVqu6xHXaiJUu4ekMq9v3IyR1Ms1qHUgt/ uc=; b=lxbYa8BVwMKNRjGZRbMY9Ob4a9HLQrnVKcp14PnVQ3P6vlmBJc3EQdviP tgPaYUR+ib4Ab7dfJsNOCtmHUoW1vos8aanpl3XzmxT1gHnh6vXliecUIPzXB1FP yIlNns0e9/9DFNfnwYKOOy4hhs4SxW9TSXY5D6SHGuMD4wWChiNE0hajz0zMDOBh uP93HF/ZRtaTyua7kPoML9A6e8oeSRmCNA8kr849BR1tIB2FyrE9ItLBV9PyC6SD LJqP0NMpnz/eWB6ycJuXFFJ6N7C87yRO8D2jd8vQgr9UOcR2Ep+s/dFP9dsqyMzT 3cDmTa32XvOepxYH+mSPhLLCUNJtQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrgeekgdekgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 24 Nov 2021 10:59:47 -0500 (EST) From: Thomas Monjalon To: Viacheslav Ovsiienko Cc: dev@dpdk.org, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru, ajit.khaparde@broadcom.com, jerinj@marvell.com, hemant.agrawal@nxp.com Subject: Re: [PATCH v3] ethdev: deprecate header fields and metadata flow actions Date: Wed, 24 Nov 2021 16:59:46 +0100 Message-ID: <17999470.0J1HC8nTTz@thomas> In-Reply-To: <20211124153756.12198-1-viacheslavo@nvidia.com> References: <20211123075940.5521-1-viacheslavo@nvidia.com> <20211124153756.12198-1-viacheslavo@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/11/2021 16:37, Viacheslav Ovsiienko: > The generic RTE_FLOW_ACTION_TYPE_MODIFY_FIELD action was > introduced by [1]. This action provides an unified way > to perform various arithmetic and transfer operations over > packet network header fields and packet metadata. > > [1] commit 641dbe4fb053 ("net/mlx5: support modify field flow action") > > On other side there are a bunch of multiple legacy actions, > that can be superseded by the generic modify field action: > > RTE_FLOW_ACTION_TYPE_OF_SET_MPLS_TTL > RTE_FLOW_ACTION_TYPE_OF_DEC_MPLS_TTL > RTE_FLOW_ACTION_TYPE_OF_SET_NW_TTL > RTE_FLOW_ACTION_TYPE_OF_DEC_NW_TTL sfc > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_OUT > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_IN > RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC bnxt, cxgbe, mlx5 > RTE_FLOW_ACTION_TYPE_SET_IPV4_DST bnxt, cxgbe, mlx5 > RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC cxgbe, mlx5 > RTE_FLOW_ACTION_TYPE_SET_IPV6_DST cxgbe, mlx5 > RTE_FLOW_ACTION_TYPE_SET_TP_SRC cxgbe, mlx5 > RTE_FLOW_ACTION_TYPE_SET_TP_DST cxgbe, mlx5 > RTE_FLOW_ACTION_TYPE_DEC_TTL mlx5, sfc > RTE_FLOW_ACTION_TYPE_SET_TTL mlx5 > RTE_FLOW_ACTION_TYPE_SET_MAC_SRC cxgbe, mlx5 > RTE_FLOW_ACTION_TYPE_SET_MAC_DST cxgbe, mlx5 > RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ mlx5 > RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ mlx5 > RTE_FLOW_ACTION_TYPE_INC_TCP_ACK mlx5 > RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK mlx5 > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP mlx5 > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP mlx5 > RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID bnxt, cnxk, cxgbe, enic, > mlx5, octeontx2, sfc > RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP bnxt, cnxk, cxgbe, enic, > mlx5, octeontx2, sfc > RTE_FLOW_ACTION_TYPE_SET_TAG mlx5 > RTE_FLOW_ACTION_TYPE_SET_META mlx5 > > This note deprecates the following RTE Flow actions: > 1. As not supported by any of PMDs: > > RTE_FLOW_ACTION_TYPE_OF_SET_MPLS_TTL > RTE_FLOW_ACTION_TYPE_OF_DEC_MPLS_TTL > RTE_FLOW_ACTION_TYPE_OF_SET_NW_TTL > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_OUT > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_IN > > 2. As supposed to be replaced by generig field modify action: > RTE_FLOW_ACTION_TYPE_OF_DEC_NW_TTL > RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC > RTE_FLOW_ACTION_TYPE_SET_IPV4_DST > RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC > RTE_FLOW_ACTION_TYPE_SET_IPV6_DST > RTE_FLOW_ACTION_TYPE_SET_TP_SRC > RTE_FLOW_ACTION_TYPE_SET_TP_DST > RTE_FLOW_ACTION_TYPE_DEC_TTL > RTE_FLOW_ACTION_TYPE_SET_TTL > RTE_FLOW_ACTION_TYPE_SET_MAC_SRC > RTE_FLOW_ACTION_TYPE_SET_MAC_DST > RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ > RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ > RTE_FLOW_ACTION_TYPE_INC_TCP_ACK > RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP > RTE_FLOW_ACTION_TYPE_SET_TAG > RTE_FLOW_ACTION_TYPE_SET_META > > The VLAN set actions are interrelated to VLAN header insertion/removal > and supported by multiple PMDs and supposed to be just deprecated but > not be removed in 22.11. > > Signed-off-by: Viacheslav Ovsiienko Few more infos: The deprecation is only in comments to suggest a replacement. It has no impact on applications using old actions. The drivers should adopt the new API for a better user experience, and to prepare future removal. > +* ethdev: Actions ``OF_SET_MPLS_TTL``, ``OF_DEC_MPLS_TTL``, ``OF_SET_NW_TTL``, > + ``OF_COPY_TTL_OUT``, ``OF_COPY_TTL_IN`` are deprecated as not supported by > + PMDs, will be removed in DPDK 22.11. > + > +* ethdev: Actions ``OF_DEC_NW_TTL``, ``SET_IPV4_SRC``, ``SET_IPV4_DST``, > + ``SET_IPV6_SRC``, ``SET_IPV6_DST``, ``SET_TP_SRC``, ``SET_TP_DST``, > + ``DEC_TTL``, ``SET_TTL``, ``SET_MAC_SRC``, ``SET_MAC_DST``, ``INC_TCP_SEQ``, > + ``DEC_TCP_SEQ``, ``INC_TCP_ACK``, ``DEC_TCP_ACK``, ``SET_IPV4_DSCP``, > + ``SET_IPV6_DSCP``, ``SET_TAG``, ``SET_META`` are deprecated as superseded > + by generic MODIFY_FIELD action, will be removed in DPDK 22.11. > + > +* ethdev: Actions ``OF_SET_VLAN_VID``, ``OF_SET_VLAN_PCP`` are deprecated > + as superseded by generic MODIFY_FIELD action. Acked-by: Thomas Monjalon