From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0F9643BCF; Thu, 7 Mar 2024 15:08:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B1CEE4067E; Thu, 7 Mar 2024 15:08:05 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 858CB40272 for ; Thu, 7 Mar 2024 15:08:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709820483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zP8gHZ/dYUth5/8Iwy34q4NAjn+AR8fq7QzdfnwOyII=; b=ajbRrlFZpF8rj4cWFg6C7niOToiVQYWLehhrlOD1axC6wstqCSLgEnus52Z5fSSh/nTC2l viKRWxqckAH1W332nneMRPL60DBpiMAzNycdRuQ1GjGpbpcIQT1j/Hc8KQr0HcY/i7heXW esjv8S7wALeo2Aj4sH+tJ1ZrZKwPPVU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-574-5hSyFDGuODaXFf7sefLZRg-1; Thu, 07 Mar 2024 09:08:01 -0500 X-MC-Unique: 5hSyFDGuODaXFf7sefLZRg-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-33dfefa9b1dso475245f8f.0 for ; Thu, 07 Mar 2024 06:08:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709820480; x=1710425280; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zP8gHZ/dYUth5/8Iwy34q4NAjn+AR8fq7QzdfnwOyII=; b=bUgACDv3VL5c/Tm+ubvYLubVjYoIsZeE37KMQ22p/qXvSNqomHa33z54ozjGRGmYbH orwZIf1AC4mlGDv00ufwnJu6jmpzG+LoS9dStDYW+WxSUaJil5TINwbTERtedszhD5Gi XP/2GorxA2n8xJO1gwKNdJEUCxJmcwrP/Nyp1pYVQn7ch63ikTOdTU5dlkr7kA41KCc7 5rOx9YmdYWYOtu49KgQ+WidHET7eEujTAQ+T18APAipRIja0aLCfYlUpENHq1DeBpLIQ xMTzWLCMia/q49fSbJbRiIOk0imcnfrR16eLcNdRc7h0ZXidcHC7P485+o/NrSDKR95i N34Q== X-Forwarded-Encrypted: i=1; AJvYcCWJasImrhpuO5LVUVO5eODeZE+OCNCgaU7hryDKUriMoN0J+n3TazYhck7Y0SYGk86JfVgHmMzeq44bHc0= X-Gm-Message-State: AOJu0YwBaqoPpDz6qp41Rc6OnjdatHDSY1IZ7/LgHWSRycxRIWgE5+GU uPdyjmiknxudCFjnLGwN2lEy/iGJBs8qRTbf2gH2c6teveEj95Pmm24pVrq1h9pQMvUv88SwlJL WMccvewNK4AxqhVEBetLI07PQueG8buzdHzZ4cWJF X-Received: by 2002:adf:e051:0:b0:33e:67c3:9ca4 with SMTP id w17-20020adfe051000000b0033e67c39ca4mr1475017wrh.7.1709820480000; Thu, 07 Mar 2024 06:08:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IH/U7GfBh/pMiQbC9BQXygipCywgfgy6Eqh1f89BFx/ZoHV0oykEe8Cwj75DzBItVBX4QuMuQ== X-Received: by 2002:adf:e051:0:b0:33e:67c3:9ca4 with SMTP id w17-20020adfe051000000b0033e67c39ca4mr1474997wrh.7.1709820479680; Thu, 07 Mar 2024 06:07:59 -0800 (PST) Received: from [192.168.0.36] ([78.17.251.53]) by smtp.gmail.com with ESMTPSA id n3-20020adfe783000000b0033b79d385f6sm20181802wrm.47.2024.03.07.06.07.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Mar 2024 06:07:59 -0800 (PST) Message-ID: <17a7cab9-ab90-49e7-9d2d-be1cedf053a5@redhat.com> Date: Thu, 7 Mar 2024 14:07:57 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] examples/l3fwd: fix conf propagation to RX queues To: Kamil Vojanec , dev@dpdk.org Cc: Konstantin Ananyev , Trevor Tao References: <20240216120207.126025-1-vojanec@cesnet.cz> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: <20240216120207.126025-1-vojanec@cesnet.cz> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 16/02/2024 12:02, Kamil Vojanec wrote: > When configuring RX queues, the default port configuration was used, > even though it was modified before. This results in the > 'relax-rx-offload' not being respected for RX queues. > This commit uses 'rte_eth_dev_conf_get()' to obtain the device > configuration structure instead. > > Fixes: 4b01cabfb0 ("examples/l3fwd: add option to relax Rx offload") > Signed-off-by: Kamil Vojanec > --- > examples/l3fwd/main.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c > index 3bf28aec0c..2b714a362a 100644 > --- a/examples/l3fwd/main.c > +++ b/examples/l3fwd/main.c > @@ -1388,6 +1388,7 @@ l3fwd_poll_resource_setup(void) > fflush(stdout); > /* init RX queues */ > for(queue = 0; queue < qconf->n_rx_queue; ++queue) { > + struct rte_eth_conf local_conf; > struct rte_eth_rxconf rxq_conf; > > portid = qconf->rx_queue_list[queue].port_id; > @@ -1408,8 +1409,14 @@ l3fwd_poll_resource_setup(void) > "Error during getting device (port %u) info: %s\n", > portid, strerror(-ret)); > > + ret = rte_eth_dev_conf_get(portid, &local_conf); > + if (ret != 0) > + rte_exit(EXIT_FAILURE, > + "Error during getting device (port %u) configuration: %s\n", > + portid, strerror(-ret)); > + > rxq_conf = dev_info.default_rxconf; > - rxq_conf.offloads = port_conf.rxmode.offloads; > + rxq_conf.offloads = local_conf.rxmode.offloads; > if (!per_port_pool) > ret = rte_eth_rx_queue_setup(portid, queueid, > nb_rxd, socketid, Acked-by: Kevin Traynor