From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A4CBBA0C46;
	Fri,  6 Aug 2021 11:03:01 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 877BB40E5A;
	Fri,  6 Aug 2021 11:03:01 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id E9B734014D
 for <dev@dpdk.org>; Fri,  6 Aug 2021 11:02:59 +0200 (CEST)
Received: from [10.180.78.90] (unknown [188.170.173.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id CDD297F563;
 Fri,  6 Aug 2021 12:02:56 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru CDD297F563
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1628240579;
 bh=8/rxUl/9Op+zdaSSoK8d5XC+v/aEaI4rsMJ7xKlJabs=;
 h=From:To:CC:Date:In-Reply-To:References:Subject;
 b=nyxSWJC58cyG9HPb+Ili2tYtlM4xPV1ePx/I5KKIIzovXHQKPH6PB4Vv5xPIVQita
 3Q7NHXYYCAW4zIaPah+Q5X1MGhsRyM00e9hUFsjklsUv4nH7Rg08xdx8/up6ZL2ym3
 uxmMpnHLpQwYebLwtU8B1enAOdMm5eABHxYc7ppA=
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Thomas Monjalon <thomas@monjalon.net>,
 Gregory Etelson <getelson@nvidia.com>
CC: <dev@dpdk.org>, <matan@nvidia.com>, <rasland@nvidia.com>,
 <orika@nvidia.com>, Ray Kinsella <mdr@ashroe.eu>, <ajit.khaparde@broadcom.com>,
 <jerinj@marvell.com>, <akhil.goyal@nxp.com>, <cristian.dumitrescu@intel.com>,
 <ferruh.yigit@intel.com>, <konstantin.ananyev@intel.com>,
 <olivier.matz@6wind.com>, <maxime.coquelin@redhat.com>,
 <david.marchand@redhat.com>
Date: Fri, 06 Aug 2021 12:02:54 +0300
Message-ID: <17b1ab37630.281a.45678ef996719ac36a921b5e5b2e03f7@oktetlabs.ru>
In-Reply-To: <1640281.NIGIfqfGR8@thomas>
References: <20210802104218.15369-1-getelson@nvidia.com>
 <1640281.NIGIfqfGR8@thomas>
User-Agent: AquaMail/1.30.1-1828 (build: 103001000)
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="us-ascii"
Content-Transfer-Encoding: 8bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [dpdk-dev] [PATCH] net: announce changes in TCP header
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

The patch lacks motivation. Why is the change required? Why is it useful?

On August 5, 2021 18:28:31 Thomas Monjalon <thomas@monjalon.net> wrote:

> Nobody rejected this change but there is not enough ack
> to make it an accepted announce of change.
>
> 02/08/2021 12:42, Gregory Etelson:
>> Announce change to add a union that will provide byte and bitfield
>> access to TCP flags.
>>
>> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
>> ---
>> +* net: structure ``rte_tcp_hdr`` will have a union that will provide
>> +  byte access to existing ``tcp_flags`` and add a bitfield for TCP flags.