From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A76454236B; Thu, 12 Oct 2023 05:51:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3292B402BA; Thu, 12 Oct 2023 05:51:37 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id A8DBE40279 for ; Thu, 12 Oct 2023 05:51:35 +0200 (CEST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4S5bGf3CNczrStr for ; Thu, 12 Oct 2023 11:48:58 +0800 (CST) Received: from [10.67.121.175] (10.67.121.175) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Thu, 12 Oct 2023 11:51:33 +0800 Message-ID: <17b90455-c6cb-fe2e-ca4a-88702f228de8@huawei.com> Date: Thu, 12 Oct 2023 11:51:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 39/40] app/proc-info: support querying RSS hash algorithm To: fengchengwen , , Reshma Pattan CC: , References: <20230908080030.3837515-1-haijie1@huawei.com> <20231011092805.693171-1-haijie1@huawei.com> <20231011092805.693171-40-haijie1@huawei.com> <42384010-a5e2-f73e-37e4-73ef9fd8e336@huawei.com> From: Jie Hai In-Reply-To: <42384010-a5e2-f73e-37e4-73ef9fd8e336@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.175] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/10/12 10:05, fengchengwen wrote: > Suggest add one new API for get hash_algo_name. e.g. rte_eth_get_rss_algo_name() > Thanks, that's better for reuse, will change it in next version. > On 2023/10/11 17:28, Jie Hai wrote: >> Display RSS hash algorithm with command show-port as below. >> - RSS info >> -- hash algorithm : toeplitz >> >> Signed-off-by: Jie Hai >> Signed-off-by: Dongdong Liu >> Acked-by: Reshma Pattan >> --- >> app/proc-info/main.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/app/proc-info/main.c b/app/proc-info/main.c >> index e98352118db1..43f264848a6f 100644 >> --- a/app/proc-info/main.c >> +++ b/app/proc-info/main.c >> @@ -153,6 +153,14 @@ static struct desc_param rx_desc_param; >> static struct desc_param tx_desc_param; >> >> #define RSS_HASH_KEY_SIZE 64 >> +static const char * const rss_hash_algos[] = { >> + [RTE_ETH_HASH_FUNCTION_SIMPLE_XOR] = "simple_xor", >> + [RTE_ETH_HASH_FUNCTION_TOEPLITZ] = "toeplitz", >> + [RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ] = "symmetric_toeplitz", >> + [RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ_SORT] = "symmetric_toeplitz_sort", >> + [RTE_ETH_HASH_FUNCTION_DEFAULT] = "default", >> + [RTE_ETH_HASH_FUNCTION_MAX] = "unknown" >> +}; >> >> /* display usage */ >> static void >> @@ -1186,6 +1194,8 @@ show_port(void) >> printf("%02x", rss_conf.rss_key[k]); >> printf("\n\t -- hash function : 0x%"PRIx64"\n", >> rss_conf.rss_hf); >> + printf("\t -- hash algorithm : %s\n", >> + rss_hash_algos[rss_conf.algorithm]); >> } >> >> #ifdef RTE_LIB_SECURITY >> > .