From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BD2EA0535; Tue, 4 Feb 2020 15:35:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C1D611C199; Tue, 4 Feb 2020 15:35:46 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 15CEAAAD5 for ; Tue, 4 Feb 2020 15:35:44 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Feb 2020 06:35:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,402,1574150400"; d="scan'208";a="224311087" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.22.38]) ([10.252.22.38]) by orsmga008.jf.intel.com with ESMTP; 04 Feb 2020 06:35:40 -0800 To: Anoob Joseph , John McNamara , Marko Kovacevic Cc: Jerin Jacob Kollanukkaran , Narayana Prasad Raju Athreya , "dev@dpdk.org" , Akhil Goyal , Konstantin Ananyev , Hemant Agrawal , Fan Zhang , Fiona Trahe References: <1575960780-1171-1-git-send-email-anoobj@marvell.com> <517349fc-4125-01de-ec38-a9dd173bad7f@intel.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <17caefe0-87dc-28b4-d5d9-c6999b55823d@intel.com> Date: Tue, 4 Feb 2020 14:35:39 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] doc: add inline protocol in feature list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/22/2020 9:47 AM, Anoob Joseph wrote: > Hi Ferruh, > > Please see inline. > > Thanks, > Anoob > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Tuesday, January 21, 2020 9:42 PM >> To: Anoob Joseph ; John McNamara >> ; Marko Kovacevic >> >> Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju >> Athreya ; dev@dpdk.org >> Subject: [EXT] Re: [dpdk-dev] [PATCH] doc: add inline protocol in feature list >> >> External Email >> >> ---------------------------------------------------------------------- >> On 1/21/2020 5:40 AM, Anoob Joseph wrote: >>> Hi Ferruh, >>> >>> Can you review this patch? >> >> Hi Anoob, >> >> What is the difference between "Inline crypto" in that document and this >> "Inline protocol"? Both seems providing same outpout. > > [Anoob] Yes. It is partly because the description of "inline crypto" is not accurate. The feature, "inline crypto" is not ipsec aware but would do crypto operation in the ipsec. This summary points to the security documentation for further details and that doc clearly explains the difference between both modes. > >> Is there a way to differentiate them more clearly? > > [Anoob] There are two options I can think of, > 1. Update the feature list to describe the difference between the two. Have a line like, > "As compared to inline crypto, inline protocol will handle the entire protocol offload in addition to the crypto operation." > 2. Both inline crypto and inline protocol falls under security. So could even rename "Inline crypto" to "Inline security offload" and we should be good to go. Also, under inline protocol, there are various protocols possible. Say, tomorrow when we add MACSEC support, the same question would arise (as in whether it's a new feature or would it be under "inline protocol"). Hi Anoob, These seems security related and I don't know enough to comment if this is correct thing to do. I have cc'ed a few more people for comment. @Akhil, would you mind if I assign this to you? Thanks, ferruh > >> >>> >>> Thanks, >>> Anoob >>> >>>> -----Original Message----- >>>> From: dev On Behalf Of Anoob Joseph >>>> Sent: Tuesday, December 10, 2019 12:23 PM >>>> To: John McNamara ; Marko Kovacevic >>>> ; Ferruh Yigit >>>> Cc: Anoob Joseph ; Jerin Jacob Kollanukkaran >>>> ; Narayana Prasad Raju Athreya >>>> ; dev@dpdk.org >>>> Subject: [dpdk-dev] [PATCH] doc: add inline protocol in feature list >>>> >>>> Update feature list to include inline protocol offload. >>>> >>>> Signed-off-by: Anoob Joseph >>>> --- >>>> doc/guides/nics/features.rst | 18 ++++++++++++++++++ >>>> doc/guides/nics/features/default.ini | 1 + >>>> 2 files changed, 19 insertions(+) >>>> >>>> diff --git a/doc/guides/nics/features.rst >>>> b/doc/guides/nics/features.rst index >>>> 8394a65..f4eb2a9 100644 >>>> --- a/doc/guides/nics/features.rst >>>> +++ b/doc/guides/nics/features.rst >>>> @@ -433,6 +433,24 @@ Supports inline crypto processing (e.g. inline >>>> IPsec). See Security library and >>>> ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``, >>>> ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``. >>>> >>>> >>>> +.. _nic_features_inline_protocol_doc: >>>> + >>>> +Inline protocol >>>> +--------------- >>>> + >>>> +Supports inline protocol processing (e.g. inline IPsec). See >>>> +Security library and >>>> PMD documentation for more details. >>>> + >>>> +* **[uses] rte_eth_rxconf,rte_eth_rxmode**: >>>> ``offloads:DEV_RX_OFFLOAD_SECURITY``, >>>> +* **[uses] rte_eth_txconf,rte_eth_txmode**: >>>> ``offloads:DEV_TX_OFFLOAD_SECURITY``. >>>> +* **[implements] rte_security_ops**: ``session_create``, >>>> +``session_update``, >>>> + ``session_stats_get``, ``session_destroy``, ``set_pkt_metadata``, >>>> +``get_userdata``, >>>> + ``capabilities_get``. >>>> +* **[provides] rte_eth_dev_info**: >>>> >> +``rx_offload_capa,rx_queue_offload_capa:DEV_RX_OFFLOAD_SECURITY``, >>>> + >> ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_SECURITY``. >>>> +* **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD``, >>>> + ``mbuf.ol_flags:PKT_TX_SEC_OFFLOAD``, >>>> ``mbuf.ol_flags:PKT_RX_SEC_OFFLOAD_FAILED``. >>>> + >>>> + >>>> .. _nic_features_crc_offload: >>>> >>>> CRC offload >>>> diff --git a/doc/guides/nics/features/default.ini >>>> b/doc/guides/nics/features/default.ini >>>> index 91ec619..4d0ad32 100644 >>>> --- a/doc/guides/nics/features/default.ini >>>> +++ b/doc/guides/nics/features/default.ini >>>> @@ -42,6 +42,7 @@ Flow API = >>>> Rate limitation = >>>> Traffic mirroring = >>>> Inline crypto = >>>> +Inline protocol = >>>> CRC offload = >>>> VLAN offload = >>>> QinQ offload = >>>> -- >>>> 2.7.4 >>> >