From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B13E41BA0; Wed, 1 Feb 2023 16:19:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46EF742B8E; Wed, 1 Feb 2023 16:19:36 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 63A9D4021D for ; Wed, 1 Feb 2023 16:19:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675264774; x=1706800774; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=nIJ2FIZveM9mC0qIVJH2MwwVgaZH3qvQ7vTm8QeAqaQ=; b=CQfRdB3sg05kExGyjHSYhNDAOcXFJqhm5p6PA4ptAlLfafRTJzEN98gQ bhhFCOQD6hL2wO/U3zU8X6pgB90kOqThpP2ZVqJ6xrRHI+XrGtQI2fVa+ TJRNtkJFL0A4xlpQmdpQrs9pbCeFwfrqL6XLUYaqdSwxCKiq+HnosSTQS SFa57vaMmpEsAUMDbZYSBOIkFRmLEL6agqxUyGnqlW3ufd0ZZnSR5itU7 ecv7uyEPibcy/j35Q8yaEnx8RwCz8WDT9OMaIzGiJfB4h29+LIRhMRReU YJkNjjapvhBSInxMHoWm/mgmHnxbqjJX73iuj3zwe3/el3gwvhsXcEawJ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="328182915" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208,217";a="328182915" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 07:19:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="733602523" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208,217";a="733602523" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 01 Feb 2023 07:19:21 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 07:19:20 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 1 Feb 2023 07:19:20 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 1 Feb 2023 07:19:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ags2JRg1plqO9Gye81123L4YR79HvwKm0LQW0edfp2iUXWKJypXihfbL0px6NcXI4VuuuN/rWhWKW+gNxWV69nJOfewK2nPGk40JeSbZJCZzWsOyuMsGyV4QbxxiU7m3GWpCKLartBZVkEMHzNK7uMtuxNv8Vsn6dyAGDD8B3ssUuZKNICAr9Gw0VSHDmTH2hJ7nlo03V/nCreZQmULftMUGhqPLR0ecUwqLG6BytNX7KJHOxGOyxRNwITfcROd7DnmBlZQvusgppY5ZhRPb745d/WKHBNdHD/CMZfnxGKTuWpDyUMUNlO1synnn/q38053DsuggrFmzBq6dXNb2HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hHYEOMDNbnfHpwAuh2JwGqSsWh50C9B6TOFM/pNeWU8=; b=O2bYWng3Lt2hSGbqMlLeepiQdvbGtXSYXuqO4rse7aws/KszuHaPlkIdazX/b76pzKwEBDcRvGEoj8S09H7laTDxbDDn6/HL5OGY0BX+C+E6k31vRwHc1HZAx/pFlKLSbUSocTo56gTaCf1xzxqPsrb71mQHIqs2aS+CzrJsRPCT/lXO+Vfgov6Chwt6GpzCt/F4PsUskf900n1a7V7ckwsdIXs/WenukGP/1spA8pY/0yDovYigalZqTmcuzFg/MUvO7hvnsAd/gavjomgTj+Jl+zUWQRkKF9RvbpU5blwn8oNRrAQrUyeykjy0qUQr0a8mcC+t+M2F/stLfkGSHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by CH0PR11MB5459.namprd11.prod.outlook.com (2603:10b6:610:d2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Wed, 1 Feb 2023 15:19:13 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::610f:2851:ae4e:ebe4]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::610f:2851:ae4e:ebe4%7]) with mapi id 15.20.6064.025; Wed, 1 Feb 2023 15:19:13 +0000 Content-Type: multipart/alternative; boundary="------------xKrgx03WZIZiwM5VAVtVhp7r" Message-ID: <17cde446-25ff-6f5c-79ef-c3ba5e0a12ea@intel.com> Date: Wed, 1 Feb 2023 20:49:02 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] app/testpmd: expand noisy neighbour forward mode support Content-Language: en-US To: Mike Pattrick , Yuying Zhang CC: , References: <20230125224531.162592-1-mkp@redhat.com> <20230126045516.176917-1-mkp@redhat.com> From: "Singh, Aman Deep" In-Reply-To: <20230126045516.176917-1-mkp@redhat.com> X-ClientProxiedBy: BM1PR01CA0146.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:68::16) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR11MB0062:EE_|CH0PR11MB5459:EE_ X-MS-Office365-Filtering-Correlation-Id: d30149be-2b97-4384-3d9c-08db0467acc3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lv0xJxjHYSZe3ZjUgerKNGvobVITSXYYvfYeT3nNHF7IX3bj3gl6Yhp3K1ZMPop8J4zMKPBRWkXDxfZKzUAb/vmMduinN4ypTM3Va9yUFiqzxUz4NUspK3j6Y20tq0mqYdcUBNcw9tNA94ezqr6nA7y52roUKdLGcMExpge02iz9yYdw2tTKQkWZoCJjq2CSEVk/xr7VMF8tWHPxs3NiUP1CU0CNcFjSilwgx3yBm/DlKkDO3JdchQiQqnsUlK8ljlg/SxPtc8SJR1dfJT3by2CYhQD68mQEHupxtRgAr/x3digib4W6mz58LsXmDfF6bIOnQmZScZCF5uH5zo07TmCyjI3snxAoy/mydHAxOQCPiAbfuc3Yd2lFfrCjQ8mhGxcMgcVMzXKPljKMaGeg7KQyXd4MKev2vt+f8PrA6FlBwCrWRHq9gTPkTbaYWlRq6Y4b+SqaS10Z2kCj3wmv43sUlyOMTHSASpK3ObDmRTLrmtTSu1afNGWRNlAenKgBBI9SZkeena5IsHcZeO93/BsrIlN8DhRQX4yY4sW7i2wIryIFIKu4ykF6aCVb6k28yV2deaLPEbYfM8b66QlWFUWD5InAdLaZWmCsZ7fmDwjvO64PU/VBNxeuD/GmLQAM1rWnNU0dI2RcD2FtmtMf1iHC5gwQPTz53+zCGgVo85o8fW+OIY0dv8qdY4brtY0unJTSrUVWyaRFY4PPEVAiU+k5uroh4Shw4eKD4O7DxBU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(396003)(346002)(136003)(366004)(376002)(39860400002)(451199018)(5660300002)(36756003)(6506007)(53546011)(186003)(26005)(6512007)(82960400001)(6636002)(6666004)(38100700002)(2616005)(316002)(33964004)(110136005)(6486002)(31696002)(478600001)(66476007)(66556008)(31686004)(83380400001)(2906002)(4326008)(86362001)(8676002)(8936002)(66946007)(41300700001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y01aRlloZVh4djNsQlZpdTdsZmFHYkxGREc1ZHIwblRWVmF0ZlZ0ZW5oSzZJ?= =?utf-8?B?VHB6L2V6VHplZURoWU9qdTVZT2R1RHUxbW5mdWNSYUtSNDluTjVBTE0wblNJ?= =?utf-8?B?R1JvT09KYm5XcE42VkkzU25hNHRnekI5VG1xSnBnK3FTdzBQWG1HcWlTRlRs?= =?utf-8?B?UitYMGVpODA1UWh6Q1pSRlJMb3hzQXlYT2hyOE9IUUFjV3g2a0dwck5tZklN?= =?utf-8?B?ZzRJMUwyYjU3ZmxEMnFLQ29MOWhLd2YzL1A2RWw5QWtPbWtieG1kRFdKNkRB?= =?utf-8?B?a1ZQUUIvUENxOEE0azFCclA0VlRpUXV0UmREOEZDZVpPSU5SWU9BeUc3WURS?= =?utf-8?B?ZUZLNDVzSjVvYmEwVS95MDhSQ3hheWI0OW1wczREaFFjUTRLK2JuQUxUZkdv?= =?utf-8?B?Y2thQXpxYytyeW9IZmZna1pYaFBGRnNiNHhtWGF5ZkU3QVNuRmJBL01Cb3Vr?= =?utf-8?B?ZURPSW9sdFlHOGRyZG5DSFJKSCtzYms4RGlwQW9nR3k0RVd1amxYdkU0UzBh?= =?utf-8?B?Z0d5Qmw2dDEybmF5ZnptLzNkbFI3UlpKa1dwSm1MbHVJZHY1SGRENEdmdmly?= =?utf-8?B?MTBRb3owclJLTTR3d3JiTjNWTWFQeWRBYXBlWlNia1RhcVlwTk9lc2h3Q29t?= =?utf-8?B?ZkZyRE02WTIwNnlhYnlhV3A5MGpYbXZiSHFwUGRIYkFqVnJwcnYyaHF1WmJp?= =?utf-8?B?ZTVDczZiQ2N2Q0IvQXNxSkZpRTBVVERCbEFRNElvNEhmWU8vZHFqcW12RC9F?= =?utf-8?B?c09OK1JhbzlTS2gyOVZROUEweFN5WXMxUzVKUmRGeEZlOWU1SGRvUStKSlJk?= =?utf-8?B?b3Q4R2VoZjU1cjhYbUZSM1krbXBya3d6RFF2MzQvQzI4dElZTXZ2dXV1SmNa?= =?utf-8?B?SGxmc29CRHpDSDZSQWpWdXdhM3ZQM2NZTnNJeFo0VEIzM29LdG9DczFVVCts?= =?utf-8?B?Z1RHSW9KSFRhamZicDhNSElFRkpYNitFMDFhdTFHTTVHSFpvd2xqdjBjTERK?= =?utf-8?B?cHYrTFIwQkdFakJDaFp1MHZuWTRUSlhnbi9JcUpzdFdSRnJoK25TMkI0cGNv?= =?utf-8?B?c1hsR2pzNVBHMSt5TkFKbkxCcktkTVpoWlJyQ01IVDJZUFEyVzY0ZkhDR2ZY?= =?utf-8?B?cXhNTjlkVXd4NVdsNFIzbEFQWjdwWmxHMHhOSFpFUWlROUR5czlrVjFrNGlL?= =?utf-8?B?bXpvQVZodWJ3SXhXR0txQ3o3SDRSa0M3Mm9ROTVrZkNiRHJ2cFo5cHpaWC9V?= =?utf-8?B?MFVLaWNnVDB4RHRDRWt2cE1kUHVjc0ZYaDUxZW92UVd2YytlMFZ6MUJoVTNP?= =?utf-8?B?Sy9GaHlyeHdsZzB2TEZyM2M0OEY0QXRJdmJkN2hCUnJxMVAwNmJmMUJ6MEM2?= =?utf-8?B?eE1BalVaQlV2NEMrUm5NL0hYTFM5RmZjOEhWcXlrQnFIbmU5bFhjcEVJRjNX?= =?utf-8?B?c1ZCQzJhdHBrT1U5Y2pOSi9NbElUd3dSVUpBMFp3akpKMkpsOGlYTWt5SWJX?= =?utf-8?B?MjhnaVZ0WDJEdTZadXFwZUJZZjgwa09SUTRKdDNpNGczcmVMYVhhZVhqZDk0?= =?utf-8?B?UnVIMnAxa040RUNscjU5b0hnaFVleDV0Z3RjK2d4RWFFSVdYUmVhVDZrbWxM?= =?utf-8?B?dUFiclhNSUFrRWp6dzFxZE5QTkpDTm1aYkxWb1ZhbW1lWStGblJzYXRVL3dH?= =?utf-8?B?REhxek1CR1FIOUcraVpQZndIUlVHQ0hsU3poa3lISzRxOU0zclJudnozS0Rk?= =?utf-8?B?WEt4a1VDMHJ1ZkM2bEhJQnAyaGFjNVNuT2x0cDR4cDh2Znl2RGdDNGd2ZEw3?= =?utf-8?B?YnQ5L2U4dXh6Rjk3L0ZzREZNQ243WU1UNmViS0MxSFNIdW5zR1ZkQXEzdjI3?= =?utf-8?B?dUE1T0VqaXVQMUN2TUd3bFpkQkg1QWUzdnd5MmZReUNRVVd4ZktvMWVHM1p6?= =?utf-8?B?Q3FGeGtZS2UyUXBCaHJDK05mb2s2MS84ODdsZHNsMWR1dVAvemhmdDFJVlFT?= =?utf-8?B?WldWTVNwZzZsTmlIdlhiU3pHSnFWZFo2K0hzZGQzQXhBdnR3cFhUa2I5ZUFo?= =?utf-8?B?alVqc2FaL0ZiM092VTJSUVlJOGhoTDVwMm9MbnlYM0R5YW5IMkg0UVFpQ0lD?= =?utf-8?B?RVB4SG5VYTBEMHIvTksxemU4NmNMQ0pEWmhPbnRraXZFOUc5dkVWK1NJckd4?= =?utf-8?B?S1E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: d30149be-2b97-4384-3d9c-08db0467acc3 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2023 15:19:13.3425 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Yu5W1ZWMPr4VJeLy0LbWxUvfvVYY7v8gdIOvRDtRsV5I4IEIT11DZQ7mUZBq/V0veL3RCBfpPJkAb7vyB8NRhxG55QHjElaZSbNnI2Wv6i8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5459 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------xKrgx03WZIZiwM5VAVtVhp7r Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Hi Mike, Thanks a lot for the patch. On 1/26/2023 10:25 AM, Mike Pattrick wrote: > Previously the noisy neighbour vnf simulation would only operate in io > mode, forwarding packets as is. However, this limited the usefulness of > noisy neighbour simulation. > > This feature has now been expanded into all forwarding modes except for > ieee1588, where it isn't relevant; and iofwd, which would otherwise be > duplicative of noisy mode. Well I would first like to know, why we need noisy neighbor for all modes IMHO, do we need to add code to each mode, if most users don't use it. Secondly, can't we achieve same behavior by running testpmd instances in parallel on same NUMA node. Where one testpmd is in noisy mode. > Signed-off-by: Mike Pattrick > > --- > --------------xKrgx03WZIZiwM5VAVtVhp7r Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit 
Hi Mike,

Thanks a lot for the patch.
On 1/26/2023 10:25 AM, Mike Pattrick wrote:
Previously the noisy neighbour vnf simulation would only operate in io
mode, forwarding packets as is. However, this limited the usefulness of
noisy neighbour simulation.

This feature has now been expanded into all forwarding modes except for
ieee1588, where it isn't relevant; and iofwd, which would otherwise be
duplicative of noisy mode.

Well I would first like to know, why we need noisy neighbor for all modes
IMHO, do we need to add code to each mode, if most users don't use it.

Secondly, can't we achieve same behavior by running testpmd instances in 
parallel on same NUMA node. Where one testpmd is in noisy mode.  

Signed-off-by: Mike Pattrick <mkp@redhat.com>

---


<snip>
--------------xKrgx03WZIZiwM5VAVtVhp7r--