Re: [dpdk-dev] [RFC 0/1] A Distributed Software Event Device

["Mattias Rönnblom" <mattias.ronnblom@ericsson.com>]

On 2018-07-12 22:39, Wiles, Keith wrote:
> 
> 
>> On Jul 11, 2018, at 4:21 PM, Mattias Rönnblom <mattias.ronnblom@ericsson.com> wrote:
>>
>> This is the Distributed Software (DSW) event device, which distributes
>> the task of scheduling events among all the eventdev ports and their
>> lcore threads.
>>
>> DSW is primarily designed for atomic-only queues, but also supports
>> single-link and parallel queues.
>>
>> (DSW would be more accurately described as 'parallel', but since that
>> term is used to describe an eventdev queue type, it's referred to as
>> 'distributed', to avoid suggesting it's somehow biased toward parallel
>> queues.)
>>
>>
> 
> Just a quick look at the format of the code I notice a number of places missing a blank line after the declarations in a function e.g. dsw_xstats_port_get() an others. Just to help when you send this in as a real patch. Make sure you run checkpatch.
> 
> As for the RFC I like the idea of this RFC, but need to dig into the code.
> 

I did run checkpatch (w/ a checkpatch.pl from a newly cloned Linux 
kernel tree), but it didn't catch this.

I'll fix it. Thanks.

Regards,
	Mattias