From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0+Ctt7=J5=ericsson.com=mattias.ronnblom@lysator.liu.se>
Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3])
 by dpdk.org (Postfix) with ESMTP id DB0E41AFF
 for <dev@dpdk.org>; Fri, 13 Jul 2018 19:22:01 +0200 (CEST)
Received: from mail.lysator.liu.se (localhost [127.0.0.1])
 by mail.lysator.liu.se (Postfix) with ESMTP id 4DD9B40004
 for <dev@dpdk.org>; Fri, 13 Jul 2018 19:22:01 +0200 (CEST)
Received: by mail.lysator.liu.se (Postfix, from userid 1004)
 id 3845D4002B; Fri, 13 Jul 2018 19:22:01 +0200 (CEST)
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
 bernadotte.lysator.liu.se
X-Spam-Level: 
X-Spam-Status: No, score=-0.2 required=5.0 tests=ALL_TRUSTED,AWL
 autolearn=disabled version=3.4.1
X-Spam-Score: -0.2
Received: from [192.168.1.59] (host-90-232-4-114.mobileonline.telia.com
 [90.232.4.114])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.lysator.liu.se (Postfix) with ESMTPSA id 8DC2240004;
 Fri, 13 Jul 2018 19:21:57 +0200 (CEST)
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>
References: <20180711212154.5807-1-mattias.ronnblom@ericsson.com>
 <9D0047EC-F089-4FD5-99C7-9E611743EFD7@intel.com>
From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= <mattias.ronnblom@ericsson.com>
Message-ID: <17ce95f7-ac9b-3bd3-fb5a-4e1abbd18bc9@ericsson.com>
Date: Fri, 13 Jul 2018 19:21:56 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <9D0047EC-F089-4FD5-99C7-9E611743EFD7@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Virus-Scanned: ClamAV using ClamSMTP
Subject: Re: [dpdk-dev] [RFC 0/1] A Distributed Software Event Device
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jul 2018 17:22:02 -0000

On 2018-07-12 22:39, Wiles, Keith wrote:
> 
> 
>> On Jul 11, 2018, at 4:21 PM, Mattias Rönnblom <mattias.ronnblom@ericsson.com> wrote:
>>
>> This is the Distributed Software (DSW) event device, which distributes
>> the task of scheduling events among all the eventdev ports and their
>> lcore threads.
>>
>> DSW is primarily designed for atomic-only queues, but also supports
>> single-link and parallel queues.
>>
>> (DSW would be more accurately described as 'parallel', but since that
>> term is used to describe an eventdev queue type, it's referred to as
>> 'distributed', to avoid suggesting it's somehow biased toward parallel
>> queues.)
>>
>>
> 
> Just a quick look at the format of the code I notice a number of places missing a blank line after the declarations in a function e.g. dsw_xstats_port_get() an others. Just to help when you send this in as a real patch. Make sure you run checkpatch.
> 
> As for the RFC I like the idea of this RFC, but need to dig into the code.
> 

I did run checkpatch (w/ a checkpatch.pl from a newly cloned Linux 
kernel tree), but it didn't catch this.

I'll fix it. Thanks.

Regards,
	Mattias