From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id B38F13DC for ; Mon, 12 Jun 2017 16:08:33 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 12 Jun 2017 07:08:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,333,1493708400"; d="scan'208";a="112111270" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga005.jf.intel.com with ESMTP; 12 Jun 2017 07:08:32 -0700 To: Bruce Richardson Cc: dev@dpdk.org References: <20170606151008.62680-1-ferruh.yigit@intel.com> <20170609175120.77652-1-ferruh.yigit@intel.com> <20170609175120.77652-2-ferruh.yigit@intel.com> <20170612132505.GA66316@bricha3-MOBL3.ger.corp.intel.com> From: Ferruh Yigit Message-ID: <17d25e58-aa21-c5c6-f78c-ed581670474b@intel.com> Date: Mon, 12 Jun 2017 15:08:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170612132505.GA66316@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 2/3] net/ring: create vdev from PMD specific API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jun 2017 14:08:34 -0000 On 6/12/2017 2:25 PM, Bruce Richardson wrote: > On Fri, Jun 09, 2017 at 06:51:19PM +0100, Ferruh Yigit wrote: >> When ring PMD created via PMD specific API instead of EAL abstraction >> it is missing the virtual device creation done by EAL vdev. >> >> And this makes eth_dev unusable exact same as other PMDs used, because >> of some missing fields, like rte_device->name. >> >> Now API creates a virtual device and sets proper fields, not all, and it >> still won't be linked in the virtual device list eal keeps track. But >> makes PMD usable in usual manner. >> >> Signed-off-by: Ferruh Yigit >> --- > > Is a better fix not to have this API call into the EAL to create the > vdev and add it to the lists as with other vdevs? [If it makes it easier, > the extra parameters passed in to the library-local function can be > saved in a context that can be accessed when the EAL calls back into the > driver, rather than having to flatten them out into devargs and re-parsed > again.] Let me send the patch as suggested. Using EAL API is better idea I think, but overall this ring PMD looked like hack after changes. Please check the latest patch, if we want to keep ring PMD API, perhaps we should postpone removing drv_name patch. > > Regards, > /Bruce >