From: "Hunt, David" <david.hunt@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Zhang, Xiao" <xiao.zhang@intel.com>
Cc: dev@dpdk.org, "Liu, Yong" <yong.liu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] examples/l3fwd-power: fix RX interrupt disable
Date: Thu, 24 Oct 2019 09:07:02 +0100 [thread overview]
Message-ID: <17d41a58-909a-0650-eac2-0ffe33081ca8@intel.com> (raw)
In-Reply-To: <2827869.UTeVd217Fa@xps>
On 23/10/2019 15:32, Thomas Monjalon wrote:
> +Cc Dave, the maintainer
>
>>> Interrupt will not be received when disabling RX interrupt without
>>> synchronization mechanism sometimes which leads to wake up issue,
>>> add spinlock to fix it.
>>>
>>> Fixes: b736d64787fc ("mples/l3fwd-power: disable Rx interrupt when
>>> waking up")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Xiao Zhang <xiao.zhang@intel.com>
>>> ---
>>> examples/l3fwd-power/main.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
>>> index fd8d952..ff1ad37 100644
>>> --- a/examples/l3fwd-power/main.c
>>> +++ b/examples/l3fwd-power/main.c
>>> @@ -880,7 +880,9 @@ sleep_until_rx_interrupt(int num)
>>> port_id = ((uintptr_t)data) >> CHAR_BIT;
>>> queue_id = ((uintptr_t)data) &
>>> RTE_LEN2MASK(CHAR_BIT, uint8_t);
>>> + rte_spinlock_lock(&(locks[port_id]));
>>> rte_eth_dev_rx_intr_disable(port_id, queue_id);
>>> + rte_spinlock_unlock(&(locks[port_id]));
>>> RTE_LOG(INFO, L3FWD_POWER,
>>> "lcore %u is waked up from rx interrupt on"
>>> " port %d queue %d\n",
>>> --
>>> 2.7.4
>> Reviewed-by: Marvin Liu <yong.liu@intel.com>
Hi Marvin,
This makes sense, as the corresponding rte_eth_dev_rx_intr_enable()
already has a spinlock around it.
Acked-by: David Hunt <david.hunt@intel.com>
next prev parent reply other threads:[~2019-10-24 8:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 16:10 Xiao Zhang
2019-09-20 5:22 ` Liu, Yong
2019-10-23 14:32 ` Thomas Monjalon
2019-10-24 8:07 ` Hunt, David [this message]
2019-10-27 17:39 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17d41a58-909a-0650-eac2-0ffe33081ca8@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=xiao.zhang@intel.com \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).