* [dpdk-dev] 17.11.7-rc1 (LTS) patches review and test @ 2019-08-15 18:05 Yongseok Koh 2019-08-19 6:37 ` Pei Zhang ` (3 more replies) 0 siblings, 4 replies; 19+ messages in thread From: Yongseok Koh @ 2019-08-15 18:05 UTC (permalink / raw) To: dpdk stable Cc: dev, pezhang, siliu, fengqinx.wang, zhaoyan.chen, qian.q.xu, alialnu, rasland Hi all, Here is a list of patches targeted for LTS release 17.11.7. Please help review and test. The planned date for the final release is Aug 23, Before that, please shout if anyone has objections with these patches being applied. Also for the companies committed to running regression tests, please run the tests and report any issue before the release date. A release candidate tarball can be found at: https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 These patches are located at branch 17.11 of dpdk-stable repo: https://dpdk.org/browse/dpdk-stable/ Thanks, Yongseok --- Aaron Conole (1): net/virtio: fix dangling pointer on failure Agalya Babu RadhaKrishnan (1): doc: fix interactive commands in testpmd guide Akhil Goyal (1): crypto/dpaa2_sec: fix session clearing Alejandro Lucero (1): net/nfp: fix RSS query Anatoly Burakov (2): eal: improve musl compatibility of string functions malloc: fix documentation of realloc function Andrew Rybchenko (2): net/sfc: remove control path logging from Rx queue count app/testpmd: set fixed flag for exact link speed Andrius Sirvys (3): net/virtio: fix duplicate naming of include guard bitrate: fix unchecked return value drivers/net: fix shifting 32-bit signed variable 31 times Anoob Joseph (1): cryptodev: fix driver name comparison Beilei Xing (1): net/i40e: fix link speed for X722 Bernard Iremonger (1): examples/ipsec-secgw: fix debug logs Bill Hong (1): net: fix Tx VLAN flag for offload emulation Bruce Richardson (9): eal: support strlcat function net/bonding: fix buffer length when printing strings examples/l2fwd-cat: fix build on FreeBSD app/crypto-perf: check range of socket id examples/vhost_scsi: fix null-check for parameter net/i40e: fix dereference before null check in mbuf release net/ixgbe: fix warning with GCC 9 bus/fslmc: fix warning with GCC 9 eal: tighten permissions on shared memory files Chaitanya Babu Talluri (2): drivers/net: fix possible overflow using strlcat cfgfile: replace strcat with strlcat David Christensen (2): maintainers: update for IBM POWER examples/vm_power_manager: fix PMD specific code David Marchand (7): eal: fix check when retrieving current CPU affinity eal: remove dead code in core list parsing app/testpmd: remove unused field from port struct doc: fix examples in bonding guide net/bonding: fix port id types net/bonding: fix queue index types app/testpmd: remove useless casts on statistics Davide Caratti (1): net/bnxt: support IOVA VA mode Dekel Peled (8): net/mlx5: fix hex dump of error completion net/mlx5: fix sync when handling Tx completions eal/ppc: fix global memory barrier eal: fix typo in comment of vector function doc: fix links to doxygen and sphinx sites app/testpmd: fix typo in comment net/mlx5: fix comments mixing Rx and Tx net/mlx5: fix release of Rx queue object Fan Zhang (1): examples/ipsec-secgw: fix AES-CTR block size Ferruh Yigit (5): kni: fix build with Linux 5.1 build: fix crash by disabling AVX512 with binutils 2.31 net/ring: fix return value check net/kni: fix return value check app/testpmd: revert fixed flag for exact link speed Gage Eads (1): ring: fix namesize macro documentation block Gavin Hu (3): test/spinlock: remove delay for correct benchmarking test/spinlock: amortize the cost of getting time spinlock: reimplement with atomic one-way barrier Hari Kumar Vemula (1): net/bonding: fix reset active slave Harry van Haaren (1): event/sw: fix enqueue checks in self-test Herakliusz Lipiec (1): doc: fix broken link in LPM guide Hyong Youb Kim (4): net/bonding: avoid warning for invalid port net/enic: fix flow director SCTP matching net/enic: fix SCTP match for flow API net/enic: check for unsupported flow item types Igor Romanov (1): app/testpmd: fix stdout flush after printing stats Ilya Maximets (2): vhost: fix device leak on connection add failure vhost: fix silent queue enabling with legacy guests Ivan Malov (1): net/sfc: log port ID as 16-bit unsigned integer on panic Jerin Jacob (1): mk: fix AVX512 disabled warning on non x86 Jianfeng Tan (1): drivers/net: do not use private ethdev data Joyce Kong (1): test/rwlock: benchmark on all available cores Kevin Traynor (3): net/qede: support IOVA VA mode eal/linux: fix log levels for pagemap reading failure power: fix frequency list buffer validation Liang Zhang (1): net/bonding: fix LACP negotiation Luo Gaoliang (1): kni: fix build on RHEL8 Marcin Smoczynski (1): examples/ipsec-secgw: fix build error log Natanael Copa (3): bus/fslmc: remove unused include of error.h bus/fslmc: fix build with musl libc app/test: fix build with musl libc Pallantla Poornima (3): app/test: fix sprintf with strlcat test/distributor: replace sprintf with strlcpy test/hash: replace sprintf with snprintf Qi Zhang (1): net/i40e: fix time sync for 25G Radu Nicolau (3): net/null: add MAC address setting fake operation test/virtual_pmd: add MAC address setting fake op test/bonding: assign non-zero MAC to null devices Rahul Lakkireddy (1): net/cxgbe: update Chelsio T5/T6 NIC device ids Rami Rosen (8): net/virtio: remove forward declaration mbuf: fix a typo doc: fix a minor typo in testpmd guide doc: remove reference to rte.doc.mk in programmers guide examples/ethtool: fix two typos doc: fix link in Linux getting started guide app/testpmd: fix a typo in log message ethdev: fix a typo Rasesh Mody (2): net/bnx2x: fix race for periodic flags net/bnx2x: fix optic module verification Shahaf Shuler (1): net/mlx5: fix packet inline on Tx queue wraparound Shahed Shaikh (5): net/bnx2x: fix segfaults due to stale interrupt status net/bnx2x: fix memory leak net/bnx2x: fix ramrod timeout net/bnx2x: fix DMAE timeout net/qede: fix Tx packet prepare for tunnel packets Shreyansh Jain (1): bus/dpaa: fix Rx discard register mask Stephen Hemminger (8): net/octeontx: fix vdev name net/bnxt: fix Rx VLAN offload flags net/virtio: remove useless condition ring: fix an error message net/ring: avoid hard-coded length net/ring: use calloc style where appropriate net/ring: check length of ring name net/virtio: fix buffer leak on VLAN insert Thomas Monjalon (2): mk: fix build of shared library with libbsd bus/vdev: fix debug message on probing Tiwei Bie (4): net/virtio: add barrier in interrupt enable vhost: restore mbuf first when freeing zmbuf vhost: fix potential use-after-free for zero copy mbuf vhost: fix potential use-after-free for memory region Vishal Kulkarni (1): net/cxgbe: fix missing checksum flags and packet type Xiao Wang (1): net/fm10k: fix VLAN strip offload flag Yipeng Wang (1): hash: fix doc about thread/process safety Yongseok Koh (4): net/mlx5: fix instruction hotspot on replenishing Rx buffer net/mlx5: check Tx queue size overflow net/mlx5: fix max number of queues for NEON Tx doc: fix typo in mlx5 guide Yunjian Wang (1): net/ixgbe: fix crash on remove ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-dev] 17.11.7-rc1 (LTS) patches review and test 2019-08-15 18:05 [dpdk-dev] 17.11.7-rc1 (LTS) patches review and test Yongseok Koh @ 2019-08-19 6:37 ` Pei Zhang 2019-08-25 10:30 ` Ali Alnubani ` (2 subsequent siblings) 3 siblings, 0 replies; 19+ messages in thread From: Pei Zhang @ 2019-08-19 6:37 UTC (permalink / raw) To: Yongseok Koh Cc: dpdk stable, dev, siliu, fengqinx wang, zhaoyan chen, qian q xu, alialnu, rasland, Chao Yang Hi Yongseok, The testing looks good in my testing with 17.11.7-rc1. All get PASS. Testing scenarios: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size): PASS (3)Guest with device assignment(VF) throughput testing: PASS (4)PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS (5)PVP vhost-user 2Q throughput testing: PASS (6)PVP vhost-user 2Q - cross numa node throughput testing: PASS (7)Guest with vhost-user 2 queues throughput testing: PASS (8)vhost-user reconnect with dpdk-client, qemu-server: qemu reconnect: PASS (9)PVP 1Q live migration testing: PASS (10)PVP 2Q cross numa node live migration testing: PASS (11)Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS (12)Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS (13)Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS Versions: kernel 4.18.0 qemu: git://git.qemu.org/qemu.git master commit afd760539308a5524accf964107cdb1d54a059e3 dpdk: git://dpdk.org/dpdk remotes/origin/17.11 commit 20a49c717e829b9b45b3313c4ed18d94aa287387 (17.11.7-rc1) Thank you. Best regards, Pei ----- Original Message ----- From: "Yongseok Koh" <yskoh@mellanox.com> To: "dpdk stable" <stable@dpdk.org> Cc: dev@dpdk.org, pezhang@redhat.com, siliu@redhat.com, "fengqinx wang" <fengqinx.wang@intel.com>, "zhaoyan chen" <zhaoyan.chen@intel.com>, "qian q xu" <qian.q.xu@intel.com>, alialnu@mellanox.com, rasland@mellanox.com Sent: Friday, August 16, 2019 2:05:08 AM Subject: 17.11.7-rc1 (LTS) patches review and test Hi all, Here is a list of patches targeted for LTS release 17.11.7. Please help review and test. The planned date for the final release is Aug 23, Before that, please shout if anyone has objections with these patches being applied. Also for the companies committed to running regression tests, please run the tests and report any issue before the release date. A release candidate tarball can be found at: https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 These patches are located at branch 17.11 of dpdk-stable repo: https://dpdk.org/browse/dpdk-stable/ Thanks, Yongseok --- Aaron Conole (1): net/virtio: fix dangling pointer on failure Agalya Babu RadhaKrishnan (1): doc: fix interactive commands in testpmd guide Akhil Goyal (1): crypto/dpaa2_sec: fix session clearing Alejandro Lucero (1): net/nfp: fix RSS query Anatoly Burakov (2): eal: improve musl compatibility of string functions malloc: fix documentation of realloc function Andrew Rybchenko (2): net/sfc: remove control path logging from Rx queue count app/testpmd: set fixed flag for exact link speed Andrius Sirvys (3): net/virtio: fix duplicate naming of include guard bitrate: fix unchecked return value drivers/net: fix shifting 32-bit signed variable 31 times Anoob Joseph (1): cryptodev: fix driver name comparison Beilei Xing (1): net/i40e: fix link speed for X722 Bernard Iremonger (1): examples/ipsec-secgw: fix debug logs Bill Hong (1): net: fix Tx VLAN flag for offload emulation Bruce Richardson (9): eal: support strlcat function net/bonding: fix buffer length when printing strings examples/l2fwd-cat: fix build on FreeBSD app/crypto-perf: check range of socket id examples/vhost_scsi: fix null-check for parameter net/i40e: fix dereference before null check in mbuf release net/ixgbe: fix warning with GCC 9 bus/fslmc: fix warning with GCC 9 eal: tighten permissions on shared memory files Chaitanya Babu Talluri (2): drivers/net: fix possible overflow using strlcat cfgfile: replace strcat with strlcat David Christensen (2): maintainers: update for IBM POWER examples/vm_power_manager: fix PMD specific code David Marchand (7): eal: fix check when retrieving current CPU affinity eal: remove dead code in core list parsing app/testpmd: remove unused field from port struct doc: fix examples in bonding guide net/bonding: fix port id types net/bonding: fix queue index types app/testpmd: remove useless casts on statistics Davide Caratti (1): net/bnxt: support IOVA VA mode Dekel Peled (8): net/mlx5: fix hex dump of error completion net/mlx5: fix sync when handling Tx completions eal/ppc: fix global memory barrier eal: fix typo in comment of vector function doc: fix links to doxygen and sphinx sites app/testpmd: fix typo in comment net/mlx5: fix comments mixing Rx and Tx net/mlx5: fix release of Rx queue object Fan Zhang (1): examples/ipsec-secgw: fix AES-CTR block size Ferruh Yigit (5): kni: fix build with Linux 5.1 build: fix crash by disabling AVX512 with binutils 2.31 net/ring: fix return value check net/kni: fix return value check app/testpmd: revert fixed flag for exact link speed Gage Eads (1): ring: fix namesize macro documentation block Gavin Hu (3): test/spinlock: remove delay for correct benchmarking test/spinlock: amortize the cost of getting time spinlock: reimplement with atomic one-way barrier Hari Kumar Vemula (1): net/bonding: fix reset active slave Harry van Haaren (1): event/sw: fix enqueue checks in self-test Herakliusz Lipiec (1): doc: fix broken link in LPM guide Hyong Youb Kim (4): net/bonding: avoid warning for invalid port net/enic: fix flow director SCTP matching net/enic: fix SCTP match for flow API net/enic: check for unsupported flow item types Igor Romanov (1): app/testpmd: fix stdout flush after printing stats Ilya Maximets (2): vhost: fix device leak on connection add failure vhost: fix silent queue enabling with legacy guests Ivan Malov (1): net/sfc: log port ID as 16-bit unsigned integer on panic Jerin Jacob (1): mk: fix AVX512 disabled warning on non x86 Jianfeng Tan (1): drivers/net: do not use private ethdev data Joyce Kong (1): test/rwlock: benchmark on all available cores Kevin Traynor (3): net/qede: support IOVA VA mode eal/linux: fix log levels for pagemap reading failure power: fix frequency list buffer validation Liang Zhang (1): net/bonding: fix LACP negotiation Luo Gaoliang (1): kni: fix build on RHEL8 Marcin Smoczynski (1): examples/ipsec-secgw: fix build error log Natanael Copa (3): bus/fslmc: remove unused include of error.h bus/fslmc: fix build with musl libc app/test: fix build with musl libc Pallantla Poornima (3): app/test: fix sprintf with strlcat test/distributor: replace sprintf with strlcpy test/hash: replace sprintf with snprintf Qi Zhang (1): net/i40e: fix time sync for 25G Radu Nicolau (3): net/null: add MAC address setting fake operation test/virtual_pmd: add MAC address setting fake op test/bonding: assign non-zero MAC to null devices Rahul Lakkireddy (1): net/cxgbe: update Chelsio T5/T6 NIC device ids Rami Rosen (8): net/virtio: remove forward declaration mbuf: fix a typo doc: fix a minor typo in testpmd guide doc: remove reference to rte.doc.mk in programmers guide examples/ethtool: fix two typos doc: fix link in Linux getting started guide app/testpmd: fix a typo in log message ethdev: fix a typo Rasesh Mody (2): net/bnx2x: fix race for periodic flags net/bnx2x: fix optic module verification Shahaf Shuler (1): net/mlx5: fix packet inline on Tx queue wraparound Shahed Shaikh (5): net/bnx2x: fix segfaults due to stale interrupt status net/bnx2x: fix memory leak net/bnx2x: fix ramrod timeout net/bnx2x: fix DMAE timeout net/qede: fix Tx packet prepare for tunnel packets Shreyansh Jain (1): bus/dpaa: fix Rx discard register mask Stephen Hemminger (8): net/octeontx: fix vdev name net/bnxt: fix Rx VLAN offload flags net/virtio: remove useless condition ring: fix an error message net/ring: avoid hard-coded length net/ring: use calloc style where appropriate net/ring: check length of ring name net/virtio: fix buffer leak on VLAN insert Thomas Monjalon (2): mk: fix build of shared library with libbsd bus/vdev: fix debug message on probing Tiwei Bie (4): net/virtio: add barrier in interrupt enable vhost: restore mbuf first when freeing zmbuf vhost: fix potential use-after-free for zero copy mbuf vhost: fix potential use-after-free for memory region Vishal Kulkarni (1): net/cxgbe: fix missing checksum flags and packet type Xiao Wang (1): net/fm10k: fix VLAN strip offload flag Yipeng Wang (1): hash: fix doc about thread/process safety Yongseok Koh (4): net/mlx5: fix instruction hotspot on replenishing Rx buffer net/mlx5: check Tx queue size overflow net/mlx5: fix max number of queues for NEON Tx doc: fix typo in mlx5 guide Yunjian Wang (1): net/ixgbe: fix crash on remove ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-dev] 17.11.7-rc1 (LTS) patches review and test 2019-08-15 18:05 [dpdk-dev] 17.11.7-rc1 (LTS) patches review and test Yongseok Koh 2019-08-19 6:37 ` Pei Zhang @ 2019-08-25 10:30 ` Ali Alnubani 2019-08-29 16:10 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit [not found] ` <4A3FBC67CD7DCF48BECD235A28B050330ADA8312@SHSMSX101.ccr.corp.intel.com> 3 siblings, 0 replies; 19+ messages in thread From: Ali Alnubani @ 2019-08-25 10:30 UTC (permalink / raw) To: Yongseok Koh, dpdk stable Cc: dev, pezhang, siliu, fengqinx.wang, zhaoyan.chen, qian.q.xu, Raslan Darawsheh, Luca Boccassi Hi, The following covers the tests that we ran on top of the 17.11 LTS branch: * Basic functionality: - Send and receive multiple types of traffic. - testpmd xstats counter test. - testpmd timestamp test. - Changing/checking link status through testpmd. * RTE flow and flow_director tests. * Some RSS tests. * VLAN stripping and insertion tests. * Checksum and TSO tests. * ptype tests. * Port interrupt testing. * Multi-process testing. Tests are Ok. Tested on: RHEL7.4 (5.3.0-rc4) / rdma-core v25.0 / ConnectX-5 / fw 16.25.6406 RHEL7.4 (5.3.0-rc4) / rdma-core v25.0 / ConnectX-4 Lx / fw 14.25.6406 RHEL7.4 (3.10.0-693.el7.x86_64) / MLNX_OFED_LINUX-4.6-1.0.1.1 / ConnectX-5 / fw 16.25.6406 RHEL7.4 (3.10.0-693.el7.x86_64) / MLNX_OFED_LINUX-4.6-1.0.1.1 / ConnectX-4 Lx / fw 14.25.6406 Latest tested version: 20a49c7 version: 17.11.7-rc1 Regards, Ali > -----Original Message----- > From: Yongseok Koh <yskoh@mellanox.com> > Sent: Thursday, August 15, 2019 9:05 PM > To: dpdk stable <stable@dpdk.org> > Cc: dev@dpdk.org; pezhang@redhat.com; siliu@redhat.com; > fengqinx.wang@intel.com; zhaoyan.chen@intel.com; qian.q.xu@intel.com; > Ali Alnubani <alialnu@mellanox.com>; Raslan Darawsheh > <rasland@mellanox.com> > Subject: 17.11.7-rc1 (LTS) patches review and test > > Hi all, > > Here is a list of patches targeted for LTS release 17.11.7. Please help review > and test. The planned date for the final release is Aug 23, Before that, please > shout if anyone has objections with these patches being applied. > > Also for the companies committed to running regression tests, please run > the tests and report any issue before the release date. > > A release candidate tarball can be found at: > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk. > org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv17.11.7- > rc1&data=02%7C01%7Calialnu%40mellanox.com%7Cd202474df6e2411ce > b2c08d721ab407f%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C63 > 7014891731064651&sdata=FpRBliGWsJmHdec6Plx%2BPyphkEvOiZ2SNsg > RKOfKkBc%3D&reserved=0 > > These patches are located at branch 17.11 of dpdk-stable repo: > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk. > org%2Fbrowse%2Fdpdk- > stable%2F&data=02%7C01%7Calialnu%40mellanox.com%7Cd202474df6 > e2411ceb2c08d721ab407f%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C > 0%7C637014891731064651&sdata=WUT0YSwmWZvschGmfbZsygL9Lp3gi > %2FjXIr739QZYxcc%3D&reserved=0 > > > Thanks, > Yongseok > > --- > > Aaron Conole (1): > net/virtio: fix dangling pointer on failure > > Agalya Babu RadhaKrishnan (1): > doc: fix interactive commands in testpmd guide > > Akhil Goyal (1): > crypto/dpaa2_sec: fix session clearing > > Alejandro Lucero (1): > net/nfp: fix RSS query > > Anatoly Burakov (2): > eal: improve musl compatibility of string functions > malloc: fix documentation of realloc function > > Andrew Rybchenko (2): > net/sfc: remove control path logging from Rx queue count > app/testpmd: set fixed flag for exact link speed > > Andrius Sirvys (3): > net/virtio: fix duplicate naming of include guard > bitrate: fix unchecked return value > drivers/net: fix shifting 32-bit signed variable 31 times > > Anoob Joseph (1): > cryptodev: fix driver name comparison > > Beilei Xing (1): > net/i40e: fix link speed for X722 > > Bernard Iremonger (1): > examples/ipsec-secgw: fix debug logs > > Bill Hong (1): > net: fix Tx VLAN flag for offload emulation > > Bruce Richardson (9): > eal: support strlcat function > net/bonding: fix buffer length when printing strings > examples/l2fwd-cat: fix build on FreeBSD > app/crypto-perf: check range of socket id > examples/vhost_scsi: fix null-check for parameter > net/i40e: fix dereference before null check in mbuf release > net/ixgbe: fix warning with GCC 9 > bus/fslmc: fix warning with GCC 9 > eal: tighten permissions on shared memory files > > Chaitanya Babu Talluri (2): > drivers/net: fix possible overflow using strlcat > cfgfile: replace strcat with strlcat > > David Christensen (2): > maintainers: update for IBM POWER > examples/vm_power_manager: fix PMD specific code > > David Marchand (7): > eal: fix check when retrieving current CPU affinity > eal: remove dead code in core list parsing > app/testpmd: remove unused field from port struct > doc: fix examples in bonding guide > net/bonding: fix port id types > net/bonding: fix queue index types > app/testpmd: remove useless casts on statistics > > Davide Caratti (1): > net/bnxt: support IOVA VA mode > > Dekel Peled (8): > net/mlx5: fix hex dump of error completion > net/mlx5: fix sync when handling Tx completions > eal/ppc: fix global memory barrier > eal: fix typo in comment of vector function > doc: fix links to doxygen and sphinx sites > app/testpmd: fix typo in comment > net/mlx5: fix comments mixing Rx and Tx > net/mlx5: fix release of Rx queue object > > Fan Zhang (1): > examples/ipsec-secgw: fix AES-CTR block size > > Ferruh Yigit (5): > kni: fix build with Linux 5.1 > build: fix crash by disabling AVX512 with binutils 2.31 > net/ring: fix return value check > net/kni: fix return value check > app/testpmd: revert fixed flag for exact link speed > > Gage Eads (1): > ring: fix namesize macro documentation block > > Gavin Hu (3): > test/spinlock: remove delay for correct benchmarking > test/spinlock: amortize the cost of getting time > spinlock: reimplement with atomic one-way barrier > > Hari Kumar Vemula (1): > net/bonding: fix reset active slave > > Harry van Haaren (1): > event/sw: fix enqueue checks in self-test > > Herakliusz Lipiec (1): > doc: fix broken link in LPM guide > > Hyong Youb Kim (4): > net/bonding: avoid warning for invalid port > net/enic: fix flow director SCTP matching > net/enic: fix SCTP match for flow API > net/enic: check for unsupported flow item types > > Igor Romanov (1): > app/testpmd: fix stdout flush after printing stats > > Ilya Maximets (2): > vhost: fix device leak on connection add failure > vhost: fix silent queue enabling with legacy guests > > Ivan Malov (1): > net/sfc: log port ID as 16-bit unsigned integer on panic > > Jerin Jacob (1): > mk: fix AVX512 disabled warning on non x86 > > Jianfeng Tan (1): > drivers/net: do not use private ethdev data > > Joyce Kong (1): > test/rwlock: benchmark on all available cores > > Kevin Traynor (3): > net/qede: support IOVA VA mode > eal/linux: fix log levels for pagemap reading failure > power: fix frequency list buffer validation > > Liang Zhang (1): > net/bonding: fix LACP negotiation > > Luo Gaoliang (1): > kni: fix build on RHEL8 > > Marcin Smoczynski (1): > examples/ipsec-secgw: fix build error log > > Natanael Copa (3): > bus/fslmc: remove unused include of error.h > bus/fslmc: fix build with musl libc > app/test: fix build with musl libc > > Pallantla Poornima (3): > app/test: fix sprintf with strlcat > test/distributor: replace sprintf with strlcpy > test/hash: replace sprintf with snprintf > > Qi Zhang (1): > net/i40e: fix time sync for 25G > > Radu Nicolau (3): > net/null: add MAC address setting fake operation > test/virtual_pmd: add MAC address setting fake op > test/bonding: assign non-zero MAC to null devices > > Rahul Lakkireddy (1): > net/cxgbe: update Chelsio T5/T6 NIC device ids > > Rami Rosen (8): > net/virtio: remove forward declaration > mbuf: fix a typo > doc: fix a minor typo in testpmd guide > doc: remove reference to rte.doc.mk in programmers guide > examples/ethtool: fix two typos > doc: fix link in Linux getting started guide > app/testpmd: fix a typo in log message > ethdev: fix a typo > > Rasesh Mody (2): > net/bnx2x: fix race for periodic flags > net/bnx2x: fix optic module verification > > Shahaf Shuler (1): > net/mlx5: fix packet inline on Tx queue wraparound > > Shahed Shaikh (5): > net/bnx2x: fix segfaults due to stale interrupt status > net/bnx2x: fix memory leak > net/bnx2x: fix ramrod timeout > net/bnx2x: fix DMAE timeout > net/qede: fix Tx packet prepare for tunnel packets > > Shreyansh Jain (1): > bus/dpaa: fix Rx discard register mask > > Stephen Hemminger (8): > net/octeontx: fix vdev name > net/bnxt: fix Rx VLAN offload flags > net/virtio: remove useless condition > ring: fix an error message > net/ring: avoid hard-coded length > net/ring: use calloc style where appropriate > net/ring: check length of ring name > net/virtio: fix buffer leak on VLAN insert > > Thomas Monjalon (2): > mk: fix build of shared library with libbsd > bus/vdev: fix debug message on probing > > Tiwei Bie (4): > net/virtio: add barrier in interrupt enable > vhost: restore mbuf first when freeing zmbuf > vhost: fix potential use-after-free for zero copy mbuf > vhost: fix potential use-after-free for memory region > > Vishal Kulkarni (1): > net/cxgbe: fix missing checksum flags and packet type > > Xiao Wang (1): > net/fm10k: fix VLAN strip offload flag > > Yipeng Wang (1): > hash: fix doc about thread/process safety > > Yongseok Koh (4): > net/mlx5: fix instruction hotspot on replenishing Rx buffer > net/mlx5: check Tx queue size overflow > net/mlx5: fix max number of queues for NEON Tx > doc: fix typo in mlx5 guide > > Yunjian Wang (1): > net/ixgbe: fix crash on remove ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] 17.11.7-rc1 (LTS) patches review and test 2019-08-15 18:05 [dpdk-dev] 17.11.7-rc1 (LTS) patches review and test Yongseok Koh 2019-08-19 6:37 ` Pei Zhang 2019-08-25 10:30 ` Ali Alnubani @ 2019-08-29 16:10 ` Ferruh Yigit [not found] ` <4A3FBC67CD7DCF48BECD235A28B050330ADA95BA@SHSMSX101.ccr.corp.intel.com> [not found] ` <4A3FBC67CD7DCF48BECD235A28B050330ADA8312@SHSMSX101.ccr.corp.intel.com> 3 siblings, 1 reply; 19+ messages in thread From: Ferruh Yigit @ 2019-08-29 16:10 UTC (permalink / raw) To: Yongseok Koh, dpdk stable Cc: dev, pezhang, siliu, fengqinx.wang, zhaoyan.chen, qian.q.xu, alialnu, rasland On 8/15/2019 7:05 PM, Yongseok Koh wrote: > Hi all, > > Here is a list of patches targeted for LTS release 17.11.7. Please help review > and test. The planned date for the final release is Aug 23, Before that, please > shout if anyone has objections with these patches being applied. > > Also for the companies committed to running regression tests, please run the > tests and report any issue before the release date. > > A release candidate tarball can be found at: > > https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 > > These patches are located at branch 17.11 of dpdk-stable repo: > https://dpdk.org/browse/dpdk-stable/ I am getting build error [1] with Fedora 30 and gcc [2], the issue seems fixed in the main repo [3]. [1] [-Werror=address-of-packed-member] .../lib/librte_eal/common/eal_common_tailqs.c: In function ‘rte_eal_tailq_lookup’: .../lib/librte_eal/common/eal_common_tailqs.c:76:11: error: taking address of packed member of ‘struct rte_mem_config’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 76 | return &mcfg->tailq_head[i]; | ^~~~~~~~~~~~~~~~~~~~ .../lib/librte_eal/common/eal_common_tailqs.c: In function ‘rte_dump_tailq’: .../lib/librte_eal/common/eal_common_tailqs.c:90:23: error: taking address of packed member of ‘struct rte_mem_config’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 90 | rte_rwlock_read_lock(&mcfg->qlock); | ^~~~~~~~~~~~ .../lib/librte_eal/common/eal_common_tailqs.c:92:40: error: taking address of packed member of ‘struct rte_mem_config’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 92 | const struct rte_tailq_head *tailq = &mcfg->tailq_head[i]; | ^~~~~~~~~~~~~~~~~~~~ .../lib/librte_eal/common/eal_common_tailqs.c:98:25: error: taking address of packed member of ‘struct rte_mem_config’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 98 | rte_rwlock_read_unlock(&mcfg->qlock); | ^~~~~~~~~~~~ .../lib/librte_eal/common/eal_common_tailqs.c: In function ‘rte_eal_tailq_create’: .../lib/librte_eal/common/eal_common_tailqs.c:111:10: error: taking address of packed member of ‘struct rte_mem_config’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 111 | head = &mcfg->tailq_head[rte_tailqs_count]; | [2] $ lsb_release -a LSB Version: :core-4.1-amd64:core-4.1-noarch Distributor ID: Fedora Description: Fedora release 30 (Thirty) Release: 30 Codename: Thirty $ gcc --version gcc (GCC) 9.1.1 20190503 (Red Hat 9.1.1-1) [3] Fixes: a385972c3675 ("mk: disable warning for packed member pointer") ^ permalink raw reply [flat|nested] 19+ messages in thread
[parent not found: <4A3FBC67CD7DCF48BECD235A28B050330ADA95BA@SHSMSX101.ccr.corp.intel.com>]
* Re: [dpdk-dev] [dpdk-stable] 17.11.7-rc1 (LTS) patches review and test [not found] ` <4A3FBC67CD7DCF48BECD235A28B050330ADA95BA@SHSMSX101.ccr.corp.intel.com> @ 2019-08-30 12:58 ` Ferruh Yigit 0 siblings, 0 replies; 19+ messages in thread From: Ferruh Yigit @ 2019-08-30 12:58 UTC (permalink / raw) To: Wang, FengqinX, Yongseok Koh, dpdk stable Cc: dev, pezhang, siliu, Chen, Zhaoyan, Xu, Qian Q, alialnu, rasland On 8/30/2019 9:42 AM, Wang, FengqinX wrote: > Hi Ferruh, > > After verify, this fixes works fine after we merge it to stable 17.11.7. Thanks for verifying this. > BTW, do we have plan to apply this patch to the stable 17.11.7? It is a task for 17.11 LTS maintainer, who we don't know yet. > > BRs, Vicky > > -----Original Message----- > From: Yigit, Ferruh > Sent: Friday, August 30, 2019 12:11 AM > To: Yongseok Koh <yskoh@mellanox.com>; dpdk stable <stable@dpdk.org> > Cc: dev@dpdk.org; pezhang@redhat.com; siliu@redhat.com; Wang, FengqinX <fengqinx.wang@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; alialnu@mellanox.com; rasland@mellanox.com > Subject: Re: [dpdk-stable] 17.11.7-rc1 (LTS) patches review and test > > On 8/15/2019 7:05 PM, Yongseok Koh wrote: >> Hi all, >> >> Here is a list of patches targeted for LTS release 17.11.7. Please >> help review and test. The planned date for the final release is Aug >> 23, Before that, please shout if anyone has objections with these patches being applied. >> >> Also for the companies committed to running regression tests, please >> run the tests and report any issue before the release date. >> >> A release candidate tarball can be found at: >> >> https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 >> >> These patches are located at branch 17.11 of dpdk-stable repo: >> https://dpdk.org/browse/dpdk-stable/ > > > I am getting build error [1] with Fedora 30 and gcc [2], the issue seems fixed in the main repo [3]. > > > > [1] [-Werror=address-of-packed-member] > > .../lib/librte_eal/common/eal_common_tailqs.c: In function ‘rte_eal_tailq_lookup’: > .../lib/librte_eal/common/eal_common_tailqs.c:76:11: error: taking address of packed member of ‘struct rte_mem_config’ may result in an unaligned pointer value [-Werror=address-of-packed-member] > 76 | return &mcfg->tailq_head[i]; > | ^~~~~~~~~~~~~~~~~~~~ > .../lib/librte_eal/common/eal_common_tailqs.c: In function ‘rte_dump_tailq’: > .../lib/librte_eal/common/eal_common_tailqs.c:90:23: error: taking address of packed member of ‘struct rte_mem_config’ may result in an unaligned pointer value [-Werror=address-of-packed-member] > 90 | rte_rwlock_read_lock(&mcfg->qlock); > | ^~~~~~~~~~~~ > .../lib/librte_eal/common/eal_common_tailqs.c:92:40: error: taking address of packed member of ‘struct rte_mem_config’ may result in an unaligned pointer value [-Werror=address-of-packed-member] > 92 | const struct rte_tailq_head *tailq = &mcfg->tailq_head[i]; > | ^~~~~~~~~~~~~~~~~~~~ > .../lib/librte_eal/common/eal_common_tailqs.c:98:25: error: taking address of packed member of ‘struct rte_mem_config’ may result in an unaligned pointer value [-Werror=address-of-packed-member] > 98 | rte_rwlock_read_unlock(&mcfg->qlock); > | ^~~~~~~~~~~~ > .../lib/librte_eal/common/eal_common_tailqs.c: In function ‘rte_eal_tailq_create’: > .../lib/librte_eal/common/eal_common_tailqs.c:111:10: error: taking address of packed member of ‘struct rte_mem_config’ may result in an unaligned pointer value [-Werror=address-of-packed-member] > 111 | head = &mcfg->tailq_head[rte_tailqs_count]; > | > > [2] > $ lsb_release -a > LSB Version: :core-4.1-amd64:core-4.1-noarch > Distributor ID: Fedora > Description: Fedora release 30 (Thirty) > Release: 30 > Codename: Thirty > > $ gcc --version > gcc (GCC) 9.1.1 20190503 (Red Hat 9.1.1-1) > > > [3] > Fixes: a385972c3675 ("mk: disable warning for packed member pointer") > ^ permalink raw reply [flat|nested] 19+ messages in thread
[parent not found: <4A3FBC67CD7DCF48BECD235A28B050330ADA8312@SHSMSX101.ccr.corp.intel.com>]
[parent not found: <FD56CD4A6C7E9841B5CD62946D45F34C01B18CF1@SHSMSX104.ccr.corp.intel.com>]
* [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test [not found] ` <FD56CD4A6C7E9841B5CD62946D45F34C01B18CF1@SHSMSX104.ccr.corp.intel.com> @ 2019-09-12 8:52 ` Peng, Yuan 2019-09-17 9:53 ` Luca Boccassi 2019-09-12 8:59 ` [dpdk-dev] " Peng, Yuan 1 sibling, 1 reply; 19+ messages in thread From: Peng, Yuan @ 2019-09-12 8:52 UTC (permalink / raw) To: dev Update the latest test status here. -----Original Message----- From: Yu, PingX Sent: Thursday, September 12, 2019 2:37 PM To: Yongseok Koh <yskoh@mellanox.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>; asafp@mellanox.com Cc: Xu, Qian Q <qian.q.xu@intel.com>; Lin, Xueqin <xueqin.lin@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>; O'Hare, Cathal <cathal.ohare@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Ma, LihongX <lihongx.ma@intel.com>; Li, WenjieX A <wenjiex.a.li@intel.com>; Wang, FengqinX <fengqinx.wang@intel.com>; Peng, Yuan <yuan.peng@intel.com> Subject: RE: 17.11.7-rc1 (LTS) patches review and test All, Update the latest test status here. The critical bug has been fixed and we have re-tested all Intel key features. Intel(R) Testing result lists here. # Basic Intel(R) NIC testing * PF(i40e): One bug found in 1st round test. 2nd round test pass after fixing the bug. (see Bug1) * PF(ixgbe): the same as PF(i40e). * VF: Pass and no issue. * Build or compile: One bug found in 1st round test. 2nd round test pass after fixing the bug. (see Bug2) * Intel NIC single core/NIC performance: Pass and no issue. #Basic cryptodev and virtio testing * vhost/virtio basic loopback, PVP and performance test: pass. * cryptodev: 3 bugs are found(see bug statistic in below). (See Bug3,4 and 5) Bugs statistic: Bug1: make -C test/ failed. It blocked about 60 test cases for both PF(i40e) and PF(ixgbe). Resolved by adding "#include <inttypes.h>" into test_rwlock.c. Please decide whether submit a patch to DPDK or not. Bug2: compile error on fc30. Patch is provided and validated pass. Need to decide whether merge into DPDK or not. Bug3: L2fwd: test_qat_h_AES_XCBC_MAC_auto failed. No progress yet. commit 39fb9500c42752a537588f7a203433ec4737fa1e Author: Arek Kusztal <arkadiuszx.kusztal@intel.com> Date: Wed Dec 12 20:59:02 2018 +0100 Bug4: Ipsec-gw_test forwarding failed with null crypto QAT. No progress yet. commit 39fb9500c42752a537588f7a203433ec4737fa1e Author: Arek Kusztal <arkadiuszx.kusztal@intel.com> Date: Wed Dec 12 20:59:02 2018 +0100 Bug5: Crypto: cryptodev_qat_autotest test failed. No progress yet. 39fb9500c42752a537588f7a203433ec4737fa1e is the first bad commit commit 39fb9500c42752a537588f7a203433ec4737fa1e Author: Arek Kusztal <arkadiuszx.kusztal@intel.com> Date: Wed Dec 12 20:59:02 2018 +0100 Regards, Yu Ping -----Original Message----- From: Wang, FengqinX Sent: Monday, August 26, 2019 3:12 PM To: Yongseok Koh <yskoh@mellanox.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>; asafp@mellanox.com Cc: Xu, Qian Q <qian.q.xu@intel.com>; Lin, Xueqin <xueqin.lin@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>; O'Hare, Cathal <cathal.ohare@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Yu, PingX <pingx.yu@intel.com>; Ma, LihongX <lihongx.ma@intel.com>; Li, WenjieX A <wenjiex.a.li@intel.com> Subject: RE: 17.11.7-rc1 (LTS) patches review and test Add asafp in the loop due to Yongseok is longer working at Mellanox. BRs, Vicky -----Original Message----- From: Wang, FengqinX Sent: Monday, August 26, 2019 3:07 PM To: 'Yongseok Koh' <yskoh@mellanox.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com> Cc: Xu, Qian Q <qian.q.xu@intel.com>; Lin, Xueqin <xueqin.lin@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>; O'Hare, Cathal <cathal.ohare@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Yu, PingX <pingx.yu@intel.com>; Ma, LihongX <lihongx.ma@intel.com>; Li, WenjieX A <wenjiex.a.li@intel.com> Subject: RE: 17.11.7-rc1 (LTS) patches review and test Hi Yongseok, Konstantin, There is one critical compile issue found, and below is the bad commit related information, this issue has blocked most of unit tests which have used dpdk/test/test, would you please help to fix this issue ASAP? commit 29e08d740ffc1e0ed9e7a9bd25fb95714fac1070 Author: Joyce Kong <joyce.kong@arm.com> Date: Thu Jul 25 14:50:21 2019 +0800 test/rwlock: benchmark on all available cores [ backported from upstream commit fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] Add performance test on all available cores to benchmark the scaling up performance of rw_lock. Fixes: af75078fece3 ("first public release") Suggested-by: Gavin Hu <gavin.hu@arm.com> Signed-off-by: Joyce Kong <joyce.kong@arm.com> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> And below is the error message output: test_rwlock.c: In function 'load_loop_fn': test_rwlock.c:126:38: error: expected ')' before 'PRIu64' printf("Core [%u] rwlock_data = %"PRIu64"\n", ^~~~~~ ) test_rwlock.c:126:19: error: format '%u' expects a matching 'unsigned int' argument [-Werror=format=] printf("Core [%u] rwlock_data = %"PRIu64"\n", ~^ test_rwlock.c:126:36: error: spurious trailing '%' in format [-Werror=format=] printf("Core [%u] rwlock_data = %"PRIu64"\n", ^ test_rwlock.c: In function 'test_rwlock_perf': test_rwlock.c:160:31: error: expected ')' before 'PRIu64' printf("Core [%u] count = %"PRIu64"\n", i, lock_count[i]); ^~~~~~ ) test_rwlock.c:160:18: error: format '%u' expects a matching 'unsigned int' argument [-Werror=format=] printf("Core [%u] count = %"PRIu64"\n", i, lock_count[i]); ~^ test_rwlock.c:160:29: error: spurious trailing '%' in format [-Werror=format=] printf("Core [%u] count = %"PRIu64"\n", i, lock_count[i]); ^ test_rwlock.c:164:26: error: expected ')' before 'PRIu64' printf("Total count = %"PRIu64"\n", total); ^~~~~~ ) test_rwlock.c:164:24: error: spurious trailing '%' in format [-Werror=format=] printf("Total count = %"PRIu64"\n", total); ^ cc1: all warnings being treated as errors BRs, Vicky -----Original Message----- From: Yongseok Koh [mailto:yskoh@mellanox.com] Sent: Friday, August 16, 2019 2:05 AM To: dpdk stable <stable@dpdk.org> Cc: dev@dpdk.org; pezhang@redhat.com; siliu@redhat.com; Wang, FengqinX <fengqinx.wang@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; alialnu@mellanox.com; rasland@mellanox.com Subject: 17.11.7-rc1 (LTS) patches review and test Hi all, Here is a list of patches targeted for LTS release 17.11.7. Please help review and test. The planned date for the final release is Aug 23, Before that, please shout if anyone has objections with these patches being applied. Also for the companies committed to running regression tests, please run the tests and report any issue before the release date. A release candidate tarball can be found at: https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 These patches are located at branch 17.11 of dpdk-stable repo: https://dpdk.org/browse/dpdk-stable/ Thanks, Yongseok --- Aaron Conole (1): net/virtio: fix dangling pointer on failure Agalya Babu RadhaKrishnan (1): doc: fix interactive commands in testpmd guide Akhil Goyal (1): crypto/dpaa2_sec: fix session clearing Alejandro Lucero (1): net/nfp: fix RSS query Anatoly Burakov (2): eal: improve musl compatibility of string functions malloc: fix documentation of realloc function Andrew Rybchenko (2): net/sfc: remove control path logging from Rx queue count app/testpmd: set fixed flag for exact link speed Andrius Sirvys (3): net/virtio: fix duplicate naming of include guard bitrate: fix unchecked return value drivers/net: fix shifting 32-bit signed variable 31 times Anoob Joseph (1): cryptodev: fix driver name comparison Beilei Xing (1): net/i40e: fix link speed for X722 Bernard Iremonger (1): examples/ipsec-secgw: fix debug logs Bill Hong (1): net: fix Tx VLAN flag for offload emulation Bruce Richardson (9): eal: support strlcat function net/bonding: fix buffer length when printing strings examples/l2fwd-cat: fix build on FreeBSD app/crypto-perf: check range of socket id examples/vhost_scsi: fix null-check for parameter net/i40e: fix dereference before null check in mbuf release net/ixgbe: fix warning with GCC 9 bus/fslmc: fix warning with GCC 9 eal: tighten permissions on shared memory files Chaitanya Babu Talluri (2): drivers/net: fix possible overflow using strlcat cfgfile: replace strcat with strlcat David Christensen (2): maintainers: update for IBM POWER examples/vm_power_manager: fix PMD specific code David Marchand (7): eal: fix check when retrieving current CPU affinity eal: remove dead code in core list parsing app/testpmd: remove unused field from port struct doc: fix examples in bonding guide net/bonding: fix port id types net/bonding: fix queue index types app/testpmd: remove useless casts on statistics Davide Caratti (1): net/bnxt: support IOVA VA mode Dekel Peled (8): net/mlx5: fix hex dump of error completion net/mlx5: fix sync when handling Tx completions eal/ppc: fix global memory barrier eal: fix typo in comment of vector function doc: fix links to doxygen and sphinx sites app/testpmd: fix typo in comment net/mlx5: fix comments mixing Rx and Tx net/mlx5: fix release of Rx queue object Fan Zhang (1): examples/ipsec-secgw: fix AES-CTR block size Ferruh Yigit (5): kni: fix build with Linux 5.1 build: fix crash by disabling AVX512 with binutils 2.31 net/ring: fix return value check net/kni: fix return value check app/testpmd: revert fixed flag for exact link speed Gage Eads (1): ring: fix namesize macro documentation block Gavin Hu (3): test/spinlock: remove delay for correct benchmarking test/spinlock: amortize the cost of getting time spinlock: reimplement with atomic one-way barrier Hari Kumar Vemula (1): net/bonding: fix reset active slave Harry van Haaren (1): event/sw: fix enqueue checks in self-test Herakliusz Lipiec (1): doc: fix broken link in LPM guide Hyong Youb Kim (4): net/bonding: avoid warning for invalid port net/enic: fix flow director SCTP matching net/enic: fix SCTP match for flow API net/enic: check for unsupported flow item types Igor Romanov (1): app/testpmd: fix stdout flush after printing stats Ilya Maximets (2): vhost: fix device leak on connection add failure vhost: fix silent queue enabling with legacy guests Ivan Malov (1): net/sfc: log port ID as 16-bit unsigned integer on panic Jerin Jacob (1): mk: fix AVX512 disabled warning on non x86 Jianfeng Tan (1): drivers/net: do not use private ethdev data Joyce Kong (1): test/rwlock: benchmark on all available cores Kevin Traynor (3): net/qede: support IOVA VA mode eal/linux: fix log levels for pagemap reading failure power: fix frequency list buffer validation Liang Zhang (1): net/bonding: fix LACP negotiation Luo Gaoliang (1): kni: fix build on RHEL8 Marcin Smoczynski (1): examples/ipsec-secgw: fix build error log Natanael Copa (3): bus/fslmc: remove unused include of error.h bus/fslmc: fix build with musl libc app/test: fix build with musl libc Pallantla Poornima (3): app/test: fix sprintf with strlcat test/distributor: replace sprintf with strlcpy test/hash: replace sprintf with snprintf Qi Zhang (1): net/i40e: fix time sync for 25G Radu Nicolau (3): net/null: add MAC address setting fake operation test/virtual_pmd: add MAC address setting fake op test/bonding: assign non-zero MAC to null devices Rahul Lakkireddy (1): net/cxgbe: update Chelsio T5/T6 NIC device ids Rami Rosen (8): net/virtio: remove forward declaration mbuf: fix a typo doc: fix a minor typo in testpmd guide doc: remove reference to rte.doc.mk in programmers guide examples/ethtool: fix two typos doc: fix link in Linux getting started guide app/testpmd: fix a typo in log message ethdev: fix a typo Rasesh Mody (2): net/bnx2x: fix race for periodic flags net/bnx2x: fix optic module verification Shahaf Shuler (1): net/mlx5: fix packet inline on Tx queue wraparound Shahed Shaikh (5): net/bnx2x: fix segfaults due to stale interrupt status net/bnx2x: fix memory leak net/bnx2x: fix ramrod timeout net/bnx2x: fix DMAE timeout net/qede: fix Tx packet prepare for tunnel packets Shreyansh Jain (1): bus/dpaa: fix Rx discard register mask Stephen Hemminger (8): net/octeontx: fix vdev name net/bnxt: fix Rx VLAN offload flags net/virtio: remove useless condition ring: fix an error message net/ring: avoid hard-coded length net/ring: use calloc style where appropriate net/ring: check length of ring name net/virtio: fix buffer leak on VLAN insert Thomas Monjalon (2): mk: fix build of shared library with libbsd bus/vdev: fix debug message on probing Tiwei Bie (4): net/virtio: add barrier in interrupt enable vhost: restore mbuf first when freeing zmbuf vhost: fix potential use-after-free for zero copy mbuf vhost: fix potential use-after-free for memory region Vishal Kulkarni (1): net/cxgbe: fix missing checksum flags and packet type Xiao Wang (1): net/fm10k: fix VLAN strip offload flag Yipeng Wang (1): hash: fix doc about thread/process safety Yongseok Koh (4): net/mlx5: fix instruction hotspot on replenishing Rx buffer net/mlx5: check Tx queue size overflow net/mlx5: fix max number of queues for NEON Tx doc: fix typo in mlx5 guide Yunjian Wang (1): net/ixgbe: fix crash on remove ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test 2019-09-12 8:52 ` [dpdk-dev] FW: " Peng, Yuan @ 2019-09-17 9:53 ` Luca Boccassi 2019-09-18 9:17 ` Luca Boccassi 0 siblings, 1 reply; 19+ messages in thread From: Luca Boccassi @ 2019-09-17 9:53 UTC (permalink / raw) To: Peng, Yuan, dev Hello, Do you have a reference for the patches for bug 1 and 2? Have they been sent to the mailing list? On Thu, 2019-09-12 at 08:52 +0000, Peng, Yuan wrote: > Update the latest test status here. > > -----Original Message----- > From: Yu, PingX > Sent: Thursday, September 12, 2019 2:37 PM > To: Yongseok Koh < > yskoh@mellanox.com > >; Ananyev, Konstantin < > konstantin.ananyev@intel.com > >; > asafp@mellanox.com > > Cc: Xu, Qian Q < > qian.q.xu@intel.com > >; Lin, Xueqin < > xueqin.lin@intel.com > >; Chen, Zhaoyan < > zhaoyan.chen@intel.com > >; O'Hare, Cathal < > cathal.ohare@intel.com > >; Yigit, Ferruh < > ferruh.yigit@intel.com > >; Ma, LihongX < > lihongx.ma@intel.com > >; Li, WenjieX A < > wenjiex.a.li@intel.com > >; Wang, FengqinX < > fengqinx.wang@intel.com > >; Peng, Yuan < > yuan.peng@intel.com > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > All, > Update the latest test status here. > The critical bug has been fixed and we have re-tested all Intel key > features. > > Intel(R) Testing result lists here. > # Basic Intel(R) NIC testing > * PF(i40e): One bug found in 1st round test. 2nd round test pass > after fixing the bug. (see Bug1) > * PF(ixgbe): the same as PF(i40e). > * VF: Pass and no issue. > * Build or compile: One bug found in 1st round test. 2nd round test > pass after fixing the bug. (see Bug2) > * Intel NIC single core/NIC performance: Pass and no issue. > > #Basic cryptodev and virtio testing > * vhost/virtio basic loopback, PVP and performance test: pass. > * cryptodev: 3 bugs are found(see bug statistic in below). (See > Bug3,4 and 5) > > Bugs statistic: > Bug1: make -C test/ failed. It blocked about 60 test cases for both > PF(i40e) and PF(ixgbe). Resolved by adding "#include <inttypes.h>" > into test_rwlock.c. Please decide whether submit a patch to DPDK or > not. > Bug2: compile error on fc30. Patch is provided and validated pass. > Need to decide whether merge into DPDK or not. > Bug3: L2fwd: test_qat_h_AES_XCBC_MAC_auto failed. No progress yet. > commit 39fb9500c42752a537588f7a203433ec4737fa1e > Author: Arek Kusztal < > arkadiuszx.kusztal@intel.com > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > Bug4: Ipsec-gw_test forwarding failed with null crypto QAT. No > progress yet. > commit 39fb9500c42752a537588f7a203433ec4737fa1e > Author: Arek Kusztal < > arkadiuszx.kusztal@intel.com > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > Bug5: Crypto: cryptodev_qat_autotest test failed. No progress yet. > 39fb9500c42752a537588f7a203433ec4737fa1e is the first bad commit > commit 39fb9500c42752a537588f7a203433ec4737fa1e > Author: Arek Kusztal < > arkadiuszx.kusztal@intel.com > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > Regards, > Yu Ping > > > -----Original Message----- > From: Wang, FengqinX > Sent: Monday, August 26, 2019 3:12 PM > To: Yongseok Koh < > yskoh@mellanox.com > >; Ananyev, Konstantin < > konstantin.ananyev@intel.com > >; > asafp@mellanox.com > > Cc: Xu, Qian Q < > qian.q.xu@intel.com > >; Lin, Xueqin < > xueqin.lin@intel.com > >; Chen, Zhaoyan < > zhaoyan.chen@intel.com > >; O'Hare, Cathal < > cathal.ohare@intel.com > >; Yigit, Ferruh < > ferruh.yigit@intel.com > >; Yu, PingX < > pingx.yu@intel.com > >; Ma, LihongX < > lihongx.ma@intel.com > >; Li, WenjieX A < > wenjiex.a.li@intel.com > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > Add asafp in the loop due to Yongseok is longer working at Mellanox. > > BRs, Vicky > > -----Original Message----- > From: Wang, FengqinX > Sent: Monday, August 26, 2019 3:07 PM > To: 'Yongseok Koh' < > yskoh@mellanox.com > >; Ananyev, Konstantin < > konstantin.ananyev@intel.com > > > Cc: Xu, Qian Q < > qian.q.xu@intel.com > >; Lin, Xueqin < > xueqin.lin@intel.com > >; Chen, Zhaoyan < > zhaoyan.chen@intel.com > >; O'Hare, Cathal < > cathal.ohare@intel.com > >; Yigit, Ferruh < > ferruh.yigit@intel.com > >; Yu, PingX < > pingx.yu@intel.com > >; Ma, LihongX < > lihongx.ma@intel.com > >; Li, WenjieX A < > wenjiex.a.li@intel.com > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > Hi Yongseok, Konstantin, > > There is one critical compile issue found, and below is the bad > commit related information, this issue has blocked most of unit tests > which have used dpdk/test/test, would you please help to fix this > issue ASAP? > > commit 29e08d740ffc1e0ed9e7a9bd25fb95714fac1070 > Author: Joyce Kong < > joyce.kong@arm.com > > > Date: Thu Jul 25 14:50:21 2019 +0800 > > test/rwlock: benchmark on all available cores > > [ backported from upstream commit > fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] > > Add performance test on all available cores to benchmark > the scaling up performance of rw_lock. > > Fixes: af75078fece3 ("first public release") > > Suggested-by: Gavin Hu < > gavin.hu@arm.com > > > Signed-off-by: Joyce Kong < > joyce.kong@arm.com > > > Acked-by: Konstantin Ananyev < > konstantin.ananyev@intel.com > > > > > And below is the error message output: > > test_rwlock.c: In function 'load_loop_fn': > test_rwlock.c:126:38: error: expected ')' before 'PRIu64' > printf("Core [%u] rwlock_data = %"PRIu64"\n", ^~~~~~ > ) > test_rwlock.c:126:19: error: format '%u' expects a matching 'unsigned > int' argument [-Werror=format=] printf("Core [%u] rwlock_data = > %"PRIu64"\n", ~^ > test_rwlock.c:126:36: error: spurious trailing '%' in format [- > Werror=format=] printf("Core [%u] rwlock_data = %"PRIu64"\n", ^ > test_rwlock.c: In function 'test_rwlock_perf': > test_rwlock.c:160:31: error: expected ')' before 'PRIu64' > printf("Core [%u] count = %"PRIu64"\n", i, lock_count[i]); ^~~~~~ > ) > test_rwlock.c:160:18: error: format '%u' expects a matching 'unsigned > int' argument [-Werror=format=] printf("Core [%u] count = > %"PRIu64"\n", i, lock_count[i]); ~^ > test_rwlock.c:160:29: error: spurious trailing '%' in format [- > Werror=format=] printf("Core [%u] count = %"PRIu64"\n", i, > lock_count[i]); ^ > test_rwlock.c:164:26: error: expected ')' before 'PRIu64' > printf("Total count = %"PRIu64"\n", total); ^~~~~~ > ) > test_rwlock.c:164:24: error: spurious trailing '%' in format [- > Werror=format=] printf("Total count = %"PRIu64"\n", total); ^ > cc1: all warnings being treated as errors > > BRs, Vicky > > -----Original Message----- > From: Yongseok Koh [mailto: > yskoh@mellanox.com > ] > Sent: Friday, August 16, 2019 2:05 AM > To: dpdk stable < > stable@dpdk.org > > > Cc: > dev@dpdk.org > ; > pezhang@redhat.com > ; > siliu@redhat.com > ; Wang, FengqinX < > fengqinx.wang@intel.com > >; Chen, Zhaoyan < > zhaoyan.chen@intel.com > >; Xu, Qian Q < > qian.q.xu@intel.com > >; > alialnu@mellanox.com > ; > rasland@mellanox.com > > Subject: 17.11.7-rc1 (LTS) patches review and test > > Hi all, > > Here is a list of patches targeted for LTS release 17.11.7. Please > help review and test. The planned date for the final release is Aug > 23, Before that, please shout if anyone has objections with these > patches being applied. > > Also for the companies committed to running regression tests, please > run the tests and report any issue before the release date. > > A release candidate tarball can be found at: > > > https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 > > > These patches are located at branch 17.11 of dpdk-stable repo: > > https://dpdk.org/browse/dpdk-stable/ > > > > Thanks, > Yongseok > > --- > > Aaron Conole (1): > net/virtio: fix dangling pointer on failure > > Agalya Babu RadhaKrishnan (1): > doc: fix interactive commands in testpmd guide > > Akhil Goyal (1): > crypto/dpaa2_sec: fix session clearing > > Alejandro Lucero (1): > net/nfp: fix RSS query > > Anatoly Burakov (2): > eal: improve musl compatibility of string functions > malloc: fix documentation of realloc function > > Andrew Rybchenko (2): > net/sfc: remove control path logging from Rx queue count > app/testpmd: set fixed flag for exact link speed > > Andrius Sirvys (3): > net/virtio: fix duplicate naming of include guard > bitrate: fix unchecked return value > drivers/net: fix shifting 32-bit signed variable 31 times > > Anoob Joseph (1): > cryptodev: fix driver name comparison > > Beilei Xing (1): > net/i40e: fix link speed for X722 > > Bernard Iremonger (1): > examples/ipsec-secgw: fix debug logs > > Bill Hong (1): > net: fix Tx VLAN flag for offload emulation > > Bruce Richardson (9): > eal: support strlcat function > net/bonding: fix buffer length when printing strings > examples/l2fwd-cat: fix build on FreeBSD > app/crypto-perf: check range of socket id > examples/vhost_scsi: fix null-check for parameter > net/i40e: fix dereference before null check in mbuf release > net/ixgbe: fix warning with GCC 9 > bus/fslmc: fix warning with GCC 9 > eal: tighten permissions on shared memory files > > Chaitanya Babu Talluri (2): > drivers/net: fix possible overflow using strlcat > cfgfile: replace strcat with strlcat > > David Christensen (2): > maintainers: update for IBM POWER > examples/vm_power_manager: fix PMD specific code > > David Marchand (7): > eal: fix check when retrieving current CPU affinity > eal: remove dead code in core list parsing > app/testpmd: remove unused field from port struct > doc: fix examples in bonding guide > net/bonding: fix port id types > net/bonding: fix queue index types > app/testpmd: remove useless casts on statistics > > Davide Caratti (1): > net/bnxt: support IOVA VA mode > > Dekel Peled (8): > net/mlx5: fix hex dump of error completion > net/mlx5: fix sync when handling Tx completions > eal/ppc: fix global memory barrier > eal: fix typo in comment of vector function > doc: fix links to doxygen and sphinx sites > app/testpmd: fix typo in comment > net/mlx5: fix comments mixing Rx and Tx > net/mlx5: fix release of Rx queue object > > Fan Zhang (1): > examples/ipsec-secgw: fix AES-CTR block size > > Ferruh Yigit (5): > kni: fix build with Linux 5.1 > build: fix crash by disabling AVX512 with binutils 2.31 > net/ring: fix return value check > net/kni: fix return value check > app/testpmd: revert fixed flag for exact link speed > > Gage Eads (1): > ring: fix namesize macro documentation block > > Gavin Hu (3): > test/spinlock: remove delay for correct benchmarking > test/spinlock: amortize the cost of getting time > spinlock: reimplement with atomic one-way barrier > > Hari Kumar Vemula (1): > net/bonding: fix reset active slave > > Harry van Haaren (1): > event/sw: fix enqueue checks in self-test > > Herakliusz Lipiec (1): > doc: fix broken link in LPM guide > > Hyong Youb Kim (4): > net/bonding: avoid warning for invalid port > net/enic: fix flow director SCTP matching > net/enic: fix SCTP match for flow API > net/enic: check for unsupported flow item types > > Igor Romanov (1): > app/testpmd: fix stdout flush after printing stats > > Ilya Maximets (2): > vhost: fix device leak on connection add failure > vhost: fix silent queue enabling with legacy guests > > Ivan Malov (1): > net/sfc: log port ID as 16-bit unsigned integer on panic > > Jerin Jacob (1): > mk: fix AVX512 disabled warning on non x86 > > Jianfeng Tan (1): > drivers/net: do not use private ethdev data > > Joyce Kong (1): > test/rwlock: benchmark on all available cores > > Kevin Traynor (3): > net/qede: support IOVA VA mode > eal/linux: fix log levels for pagemap reading failure > power: fix frequency list buffer validation > > Liang Zhang (1): > net/bonding: fix LACP negotiation > > Luo Gaoliang (1): > kni: fix build on RHEL8 > > Marcin Smoczynski (1): > examples/ipsec-secgw: fix build error log > > Natanael Copa (3): > bus/fslmc: remove unused include of error.h > bus/fslmc: fix build with musl libc > app/test: fix build with musl libc > > Pallantla Poornima (3): > app/test: fix sprintf with strlcat > test/distributor: replace sprintf with strlcpy > test/hash: replace sprintf with snprintf > > Qi Zhang (1): > net/i40e: fix time sync for 25G > > Radu Nicolau (3): > net/null: add MAC address setting fake operation > test/virtual_pmd: add MAC address setting fake op > test/bonding: assign non-zero MAC to null devices > > Rahul Lakkireddy (1): > net/cxgbe: update Chelsio T5/T6 NIC device ids > > Rami Rosen (8): > net/virtio: remove forward declaration > mbuf: fix a typo > doc: fix a minor typo in testpmd guide > doc: remove reference to rte.doc.mk in programmers guide > examples/ethtool: fix two typos > doc: fix link in Linux getting started guide > app/testpmd: fix a typo in log message > ethdev: fix a typo > > Rasesh Mody (2): > net/bnx2x: fix race for periodic flags > net/bnx2x: fix optic module verification > > Shahaf Shuler (1): > net/mlx5: fix packet inline on Tx queue wraparound > > Shahed Shaikh (5): > net/bnx2x: fix segfaults due to stale interrupt status > net/bnx2x: fix memory leak > net/bnx2x: fix ramrod timeout > net/bnx2x: fix DMAE timeout > net/qede: fix Tx packet prepare for tunnel packets > > Shreyansh Jain (1): > bus/dpaa: fix Rx discard register mask > > Stephen Hemminger (8): > net/octeontx: fix vdev name > net/bnxt: fix Rx VLAN offload flags > net/virtio: remove useless condition > ring: fix an error message > net/ring: avoid hard-coded length > net/ring: use calloc style where appropriate > net/ring: check length of ring name > net/virtio: fix buffer leak on VLAN insert > > Thomas Monjalon (2): > mk: fix build of shared library with libbsd > bus/vdev: fix debug message on probing > > Tiwei Bie (4): > net/virtio: add barrier in interrupt enable > vhost: restore mbuf first when freeing zmbuf > vhost: fix potential use-after-free for zero copy mbuf > vhost: fix potential use-after-free for memory region > > Vishal Kulkarni (1): > net/cxgbe: fix missing checksum flags and packet type > > Xiao Wang (1): > net/fm10k: fix VLAN strip offload flag > > Yipeng Wang (1): > hash: fix doc about thread/process safety > > Yongseok Koh (4): > net/mlx5: fix instruction hotspot on replenishing Rx buffer > net/mlx5: check Tx queue size overflow > net/mlx5: fix max number of queues for NEON Tx > doc: fix typo in mlx5 guide > > Yunjian Wang (1): > net/ixgbe: fix crash on remove > > -- Kind regards, Luca Boccassi ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test 2019-09-17 9:53 ` Luca Boccassi @ 2019-09-18 9:17 ` Luca Boccassi 2019-09-18 10:03 ` Yu, PingX 0 siblings, 1 reply; 19+ messages in thread From: Luca Boccassi @ 2019-09-18 9:17 UTC (permalink / raw) To: Peng, Yuan, dev Hi, Ping - this is blocking the 17.11.7 release. Thanks! On Tue, 2019-09-17 at 10:53 +0100, Luca Boccassi wrote: > Hello, > > Do you have a reference for the patches for bug 1 and 2? Have they > been > sent to the mailing list? > > On Thu, 2019-09-12 at 08:52 +0000, Peng, Yuan wrote: > > Update the latest test status here. > > > > -----Original Message----- > > From: Yu, PingX > > Sent: Thursday, September 12, 2019 2:37 PM > > To: Yongseok Koh < > > yskoh@mellanox.com > > > > > ; Ananyev, Konstantin < > > > > konstantin.ananyev@intel.com > > > > > ; > > > > asafp@mellanox.com > > > > > > Cc: Xu, Qian Q < > > qian.q.xu@intel.com > > > > > ; Lin, Xueqin < > > > > xueqin.lin@intel.com > > > > > ; Chen, Zhaoyan < > > > > zhaoyan.chen@intel.com > > > > > ; O'Hare, Cathal < > > > > cathal.ohare@intel.com > > > > > ; Yigit, Ferruh < > > > > ferruh.yigit@intel.com > > > > > ; Ma, LihongX < > > > > lihongx.ma@intel.com > > > > > ; Li, WenjieX A < > > > > wenjiex.a.li@intel.com > > > > > ; Wang, FengqinX < > > > > fengqinx.wang@intel.com > > > > > ; Peng, Yuan < > > > > yuan.peng@intel.com > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > All, > > Update the latest test status here. > > The critical bug has been fixed and we have re-tested all Intel key > > features. > > > > Intel(R) Testing result lists here. > > # Basic Intel(R) NIC testing > > * PF(i40e): One bug found in 1st round test. 2nd round test pass > > after fixing the bug. (see Bug1) > > * PF(ixgbe): the same as PF(i40e). > > * VF: Pass and no issue. > > * Build or compile: One bug found in 1st round test. 2nd round test > > pass after fixing the bug. (see Bug2) > > * Intel NIC single core/NIC performance: Pass and no issue. > > > > #Basic cryptodev and virtio testing > > * vhost/virtio basic loopback, PVP and performance test: pass. > > * cryptodev: 3 bugs are found(see bug statistic in below). (See > > Bug3,4 and 5) > > > > Bugs statistic: > > Bug1: make -C test/ failed. It blocked about 60 test cases for > > both > > PF(i40e) and PF(ixgbe). Resolved by adding "#include <inttypes.h>" > > into test_rwlock.c. Please decide whether submit a patch to DPDK or > > not. > > Bug2: compile error on fc30. Patch is provided and validated pass. > > Need to decide whether merge into DPDK or not. > > Bug3: L2fwd: test_qat_h_AES_XCBC_MAC_auto failed. No progress yet. > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > Author: Arek Kusztal < > > arkadiuszx.kusztal@intel.com > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > Bug4: Ipsec-gw_test forwarding failed with null crypto QAT. No > > progress yet. > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > Author: Arek Kusztal < > > arkadiuszx.kusztal@intel.com > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > Bug5: Crypto: cryptodev_qat_autotest test failed. No progress yet. > > 39fb9500c42752a537588f7a203433ec4737fa1e is the first bad commit > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > Author: Arek Kusztal < > > arkadiuszx.kusztal@intel.com > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > Regards, > > Yu Ping > > > > > > -----Original Message----- > > From: Wang, FengqinX > > Sent: Monday, August 26, 2019 3:12 PM > > To: Yongseok Koh < > > yskoh@mellanox.com > > > > > ; Ananyev, Konstantin < > > > > konstantin.ananyev@intel.com > > > > > ; > > > > asafp@mellanox.com > > > > > > Cc: Xu, Qian Q < > > qian.q.xu@intel.com > > > > > ; Lin, Xueqin < > > > > xueqin.lin@intel.com > > > > > ; Chen, Zhaoyan < > > > > zhaoyan.chen@intel.com > > > > > ; O'Hare, Cathal < > > > > cathal.ohare@intel.com > > > > > ; Yigit, Ferruh < > > > > ferruh.yigit@intel.com > > > > > ; Yu, PingX < > > > > pingx.yu@intel.com > > > > > ; Ma, LihongX < > > > > lihongx.ma@intel.com > > > > > ; Li, WenjieX A < > > > > wenjiex.a.li@intel.com > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > Add asafp in the loop due to Yongseok is longer working at > > Mellanox. > > > > BRs, Vicky > > > > -----Original Message----- > > From: Wang, FengqinX > > Sent: Monday, August 26, 2019 3:07 PM > > To: 'Yongseok Koh' < > > yskoh@mellanox.com > > > > > ; Ananyev, Konstantin < > > > > konstantin.ananyev@intel.com > > > > > > Cc: Xu, Qian Q < > > qian.q.xu@intel.com > > > > > ; Lin, Xueqin < > > > > xueqin.lin@intel.com > > > > > ; Chen, Zhaoyan < > > > > zhaoyan.chen@intel.com > > > > > ; O'Hare, Cathal < > > > > cathal.ohare@intel.com > > > > > ; Yigit, Ferruh < > > > > ferruh.yigit@intel.com > > > > > ; Yu, PingX < > > > > pingx.yu@intel.com > > > > > ; Ma, LihongX < > > > > lihongx.ma@intel.com > > > > > ; Li, WenjieX A < > > > > wenjiex.a.li@intel.com > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > Hi Yongseok, Konstantin, > > > > There is one critical compile issue found, and below is the bad > > commit related information, this issue has blocked most of unit > > tests > > which have used dpdk/test/test, would you please help to fix this > > issue ASAP? > > > > commit 29e08d740ffc1e0ed9e7a9bd25fb95714fac1070 > > Author: Joyce Kong < > > joyce.kong@arm.com > > > > > > Date: Thu Jul 25 14:50:21 2019 +0800 > > > > test/rwlock: benchmark on all available cores > > > > [ backported from upstream commit > > fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] > > > > Add performance test on all available cores to benchmark > > the scaling up performance of rw_lock. > > > > Fixes: af75078fece3 ("first public release") > > > > Suggested-by: Gavin Hu < > > gavin.hu@arm.com > > > > > > Signed-off-by: Joyce Kong < > > joyce.kong@arm.com > > > > > > Acked-by: Konstantin Ananyev < > > konstantin.ananyev@intel.com > > > > > > > > And below is the error message output: > > > > test_rwlock.c: In function 'load_loop_fn': > > test_rwlock.c:126:38: error: expected ')' before 'PRIu64' > > printf("Core [%u] rwlock_data = %"PRIu64"\n", ^~~~~~ > > ) > > test_rwlock.c:126:19: error: format '%u' expects a matching > > 'unsigned > > int' argument [-Werror=format=] printf("Core [%u] rwlock_data = > > %"PRIu64"\n", ~^ > > test_rwlock.c:126:36: error: spurious trailing '%' in format [- > > Werror=format=] printf("Core [%u] rwlock_data = %"PRIu64"\n", ^ > > test_rwlock.c: In function 'test_rwlock_perf': > > test_rwlock.c:160:31: error: expected ')' before 'PRIu64' > > printf("Core [%u] count = %"PRIu64"\n", i, lock_count[i]); ^~~~~~ > > ) > > test_rwlock.c:160:18: error: format '%u' expects a matching > > 'unsigned > > int' argument [-Werror=format=] printf("Core [%u] count = > > %"PRIu64"\n", i, lock_count[i]); ~^ > > test_rwlock.c:160:29: error: spurious trailing '%' in format [- > > Werror=format=] printf("Core [%u] count = %"PRIu64"\n", i, > > lock_count[i]); ^ > > test_rwlock.c:164:26: error: expected ')' before 'PRIu64' > > printf("Total count = %"PRIu64"\n", total); ^~~~~~ > > ) > > test_rwlock.c:164:24: error: spurious trailing '%' in format [- > > Werror=format=] printf("Total count = %"PRIu64"\n", total); ^ > > cc1: all warnings being treated as errors > > > > BRs, Vicky > > > > -----Original Message----- > > From: Yongseok Koh [mailto: > > yskoh@mellanox.com > > > > ] > > Sent: Friday, August 16, 2019 2:05 AM > > To: dpdk stable < > > stable@dpdk.org > > > > > > Cc: > > dev@dpdk.org > > > > ; > > pezhang@redhat.com > > > > ; > > siliu@redhat.com > > > > ; Wang, FengqinX < > > fengqinx.wang@intel.com > > > > > ; Chen, Zhaoyan < > > > > zhaoyan.chen@intel.com > > > > > ; Xu, Qian Q < > > > > qian.q.xu@intel.com > > > > > ; > > > > alialnu@mellanox.com > > > > ; > > rasland@mellanox.com > > > > > > Subject: 17.11.7-rc1 (LTS) patches review and test > > > > Hi all, > > > > Here is a list of patches targeted for LTS release 17.11.7. Please > > help review and test. The planned date for the final release is Aug > > 23, Before that, please shout if anyone has objections with these > > patches being applied. > > > > Also for the companies committed to running regression tests, > > please > > run the tests and report any issue before the release date. > > > > A release candidate tarball can be found at: > > > > > > https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 > > > > > > > > These patches are located at branch 17.11 of dpdk-stable repo: > > > > https://dpdk.org/browse/dpdk-stable/ > > > > > > > > > > Thanks, > > Yongseok > > > > --- > > > > Aaron Conole (1): > > net/virtio: fix dangling pointer on failure > > > > Agalya Babu RadhaKrishnan (1): > > doc: fix interactive commands in testpmd guide > > > > Akhil Goyal (1): > > crypto/dpaa2_sec: fix session clearing > > > > Alejandro Lucero (1): > > net/nfp: fix RSS query > > > > Anatoly Burakov (2): > > eal: improve musl compatibility of string functions > > malloc: fix documentation of realloc function > > > > Andrew Rybchenko (2): > > net/sfc: remove control path logging from Rx queue count > > app/testpmd: set fixed flag for exact link speed > > > > Andrius Sirvys (3): > > net/virtio: fix duplicate naming of include guard > > bitrate: fix unchecked return value > > drivers/net: fix shifting 32-bit signed variable 31 times > > > > Anoob Joseph (1): > > cryptodev: fix driver name comparison > > > > Beilei Xing (1): > > net/i40e: fix link speed for X722 > > > > Bernard Iremonger (1): > > examples/ipsec-secgw: fix debug logs > > > > Bill Hong (1): > > net: fix Tx VLAN flag for offload emulation > > > > Bruce Richardson (9): > > eal: support strlcat function > > net/bonding: fix buffer length when printing strings > > examples/l2fwd-cat: fix build on FreeBSD > > app/crypto-perf: check range of socket id > > examples/vhost_scsi: fix null-check for parameter > > net/i40e: fix dereference before null check in mbuf release > > net/ixgbe: fix warning with GCC 9 > > bus/fslmc: fix warning with GCC 9 > > eal: tighten permissions on shared memory files > > > > Chaitanya Babu Talluri (2): > > drivers/net: fix possible overflow using strlcat > > cfgfile: replace strcat with strlcat > > > > David Christensen (2): > > maintainers: update for IBM POWER > > examples/vm_power_manager: fix PMD specific code > > > > David Marchand (7): > > eal: fix check when retrieving current CPU affinity > > eal: remove dead code in core list parsing > > app/testpmd: remove unused field from port struct > > doc: fix examples in bonding guide > > net/bonding: fix port id types > > net/bonding: fix queue index types > > app/testpmd: remove useless casts on statistics > > > > Davide Caratti (1): > > net/bnxt: support IOVA VA mode > > > > Dekel Peled (8): > > net/mlx5: fix hex dump of error completion > > net/mlx5: fix sync when handling Tx completions > > eal/ppc: fix global memory barrier > > eal: fix typo in comment of vector function > > doc: fix links to doxygen and sphinx sites > > app/testpmd: fix typo in comment > > net/mlx5: fix comments mixing Rx and Tx > > net/mlx5: fix release of Rx queue object > > > > Fan Zhang (1): > > examples/ipsec-secgw: fix AES-CTR block size > > > > Ferruh Yigit (5): > > kni: fix build with Linux 5.1 > > build: fix crash by disabling AVX512 with binutils 2.31 > > net/ring: fix return value check > > net/kni: fix return value check > > app/testpmd: revert fixed flag for exact link speed > > > > Gage Eads (1): > > ring: fix namesize macro documentation block > > > > Gavin Hu (3): > > test/spinlock: remove delay for correct benchmarking > > test/spinlock: amortize the cost of getting time > > spinlock: reimplement with atomic one-way barrier > > > > Hari Kumar Vemula (1): > > net/bonding: fix reset active slave > > > > Harry van Haaren (1): > > event/sw: fix enqueue checks in self-test > > > > Herakliusz Lipiec (1): > > doc: fix broken link in LPM guide > > > > Hyong Youb Kim (4): > > net/bonding: avoid warning for invalid port > > net/enic: fix flow director SCTP matching > > net/enic: fix SCTP match for flow API > > net/enic: check for unsupported flow item types > > > > Igor Romanov (1): > > app/testpmd: fix stdout flush after printing stats > > > > Ilya Maximets (2): > > vhost: fix device leak on connection add failure > > vhost: fix silent queue enabling with legacy guests > > > > Ivan Malov (1): > > net/sfc: log port ID as 16-bit unsigned integer on panic > > > > Jerin Jacob (1): > > mk: fix AVX512 disabled warning on non x86 > > > > Jianfeng Tan (1): > > drivers/net: do not use private ethdev data > > > > Joyce Kong (1): > > test/rwlock: benchmark on all available cores > > > > Kevin Traynor (3): > > net/qede: support IOVA VA mode > > eal/linux: fix log levels for pagemap reading failure > > power: fix frequency list buffer validation > > > > Liang Zhang (1): > > net/bonding: fix LACP negotiation > > > > Luo Gaoliang (1): > > kni: fix build on RHEL8 > > > > Marcin Smoczynski (1): > > examples/ipsec-secgw: fix build error log > > > > Natanael Copa (3): > > bus/fslmc: remove unused include of error.h > > bus/fslmc: fix build with musl libc > > app/test: fix build with musl libc > > > > Pallantla Poornima (3): > > app/test: fix sprintf with strlcat > > test/distributor: replace sprintf with strlcpy > > test/hash: replace sprintf with snprintf > > > > Qi Zhang (1): > > net/i40e: fix time sync for 25G > > > > Radu Nicolau (3): > > net/null: add MAC address setting fake operation > > test/virtual_pmd: add MAC address setting fake op > > test/bonding: assign non-zero MAC to null devices > > > > Rahul Lakkireddy (1): > > net/cxgbe: update Chelsio T5/T6 NIC device ids > > > > Rami Rosen (8): > > net/virtio: remove forward declaration > > mbuf: fix a typo > > doc: fix a minor typo in testpmd guide > > doc: remove reference to rte.doc.mk in programmers guide > > examples/ethtool: fix two typos > > doc: fix link in Linux getting started guide > > app/testpmd: fix a typo in log message > > ethdev: fix a typo > > > > Rasesh Mody (2): > > net/bnx2x: fix race for periodic flags > > net/bnx2x: fix optic module verification > > > > Shahaf Shuler (1): > > net/mlx5: fix packet inline on Tx queue wraparound > > > > Shahed Shaikh (5): > > net/bnx2x: fix segfaults due to stale interrupt status > > net/bnx2x: fix memory leak > > net/bnx2x: fix ramrod timeout > > net/bnx2x: fix DMAE timeout > > net/qede: fix Tx packet prepare for tunnel packets > > > > Shreyansh Jain (1): > > bus/dpaa: fix Rx discard register mask > > > > Stephen Hemminger (8): > > net/octeontx: fix vdev name > > net/bnxt: fix Rx VLAN offload flags > > net/virtio: remove useless condition > > ring: fix an error message > > net/ring: avoid hard-coded length > > net/ring: use calloc style where appropriate > > net/ring: check length of ring name > > net/virtio: fix buffer leak on VLAN insert > > > > Thomas Monjalon (2): > > mk: fix build of shared library with libbsd > > bus/vdev: fix debug message on probing > > > > Tiwei Bie (4): > > net/virtio: add barrier in interrupt enable > > vhost: restore mbuf first when freeing zmbuf > > vhost: fix potential use-after-free for zero copy mbuf > > vhost: fix potential use-after-free for memory region > > > > Vishal Kulkarni (1): > > net/cxgbe: fix missing checksum flags and packet type > > > > Xiao Wang (1): > > net/fm10k: fix VLAN strip offload flag > > > > Yipeng Wang (1): > > hash: fix doc about thread/process safety > > > > Yongseok Koh (4): > > net/mlx5: fix instruction hotspot on replenishing Rx buffer > > net/mlx5: check Tx queue size overflow > > net/mlx5: fix max number of queues for NEON Tx > > doc: fix typo in mlx5 guide > > > > Yunjian Wang (1): > > net/ixgbe: fix crash on remove > > > > -- Kind regards, Luca Boccassi ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test 2019-09-18 9:17 ` Luca Boccassi @ 2019-09-18 10:03 ` Yu, PingX 2019-09-24 11:07 ` Luca Boccassi 0 siblings, 1 reply; 19+ messages in thread From: Yu, PingX @ 2019-09-18 10:03 UTC (permalink / raw) To: Luca Boccassi, Peng, Yuan, dev Luca, FYI. Currently there isn't reference for bug1 and bug2 and also haven't send to mailing list yet. These bugs should be fixed before release as they will block the basic PF test. Regards, Yu Ping -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Luca Boccassi Sent: Wednesday, September 18, 2019 5:18 PM To: Peng, Yuan <yuan.peng@intel.com>; dev@dpdk.org Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test Hi, Ping - this is blocking the 17.11.7 release. Thanks! On Tue, 2019-09-17 at 10:53 +0100, Luca Boccassi wrote: > Hello, > > Do you have a reference for the patches for bug 1 and 2? Have they > been sent to the mailing list? > > On Thu, 2019-09-12 at 08:52 +0000, Peng, Yuan wrote: > > Update the latest test status here. > > > > -----Original Message----- > > From: Yu, PingX > > Sent: Thursday, September 12, 2019 2:37 PM > > To: Yongseok Koh < > > yskoh@mellanox.com > > > > > ; Ananyev, Konstantin < > > > > konstantin.ananyev@intel.com > > > > > ; > > > > asafp@mellanox.com > > > > > > Cc: Xu, Qian Q < > > qian.q.xu@intel.com > > > > > ; Lin, Xueqin < > > > > xueqin.lin@intel.com > > > > > ; Chen, Zhaoyan < > > > > zhaoyan.chen@intel.com > > > > > ; O'Hare, Cathal < > > > > cathal.ohare@intel.com > > > > > ; Yigit, Ferruh < > > > > ferruh.yigit@intel.com > > > > > ; Ma, LihongX < > > > > lihongx.ma@intel.com > > > > > ; Li, WenjieX A < > > > > wenjiex.a.li@intel.com > > > > > ; Wang, FengqinX < > > > > fengqinx.wang@intel.com > > > > > ; Peng, Yuan < > > > > yuan.peng@intel.com > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > All, > > Update the latest test status here. > > The critical bug has been fixed and we have re-tested all Intel key > > features. > > > > Intel(R) Testing result lists here. > > # Basic Intel(R) NIC testing > > * PF(i40e): One bug found in 1st round test. 2nd round test pass > > after fixing the bug. (see Bug1) > > * PF(ixgbe): the same as PF(i40e). > > * VF: Pass and no issue. > > * Build or compile: One bug found in 1st round test. 2nd round test > > pass after fixing the bug. (see Bug2) > > * Intel NIC single core/NIC performance: Pass and no issue. > > > > #Basic cryptodev and virtio testing > > * vhost/virtio basic loopback, PVP and performance test: pass. > > * cryptodev: 3 bugs are found(see bug statistic in below). (See > > Bug3,4 and 5) > > > > Bugs statistic: > > Bug1: make -C test/ failed. It blocked about 60 test cases for both > > PF(i40e) and PF(ixgbe). Resolved by adding "#include <inttypes.h>" > > into test_rwlock.c. Please decide whether submit a patch to DPDK or > > not. > > Bug2: compile error on fc30. Patch is provided and validated pass. > > Need to decide whether merge into DPDK or not. > > Bug3: L2fwd: test_qat_h_AES_XCBC_MAC_auto failed. No progress yet. > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > Author: Arek Kusztal < > > arkadiuszx.kusztal@intel.com > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > Bug4: Ipsec-gw_test forwarding failed with null crypto QAT. No > > progress yet. > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > Author: Arek Kusztal < > > arkadiuszx.kusztal@intel.com > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > Bug5: Crypto: cryptodev_qat_autotest test failed. No progress yet. > > 39fb9500c42752a537588f7a203433ec4737fa1e is the first bad commit > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > Author: Arek Kusztal < > > arkadiuszx.kusztal@intel.com > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > Regards, > > Yu Ping > > > > > > -----Original Message----- > > From: Wang, FengqinX > > Sent: Monday, August 26, 2019 3:12 PM > > To: Yongseok Koh < > > yskoh@mellanox.com > > > > > ; Ananyev, Konstantin < > > > > konstantin.ananyev@intel.com > > > > > ; > > > > asafp@mellanox.com > > > > > > Cc: Xu, Qian Q < > > qian.q.xu@intel.com > > > > > ; Lin, Xueqin < > > > > xueqin.lin@intel.com > > > > > ; Chen, Zhaoyan < > > > > zhaoyan.chen@intel.com > > > > > ; O'Hare, Cathal < > > > > cathal.ohare@intel.com > > > > > ; Yigit, Ferruh < > > > > ferruh.yigit@intel.com > > > > > ; Yu, PingX < > > > > pingx.yu@intel.com > > > > > ; Ma, LihongX < > > > > lihongx.ma@intel.com > > > > > ; Li, WenjieX A < > > > > wenjiex.a.li@intel.com > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > Add asafp in the loop due to Yongseok is longer working at Mellanox. > > > > BRs, Vicky > > > > -----Original Message----- > > From: Wang, FengqinX > > Sent: Monday, August 26, 2019 3:07 PM > > To: 'Yongseok Koh' < > > yskoh@mellanox.com > > > > > ; Ananyev, Konstantin < > > > > konstantin.ananyev@intel.com > > > > > > Cc: Xu, Qian Q < > > qian.q.xu@intel.com > > > > > ; Lin, Xueqin < > > > > xueqin.lin@intel.com > > > > > ; Chen, Zhaoyan < > > > > zhaoyan.chen@intel.com > > > > > ; O'Hare, Cathal < > > > > cathal.ohare@intel.com > > > > > ; Yigit, Ferruh < > > > > ferruh.yigit@intel.com > > > > > ; Yu, PingX < > > > > pingx.yu@intel.com > > > > > ; Ma, LihongX < > > > > lihongx.ma@intel.com > > > > > ; Li, WenjieX A < > > > > wenjiex.a.li@intel.com > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > Hi Yongseok, Konstantin, > > > > There is one critical compile issue found, and below is the bad > > commit related information, this issue has blocked most of unit > > tests which have used dpdk/test/test, would you please help to fix > > this issue ASAP? > > > > commit 29e08d740ffc1e0ed9e7a9bd25fb95714fac1070 > > Author: Joyce Kong < > > joyce.kong@arm.com > > > > > > Date: Thu Jul 25 14:50:21 2019 +0800 > > > > test/rwlock: benchmark on all available cores > > > > [ backported from upstream commit > > fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] > > > > Add performance test on all available cores to benchmark > > the scaling up performance of rw_lock. > > > > Fixes: af75078fece3 ("first public release") > > > > Suggested-by: Gavin Hu < > > gavin.hu@arm.com > > > > > > Signed-off-by: Joyce Kong < > > joyce.kong@arm.com > > > > > > Acked-by: Konstantin Ananyev < > > konstantin.ananyev@intel.com > > > > > > > > And below is the error message output: > > > > test_rwlock.c: In function 'load_loop_fn': > > test_rwlock.c:126:38: error: expected ')' before 'PRIu64' > > printf("Core [%u] rwlock_data = %"PRIu64"\n", ^~~~~~ > > ) > > test_rwlock.c:126:19: error: format '%u' expects a matching > > 'unsigned int' argument [-Werror=format=] printf("Core [%u] > > rwlock_data = %"PRIu64"\n", ~^ > > test_rwlock.c:126:36: error: spurious trailing '%' in format [- > > Werror=format=] printf("Core [%u] rwlock_data = %"PRIu64"\n", ^ > > test_rwlock.c: In function 'test_rwlock_perf': > > test_rwlock.c:160:31: error: expected ')' before 'PRIu64' > > printf("Core [%u] count = %"PRIu64"\n", i, lock_count[i]); ^~~~~~ > > ) > > test_rwlock.c:160:18: error: format '%u' expects a matching > > 'unsigned int' argument [-Werror=format=] printf("Core [%u] count = > > %"PRIu64"\n", i, lock_count[i]); ~^ > > test_rwlock.c:160:29: error: spurious trailing '%' in format [- > > Werror=format=] printf("Core [%u] count = %"PRIu64"\n", i, > > lock_count[i]); ^ > > test_rwlock.c:164:26: error: expected ')' before 'PRIu64' > > printf("Total count = %"PRIu64"\n", total); ^~~~~~ > > ) > > test_rwlock.c:164:24: error: spurious trailing '%' in format [- > > Werror=format=] printf("Total count = %"PRIu64"\n", total); ^ > > cc1: all warnings being treated as errors > > > > BRs, Vicky > > > > -----Original Message----- > > From: Yongseok Koh [mailto: > > yskoh@mellanox.com > > > > ] > > Sent: Friday, August 16, 2019 2:05 AM > > To: dpdk stable < > > stable@dpdk.org > > > > > > Cc: > > dev@dpdk.org > > > > ; > > pezhang@redhat.com > > > > ; > > siliu@redhat.com > > > > ; Wang, FengqinX < > > fengqinx.wang@intel.com > > > > > ; Chen, Zhaoyan < > > > > zhaoyan.chen@intel.com > > > > > ; Xu, Qian Q < > > > > qian.q.xu@intel.com > > > > > ; > > > > alialnu@mellanox.com > > > > ; > > rasland@mellanox.com > > > > > > Subject: 17.11.7-rc1 (LTS) patches review and test > > > > Hi all, > > > > Here is a list of patches targeted for LTS release 17.11.7. Please > > help review and test. The planned date for the final release is Aug > > 23, Before that, please shout if anyone has objections with these > > patches being applied. > > > > Also for the companies committed to running regression tests, please > > run the tests and report any issue before the release date. > > > > A release candidate tarball can be found at: > > > > > > https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 > > > > > > > > These patches are located at branch 17.11 of dpdk-stable repo: > > > > https://dpdk.org/browse/dpdk-stable/ > > > > > > > > > > Thanks, > > Yongseok > > > > --- > > > > Aaron Conole (1): > > net/virtio: fix dangling pointer on failure > > > > Agalya Babu RadhaKrishnan (1): > > doc: fix interactive commands in testpmd guide > > > > Akhil Goyal (1): > > crypto/dpaa2_sec: fix session clearing > > > > Alejandro Lucero (1): > > net/nfp: fix RSS query > > > > Anatoly Burakov (2): > > eal: improve musl compatibility of string functions > > malloc: fix documentation of realloc function > > > > Andrew Rybchenko (2): > > net/sfc: remove control path logging from Rx queue count > > app/testpmd: set fixed flag for exact link speed > > > > Andrius Sirvys (3): > > net/virtio: fix duplicate naming of include guard > > bitrate: fix unchecked return value > > drivers/net: fix shifting 32-bit signed variable 31 times > > > > Anoob Joseph (1): > > cryptodev: fix driver name comparison > > > > Beilei Xing (1): > > net/i40e: fix link speed for X722 > > > > Bernard Iremonger (1): > > examples/ipsec-secgw: fix debug logs > > > > Bill Hong (1): > > net: fix Tx VLAN flag for offload emulation > > > > Bruce Richardson (9): > > eal: support strlcat function > > net/bonding: fix buffer length when printing strings > > examples/l2fwd-cat: fix build on FreeBSD > > app/crypto-perf: check range of socket id > > examples/vhost_scsi: fix null-check for parameter > > net/i40e: fix dereference before null check in mbuf release > > net/ixgbe: fix warning with GCC 9 > > bus/fslmc: fix warning with GCC 9 > > eal: tighten permissions on shared memory files > > > > Chaitanya Babu Talluri (2): > > drivers/net: fix possible overflow using strlcat > > cfgfile: replace strcat with strlcat > > > > David Christensen (2): > > maintainers: update for IBM POWER > > examples/vm_power_manager: fix PMD specific code > > > > David Marchand (7): > > eal: fix check when retrieving current CPU affinity > > eal: remove dead code in core list parsing > > app/testpmd: remove unused field from port struct > > doc: fix examples in bonding guide > > net/bonding: fix port id types > > net/bonding: fix queue index types > > app/testpmd: remove useless casts on statistics > > > > Davide Caratti (1): > > net/bnxt: support IOVA VA mode > > > > Dekel Peled (8): > > net/mlx5: fix hex dump of error completion > > net/mlx5: fix sync when handling Tx completions > > eal/ppc: fix global memory barrier > > eal: fix typo in comment of vector function > > doc: fix links to doxygen and sphinx sites > > app/testpmd: fix typo in comment > > net/mlx5: fix comments mixing Rx and Tx > > net/mlx5: fix release of Rx queue object > > > > Fan Zhang (1): > > examples/ipsec-secgw: fix AES-CTR block size > > > > Ferruh Yigit (5): > > kni: fix build with Linux 5.1 > > build: fix crash by disabling AVX512 with binutils 2.31 > > net/ring: fix return value check > > net/kni: fix return value check > > app/testpmd: revert fixed flag for exact link speed > > > > Gage Eads (1): > > ring: fix namesize macro documentation block > > > > Gavin Hu (3): > > test/spinlock: remove delay for correct benchmarking > > test/spinlock: amortize the cost of getting time > > spinlock: reimplement with atomic one-way barrier > > > > Hari Kumar Vemula (1): > > net/bonding: fix reset active slave > > > > Harry van Haaren (1): > > event/sw: fix enqueue checks in self-test > > > > Herakliusz Lipiec (1): > > doc: fix broken link in LPM guide > > > > Hyong Youb Kim (4): > > net/bonding: avoid warning for invalid port > > net/enic: fix flow director SCTP matching > > net/enic: fix SCTP match for flow API > > net/enic: check for unsupported flow item types > > > > Igor Romanov (1): > > app/testpmd: fix stdout flush after printing stats > > > > Ilya Maximets (2): > > vhost: fix device leak on connection add failure > > vhost: fix silent queue enabling with legacy guests > > > > Ivan Malov (1): > > net/sfc: log port ID as 16-bit unsigned integer on panic > > > > Jerin Jacob (1): > > mk: fix AVX512 disabled warning on non x86 > > > > Jianfeng Tan (1): > > drivers/net: do not use private ethdev data > > > > Joyce Kong (1): > > test/rwlock: benchmark on all available cores > > > > Kevin Traynor (3): > > net/qede: support IOVA VA mode > > eal/linux: fix log levels for pagemap reading failure > > power: fix frequency list buffer validation > > > > Liang Zhang (1): > > net/bonding: fix LACP negotiation > > > > Luo Gaoliang (1): > > kni: fix build on RHEL8 > > > > Marcin Smoczynski (1): > > examples/ipsec-secgw: fix build error log > > > > Natanael Copa (3): > > bus/fslmc: remove unused include of error.h > > bus/fslmc: fix build with musl libc > > app/test: fix build with musl libc > > > > Pallantla Poornima (3): > > app/test: fix sprintf with strlcat > > test/distributor: replace sprintf with strlcpy > > test/hash: replace sprintf with snprintf > > > > Qi Zhang (1): > > net/i40e: fix time sync for 25G > > > > Radu Nicolau (3): > > net/null: add MAC address setting fake operation > > test/virtual_pmd: add MAC address setting fake op > > test/bonding: assign non-zero MAC to null devices > > > > Rahul Lakkireddy (1): > > net/cxgbe: update Chelsio T5/T6 NIC device ids > > > > Rami Rosen (8): > > net/virtio: remove forward declaration > > mbuf: fix a typo > > doc: fix a minor typo in testpmd guide > > doc: remove reference to rte.doc.mk in programmers guide > > examples/ethtool: fix two typos > > doc: fix link in Linux getting started guide > > app/testpmd: fix a typo in log message > > ethdev: fix a typo > > > > Rasesh Mody (2): > > net/bnx2x: fix race for periodic flags > > net/bnx2x: fix optic module verification > > > > Shahaf Shuler (1): > > net/mlx5: fix packet inline on Tx queue wraparound > > > > Shahed Shaikh (5): > > net/bnx2x: fix segfaults due to stale interrupt status > > net/bnx2x: fix memory leak > > net/bnx2x: fix ramrod timeout > > net/bnx2x: fix DMAE timeout > > net/qede: fix Tx packet prepare for tunnel packets > > > > Shreyansh Jain (1): > > bus/dpaa: fix Rx discard register mask > > > > Stephen Hemminger (8): > > net/octeontx: fix vdev name > > net/bnxt: fix Rx VLAN offload flags > > net/virtio: remove useless condition > > ring: fix an error message > > net/ring: avoid hard-coded length > > net/ring: use calloc style where appropriate > > net/ring: check length of ring name > > net/virtio: fix buffer leak on VLAN insert > > > > Thomas Monjalon (2): > > mk: fix build of shared library with libbsd > > bus/vdev: fix debug message on probing > > > > Tiwei Bie (4): > > net/virtio: add barrier in interrupt enable > > vhost: restore mbuf first when freeing zmbuf > > vhost: fix potential use-after-free for zero copy mbuf > > vhost: fix potential use-after-free for memory region > > > > Vishal Kulkarni (1): > > net/cxgbe: fix missing checksum flags and packet type > > > > Xiao Wang (1): > > net/fm10k: fix VLAN strip offload flag > > > > Yipeng Wang (1): > > hash: fix doc about thread/process safety > > > > Yongseok Koh (4): > > net/mlx5: fix instruction hotspot on replenishing Rx buffer > > net/mlx5: check Tx queue size overflow > > net/mlx5: fix max number of queues for NEON Tx > > doc: fix typo in mlx5 guide > > > > Yunjian Wang (1): > > net/ixgbe: fix crash on remove > > > > -- Kind regards, Luca Boccassi ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test 2019-09-18 10:03 ` Yu, PingX @ 2019-09-24 11:07 ` Luca Boccassi 2019-09-24 16:36 ` Ferruh Yigit 0 siblings, 1 reply; 19+ messages in thread From: Luca Boccassi @ 2019-09-24 11:07 UTC (permalink / raw) To: Ferruh Yigit, Mcnamara, John; +Cc: Yu, PingX, Peng, Yuan, dev, qian.q.xu Ping - any updates on these patches? The release of 17.11.7 is currently on hold waiting for a resolution here. Thanks! On Wed, 2019-09-18 at 10:03 +0000, Yu, PingX wrote: > Luca, > FYI. Currently there isn't reference for bug1 and bug2 and also > haven't send to mailing list yet. These bugs should be fixed before > release as they will block the basic PF test. > > Regards, > Yu Ping > > > -----Original Message----- > From: dev [mailto: > dev-bounces@dpdk.org > ] On Behalf Of Luca Boccassi > Sent: Wednesday, September 18, 2019 5:18 PM > To: Peng, Yuan < > yuan.peng@intel.com > >; > dev@dpdk.org > > Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test > > Hi, > > Ping - this is blocking the 17.11.7 release. > > Thanks! > > On Tue, 2019-09-17 at 10:53 +0100, Luca Boccassi wrote: > > Hello, > > > > Do you have a reference for the patches for bug 1 and 2? Have they > > been sent to the mailing list? > > > > On Thu, 2019-09-12 at 08:52 +0000, Peng, Yuan wrote: > > > Update the latest test status here. > > > > > > -----Original Message----- > > > From: Yu, PingX > > > Sent: Thursday, September 12, 2019 2:37 PM > > > To: Yongseok Koh < > > > yskoh@mellanox.com > > > > > > > > > > ; Ananyev, Konstantin < > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > ; > > > > > > asafp@mellanox.com > > > > > > > > > > > > Cc: Xu, Qian Q < > > > qian.q.xu@intel.com > > > > > > > > > > ; Lin, Xueqin < > > > > > > xueqin.lin@intel.com > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > ; O'Hare, Cathal < > > > > > > cathal.ohare@intel.com > > > > > > > > > > ; Yigit, Ferruh < > > > > > > ferruh.yigit@intel.com > > > > > > > > > > ; Ma, LihongX < > > > > > > lihongx.ma@intel.com > > > > > > > > > > ; Li, WenjieX A < > > > > > > wenjiex.a.li@intel.com > > > > > > > > > > ; Wang, FengqinX < > > > > > > fengqinx.wang@intel.com > > > > > > > > > > ; Peng, Yuan < > > > > > > yuan.peng@intel.com > > > > > > > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > > > All, > > > Update the latest test status here. > > > The critical bug has been fixed and we have re-tested all Intel > > > key > > > features. > > > > > > Intel(R) Testing result lists here. > > > # Basic Intel(R) NIC testing > > > * PF(i40e): One bug found in 1st round test. 2nd round test pass > > > after fixing the bug. (see Bug1) > > > * PF(ixgbe): the same as PF(i40e). > > > * VF: Pass and no issue. > > > * Build or compile: One bug found in 1st round test. 2nd round > > > test > > > pass after fixing the bug. (see Bug2) > > > * Intel NIC single core/NIC performance: Pass and no issue. > > > > > > #Basic cryptodev and virtio testing > > > * vhost/virtio basic loopback, PVP and performance test: pass. > > > * cryptodev: 3 bugs are found(see bug statistic in below). (See > > > Bug3,4 and 5) > > > > > > Bugs statistic: > > > Bug1: make -C test/ failed. It blocked about 60 test cases for > > > both > > > PF(i40e) and PF(ixgbe). Resolved by adding "#include > > > <inttypes.h>" > > > into test_rwlock.c. Please decide whether submit a patch to DPDK > > > or > > > not. > > > Bug2: compile error on fc30. Patch is provided and validated > > > pass. > > > Need to decide whether merge into DPDK or not. > > > Bug3: L2fwd: test_qat_h_AES_XCBC_MAC_auto failed. No progress > > > yet. > > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > > Author: Arek Kusztal < > > > arkadiuszx.kusztal@intel.com > > > > > > > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > > > Bug4: Ipsec-gw_test forwarding failed with null crypto QAT. No > > > progress yet. > > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > > Author: Arek Kusztal < > > > arkadiuszx.kusztal@intel.com > > > > > > > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > > > Bug5: Crypto: cryptodev_qat_autotest test failed. No progress > > > yet. > > > 39fb9500c42752a537588f7a203433ec4737fa1e is the first bad > > > commit > > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > > Author: Arek Kusztal < > > > arkadiuszx.kusztal@intel.com > > > > > > > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > > > Regards, > > > Yu Ping > > > > > > > > > -----Original Message----- > > > From: Wang, FengqinX > > > Sent: Monday, August 26, 2019 3:12 PM > > > To: Yongseok Koh < > > > yskoh@mellanox.com > > > > > > > > > > ; Ananyev, Konstantin < > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > ; > > > > > > asafp@mellanox.com > > > > > > > > > > > > Cc: Xu, Qian Q < > > > qian.q.xu@intel.com > > > > > > > > > > ; Lin, Xueqin < > > > > > > xueqin.lin@intel.com > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > ; O'Hare, Cathal < > > > > > > cathal.ohare@intel.com > > > > > > > > > > ; Yigit, Ferruh < > > > > > > ferruh.yigit@intel.com > > > > > > > > > > ; Yu, PingX < > > > > > > pingx.yu@intel.com > > > > > > > > > > ; Ma, LihongX < > > > > > > lihongx.ma@intel.com > > > > > > > > > > ; Li, WenjieX A < > > > > > > wenjiex.a.li@intel.com > > > > > > > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > > > Add asafp in the loop due to Yongseok is longer working at > > > Mellanox. > > > > > > BRs, Vicky > > > > > > -----Original Message----- > > > From: Wang, FengqinX > > > Sent: Monday, August 26, 2019 3:07 PM > > > To: 'Yongseok Koh' < > > > yskoh@mellanox.com > > > > > > > > > > ; Ananyev, Konstantin < > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > > > Cc: Xu, Qian Q < > > > qian.q.xu@intel.com > > > > > > > > > > ; Lin, Xueqin < > > > > > > xueqin.lin@intel.com > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > ; O'Hare, Cathal < > > > > > > cathal.ohare@intel.com > > > > > > > > > > ; Yigit, Ferruh < > > > > > > ferruh.yigit@intel.com > > > > > > > > > > ; Yu, PingX < > > > > > > pingx.yu@intel.com > > > > > > > > > > ; Ma, LihongX < > > > > > > lihongx.ma@intel.com > > > > > > > > > > ; Li, WenjieX A < > > > > > > wenjiex.a.li@intel.com > > > > > > > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > > > Hi Yongseok, Konstantin, > > > > > > There is one critical compile issue found, and below is the bad > > > commit related information, this issue has blocked most of unit > > > tests which have used dpdk/test/test, would you please help to > > > fix > > > this issue ASAP? > > > > > > commit 29e08d740ffc1e0ed9e7a9bd25fb95714fac1070 > > > Author: Joyce Kong < > > > joyce.kong@arm.com > > > > > > > > > > > > Date: Thu Jul 25 14:50:21 2019 +0800 > > > > > > test/rwlock: benchmark on all available cores > > > > > > [ backported from upstream commit > > > fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] > > > > > > Add performance test on all available cores to benchmark > > > the scaling up performance of rw_lock. > > > > > > Fixes: af75078fece3 ("first public release") > > > > > > Suggested-by: Gavin Hu < > > > gavin.hu@arm.com > > > > > > > > > > > > Signed-off-by: Joyce Kong < > > > joyce.kong@arm.com > > > > > > > > > > > > Acked-by: Konstantin Ananyev < > > > konstantin.ananyev@intel.com > > > > > > > > > > > > > > > And below is the error message output: > > > > > > test_rwlock.c: In function 'load_loop_fn': > > > test_rwlock.c:126:38: error: expected ')' before 'PRIu64' > > > printf("Core [%u] rwlock_data = %"PRIu64"\n", ^~~~~~ > > > ) > > > test_rwlock.c:126:19: error: format '%u' expects a matching > > > 'unsigned int' argument [-Werror=format=] printf("Core [%u] > > > rwlock_data = %"PRIu64"\n", ~^ > > > test_rwlock.c:126:36: error: spurious trailing '%' in format [- > > > Werror=format=] printf("Core [%u] rwlock_data = %"PRIu64"\n", ^ > > > test_rwlock.c: In function 'test_rwlock_perf': > > > test_rwlock.c:160:31: error: expected ')' before 'PRIu64' > > > printf("Core [%u] count = %"PRIu64"\n", i, lock_count[i]); ^~~~~~ > > > ) > > > test_rwlock.c:160:18: error: format '%u' expects a matching > > > 'unsigned int' argument [-Werror=format=] printf("Core [%u] count > > > = > > > %"PRIu64"\n", i, lock_count[i]); ~^ > > > test_rwlock.c:160:29: error: spurious trailing '%' in format [- > > > Werror=format=] printf("Core [%u] count = %"PRIu64"\n", i, > > > lock_count[i]); ^ > > > test_rwlock.c:164:26: error: expected ')' before 'PRIu64' > > > printf("Total count = %"PRIu64"\n", total); ^~~~~~ > > > ) > > > test_rwlock.c:164:24: error: spurious trailing '%' in format [- > > > Werror=format=] printf("Total count = %"PRIu64"\n", total); ^ > > > cc1: all warnings being treated as errors > > > > > > BRs, Vicky > > > > > > -----Original Message----- > > > From: Yongseok Koh [mailto: > > > yskoh@mellanox.com > > > > > > > > > ] > > > Sent: Friday, August 16, 2019 2:05 AM > > > To: dpdk stable < > > > stable@dpdk.org > > > > > > > > > > > > Cc: > > > dev@dpdk.org > > > > > > > > > ; > > > pezhang@redhat.com > > > > > > > > > ; > > > siliu@redhat.com > > > > > > > > > ; Wang, FengqinX < > > > fengqinx.wang@intel.com > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > ; Xu, Qian Q < > > > > > > qian.q.xu@intel.com > > > > > > > > > > ; > > > > > > alialnu@mellanox.com > > > > > > > > > ; > > > rasland@mellanox.com > > > > > > > > > > > > Subject: 17.11.7-rc1 (LTS) patches review and test > > > > > > Hi all, > > > > > > Here is a list of patches targeted for LTS release 17.11.7. > > > Please > > > help review and test. The planned date for the final release is > > > Aug > > > 23, Before that, please shout if anyone has objections with > > > these > > > patches being applied. > > > > > > Also for the companies committed to running regression tests, > > > please > > > run the tests and report any issue before the release date. > > > > > > A release candidate tarball can be found at: > > > > > > > > > https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 > > > > > > > > > > > > > > > These patches are located at branch 17.11 of dpdk-stable repo: > > > > > > https://dpdk.org/browse/dpdk-stable/ > > > > > > > > > > > > > > > > > > Thanks, > > > Yongseok > > > > > > --- > > > > > > Aaron Conole (1): > > > net/virtio: fix dangling pointer on failure > > > > > > Agalya Babu RadhaKrishnan (1): > > > doc: fix interactive commands in testpmd guide > > > > > > Akhil Goyal (1): > > > crypto/dpaa2_sec: fix session clearing > > > > > > Alejandro Lucero (1): > > > net/nfp: fix RSS query > > > > > > Anatoly Burakov (2): > > > eal: improve musl compatibility of string functions > > > malloc: fix documentation of realloc function > > > > > > Andrew Rybchenko (2): > > > net/sfc: remove control path logging from Rx queue count > > > app/testpmd: set fixed flag for exact link speed > > > > > > Andrius Sirvys (3): > > > net/virtio: fix duplicate naming of include guard > > > bitrate: fix unchecked return value > > > drivers/net: fix shifting 32-bit signed variable 31 times > > > > > > Anoob Joseph (1): > > > cryptodev: fix driver name comparison > > > > > > Beilei Xing (1): > > > net/i40e: fix link speed for X722 > > > > > > Bernard Iremonger (1): > > > examples/ipsec-secgw: fix debug logs > > > > > > Bill Hong (1): > > > net: fix Tx VLAN flag for offload emulation > > > > > > Bruce Richardson (9): > > > eal: support strlcat function > > > net/bonding: fix buffer length when printing strings > > > examples/l2fwd-cat: fix build on FreeBSD > > > app/crypto-perf: check range of socket id > > > examples/vhost_scsi: fix null-check for parameter > > > net/i40e: fix dereference before null check in mbuf release > > > net/ixgbe: fix warning with GCC 9 > > > bus/fslmc: fix warning with GCC 9 > > > eal: tighten permissions on shared memory files > > > > > > Chaitanya Babu Talluri (2): > > > drivers/net: fix possible overflow using strlcat > > > cfgfile: replace strcat with strlcat > > > > > > David Christensen (2): > > > maintainers: update for IBM POWER > > > examples/vm_power_manager: fix PMD specific code > > > > > > David Marchand (7): > > > eal: fix check when retrieving current CPU affinity > > > eal: remove dead code in core list parsing > > > app/testpmd: remove unused field from port struct > > > doc: fix examples in bonding guide > > > net/bonding: fix port id types > > > net/bonding: fix queue index types > > > app/testpmd: remove useless casts on statistics > > > > > > Davide Caratti (1): > > > net/bnxt: support IOVA VA mode > > > > > > Dekel Peled (8): > > > net/mlx5: fix hex dump of error completion > > > net/mlx5: fix sync when handling Tx completions > > > eal/ppc: fix global memory barrier > > > eal: fix typo in comment of vector function > > > doc: fix links to doxygen and sphinx sites > > > app/testpmd: fix typo in comment > > > net/mlx5: fix comments mixing Rx and Tx > > > net/mlx5: fix release of Rx queue object > > > > > > Fan Zhang (1): > > > examples/ipsec-secgw: fix AES-CTR block size > > > > > > Ferruh Yigit (5): > > > kni: fix build with Linux 5.1 > > > build: fix crash by disabling AVX512 with binutils 2.31 > > > net/ring: fix return value check > > > net/kni: fix return value check > > > app/testpmd: revert fixed flag for exact link speed > > > > > > Gage Eads (1): > > > ring: fix namesize macro documentation block > > > > > > Gavin Hu (3): > > > test/spinlock: remove delay for correct benchmarking > > > test/spinlock: amortize the cost of getting time > > > spinlock: reimplement with atomic one-way barrier > > > > > > Hari Kumar Vemula (1): > > > net/bonding: fix reset active slave > > > > > > Harry van Haaren (1): > > > event/sw: fix enqueue checks in self-test > > > > > > Herakliusz Lipiec (1): > > > doc: fix broken link in LPM guide > > > > > > Hyong Youb Kim (4): > > > net/bonding: avoid warning for invalid port > > > net/enic: fix flow director SCTP matching > > > net/enic: fix SCTP match for flow API > > > net/enic: check for unsupported flow item types > > > > > > Igor Romanov (1): > > > app/testpmd: fix stdout flush after printing stats > > > > > > Ilya Maximets (2): > > > vhost: fix device leak on connection add failure > > > vhost: fix silent queue enabling with legacy guests > > > > > > Ivan Malov (1): > > > net/sfc: log port ID as 16-bit unsigned integer on panic > > > > > > Jerin Jacob (1): > > > mk: fix AVX512 disabled warning on non x86 > > > > > > Jianfeng Tan (1): > > > drivers/net: do not use private ethdev data > > > > > > Joyce Kong (1): > > > test/rwlock: benchmark on all available cores > > > > > > Kevin Traynor (3): > > > net/qede: support IOVA VA mode > > > eal/linux: fix log levels for pagemap reading failure > > > power: fix frequency list buffer validation > > > > > > Liang Zhang (1): > > > net/bonding: fix LACP negotiation > > > > > > Luo Gaoliang (1): > > > kni: fix build on RHEL8 > > > > > > Marcin Smoczynski (1): > > > examples/ipsec-secgw: fix build error log > > > > > > Natanael Copa (3): > > > bus/fslmc: remove unused include of error.h > > > bus/fslmc: fix build with musl libc > > > app/test: fix build with musl libc > > > > > > Pallantla Poornima (3): > > > app/test: fix sprintf with strlcat > > > test/distributor: replace sprintf with strlcpy > > > test/hash: replace sprintf with snprintf > > > > > > Qi Zhang (1): > > > net/i40e: fix time sync for 25G > > > > > > Radu Nicolau (3): > > > net/null: add MAC address setting fake operation > > > test/virtual_pmd: add MAC address setting fake op > > > test/bonding: assign non-zero MAC to null devices > > > > > > Rahul Lakkireddy (1): > > > net/cxgbe: update Chelsio T5/T6 NIC device ids > > > > > > Rami Rosen (8): > > > net/virtio: remove forward declaration > > > mbuf: fix a typo > > > doc: fix a minor typo in testpmd guide > > > doc: remove reference to rte.doc.mk in programmers guide > > > examples/ethtool: fix two typos > > > doc: fix link in Linux getting started guide > > > app/testpmd: fix a typo in log message > > > ethdev: fix a typo > > > > > > Rasesh Mody (2): > > > net/bnx2x: fix race for periodic flags > > > net/bnx2x: fix optic module verification > > > > > > Shahaf Shuler (1): > > > net/mlx5: fix packet inline on Tx queue wraparound > > > > > > Shahed Shaikh (5): > > > net/bnx2x: fix segfaults due to stale interrupt status > > > net/bnx2x: fix memory leak > > > net/bnx2x: fix ramrod timeout > > > net/bnx2x: fix DMAE timeout > > > net/qede: fix Tx packet prepare for tunnel packets > > > > > > Shreyansh Jain (1): > > > bus/dpaa: fix Rx discard register mask > > > > > > Stephen Hemminger (8): > > > net/octeontx: fix vdev name > > > net/bnxt: fix Rx VLAN offload flags > > > net/virtio: remove useless condition > > > ring: fix an error message > > > net/ring: avoid hard-coded length > > > net/ring: use calloc style where appropriate > > > net/ring: check length of ring name > > > net/virtio: fix buffer leak on VLAN insert > > > > > > Thomas Monjalon (2): > > > mk: fix build of shared library with libbsd > > > bus/vdev: fix debug message on probing > > > > > > Tiwei Bie (4): > > > net/virtio: add barrier in interrupt enable > > > vhost: restore mbuf first when freeing zmbuf > > > vhost: fix potential use-after-free for zero copy mbuf > > > vhost: fix potential use-after-free for memory region > > > > > > Vishal Kulkarni (1): > > > net/cxgbe: fix missing checksum flags and packet type > > > > > > Xiao Wang (1): > > > net/fm10k: fix VLAN strip offload flag > > > > > > Yipeng Wang (1): > > > hash: fix doc about thread/process safety > > > > > > Yongseok Koh (4): > > > net/mlx5: fix instruction hotspot on replenishing Rx buffer > > > net/mlx5: check Tx queue size overflow > > > net/mlx5: fix max number of queues for NEON Tx > > > doc: fix typo in mlx5 guide > > > > > > Yunjian Wang (1): > > > net/ixgbe: fix crash on remove > > > > > > > > -- > Kind regards, > Luca Boccassi > -- Kind regards, Luca Boccassi ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test 2019-09-24 11:07 ` Luca Boccassi @ 2019-09-24 16:36 ` Ferruh Yigit 2019-09-24 17:15 ` Kevin Traynor 0 siblings, 1 reply; 19+ messages in thread From: Ferruh Yigit @ 2019-09-24 16:36 UTC (permalink / raw) To: Luca Boccassi, Mcnamara, John; +Cc: Yu, PingX, Peng, Yuan, dev, qian.q.xu On 9/24/2019 12:07 PM, Luca Boccassi wrote: > Ping - any updates on these patches? The release of 17.11.7 is > currently on hold waiting for a resolution here. Hi Luca, Test team provided some internal details: 1- Build issue on f30, A patch has been sent to stable mail list to fix it, not sure if it has been merged: https://mails.dpdk.org/archives/stable/2019-September/017122.html 2- "make -C test/" fails. "Fix looks to be to add "#include <inttypes.h>" into test_rwlock.c" Not sure if there is a patch for this. 3- l2fwd-crypto, ERROR: Test Case test_qat_h_AES_XCBC_MAC_auto Result FAILED Work in progress 4- ipsec-secgw, forwarding failed with null crypto QAT Work in progress 5- Unit test "cryptodev_qat_autotest" failed Issue not analyzed yet. > > Thanks! > > On Wed, 2019-09-18 at 10:03 +0000, Yu, PingX wrote: >> Luca, >> FYI. Currently there isn't reference for bug1 and bug2 and also >> haven't send to mailing list yet. These bugs should be fixed before >> release as they will block the basic PF test. >> >> Regards, >> Yu Ping >> >> >> -----Original Message----- >> From: dev [mailto: >> dev-bounces@dpdk.org >> ] On Behalf Of Luca Boccassi >> Sent: Wednesday, September 18, 2019 5:18 PM >> To: Peng, Yuan < >> yuan.peng@intel.com >>> ; >> dev@dpdk.org >> >> Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test >> >> Hi, >> >> Ping - this is blocking the 17.11.7 release. >> >> Thanks! >> >> On Tue, 2019-09-17 at 10:53 +0100, Luca Boccassi wrote: >>> Hello, >>> >>> Do you have a reference for the patches for bug 1 and 2? Have they >>> been sent to the mailing list? >>> >>> On Thu, 2019-09-12 at 08:52 +0000, Peng, Yuan wrote: >>>> Update the latest test status here. >>>> >>>> -----Original Message----- >>>> From: Yu, PingX >>>> Sent: Thursday, September 12, 2019 2:37 PM >>>> To: Yongseok Koh < >>>> yskoh@mellanox.com >>>> >>>> >>>>> ; Ananyev, Konstantin < >>>> >>>> konstantin.ananyev@intel.com >>>> >>>> >>>>> ; >>>> >>>> asafp@mellanox.com >>>> >>>> >>>> >>>> Cc: Xu, Qian Q < >>>> qian.q.xu@intel.com >>>> >>>> >>>>> ; Lin, Xueqin < >>>> >>>> xueqin.lin@intel.com >>>> >>>> >>>>> ; Chen, Zhaoyan < >>>> >>>> zhaoyan.chen@intel.com >>>> >>>> >>>>> ; O'Hare, Cathal < >>>> >>>> cathal.ohare@intel.com >>>> >>>> >>>>> ; Yigit, Ferruh < >>>> >>>> ferruh.yigit@intel.com >>>> >>>> >>>>> ; Ma, LihongX < >>>> >>>> lihongx.ma@intel.com >>>> >>>> >>>>> ; Li, WenjieX A < >>>> >>>> wenjiex.a.li@intel.com >>>> >>>> >>>>> ; Wang, FengqinX < >>>> >>>> fengqinx.wang@intel.com >>>> >>>> >>>>> ; Peng, Yuan < >>>> >>>> yuan.peng@intel.com >>>> >>>> >>>> >>>> Subject: RE: 17.11.7-rc1 (LTS) patches review and test >>>> >>>> All, >>>> Update the latest test status here. >>>> The critical bug has been fixed and we have re-tested all Intel >>>> key >>>> features. >>>> >>>> Intel(R) Testing result lists here. >>>> # Basic Intel(R) NIC testing >>>> * PF(i40e): One bug found in 1st round test. 2nd round test pass >>>> after fixing the bug. (see Bug1) >>>> * PF(ixgbe): the same as PF(i40e). >>>> * VF: Pass and no issue. >>>> * Build or compile: One bug found in 1st round test. 2nd round >>>> test >>>> pass after fixing the bug. (see Bug2) >>>> * Intel NIC single core/NIC performance: Pass and no issue. >>>> >>>> #Basic cryptodev and virtio testing >>>> * vhost/virtio basic loopback, PVP and performance test: pass. >>>> * cryptodev: 3 bugs are found(see bug statistic in below). (See >>>> Bug3,4 and 5) >>>> >>>> Bugs statistic: >>>> Bug1: make -C test/ failed. It blocked about 60 test cases for >>>> both >>>> PF(i40e) and PF(ixgbe). Resolved by adding "#include >>>> <inttypes.h>" >>>> into test_rwlock.c. Please decide whether submit a patch to DPDK >>>> or >>>> not. >>>> Bug2: compile error on fc30. Patch is provided and validated >>>> pass. >>>> Need to decide whether merge into DPDK or not. >>>> Bug3: L2fwd: test_qat_h_AES_XCBC_MAC_auto failed. No progress >>>> yet. >>>> commit 39fb9500c42752a537588f7a203433ec4737fa1e >>>> Author: Arek Kusztal < >>>> arkadiuszx.kusztal@intel.com >>>> >>>> >>>> >>>> Date: Wed Dec 12 20:59:02 2018 +0100 >>>> >>>> Bug4: Ipsec-gw_test forwarding failed with null crypto QAT. No >>>> progress yet. >>>> commit 39fb9500c42752a537588f7a203433ec4737fa1e >>>> Author: Arek Kusztal < >>>> arkadiuszx.kusztal@intel.com >>>> >>>> >>>> >>>> Date: Wed Dec 12 20:59:02 2018 +0100 >>>> >>>> Bug5: Crypto: cryptodev_qat_autotest test failed. No progress >>>> yet. >>>> 39fb9500c42752a537588f7a203433ec4737fa1e is the first bad >>>> commit >>>> commit 39fb9500c42752a537588f7a203433ec4737fa1e >>>> Author: Arek Kusztal < >>>> arkadiuszx.kusztal@intel.com >>>> >>>> >>>> >>>> Date: Wed Dec 12 20:59:02 2018 +0100 >>>> >>>> Regards, >>>> Yu Ping >>>> >>>> >>>> -----Original Message----- >>>> From: Wang, FengqinX >>>> Sent: Monday, August 26, 2019 3:12 PM >>>> To: Yongseok Koh < >>>> yskoh@mellanox.com >>>> >>>> >>>>> ; Ananyev, Konstantin < >>>> >>>> konstantin.ananyev@intel.com >>>> >>>> >>>>> ; >>>> >>>> asafp@mellanox.com >>>> >>>> >>>> >>>> Cc: Xu, Qian Q < >>>> qian.q.xu@intel.com >>>> >>>> >>>>> ; Lin, Xueqin < >>>> >>>> xueqin.lin@intel.com >>>> >>>> >>>>> ; Chen, Zhaoyan < >>>> >>>> zhaoyan.chen@intel.com >>>> >>>> >>>>> ; O'Hare, Cathal < >>>> >>>> cathal.ohare@intel.com >>>> >>>> >>>>> ; Yigit, Ferruh < >>>> >>>> ferruh.yigit@intel.com >>>> >>>> >>>>> ; Yu, PingX < >>>> >>>> pingx.yu@intel.com >>>> >>>> >>>>> ; Ma, LihongX < >>>> >>>> lihongx.ma@intel.com >>>> >>>> >>>>> ; Li, WenjieX A < >>>> >>>> wenjiex.a.li@intel.com >>>> >>>> >>>> >>>> Subject: RE: 17.11.7-rc1 (LTS) patches review and test >>>> >>>> Add asafp in the loop due to Yongseok is longer working at >>>> Mellanox. >>>> >>>> BRs, Vicky >>>> >>>> -----Original Message----- >>>> From: Wang, FengqinX >>>> Sent: Monday, August 26, 2019 3:07 PM >>>> To: 'Yongseok Koh' < >>>> yskoh@mellanox.com >>>> >>>> >>>>> ; Ananyev, Konstantin < >>>> >>>> konstantin.ananyev@intel.com >>>> >>>> >>>> >>>> Cc: Xu, Qian Q < >>>> qian.q.xu@intel.com >>>> >>>> >>>>> ; Lin, Xueqin < >>>> >>>> xueqin.lin@intel.com >>>> >>>> >>>>> ; Chen, Zhaoyan < >>>> >>>> zhaoyan.chen@intel.com >>>> >>>> >>>>> ; O'Hare, Cathal < >>>> >>>> cathal.ohare@intel.com >>>> >>>> >>>>> ; Yigit, Ferruh < >>>> >>>> ferruh.yigit@intel.com >>>> >>>> >>>>> ; Yu, PingX < >>>> >>>> pingx.yu@intel.com >>>> >>>> >>>>> ; Ma, LihongX < >>>> >>>> lihongx.ma@intel.com >>>> >>>> >>>>> ; Li, WenjieX A < >>>> >>>> wenjiex.a.li@intel.com >>>> >>>> >>>> >>>> Subject: RE: 17.11.7-rc1 (LTS) patches review and test >>>> >>>> Hi Yongseok, Konstantin, >>>> >>>> There is one critical compile issue found, and below is the bad >>>> commit related information, this issue has blocked most of unit >>>> tests which have used dpdk/test/test, would you please help to >>>> fix >>>> this issue ASAP? >>>> >>>> commit 29e08d740ffc1e0ed9e7a9bd25fb95714fac1070 >>>> Author: Joyce Kong < >>>> joyce.kong@arm.com >>>> >>>> >>>> >>>> Date: Thu Jul 25 14:50:21 2019 +0800 >>>> >>>> test/rwlock: benchmark on all available cores >>>> >>>> [ backported from upstream commit >>>> fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] >>>> >>>> Add performance test on all available cores to benchmark >>>> the scaling up performance of rw_lock. >>>> >>>> Fixes: af75078fece3 ("first public release") >>>> >>>> Suggested-by: Gavin Hu < >>>> gavin.hu@arm.com >>>> >>>> >>>> >>>> Signed-off-by: Joyce Kong < >>>> joyce.kong@arm.com >>>> >>>> >>>> >>>> Acked-by: Konstantin Ananyev < >>>> konstantin.ananyev@intel.com >>>> >>>> >>>> >>>> >>>> And below is the error message output: >>>> >>>> test_rwlock.c: In function 'load_loop_fn': >>>> test_rwlock.c:126:38: error: expected ')' before 'PRIu64' >>>> printf("Core [%u] rwlock_data = %"PRIu64"\n", ^~~~~~ >>>> ) >>>> test_rwlock.c:126:19: error: format '%u' expects a matching >>>> 'unsigned int' argument [-Werror=format=] printf("Core [%u] >>>> rwlock_data = %"PRIu64"\n", ~^ >>>> test_rwlock.c:126:36: error: spurious trailing '%' in format [- >>>> Werror=format=] printf("Core [%u] rwlock_data = %"PRIu64"\n", ^ >>>> test_rwlock.c: In function 'test_rwlock_perf': >>>> test_rwlock.c:160:31: error: expected ')' before 'PRIu64' >>>> printf("Core [%u] count = %"PRIu64"\n", i, lock_count[i]); ^~~~~~ >>>> ) >>>> test_rwlock.c:160:18: error: format '%u' expects a matching >>>> 'unsigned int' argument [-Werror=format=] printf("Core [%u] count >>>> = >>>> %"PRIu64"\n", i, lock_count[i]); ~^ >>>> test_rwlock.c:160:29: error: spurious trailing '%' in format [- >>>> Werror=format=] printf("Core [%u] count = %"PRIu64"\n", i, >>>> lock_count[i]); ^ >>>> test_rwlock.c:164:26: error: expected ')' before 'PRIu64' >>>> printf("Total count = %"PRIu64"\n", total); ^~~~~~ >>>> ) >>>> test_rwlock.c:164:24: error: spurious trailing '%' in format [- >>>> Werror=format=] printf("Total count = %"PRIu64"\n", total); ^ >>>> cc1: all warnings being treated as errors >>>> >>>> BRs, Vicky >>>> >>>> -----Original Message----- >>>> From: Yongseok Koh [mailto: >>>> yskoh@mellanox.com >>>> >>>> >>>> ] >>>> Sent: Friday, August 16, 2019 2:05 AM >>>> To: dpdk stable < >>>> stable@dpdk.org >>>> >>>> >>>> >>>> Cc: >>>> dev@dpdk.org >>>> >>>> >>>> ; >>>> pezhang@redhat.com >>>> >>>> >>>> ; >>>> siliu@redhat.com >>>> >>>> >>>> ; Wang, FengqinX < >>>> fengqinx.wang@intel.com >>>> >>>> >>>>> ; Chen, Zhaoyan < >>>> >>>> zhaoyan.chen@intel.com >>>> >>>> >>>>> ; Xu, Qian Q < >>>> >>>> qian.q.xu@intel.com >>>> >>>> >>>>> ; >>>> >>>> alialnu@mellanox.com >>>> >>>> >>>> ; >>>> rasland@mellanox.com >>>> >>>> >>>> >>>> Subject: 17.11.7-rc1 (LTS) patches review and test >>>> >>>> Hi all, >>>> >>>> Here is a list of patches targeted for LTS release 17.11.7. >>>> Please >>>> help review and test. The planned date for the final release is >>>> Aug >>>> 23, Before that, please shout if anyone has objections with >>>> these >>>> patches being applied. >>>> >>>> Also for the companies committed to running regression tests, >>>> please >>>> run the tests and report any issue before the release date. >>>> >>>> A release candidate tarball can be found at: >>>> >>>> >>>> https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 >>>> >>>> >>>> >>>> >>>> These patches are located at branch 17.11 of dpdk-stable repo: >>>> >>>> https://dpdk.org/browse/dpdk-stable/ >>>> >>>> >>>> >>>> >>>> >>>> Thanks, >>>> Yongseok >>>> >>>> --- >>>> >>>> Aaron Conole (1): >>>> net/virtio: fix dangling pointer on failure >>>> >>>> Agalya Babu RadhaKrishnan (1): >>>> doc: fix interactive commands in testpmd guide >>>> >>>> Akhil Goyal (1): >>>> crypto/dpaa2_sec: fix session clearing >>>> >>>> Alejandro Lucero (1): >>>> net/nfp: fix RSS query >>>> >>>> Anatoly Burakov (2): >>>> eal: improve musl compatibility of string functions >>>> malloc: fix documentation of realloc function >>>> >>>> Andrew Rybchenko (2): >>>> net/sfc: remove control path logging from Rx queue count >>>> app/testpmd: set fixed flag for exact link speed >>>> >>>> Andrius Sirvys (3): >>>> net/virtio: fix duplicate naming of include guard >>>> bitrate: fix unchecked return value >>>> drivers/net: fix shifting 32-bit signed variable 31 times >>>> >>>> Anoob Joseph (1): >>>> cryptodev: fix driver name comparison >>>> >>>> Beilei Xing (1): >>>> net/i40e: fix link speed for X722 >>>> >>>> Bernard Iremonger (1): >>>> examples/ipsec-secgw: fix debug logs >>>> >>>> Bill Hong (1): >>>> net: fix Tx VLAN flag for offload emulation >>>> >>>> Bruce Richardson (9): >>>> eal: support strlcat function >>>> net/bonding: fix buffer length when printing strings >>>> examples/l2fwd-cat: fix build on FreeBSD >>>> app/crypto-perf: check range of socket id >>>> examples/vhost_scsi: fix null-check for parameter >>>> net/i40e: fix dereference before null check in mbuf release >>>> net/ixgbe: fix warning with GCC 9 >>>> bus/fslmc: fix warning with GCC 9 >>>> eal: tighten permissions on shared memory files >>>> >>>> Chaitanya Babu Talluri (2): >>>> drivers/net: fix possible overflow using strlcat >>>> cfgfile: replace strcat with strlcat >>>> >>>> David Christensen (2): >>>> maintainers: update for IBM POWER >>>> examples/vm_power_manager: fix PMD specific code >>>> >>>> David Marchand (7): >>>> eal: fix check when retrieving current CPU affinity >>>> eal: remove dead code in core list parsing >>>> app/testpmd: remove unused field from port struct >>>> doc: fix examples in bonding guide >>>> net/bonding: fix port id types >>>> net/bonding: fix queue index types >>>> app/testpmd: remove useless casts on statistics >>>> >>>> Davide Caratti (1): >>>> net/bnxt: support IOVA VA mode >>>> >>>> Dekel Peled (8): >>>> net/mlx5: fix hex dump of error completion >>>> net/mlx5: fix sync when handling Tx completions >>>> eal/ppc: fix global memory barrier >>>> eal: fix typo in comment of vector function >>>> doc: fix links to doxygen and sphinx sites >>>> app/testpmd: fix typo in comment >>>> net/mlx5: fix comments mixing Rx and Tx >>>> net/mlx5: fix release of Rx queue object >>>> >>>> Fan Zhang (1): >>>> examples/ipsec-secgw: fix AES-CTR block size >>>> >>>> Ferruh Yigit (5): >>>> kni: fix build with Linux 5.1 >>>> build: fix crash by disabling AVX512 with binutils 2.31 >>>> net/ring: fix return value check >>>> net/kni: fix return value check >>>> app/testpmd: revert fixed flag for exact link speed >>>> >>>> Gage Eads (1): >>>> ring: fix namesize macro documentation block >>>> >>>> Gavin Hu (3): >>>> test/spinlock: remove delay for correct benchmarking >>>> test/spinlock: amortize the cost of getting time >>>> spinlock: reimplement with atomic one-way barrier >>>> >>>> Hari Kumar Vemula (1): >>>> net/bonding: fix reset active slave >>>> >>>> Harry van Haaren (1): >>>> event/sw: fix enqueue checks in self-test >>>> >>>> Herakliusz Lipiec (1): >>>> doc: fix broken link in LPM guide >>>> >>>> Hyong Youb Kim (4): >>>> net/bonding: avoid warning for invalid port >>>> net/enic: fix flow director SCTP matching >>>> net/enic: fix SCTP match for flow API >>>> net/enic: check for unsupported flow item types >>>> >>>> Igor Romanov (1): >>>> app/testpmd: fix stdout flush after printing stats >>>> >>>> Ilya Maximets (2): >>>> vhost: fix device leak on connection add failure >>>> vhost: fix silent queue enabling with legacy guests >>>> >>>> Ivan Malov (1): >>>> net/sfc: log port ID as 16-bit unsigned integer on panic >>>> >>>> Jerin Jacob (1): >>>> mk: fix AVX512 disabled warning on non x86 >>>> >>>> Jianfeng Tan (1): >>>> drivers/net: do not use private ethdev data >>>> >>>> Joyce Kong (1): >>>> test/rwlock: benchmark on all available cores >>>> >>>> Kevin Traynor (3): >>>> net/qede: support IOVA VA mode >>>> eal/linux: fix log levels for pagemap reading failure >>>> power: fix frequency list buffer validation >>>> >>>> Liang Zhang (1): >>>> net/bonding: fix LACP negotiation >>>> >>>> Luo Gaoliang (1): >>>> kni: fix build on RHEL8 >>>> >>>> Marcin Smoczynski (1): >>>> examples/ipsec-secgw: fix build error log >>>> >>>> Natanael Copa (3): >>>> bus/fslmc: remove unused include of error.h >>>> bus/fslmc: fix build with musl libc >>>> app/test: fix build with musl libc >>>> >>>> Pallantla Poornima (3): >>>> app/test: fix sprintf with strlcat >>>> test/distributor: replace sprintf with strlcpy >>>> test/hash: replace sprintf with snprintf >>>> >>>> Qi Zhang (1): >>>> net/i40e: fix time sync for 25G >>>> >>>> Radu Nicolau (3): >>>> net/null: add MAC address setting fake operation >>>> test/virtual_pmd: add MAC address setting fake op >>>> test/bonding: assign non-zero MAC to null devices >>>> >>>> Rahul Lakkireddy (1): >>>> net/cxgbe: update Chelsio T5/T6 NIC device ids >>>> >>>> Rami Rosen (8): >>>> net/virtio: remove forward declaration >>>> mbuf: fix a typo >>>> doc: fix a minor typo in testpmd guide >>>> doc: remove reference to rte.doc.mk in programmers guide >>>> examples/ethtool: fix two typos >>>> doc: fix link in Linux getting started guide >>>> app/testpmd: fix a typo in log message >>>> ethdev: fix a typo >>>> >>>> Rasesh Mody (2): >>>> net/bnx2x: fix race for periodic flags >>>> net/bnx2x: fix optic module verification >>>> >>>> Shahaf Shuler (1): >>>> net/mlx5: fix packet inline on Tx queue wraparound >>>> >>>> Shahed Shaikh (5): >>>> net/bnx2x: fix segfaults due to stale interrupt status >>>> net/bnx2x: fix memory leak >>>> net/bnx2x: fix ramrod timeout >>>> net/bnx2x: fix DMAE timeout >>>> net/qede: fix Tx packet prepare for tunnel packets >>>> >>>> Shreyansh Jain (1): >>>> bus/dpaa: fix Rx discard register mask >>>> >>>> Stephen Hemminger (8): >>>> net/octeontx: fix vdev name >>>> net/bnxt: fix Rx VLAN offload flags >>>> net/virtio: remove useless condition >>>> ring: fix an error message >>>> net/ring: avoid hard-coded length >>>> net/ring: use calloc style where appropriate >>>> net/ring: check length of ring name >>>> net/virtio: fix buffer leak on VLAN insert >>>> >>>> Thomas Monjalon (2): >>>> mk: fix build of shared library with libbsd >>>> bus/vdev: fix debug message on probing >>>> >>>> Tiwei Bie (4): >>>> net/virtio: add barrier in interrupt enable >>>> vhost: restore mbuf first when freeing zmbuf >>>> vhost: fix potential use-after-free for zero copy mbuf >>>> vhost: fix potential use-after-free for memory region >>>> >>>> Vishal Kulkarni (1): >>>> net/cxgbe: fix missing checksum flags and packet type >>>> >>>> Xiao Wang (1): >>>> net/fm10k: fix VLAN strip offload flag >>>> >>>> Yipeng Wang (1): >>>> hash: fix doc about thread/process safety >>>> >>>> Yongseok Koh (4): >>>> net/mlx5: fix instruction hotspot on replenishing Rx buffer >>>> net/mlx5: check Tx queue size overflow >>>> net/mlx5: fix max number of queues for NEON Tx >>>> doc: fix typo in mlx5 guide >>>> >>>> Yunjian Wang (1): >>>> net/ixgbe: fix crash on remove >>>> >>>> >> >> -- >> Kind regards, >> Luca Boccassi >> ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test 2019-09-24 16:36 ` Ferruh Yigit @ 2019-09-24 17:15 ` Kevin Traynor 2019-09-24 17:25 ` Luca Boccassi 0 siblings, 1 reply; 19+ messages in thread From: Kevin Traynor @ 2019-09-24 17:15 UTC (permalink / raw) To: Ferruh Yigit, Luca Boccassi, Mcnamara, John Cc: Yu, PingX, Peng, Yuan, dev, qian.q.xu On 24/09/2019 17:36, Ferruh Yigit wrote: > On 9/24/2019 12:07 PM, Luca Boccassi wrote: >> Ping - any updates on these patches? The release of 17.11.7 is >> currently on hold waiting for a resolution here. > > Hi Luca, > > Test team provided some internal details: > > 1- Build issue on f30, > A patch has been sent to stable mail list to fix it, not sure if it has been > merged: > https://mails.dpdk.org/archives/stable/2019-September/017122.html > > 2- "make -C test/" fails. > "Fix looks to be to add "#include <inttypes.h>" into test_rwlock.c" > Not sure if there is a patch for this. Hi, this include was added in 18.11 as part of: commit 0d0dfaaff93cb599b2c58fd6fe405fd4f44b5710 Author: Joyce Kong <joyce.kong@arm.com> Date: Tue Sep 10 11:36:58 2019 +0800 test/rwlock: benchmark on all available cores [ upstream commit fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] Note, the master commit would not apply and it was a custom backport for 18.11 by Joyce (http://inbox.dpdk.org/stable/1568086619-5029-1-git-send-email-joyce.kong@arm.com) Maybe it can work for 17.11 too? > > 3- l2fwd-crypto, ERROR: Test Case test_qat_h_AES_XCBC_MAC_auto Result FAILED > Work in progress > > 4- ipsec-secgw, forwarding failed with null crypto QAT > Work in progress > > 5- Unit test "cryptodev_qat_autotest" failed > Issue not analyzed yet. > > >> >> Thanks! >> >> On Wed, 2019-09-18 at 10:03 +0000, Yu, PingX wrote: >>> Luca, >>> FYI. Currently there isn't reference for bug1 and bug2 and also >>> haven't send to mailing list yet. These bugs should be fixed before >>> release as they will block the basic PF test. >>> >>> Regards, >>> Yu Ping >>> >>> >>> -----Original Message----- >>> From: dev [mailto: >>> dev-bounces@dpdk.org >>> ] On Behalf Of Luca Boccassi >>> Sent: Wednesday, September 18, 2019 5:18 PM >>> To: Peng, Yuan < >>> yuan.peng@intel.com >>>> ; >>> dev@dpdk.org >>> >>> Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test >>> >>> Hi, >>> >>> Ping - this is blocking the 17.11.7 release. >>> >>> Thanks! >>> >>> On Tue, 2019-09-17 at 10:53 +0100, Luca Boccassi wrote: >>>> Hello, >>>> >>>> Do you have a reference for the patches for bug 1 and 2? Have they >>>> been sent to the mailing list? >>>> >>>> On Thu, 2019-09-12 at 08:52 +0000, Peng, Yuan wrote: >>>>> Update the latest test status here. >>>>> >>>>> -----Original Message----- >>>>> From: Yu, PingX >>>>> Sent: Thursday, September 12, 2019 2:37 PM >>>>> To: Yongseok Koh < >>>>> yskoh@mellanox.com >>>>> >>>>> >>>>>> ; Ananyev, Konstantin < >>>>> >>>>> konstantin.ananyev@intel.com >>>>> >>>>> >>>>>> ; >>>>> >>>>> asafp@mellanox.com >>>>> >>>>> >>>>> >>>>> Cc: Xu, Qian Q < >>>>> qian.q.xu@intel.com >>>>> >>>>> >>>>>> ; Lin, Xueqin < >>>>> >>>>> xueqin.lin@intel.com >>>>> >>>>> >>>>>> ; Chen, Zhaoyan < >>>>> >>>>> zhaoyan.chen@intel.com >>>>> >>>>> >>>>>> ; O'Hare, Cathal < >>>>> >>>>> cathal.ohare@intel.com >>>>> >>>>> >>>>>> ; Yigit, Ferruh < >>>>> >>>>> ferruh.yigit@intel.com >>>>> >>>>> >>>>>> ; Ma, LihongX < >>>>> >>>>> lihongx.ma@intel.com >>>>> >>>>> >>>>>> ; Li, WenjieX A < >>>>> >>>>> wenjiex.a.li@intel.com >>>>> >>>>> >>>>>> ; Wang, FengqinX < >>>>> >>>>> fengqinx.wang@intel.com >>>>> >>>>> >>>>>> ; Peng, Yuan < >>>>> >>>>> yuan.peng@intel.com >>>>> >>>>> >>>>> >>>>> Subject: RE: 17.11.7-rc1 (LTS) patches review and test >>>>> >>>>> All, >>>>> Update the latest test status here. >>>>> The critical bug has been fixed and we have re-tested all Intel >>>>> key >>>>> features. >>>>> >>>>> Intel(R) Testing result lists here. >>>>> # Basic Intel(R) NIC testing >>>>> * PF(i40e): One bug found in 1st round test. 2nd round test pass >>>>> after fixing the bug. (see Bug1) >>>>> * PF(ixgbe): the same as PF(i40e). >>>>> * VF: Pass and no issue. >>>>> * Build or compile: One bug found in 1st round test. 2nd round >>>>> test >>>>> pass after fixing the bug. (see Bug2) >>>>> * Intel NIC single core/NIC performance: Pass and no issue. >>>>> >>>>> #Basic cryptodev and virtio testing >>>>> * vhost/virtio basic loopback, PVP and performance test: pass. >>>>> * cryptodev: 3 bugs are found(see bug statistic in below). (See >>>>> Bug3,4 and 5) >>>>> >>>>> Bugs statistic: >>>>> Bug1: make -C test/ failed. It blocked about 60 test cases for >>>>> both >>>>> PF(i40e) and PF(ixgbe). Resolved by adding "#include >>>>> <inttypes.h>" >>>>> into test_rwlock.c. Please decide whether submit a patch to DPDK >>>>> or >>>>> not. >>>>> Bug2: compile error on fc30. Patch is provided and validated >>>>> pass. >>>>> Need to decide whether merge into DPDK or not. >>>>> Bug3: L2fwd: test_qat_h_AES_XCBC_MAC_auto failed. No progress >>>>> yet. >>>>> commit 39fb9500c42752a537588f7a203433ec4737fa1e >>>>> Author: Arek Kusztal < >>>>> arkadiuszx.kusztal@intel.com >>>>> >>>>> >>>>> >>>>> Date: Wed Dec 12 20:59:02 2018 +0100 >>>>> >>>>> Bug4: Ipsec-gw_test forwarding failed with null crypto QAT. No >>>>> progress yet. >>>>> commit 39fb9500c42752a537588f7a203433ec4737fa1e >>>>> Author: Arek Kusztal < >>>>> arkadiuszx.kusztal@intel.com >>>>> >>>>> >>>>> >>>>> Date: Wed Dec 12 20:59:02 2018 +0100 >>>>> >>>>> Bug5: Crypto: cryptodev_qat_autotest test failed. No progress >>>>> yet. >>>>> 39fb9500c42752a537588f7a203433ec4737fa1e is the first bad >>>>> commit >>>>> commit 39fb9500c42752a537588f7a203433ec4737fa1e >>>>> Author: Arek Kusztal < >>>>> arkadiuszx.kusztal@intel.com >>>>> >>>>> >>>>> >>>>> Date: Wed Dec 12 20:59:02 2018 +0100 >>>>> >>>>> Regards, >>>>> Yu Ping >>>>> >>>>> >>>>> -----Original Message----- >>>>> From: Wang, FengqinX >>>>> Sent: Monday, August 26, 2019 3:12 PM >>>>> To: Yongseok Koh < >>>>> yskoh@mellanox.com >>>>> >>>>> >>>>>> ; Ananyev, Konstantin < >>>>> >>>>> konstantin.ananyev@intel.com >>>>> >>>>> >>>>>> ; >>>>> >>>>> asafp@mellanox.com >>>>> >>>>> >>>>> >>>>> Cc: Xu, Qian Q < >>>>> qian.q.xu@intel.com >>>>> >>>>> >>>>>> ; Lin, Xueqin < >>>>> >>>>> xueqin.lin@intel.com >>>>> >>>>> >>>>>> ; Chen, Zhaoyan < >>>>> >>>>> zhaoyan.chen@intel.com >>>>> >>>>> >>>>>> ; O'Hare, Cathal < >>>>> >>>>> cathal.ohare@intel.com >>>>> >>>>> >>>>>> ; Yigit, Ferruh < >>>>> >>>>> ferruh.yigit@intel.com >>>>> >>>>> >>>>>> ; Yu, PingX < >>>>> >>>>> pingx.yu@intel.com >>>>> >>>>> >>>>>> ; Ma, LihongX < >>>>> >>>>> lihongx.ma@intel.com >>>>> >>>>> >>>>>> ; Li, WenjieX A < >>>>> >>>>> wenjiex.a.li@intel.com >>>>> >>>>> >>>>> >>>>> Subject: RE: 17.11.7-rc1 (LTS) patches review and test >>>>> >>>>> Add asafp in the loop due to Yongseok is longer working at >>>>> Mellanox. >>>>> >>>>> BRs, Vicky >>>>> >>>>> -----Original Message----- >>>>> From: Wang, FengqinX >>>>> Sent: Monday, August 26, 2019 3:07 PM >>>>> To: 'Yongseok Koh' < >>>>> yskoh@mellanox.com >>>>> >>>>> >>>>>> ; Ananyev, Konstantin < >>>>> >>>>> konstantin.ananyev@intel.com >>>>> >>>>> >>>>> >>>>> Cc: Xu, Qian Q < >>>>> qian.q.xu@intel.com >>>>> >>>>> >>>>>> ; Lin, Xueqin < >>>>> >>>>> xueqin.lin@intel.com >>>>> >>>>> >>>>>> ; Chen, Zhaoyan < >>>>> >>>>> zhaoyan.chen@intel.com >>>>> >>>>> >>>>>> ; O'Hare, Cathal < >>>>> >>>>> cathal.ohare@intel.com >>>>> >>>>> >>>>>> ; Yigit, Ferruh < >>>>> >>>>> ferruh.yigit@intel.com >>>>> >>>>> >>>>>> ; Yu, PingX < >>>>> >>>>> pingx.yu@intel.com >>>>> >>>>> >>>>>> ; Ma, LihongX < >>>>> >>>>> lihongx.ma@intel.com >>>>> >>>>> >>>>>> ; Li, WenjieX A < >>>>> >>>>> wenjiex.a.li@intel.com >>>>> >>>>> >>>>> >>>>> Subject: RE: 17.11.7-rc1 (LTS) patches review and test >>>>> >>>>> Hi Yongseok, Konstantin, >>>>> >>>>> There is one critical compile issue found, and below is the bad >>>>> commit related information, this issue has blocked most of unit >>>>> tests which have used dpdk/test/test, would you please help to >>>>> fix >>>>> this issue ASAP? >>>>> >>>>> commit 29e08d740ffc1e0ed9e7a9bd25fb95714fac1070 >>>>> Author: Joyce Kong < >>>>> joyce.kong@arm.com >>>>> >>>>> >>>>> >>>>> Date: Thu Jul 25 14:50:21 2019 +0800 >>>>> >>>>> test/rwlock: benchmark on all available cores >>>>> >>>>> [ backported from upstream commit >>>>> fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] >>>>> >>>>> Add performance test on all available cores to benchmark >>>>> the scaling up performance of rw_lock. >>>>> >>>>> Fixes: af75078fece3 ("first public release") >>>>> >>>>> Suggested-by: Gavin Hu < >>>>> gavin.hu@arm.com >>>>> >>>>> >>>>> >>>>> Signed-off-by: Joyce Kong < >>>>> joyce.kong@arm.com >>>>> >>>>> >>>>> >>>>> Acked-by: Konstantin Ananyev < >>>>> konstantin.ananyev@intel.com >>>>> >>>>> >>>>> >>>>> >>>>> And below is the error message output: >>>>> >>>>> test_rwlock.c: In function 'load_loop_fn': >>>>> test_rwlock.c:126:38: error: expected ')' before 'PRIu64' >>>>> printf("Core [%u] rwlock_data = %"PRIu64"\n", ^~~~~~ >>>>> ) >>>>> test_rwlock.c:126:19: error: format '%u' expects a matching >>>>> 'unsigned int' argument [-Werror=format=] printf("Core [%u] >>>>> rwlock_data = %"PRIu64"\n", ~^ >>>>> test_rwlock.c:126:36: error: spurious trailing '%' in format [- >>>>> Werror=format=] printf("Core [%u] rwlock_data = %"PRIu64"\n", ^ >>>>> test_rwlock.c: In function 'test_rwlock_perf': >>>>> test_rwlock.c:160:31: error: expected ')' before 'PRIu64' >>>>> printf("Core [%u] count = %"PRIu64"\n", i, lock_count[i]); ^~~~~~ >>>>> ) >>>>> test_rwlock.c:160:18: error: format '%u' expects a matching >>>>> 'unsigned int' argument [-Werror=format=] printf("Core [%u] count >>>>> = >>>>> %"PRIu64"\n", i, lock_count[i]); ~^ >>>>> test_rwlock.c:160:29: error: spurious trailing '%' in format [- >>>>> Werror=format=] printf("Core [%u] count = %"PRIu64"\n", i, >>>>> lock_count[i]); ^ >>>>> test_rwlock.c:164:26: error: expected ')' before 'PRIu64' >>>>> printf("Total count = %"PRIu64"\n", total); ^~~~~~ >>>>> ) >>>>> test_rwlock.c:164:24: error: spurious trailing '%' in format [- >>>>> Werror=format=] printf("Total count = %"PRIu64"\n", total); ^ >>>>> cc1: all warnings being treated as errors >>>>> >>>>> BRs, Vicky >>>>> >>>>> -----Original Message----- >>>>> From: Yongseok Koh [mailto: >>>>> yskoh@mellanox.com >>>>> >>>>> >>>>> ] >>>>> Sent: Friday, August 16, 2019 2:05 AM >>>>> To: dpdk stable < >>>>> stable@dpdk.org >>>>> >>>>> >>>>> >>>>> Cc: >>>>> dev@dpdk.org >>>>> >>>>> >>>>> ; >>>>> pezhang@redhat.com >>>>> >>>>> >>>>> ; >>>>> siliu@redhat.com >>>>> >>>>> >>>>> ; Wang, FengqinX < >>>>> fengqinx.wang@intel.com >>>>> >>>>> >>>>>> ; Chen, Zhaoyan < >>>>> >>>>> zhaoyan.chen@intel.com >>>>> >>>>> >>>>>> ; Xu, Qian Q < >>>>> >>>>> qian.q.xu@intel.com >>>>> >>>>> >>>>>> ; >>>>> >>>>> alialnu@mellanox.com >>>>> >>>>> >>>>> ; >>>>> rasland@mellanox.com >>>>> >>>>> >>>>> >>>>> Subject: 17.11.7-rc1 (LTS) patches review and test >>>>> >>>>> Hi all, >>>>> >>>>> Here is a list of patches targeted for LTS release 17.11.7. >>>>> Please >>>>> help review and test. The planned date for the final release is >>>>> Aug >>>>> 23, Before that, please shout if anyone has objections with >>>>> these >>>>> patches being applied. >>>>> >>>>> Also for the companies committed to running regression tests, >>>>> please >>>>> run the tests and report any issue before the release date. >>>>> >>>>> A release candidate tarball can be found at: >>>>> >>>>> >>>>> https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 >>>>> >>>>> >>>>> >>>>> >>>>> These patches are located at branch 17.11 of dpdk-stable repo: >>>>> >>>>> https://dpdk.org/browse/dpdk-stable/ >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> Thanks, >>>>> Yongseok >>>>> >>>>> --- >>>>> >>>>> Aaron Conole (1): >>>>> net/virtio: fix dangling pointer on failure >>>>> >>>>> Agalya Babu RadhaKrishnan (1): >>>>> doc: fix interactive commands in testpmd guide >>>>> >>>>> Akhil Goyal (1): >>>>> crypto/dpaa2_sec: fix session clearing >>>>> >>>>> Alejandro Lucero (1): >>>>> net/nfp: fix RSS query >>>>> >>>>> Anatoly Burakov (2): >>>>> eal: improve musl compatibility of string functions >>>>> malloc: fix documentation of realloc function >>>>> >>>>> Andrew Rybchenko (2): >>>>> net/sfc: remove control path logging from Rx queue count >>>>> app/testpmd: set fixed flag for exact link speed >>>>> >>>>> Andrius Sirvys (3): >>>>> net/virtio: fix duplicate naming of include guard >>>>> bitrate: fix unchecked return value >>>>> drivers/net: fix shifting 32-bit signed variable 31 times >>>>> >>>>> Anoob Joseph (1): >>>>> cryptodev: fix driver name comparison >>>>> >>>>> Beilei Xing (1): >>>>> net/i40e: fix link speed for X722 >>>>> >>>>> Bernard Iremonger (1): >>>>> examples/ipsec-secgw: fix debug logs >>>>> >>>>> Bill Hong (1): >>>>> net: fix Tx VLAN flag for offload emulation >>>>> >>>>> Bruce Richardson (9): >>>>> eal: support strlcat function >>>>> net/bonding: fix buffer length when printing strings >>>>> examples/l2fwd-cat: fix build on FreeBSD >>>>> app/crypto-perf: check range of socket id >>>>> examples/vhost_scsi: fix null-check for parameter >>>>> net/i40e: fix dereference before null check in mbuf release >>>>> net/ixgbe: fix warning with GCC 9 >>>>> bus/fslmc: fix warning with GCC 9 >>>>> eal: tighten permissions on shared memory files >>>>> >>>>> Chaitanya Babu Talluri (2): >>>>> drivers/net: fix possible overflow using strlcat >>>>> cfgfile: replace strcat with strlcat >>>>> >>>>> David Christensen (2): >>>>> maintainers: update for IBM POWER >>>>> examples/vm_power_manager: fix PMD specific code >>>>> >>>>> David Marchand (7): >>>>> eal: fix check when retrieving current CPU affinity >>>>> eal: remove dead code in core list parsing >>>>> app/testpmd: remove unused field from port struct >>>>> doc: fix examples in bonding guide >>>>> net/bonding: fix port id types >>>>> net/bonding: fix queue index types >>>>> app/testpmd: remove useless casts on statistics >>>>> >>>>> Davide Caratti (1): >>>>> net/bnxt: support IOVA VA mode >>>>> >>>>> Dekel Peled (8): >>>>> net/mlx5: fix hex dump of error completion >>>>> net/mlx5: fix sync when handling Tx completions >>>>> eal/ppc: fix global memory barrier >>>>> eal: fix typo in comment of vector function >>>>> doc: fix links to doxygen and sphinx sites >>>>> app/testpmd: fix typo in comment >>>>> net/mlx5: fix comments mixing Rx and Tx >>>>> net/mlx5: fix release of Rx queue object >>>>> >>>>> Fan Zhang (1): >>>>> examples/ipsec-secgw: fix AES-CTR block size >>>>> >>>>> Ferruh Yigit (5): >>>>> kni: fix build with Linux 5.1 >>>>> build: fix crash by disabling AVX512 with binutils 2.31 >>>>> net/ring: fix return value check >>>>> net/kni: fix return value check >>>>> app/testpmd: revert fixed flag for exact link speed >>>>> >>>>> Gage Eads (1): >>>>> ring: fix namesize macro documentation block >>>>> >>>>> Gavin Hu (3): >>>>> test/spinlock: remove delay for correct benchmarking >>>>> test/spinlock: amortize the cost of getting time >>>>> spinlock: reimplement with atomic one-way barrier >>>>> >>>>> Hari Kumar Vemula (1): >>>>> net/bonding: fix reset active slave >>>>> >>>>> Harry van Haaren (1): >>>>> event/sw: fix enqueue checks in self-test >>>>> >>>>> Herakliusz Lipiec (1): >>>>> doc: fix broken link in LPM guide >>>>> >>>>> Hyong Youb Kim (4): >>>>> net/bonding: avoid warning for invalid port >>>>> net/enic: fix flow director SCTP matching >>>>> net/enic: fix SCTP match for flow API >>>>> net/enic: check for unsupported flow item types >>>>> >>>>> Igor Romanov (1): >>>>> app/testpmd: fix stdout flush after printing stats >>>>> >>>>> Ilya Maximets (2): >>>>> vhost: fix device leak on connection add failure >>>>> vhost: fix silent queue enabling with legacy guests >>>>> >>>>> Ivan Malov (1): >>>>> net/sfc: log port ID as 16-bit unsigned integer on panic >>>>> >>>>> Jerin Jacob (1): >>>>> mk: fix AVX512 disabled warning on non x86 >>>>> >>>>> Jianfeng Tan (1): >>>>> drivers/net: do not use private ethdev data >>>>> >>>>> Joyce Kong (1): >>>>> test/rwlock: benchmark on all available cores >>>>> >>>>> Kevin Traynor (3): >>>>> net/qede: support IOVA VA mode >>>>> eal/linux: fix log levels for pagemap reading failure >>>>> power: fix frequency list buffer validation >>>>> >>>>> Liang Zhang (1): >>>>> net/bonding: fix LACP negotiation >>>>> >>>>> Luo Gaoliang (1): >>>>> kni: fix build on RHEL8 >>>>> >>>>> Marcin Smoczynski (1): >>>>> examples/ipsec-secgw: fix build error log >>>>> >>>>> Natanael Copa (3): >>>>> bus/fslmc: remove unused include of error.h >>>>> bus/fslmc: fix build with musl libc >>>>> app/test: fix build with musl libc >>>>> >>>>> Pallantla Poornima (3): >>>>> app/test: fix sprintf with strlcat >>>>> test/distributor: replace sprintf with strlcpy >>>>> test/hash: replace sprintf with snprintf >>>>> >>>>> Qi Zhang (1): >>>>> net/i40e: fix time sync for 25G >>>>> >>>>> Radu Nicolau (3): >>>>> net/null: add MAC address setting fake operation >>>>> test/virtual_pmd: add MAC address setting fake op >>>>> test/bonding: assign non-zero MAC to null devices >>>>> >>>>> Rahul Lakkireddy (1): >>>>> net/cxgbe: update Chelsio T5/T6 NIC device ids >>>>> >>>>> Rami Rosen (8): >>>>> net/virtio: remove forward declaration >>>>> mbuf: fix a typo >>>>> doc: fix a minor typo in testpmd guide >>>>> doc: remove reference to rte.doc.mk in programmers guide >>>>> examples/ethtool: fix two typos >>>>> doc: fix link in Linux getting started guide >>>>> app/testpmd: fix a typo in log message >>>>> ethdev: fix a typo >>>>> >>>>> Rasesh Mody (2): >>>>> net/bnx2x: fix race for periodic flags >>>>> net/bnx2x: fix optic module verification >>>>> >>>>> Shahaf Shuler (1): >>>>> net/mlx5: fix packet inline on Tx queue wraparound >>>>> >>>>> Shahed Shaikh (5): >>>>> net/bnx2x: fix segfaults due to stale interrupt status >>>>> net/bnx2x: fix memory leak >>>>> net/bnx2x: fix ramrod timeout >>>>> net/bnx2x: fix DMAE timeout >>>>> net/qede: fix Tx packet prepare for tunnel packets >>>>> >>>>> Shreyansh Jain (1): >>>>> bus/dpaa: fix Rx discard register mask >>>>> >>>>> Stephen Hemminger (8): >>>>> net/octeontx: fix vdev name >>>>> net/bnxt: fix Rx VLAN offload flags >>>>> net/virtio: remove useless condition >>>>> ring: fix an error message >>>>> net/ring: avoid hard-coded length >>>>> net/ring: use calloc style where appropriate >>>>> net/ring: check length of ring name >>>>> net/virtio: fix buffer leak on VLAN insert >>>>> >>>>> Thomas Monjalon (2): >>>>> mk: fix build of shared library with libbsd >>>>> bus/vdev: fix debug message on probing >>>>> >>>>> Tiwei Bie (4): >>>>> net/virtio: add barrier in interrupt enable >>>>> vhost: restore mbuf first when freeing zmbuf >>>>> vhost: fix potential use-after-free for zero copy mbuf >>>>> vhost: fix potential use-after-free for memory region >>>>> >>>>> Vishal Kulkarni (1): >>>>> net/cxgbe: fix missing checksum flags and packet type >>>>> >>>>> Xiao Wang (1): >>>>> net/fm10k: fix VLAN strip offload flag >>>>> >>>>> Yipeng Wang (1): >>>>> hash: fix doc about thread/process safety >>>>> >>>>> Yongseok Koh (4): >>>>> net/mlx5: fix instruction hotspot on replenishing Rx buffer >>>>> net/mlx5: check Tx queue size overflow >>>>> net/mlx5: fix max number of queues for NEON Tx >>>>> doc: fix typo in mlx5 guide >>>>> >>>>> Yunjian Wang (1): >>>>> net/ixgbe: fix crash on remove >>>>> >>>>> >>> >>> -- >>> Kind regards, >>> Luca Boccassi >>> > ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test 2019-09-24 17:15 ` Kevin Traynor @ 2019-09-24 17:25 ` Luca Boccassi 2019-09-24 20:08 ` Luca Boccassi 0 siblings, 1 reply; 19+ messages in thread From: Luca Boccassi @ 2019-09-24 17:25 UTC (permalink / raw) To: Kevin Traynor, Ferruh Yigit, Mcnamara, John Cc: Yu, PingX, Peng, Yuan, dev, qian.q.xu On Tue, 2019-09-24 at 18:15 +0100, Kevin Traynor wrote: > On 24/09/2019 17:36, Ferruh Yigit wrote: > > On 9/24/2019 12:07 PM, Luca Boccassi wrote: > > > Ping - any updates on these patches? The release of 17.11.7 is > > > currently on hold waiting for a resolution here. > > > > Hi Luca, > > > > Test team provided some internal details: > > > > 1- Build issue on f30, > > A patch has been sent to stable mail list to fix it, not sure if it > > has been > > merged: > > https://mails.dpdk.org/archives/stable/2019-September/017122.html > > Thanks Ferruh, I am testing a build with that one. > > 2- "make -C test/" fails. > > "Fix looks to be to add "#include <inttypes.h>" into test_rwlock.c" > > Not sure if there is a patch for this. > > Hi, this include was added in 18.11 as part of: > > commit 0d0dfaaff93cb599b2c58fd6fe405fd4f44b5710 > Author: Joyce Kong < > joyce.kong@arm.com > > > Date: Tue Sep 10 11:36:58 2019 +0800 > > test/rwlock: benchmark on all available cores > > [ upstream commit fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] > > > Note, the master commit would not apply and it was a custom backport > for > 18.11 by Joyce > ( > http://inbox.dpdk.org/stable/1568086619-5029-1-git-send-email-joyce.kong@arm.com > ) > Maybe it can work for 17.11 too? Hi, It was backported for 17.11 too, but it does not have the include. I'll test another commits that has it. > > 3- l2fwd-crypto, ERROR: Test Case test_qat_h_AES_XCBC_MAC_auto > > Result FAILED > > Work in progress > > > > 4- ipsec-secgw, forwarding failed with null crypto QAT > > Work in progress > > > > 5- Unit test "cryptodev_qat_autotest" failed > > Issue not analyzed yet. > > > > > > > Thanks! > > > > > > On Wed, 2019-09-18 at 10:03 +0000, Yu, PingX wrote: > > > > Luca, > > > > FYI. Currently there isn't reference for bug1 and bug2 and also > > > > haven't send to mailing list yet. These bugs should be fixed > > > > before > > > > release as they will block the basic PF test. > > > > > > > > Regards, > > > > Yu Ping > > > > > > > > > > > > -----Original Message----- > > > > From: dev [mailto: > > > > dev-bounces@dpdk.org > > > > > > > > ] On Behalf Of Luca Boccassi > > > > Sent: Wednesday, September 18, 2019 5:18 PM > > > > To: Peng, Yuan < > > > > yuan.peng@intel.com > > > > > > > > > ; > > > > > > > > dev@dpdk.org > > > > > > > > > > > > Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review > > > > and test > > > > > > > > Hi, > > > > > > > > Ping - this is blocking the 17.11.7 release. > > > > > > > > Thanks! > > > > > > > > On Tue, 2019-09-17 at 10:53 +0100, Luca Boccassi wrote: > > > > > Hello, > > > > > > > > > > Do you have a reference for the patches for bug 1 and 2? Have > > > > > they > > > > > been sent to the mailing list? > > > > > > > > > > On Thu, 2019-09-12 at 08:52 +0000, Peng, Yuan wrote: > > > > > > Update the latest test status here. > > > > > > > > > > > > -----Original Message----- > > > > > > From: Yu, PingX > > > > > > Sent: Thursday, September 12, 2019 2:37 PM > > > > > > To: Yongseok Koh < > > > > > > yskoh@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Ananyev, Konstantin < > > > > > > > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > > > > > > asafp@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cc: Xu, Qian Q < > > > > > > qian.q.xu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Lin, Xueqin < > > > > > > > > > > > > xueqin.lin@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; O'Hare, Cathal < > > > > > > > > > > > > cathal.ohare@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Yigit, Ferruh < > > > > > > > > > > > > ferruh.yigit@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Ma, LihongX < > > > > > > > > > > > > lihongx.ma@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Li, WenjieX A < > > > > > > > > > > > > wenjiex.a.li@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Wang, FengqinX < > > > > > > > > > > > > fengqinx.wang@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Peng, Yuan < > > > > > > > > > > > > yuan.peng@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > > > > > > > > > All, > > > > > > Update the latest test status here. > > > > > > The critical bug has been fixed and we have re-tested all > > > > > > Intel > > > > > > key > > > > > > features. > > > > > > > > > > > > Intel(R) Testing result lists here. > > > > > > # Basic Intel(R) NIC testing > > > > > > * PF(i40e): One bug found in 1st round test. 2nd round test > > > > > > pass > > > > > > after fixing the bug. (see Bug1) > > > > > > * PF(ixgbe): the same as PF(i40e). > > > > > > * VF: Pass and no issue. > > > > > > * Build or compile: One bug found in 1st round test. 2nd > > > > > > round > > > > > > test > > > > > > pass after fixing the bug. (see Bug2) > > > > > > * Intel NIC single core/NIC performance: Pass and no issue. > > > > > > > > > > > > #Basic cryptodev and virtio testing > > > > > > * vhost/virtio basic loopback, PVP and performance test: > > > > > > pass. > > > > > > * cryptodev: 3 bugs are found(see bug statistic in below). > > > > > > (See > > > > > > Bug3,4 and 5) > > > > > > > > > > > > Bugs statistic: > > > > > > Bug1: make -C test/ failed. It blocked about 60 test cases > > > > > > for > > > > > > both > > > > > > PF(i40e) and PF(ixgbe). Resolved by adding "#include > > > > > > <inttypes.h>" > > > > > > into test_rwlock.c. Please decide whether submit a patch to > > > > > > DPDK > > > > > > or > > > > > > not. > > > > > > Bug2: compile error on fc30. Patch is provided and > > > > > > validated > > > > > > pass. > > > > > > Need to decide whether merge into DPDK or not. > > > > > > Bug3: L2fwd: test_qat_h_AES_XCBC_MAC_auto failed. No > > > > > > progress > > > > > > yet. > > > > > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > > > > > Author: Arek Kusztal < > > > > > > arkadiuszx.kusztal@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > > > > > > > > > Bug4: Ipsec-gw_test forwarding failed with null crypto QAT. > > > > > > No > > > > > > progress yet. > > > > > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > > > > > Author: Arek Kusztal < > > > > > > arkadiuszx.kusztal@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > > > > > > > > > Bug5: Crypto: cryptodev_qat_autotest test failed. No > > > > > > progress > > > > > > yet. > > > > > > 39fb9500c42752a537588f7a203433ec4737fa1e is the first bad > > > > > > commit > > > > > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > > > > > Author: Arek Kusztal < > > > > > > arkadiuszx.kusztal@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > > > > > > > > > Regards, > > > > > > Yu Ping > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Wang, FengqinX > > > > > > Sent: Monday, August 26, 2019 3:12 PM > > > > > > To: Yongseok Koh < > > > > > > yskoh@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Ananyev, Konstantin < > > > > > > > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > > > > > > asafp@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cc: Xu, Qian Q < > > > > > > qian.q.xu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Lin, Xueqin < > > > > > > > > > > > > xueqin.lin@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; O'Hare, Cathal < > > > > > > > > > > > > cathal.ohare@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Yigit, Ferruh < > > > > > > > > > > > > ferruh.yigit@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Yu, PingX < > > > > > > > > > > > > pingx.yu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Ma, LihongX < > > > > > > > > > > > > lihongx.ma@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Li, WenjieX A < > > > > > > > > > > > > wenjiex.a.li@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > > > > > > > > > Add asafp in the loop due to Yongseok is longer working at > > > > > > Mellanox. > > > > > > > > > > > > BRs, Vicky > > > > > > > > > > > > -----Original Message----- > > > > > > From: Wang, FengqinX > > > > > > Sent: Monday, August 26, 2019 3:07 PM > > > > > > To: 'Yongseok Koh' < > > > > > > yskoh@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Ananyev, Konstantin < > > > > > > > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cc: Xu, Qian Q < > > > > > > qian.q.xu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Lin, Xueqin < > > > > > > > > > > > > xueqin.lin@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; O'Hare, Cathal < > > > > > > > > > > > > cathal.ohare@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Yigit, Ferruh < > > > > > > > > > > > > ferruh.yigit@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Yu, PingX < > > > > > > > > > > > > pingx.yu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Ma, LihongX < > > > > > > > > > > > > lihongx.ma@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Li, WenjieX A < > > > > > > > > > > > > wenjiex.a.li@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > > > > > > > > > Hi Yongseok, Konstantin, > > > > > > > > > > > > There is one critical compile issue found, and below is the > > > > > > bad > > > > > > commit related information, this issue has blocked most of > > > > > > unit > > > > > > tests which have used dpdk/test/test, would you please help > > > > > > to > > > > > > fix > > > > > > this issue ASAP? > > > > > > > > > > > > commit 29e08d740ffc1e0ed9e7a9bd25fb95714fac1070 > > > > > > Author: Joyce Kong < > > > > > > joyce.kong@arm.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Thu Jul 25 14:50:21 2019 +0800 > > > > > > > > > > > > test/rwlock: benchmark on all available cores > > > > > > > > > > > > [ backported from upstream commit > > > > > > fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] > > > > > > > > > > > > Add performance test on all available cores to > > > > > > benchmark > > > > > > the scaling up performance of rw_lock. > > > > > > > > > > > > Fixes: af75078fece3 ("first public release") > > > > > > > > > > > > Suggested-by: Gavin Hu < > > > > > > gavin.hu@arm.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Joyce Kong < > > > > > > joyce.kong@arm.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Acked-by: Konstantin Ananyev < > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > And below is the error message output: > > > > > > > > > > > > test_rwlock.c: In function 'load_loop_fn': > > > > > > test_rwlock.c:126:38: error: expected ')' before 'PRIu64' > > > > > > printf("Core [%u] rwlock_data = %"PRIu64"\n", ^~~~~~ > > > > > > ) > > > > > > test_rwlock.c:126:19: error: format '%u' expects a > > > > > > matching > > > > > > 'unsigned int' argument [-Werror=format=] printf("Core > > > > > > [%u] > > > > > > rwlock_data = %"PRIu64"\n", ~^ > > > > > > test_rwlock.c:126:36: error: spurious trailing '%' in > > > > > > format [- > > > > > > Werror=format=] printf("Core [%u] rwlock_data = > > > > > > %"PRIu64"\n", ^ > > > > > > test_rwlock.c: In function 'test_rwlock_perf': > > > > > > test_rwlock.c:160:31: error: expected ')' before 'PRIu64' > > > > > > printf("Core [%u] count = %"PRIu64"\n", i, lock_count[i]); > > > > > > ^~~~~~ > > > > > > ) > > > > > > test_rwlock.c:160:18: error: format '%u' expects a > > > > > > matching > > > > > > 'unsigned int' argument [-Werror=format=] printf("Core [%u] > > > > > > count > > > > > > = > > > > > > %"PRIu64"\n", i, lock_count[i]); ~^ > > > > > > test_rwlock.c:160:29: error: spurious trailing '%' in > > > > > > format [- > > > > > > Werror=format=] printf("Core [%u] count = %"PRIu64"\n", i, > > > > > > lock_count[i]); ^ > > > > > > test_rwlock.c:164:26: error: expected ')' before 'PRIu64' > > > > > > printf("Total count = %"PRIu64"\n", total); ^~~~~~ > > > > > > ) > > > > > > test_rwlock.c:164:24: error: spurious trailing '%' in > > > > > > format [- > > > > > > Werror=format=] printf("Total count = %"PRIu64"\n", total); > > > > > > ^ > > > > > > cc1: all warnings being treated as errors > > > > > > > > > > > > BRs, Vicky > > > > > > > > > > > > -----Original Message----- > > > > > > From: Yongseok Koh [mailto: > > > > > > yskoh@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > ] > > > > > > Sent: Friday, August 16, 2019 2:05 AM > > > > > > To: dpdk stable < > > > > > > stable@dpdk.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cc: > > > > > > dev@dpdk.org > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > pezhang@redhat.com > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > siliu@redhat.com > > > > > > > > > > > > > > > > > > > > > > > > ; Wang, FengqinX < > > > > > > fengqinx.wang@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; Xu, Qian Q < > > > > > > > > > > > > qian.q.xu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > > > > > > alialnu@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > rasland@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Subject: 17.11.7-rc1 (LTS) patches review and test > > > > > > > > > > > > Hi all, > > > > > > > > > > > > Here is a list of patches targeted for LTS release 17.11.7. > > > > > > Please > > > > > > help review and test. The planned date for the final > > > > > > release is > > > > > > Aug > > > > > > 23, Before that, please shout if anyone has objections with > > > > > > these > > > > > > patches being applied. > > > > > > > > > > > > Also for the companies committed to running regression > > > > > > tests, > > > > > > please > > > > > > run the tests and report any issue before the release date. > > > > > > > > > > > > A release candidate tarball can be found at: > > > > > > > > > > > > > > > > > > https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > These patches are located at branch 17.11 of dpdk-stable > > > > > > repo: > > > > > > > > > > > > https://dpdk.org/browse/dpdk-stable/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > Yongseok > > > > > > > > > > > > --- > > > > > > > > > > > > Aaron Conole (1): > > > > > > net/virtio: fix dangling pointer on failure > > > > > > > > > > > > Agalya Babu RadhaKrishnan (1): > > > > > > doc: fix interactive commands in testpmd guide > > > > > > > > > > > > Akhil Goyal (1): > > > > > > crypto/dpaa2_sec: fix session clearing > > > > > > > > > > > > Alejandro Lucero (1): > > > > > > net/nfp: fix RSS query > > > > > > > > > > > > Anatoly Burakov (2): > > > > > > eal: improve musl compatibility of string functions > > > > > > malloc: fix documentation of realloc function > > > > > > > > > > > > Andrew Rybchenko (2): > > > > > > net/sfc: remove control path logging from Rx queue > > > > > > count > > > > > > app/testpmd: set fixed flag for exact link speed > > > > > > > > > > > > Andrius Sirvys (3): > > > > > > net/virtio: fix duplicate naming of include guard > > > > > > bitrate: fix unchecked return value > > > > > > drivers/net: fix shifting 32-bit signed variable 31 > > > > > > times > > > > > > > > > > > > Anoob Joseph (1): > > > > > > cryptodev: fix driver name comparison > > > > > > > > > > > > Beilei Xing (1): > > > > > > net/i40e: fix link speed for X722 > > > > > > > > > > > > Bernard Iremonger (1): > > > > > > examples/ipsec-secgw: fix debug logs > > > > > > > > > > > > Bill Hong (1): > > > > > > net: fix Tx VLAN flag for offload emulation > > > > > > > > > > > > Bruce Richardson (9): > > > > > > eal: support strlcat function > > > > > > net/bonding: fix buffer length when printing strings > > > > > > examples/l2fwd-cat: fix build on FreeBSD > > > > > > app/crypto-perf: check range of socket id > > > > > > examples/vhost_scsi: fix null-check for parameter > > > > > > net/i40e: fix dereference before null check in mbuf > > > > > > release > > > > > > net/ixgbe: fix warning with GCC 9 > > > > > > bus/fslmc: fix warning with GCC 9 > > > > > > eal: tighten permissions on shared memory files > > > > > > > > > > > > Chaitanya Babu Talluri (2): > > > > > > drivers/net: fix possible overflow using strlcat > > > > > > cfgfile: replace strcat with strlcat > > > > > > > > > > > > David Christensen (2): > > > > > > maintainers: update for IBM POWER > > > > > > examples/vm_power_manager: fix PMD specific code > > > > > > > > > > > > David Marchand (7): > > > > > > eal: fix check when retrieving current CPU affinity > > > > > > eal: remove dead code in core list parsing > > > > > > app/testpmd: remove unused field from port struct > > > > > > doc: fix examples in bonding guide > > > > > > net/bonding: fix port id types > > > > > > net/bonding: fix queue index types > > > > > > app/testpmd: remove useless casts on statistics > > > > > > > > > > > > Davide Caratti (1): > > > > > > net/bnxt: support IOVA VA mode > > > > > > > > > > > > Dekel Peled (8): > > > > > > net/mlx5: fix hex dump of error completion > > > > > > net/mlx5: fix sync when handling Tx completions > > > > > > eal/ppc: fix global memory barrier > > > > > > eal: fix typo in comment of vector function > > > > > > doc: fix links to doxygen and sphinx sites > > > > > > app/testpmd: fix typo in comment > > > > > > net/mlx5: fix comments mixing Rx and Tx > > > > > > net/mlx5: fix release of Rx queue object > > > > > > > > > > > > Fan Zhang (1): > > > > > > examples/ipsec-secgw: fix AES-CTR block size > > > > > > > > > > > > Ferruh Yigit (5): > > > > > > kni: fix build with Linux 5.1 > > > > > > build: fix crash by disabling AVX512 with binutils > > > > > > 2.31 > > > > > > net/ring: fix return value check > > > > > > net/kni: fix return value check > > > > > > app/testpmd: revert fixed flag for exact link speed > > > > > > > > > > > > Gage Eads (1): > > > > > > ring: fix namesize macro documentation block > > > > > > > > > > > > Gavin Hu (3): > > > > > > test/spinlock: remove delay for correct benchmarking > > > > > > test/spinlock: amortize the cost of getting time > > > > > > spinlock: reimplement with atomic one-way barrier > > > > > > > > > > > > Hari Kumar Vemula (1): > > > > > > net/bonding: fix reset active slave > > > > > > > > > > > > Harry van Haaren (1): > > > > > > event/sw: fix enqueue checks in self-test > > > > > > > > > > > > Herakliusz Lipiec (1): > > > > > > doc: fix broken link in LPM guide > > > > > > > > > > > > Hyong Youb Kim (4): > > > > > > net/bonding: avoid warning for invalid port > > > > > > net/enic: fix flow director SCTP matching > > > > > > net/enic: fix SCTP match for flow API > > > > > > net/enic: check for unsupported flow item types > > > > > > > > > > > > Igor Romanov (1): > > > > > > app/testpmd: fix stdout flush after printing stats > > > > > > > > > > > > Ilya Maximets (2): > > > > > > vhost: fix device leak on connection add failure > > > > > > vhost: fix silent queue enabling with legacy guests > > > > > > > > > > > > Ivan Malov (1): > > > > > > net/sfc: log port ID as 16-bit unsigned integer on > > > > > > panic > > > > > > > > > > > > Jerin Jacob (1): > > > > > > mk: fix AVX512 disabled warning on non x86 > > > > > > > > > > > > Jianfeng Tan (1): > > > > > > drivers/net: do not use private ethdev data > > > > > > > > > > > > Joyce Kong (1): > > > > > > test/rwlock: benchmark on all available cores > > > > > > > > > > > > Kevin Traynor (3): > > > > > > net/qede: support IOVA VA mode > > > > > > eal/linux: fix log levels for pagemap reading failure > > > > > > power: fix frequency list buffer validation > > > > > > > > > > > > Liang Zhang (1): > > > > > > net/bonding: fix LACP negotiation > > > > > > > > > > > > Luo Gaoliang (1): > > > > > > kni: fix build on RHEL8 > > > > > > > > > > > > Marcin Smoczynski (1): > > > > > > examples/ipsec-secgw: fix build error log > > > > > > > > > > > > Natanael Copa (3): > > > > > > bus/fslmc: remove unused include of error.h > > > > > > bus/fslmc: fix build with musl libc > > > > > > app/test: fix build with musl libc > > > > > > > > > > > > Pallantla Poornima (3): > > > > > > app/test: fix sprintf with strlcat > > > > > > test/distributor: replace sprintf with strlcpy > > > > > > test/hash: replace sprintf with snprintf > > > > > > > > > > > > Qi Zhang (1): > > > > > > net/i40e: fix time sync for 25G > > > > > > > > > > > > Radu Nicolau (3): > > > > > > net/null: add MAC address setting fake operation > > > > > > test/virtual_pmd: add MAC address setting fake op > > > > > > test/bonding: assign non-zero MAC to null devices > > > > > > > > > > > > Rahul Lakkireddy (1): > > > > > > net/cxgbe: update Chelsio T5/T6 NIC device ids > > > > > > > > > > > > Rami Rosen (8): > > > > > > net/virtio: remove forward declaration > > > > > > mbuf: fix a typo > > > > > > doc: fix a minor typo in testpmd guide > > > > > > doc: remove reference to rte.doc.mk in programmers > > > > > > guide > > > > > > examples/ethtool: fix two typos > > > > > > doc: fix link in Linux getting started guide > > > > > > app/testpmd: fix a typo in log message > > > > > > ethdev: fix a typo > > > > > > > > > > > > Rasesh Mody (2): > > > > > > net/bnx2x: fix race for periodic flags > > > > > > net/bnx2x: fix optic module verification > > > > > > > > > > > > Shahaf Shuler (1): > > > > > > net/mlx5: fix packet inline on Tx queue wraparound > > > > > > > > > > > > Shahed Shaikh (5): > > > > > > net/bnx2x: fix segfaults due to stale interrupt > > > > > > status > > > > > > net/bnx2x: fix memory leak > > > > > > net/bnx2x: fix ramrod timeout > > > > > > net/bnx2x: fix DMAE timeout > > > > > > net/qede: fix Tx packet prepare for tunnel packets > > > > > > > > > > > > Shreyansh Jain (1): > > > > > > bus/dpaa: fix Rx discard register mask > > > > > > > > > > > > Stephen Hemminger (8): > > > > > > net/octeontx: fix vdev name > > > > > > net/bnxt: fix Rx VLAN offload flags > > > > > > net/virtio: remove useless condition > > > > > > ring: fix an error message > > > > > > net/ring: avoid hard-coded length > > > > > > net/ring: use calloc style where appropriate > > > > > > net/ring: check length of ring name > > > > > > net/virtio: fix buffer leak on VLAN insert > > > > > > > > > > > > Thomas Monjalon (2): > > > > > > mk: fix build of shared library with libbsd > > > > > > bus/vdev: fix debug message on probing > > > > > > > > > > > > Tiwei Bie (4): > > > > > > net/virtio: add barrier in interrupt enable > > > > > > vhost: restore mbuf first when freeing zmbuf > > > > > > vhost: fix potential use-after-free for zero copy > > > > > > mbuf > > > > > > vhost: fix potential use-after-free for memory region > > > > > > > > > > > > Vishal Kulkarni (1): > > > > > > net/cxgbe: fix missing checksum flags and packet type > > > > > > > > > > > > Xiao Wang (1): > > > > > > net/fm10k: fix VLAN strip offload flag > > > > > > > > > > > > Yipeng Wang (1): > > > > > > hash: fix doc about thread/process safety > > > > > > > > > > > > Yongseok Koh (4): > > > > > > net/mlx5: fix instruction hotspot on replenishing Rx > > > > > > buffer > > > > > > net/mlx5: check Tx queue size overflow > > > > > > net/mlx5: fix max number of queues for NEON Tx > > > > > > doc: fix typo in mlx5 guide > > > > > > > > > > > > Yunjian Wang (1): > > > > > > net/ixgbe: fix crash on remove > > > > > > > > > > > > > > > > > > > > -- > > > > Kind regards, > > > > Luca Boccassi > > > > > > > -- Kind regards, Luca Boccassi ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test 2019-09-24 17:25 ` Luca Boccassi @ 2019-09-24 20:08 ` Luca Boccassi 2019-09-26 7:34 ` Yu, PingX 0 siblings, 1 reply; 19+ messages in thread From: Luca Boccassi @ 2019-09-24 20:08 UTC (permalink / raw) To: Kevin Traynor, Ferruh Yigit, Mcnamara, John Cc: Yu, PingX, Peng, Yuan, dev, qian.q.xu Yu Ping, Qian, I have pushed to the 17.11 branch with the fixes for 1 and 2, and for building with kernel 5.3 (just a change in the comments, nothing functional). Do you need to re-run the test suite, or are you confident enough with a quick check? This release is already quite late, is it OK if bugs 3/4/5 are postponed to the next release? On Tue, 2019-09-24 at 18:25 +0100, Luca Boccassi wrote: > On Tue, 2019-09-24 at 18:15 +0100, Kevin Traynor wrote: > > On 24/09/2019 17:36, Ferruh Yigit wrote: > > > On 9/24/2019 12:07 PM, Luca Boccassi wrote: > > > > Ping - any updates on these patches? The release of 17.11.7 is > > > > currently on hold waiting for a resolution here. > > > > > > Hi Luca, > > > > > > Test team provided some internal details: > > > > > > 1- Build issue on f30, > > > A patch has been sent to stable mail list to fix it, not sure if > > > it > > > has been > > > merged: > > > https://mails.dpdk.org/archives/stable/2019-September/017122.html > > > > > > > > Thanks Ferruh, I am testing a build with that one. > > > > 2- "make -C test/" fails. > > > "Fix looks to be to add "#include <inttypes.h>" into > > > test_rwlock.c" > > > Not sure if there is a patch for this. > > > > Hi, this include was added in 18.11 as part of: > > > > commit 0d0dfaaff93cb599b2c58fd6fe405fd4f44b5710 > > Author: Joyce Kong < > > joyce.kong@arm.com > > > > > > Date: Tue Sep 10 11:36:58 2019 +0800 > > > > test/rwlock: benchmark on all available cores > > > > [ upstream commit fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] > > > > > > Note, the master commit would not apply and it was a custom > > backport > > for > > 18.11 by Joyce > > ( > > http://inbox.dpdk.org/stable/1568086619-5029-1-git-send-email-joyce.kong@arm.com > > > > ) > > Maybe it can work for 17.11 too? > > Hi, > > It was backported for 17.11 too, but it does not have the include. > I'll > test another commits that has it. > > > > 3- l2fwd-crypto, ERROR: Test Case test_qat_h_AES_XCBC_MAC_auto > > > Result FAILED > > > Work in progress > > > > > > 4- ipsec-secgw, forwarding failed with null crypto QAT > > > Work in progress > > > > > > 5- Unit test "cryptodev_qat_autotest" failed > > > Issue not analyzed yet. > > > > > > > > > > Thanks! > > > > > > > > On Wed, 2019-09-18 at 10:03 +0000, Yu, PingX wrote: > > > > > Luca, > > > > > FYI. Currently there isn't reference for bug1 and bug2 and > > > > > also > > > > > haven't send to mailing list yet. These bugs should be fixed > > > > > before > > > > > release as they will block the basic PF test. > > > > > > > > > > Regards, > > > > > Yu Ping > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: dev [mailto: > > > > > dev-bounces@dpdk.org > > > > > > > > > > > > > > > ] On Behalf Of Luca Boccassi > > > > > Sent: Wednesday, September 18, 2019 5:18 PM > > > > > To: Peng, Yuan < > > > > > yuan.peng@intel.com > > > > > > > > > > > > > > > > ; > > > > > > > > > > dev@dpdk.org > > > > > > > > > > > > > > > > > > > > Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review > > > > > and test > > > > > > > > > > Hi, > > > > > > > > > > Ping - this is blocking the 17.11.7 release. > > > > > > > > > > Thanks! > > > > > > > > > > On Tue, 2019-09-17 at 10:53 +0100, Luca Boccassi wrote: > > > > > > Hello, > > > > > > > > > > > > Do you have a reference for the patches for bug 1 and 2? > > > > > > Have > > > > > > they > > > > > > been sent to the mailing list? > > > > > > > > > > > > On Thu, 2019-09-12 at 08:52 +0000, Peng, Yuan wrote: > > > > > > > Update the latest test status here. > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Yu, PingX > > > > > > > Sent: Thursday, September 12, 2019 2:37 PM > > > > > > > To: Yongseok Koh < > > > > > > > yskoh@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ananyev, Konstantin < > > > > > > > > > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > > > > > > > > asafp@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cc: Xu, Qian Q < > > > > > > > qian.q.xu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Lin, Xueqin < > > > > > > > > > > > > > > xueqin.lin@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > > > > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; O'Hare, Cathal < > > > > > > > > > > > > > > cathal.ohare@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Yigit, Ferruh < > > > > > > > > > > > > > > ferruh.yigit@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ma, LihongX < > > > > > > > > > > > > > > lihongx.ma@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Li, WenjieX A < > > > > > > > > > > > > > > wenjiex.a.li@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Wang, FengqinX < > > > > > > > > > > > > > > fengqinx.wang@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Peng, Yuan < > > > > > > > > > > > > > > yuan.peng@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > > > > > > > > > > > All, > > > > > > > Update the latest test status here. > > > > > > > The critical bug has been fixed and we have re-tested all > > > > > > > Intel > > > > > > > key > > > > > > > features. > > > > > > > > > > > > > > Intel(R) Testing result lists here. > > > > > > > # Basic Intel(R) NIC testing > > > > > > > * PF(i40e): One bug found in 1st round test. 2nd round > > > > > > > test > > > > > > > pass > > > > > > > after fixing the bug. (see Bug1) > > > > > > > * PF(ixgbe): the same as PF(i40e). > > > > > > > * VF: Pass and no issue. > > > > > > > * Build or compile: One bug found in 1st round test. 2nd > > > > > > > round > > > > > > > test > > > > > > > pass after fixing the bug. (see Bug2) > > > > > > > * Intel NIC single core/NIC performance: Pass and no > > > > > > > issue. > > > > > > > > > > > > > > #Basic cryptodev and virtio testing > > > > > > > * vhost/virtio basic loopback, PVP and performance test: > > > > > > > pass. > > > > > > > * cryptodev: 3 bugs are found(see bug statistic in > > > > > > > below). > > > > > > > (See > > > > > > > Bug3,4 and 5) > > > > > > > > > > > > > > Bugs statistic: > > > > > > > Bug1: make -C test/ failed. It blocked about 60 test > > > > > > > cases > > > > > > > for > > > > > > > both > > > > > > > PF(i40e) and PF(ixgbe). Resolved by adding "#include > > > > > > > <inttypes.h>" > > > > > > > into test_rwlock.c. Please decide whether submit a patch > > > > > > > to > > > > > > > DPDK > > > > > > > or > > > > > > > not. > > > > > > > Bug2: compile error on fc30. Patch is provided and > > > > > > > validated > > > > > > > pass. > > > > > > > Need to decide whether merge into DPDK or not. > > > > > > > Bug3: L2fwd: test_qat_h_AES_XCBC_MAC_auto failed. No > > > > > > > progress > > > > > > > yet. > > > > > > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > > > > > > Author: Arek Kusztal < > > > > > > > arkadiuszx.kusztal@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > > > > > > > > > > > Bug4: Ipsec-gw_test forwarding failed with null crypto > > > > > > > QAT. > > > > > > > No > > > > > > > progress yet. > > > > > > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > > > > > > Author: Arek Kusztal < > > > > > > > arkadiuszx.kusztal@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > > > > > > > > > > > Bug5: Crypto: cryptodev_qat_autotest test failed. No > > > > > > > progress > > > > > > > yet. > > > > > > > 39fb9500c42752a537588f7a203433ec4737fa1e is the first > > > > > > > bad > > > > > > > commit > > > > > > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > > > > > > Author: Arek Kusztal < > > > > > > > arkadiuszx.kusztal@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > > > > > > > > > > > Regards, > > > > > > > Yu Ping > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Wang, FengqinX > > > > > > > Sent: Monday, August 26, 2019 3:12 PM > > > > > > > To: Yongseok Koh < > > > > > > > yskoh@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ananyev, Konstantin < > > > > > > > > > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > > > > > > > > asafp@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cc: Xu, Qian Q < > > > > > > > qian.q.xu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Lin, Xueqin < > > > > > > > > > > > > > > xueqin.lin@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > > > > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; O'Hare, Cathal < > > > > > > > > > > > > > > cathal.ohare@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Yigit, Ferruh < > > > > > > > > > > > > > > ferruh.yigit@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Yu, PingX < > > > > > > > > > > > > > > pingx.yu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ma, LihongX < > > > > > > > > > > > > > > lihongx.ma@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Li, WenjieX A < > > > > > > > > > > > > > > wenjiex.a.li@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > > > > > > > > > > > Add asafp in the loop due to Yongseok is longer working > > > > > > > at > > > > > > > Mellanox. > > > > > > > > > > > > > > BRs, Vicky > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Wang, FengqinX > > > > > > > Sent: Monday, August 26, 2019 3:07 PM > > > > > > > To: 'Yongseok Koh' < > > > > > > > yskoh@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ananyev, Konstantin < > > > > > > > > > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cc: Xu, Qian Q < > > > > > > > qian.q.xu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Lin, Xueqin < > > > > > > > > > > > > > > xueqin.lin@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > > > > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; O'Hare, Cathal < > > > > > > > > > > > > > > cathal.ohare@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Yigit, Ferruh < > > > > > > > > > > > > > > ferruh.yigit@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Yu, PingX < > > > > > > > > > > > > > > pingx.yu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ma, LihongX < > > > > > > > > > > > > > > lihongx.ma@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Li, WenjieX A < > > > > > > > > > > > > > > wenjiex.a.li@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > > > > > > > > > > > Hi Yongseok, Konstantin, > > > > > > > > > > > > > > There is one critical compile issue found, and below is > > > > > > > the > > > > > > > bad > > > > > > > commit related information, this issue has blocked most > > > > > > > of > > > > > > > unit > > > > > > > tests which have used dpdk/test/test, would you please > > > > > > > help > > > > > > > to > > > > > > > fix > > > > > > > this issue ASAP? > > > > > > > > > > > > > > commit 29e08d740ffc1e0ed9e7a9bd25fb95714fac1070 > > > > > > > Author: Joyce Kong < > > > > > > > joyce.kong@arm.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Thu Jul 25 14:50:21 2019 +0800 > > > > > > > > > > > > > > test/rwlock: benchmark on all available cores > > > > > > > > > > > > > > [ backported from upstream commit > > > > > > > fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] > > > > > > > > > > > > > > Add performance test on all available cores to > > > > > > > benchmark > > > > > > > the scaling up performance of rw_lock. > > > > > > > > > > > > > > Fixes: af75078fece3 ("first public release") > > > > > > > > > > > > > > Suggested-by: Gavin Hu < > > > > > > > gavin.hu@arm.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Joyce Kong < > > > > > > > joyce.kong@arm.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Acked-by: Konstantin Ananyev < > > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > And below is the error message output: > > > > > > > > > > > > > > test_rwlock.c: In function 'load_loop_fn': > > > > > > > test_rwlock.c:126:38: error: expected ')' before 'PRIu64' > > > > > > > printf("Core [%u] rwlock_data = %"PRIu64"\n", ^~~~~~ > > > > > > > ) > > > > > > > test_rwlock.c:126:19: error: format '%u' expects a > > > > > > > matching > > > > > > > 'unsigned int' argument [-Werror=format=] printf("Core > > > > > > > [%u] > > > > > > > rwlock_data = %"PRIu64"\n", ~^ > > > > > > > test_rwlock.c:126:36: error: spurious trailing '%' in > > > > > > > format [- > > > > > > > Werror=format=] printf("Core [%u] rwlock_data = > > > > > > > %"PRIu64"\n", ^ > > > > > > > test_rwlock.c: In function 'test_rwlock_perf': > > > > > > > test_rwlock.c:160:31: error: expected ')' before 'PRIu64' > > > > > > > printf("Core [%u] count = %"PRIu64"\n", i, > > > > > > > lock_count[i]); > > > > > > > ^~~~~~ > > > > > > > ) > > > > > > > test_rwlock.c:160:18: error: format '%u' expects a > > > > > > > matching > > > > > > > 'unsigned int' argument [-Werror=format=] printf("Core > > > > > > > [%u] > > > > > > > count > > > > > > > = > > > > > > > %"PRIu64"\n", i, lock_count[i]); ~^ > > > > > > > test_rwlock.c:160:29: error: spurious trailing '%' in > > > > > > > format [- > > > > > > > Werror=format=] printf("Core [%u] count = %"PRIu64"\n", > > > > > > > i, > > > > > > > lock_count[i]); ^ > > > > > > > test_rwlock.c:164:26: error: expected ')' before 'PRIu64' > > > > > > > printf("Total count = %"PRIu64"\n", total); ^~~~~~ > > > > > > > ) > > > > > > > test_rwlock.c:164:24: error: spurious trailing '%' in > > > > > > > format [- > > > > > > > Werror=format=] printf("Total count = %"PRIu64"\n", > > > > > > > total); > > > > > > > ^ > > > > > > > cc1: all warnings being treated as errors > > > > > > > > > > > > > > BRs, Vicky > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Yongseok Koh [mailto: > > > > > > > yskoh@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ] > > > > > > > Sent: Friday, August 16, 2019 2:05 AM > > > > > > > To: dpdk stable < > > > > > > > stable@dpdk.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cc: > > > > > > > dev@dpdk.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > pezhang@redhat.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > siliu@redhat.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Wang, FengqinX < > > > > > > > fengqinx.wang@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > > > > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Xu, Qian Q < > > > > > > > > > > > > > > qian.q.xu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > > > > > > > > alialnu@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > rasland@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Subject: 17.11.7-rc1 (LTS) patches review and test > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > Here is a list of patches targeted for LTS release > > > > > > > 17.11.7. > > > > > > > Please > > > > > > > help review and test. The planned date for the final > > > > > > > release is > > > > > > > Aug > > > > > > > 23, Before that, please shout if anyone has objections > > > > > > > with > > > > > > > these > > > > > > > patches being applied. > > > > > > > > > > > > > > Also for the companies committed to running regression > > > > > > > tests, > > > > > > > please > > > > > > > run the tests and report any issue before the release > > > > > > > date. > > > > > > > > > > > > > > A release candidate tarball can be found at: > > > > > > > > > > > > > > > > > > > > > https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > These patches are located at branch 17.11 of dpdk-stable > > > > > > > repo: > > > > > > > > > > > > > > https://dpdk.org/browse/dpdk-stable/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > Yongseok > > > > > > > > > > > > > > --- > > > > > > > > > > > > > > Aaron Conole (1): > > > > > > > net/virtio: fix dangling pointer on failure > > > > > > > > > > > > > > Agalya Babu RadhaKrishnan (1): > > > > > > > doc: fix interactive commands in testpmd guide > > > > > > > > > > > > > > Akhil Goyal (1): > > > > > > > crypto/dpaa2_sec: fix session clearing > > > > > > > > > > > > > > Alejandro Lucero (1): > > > > > > > net/nfp: fix RSS query > > > > > > > > > > > > > > Anatoly Burakov (2): > > > > > > > eal: improve musl compatibility of string functions > > > > > > > malloc: fix documentation of realloc function > > > > > > > > > > > > > > Andrew Rybchenko (2): > > > > > > > net/sfc: remove control path logging from Rx queue > > > > > > > count > > > > > > > app/testpmd: set fixed flag for exact link speed > > > > > > > > > > > > > > Andrius Sirvys (3): > > > > > > > net/virtio: fix duplicate naming of include guard > > > > > > > bitrate: fix unchecked return value > > > > > > > drivers/net: fix shifting 32-bit signed variable 31 > > > > > > > times > > > > > > > > > > > > > > Anoob Joseph (1): > > > > > > > cryptodev: fix driver name comparison > > > > > > > > > > > > > > Beilei Xing (1): > > > > > > > net/i40e: fix link speed for X722 > > > > > > > > > > > > > > Bernard Iremonger (1): > > > > > > > examples/ipsec-secgw: fix debug logs > > > > > > > > > > > > > > Bill Hong (1): > > > > > > > net: fix Tx VLAN flag for offload emulation > > > > > > > > > > > > > > Bruce Richardson (9): > > > > > > > eal: support strlcat function > > > > > > > net/bonding: fix buffer length when printing > > > > > > > strings > > > > > > > examples/l2fwd-cat: fix build on FreeBSD > > > > > > > app/crypto-perf: check range of socket id > > > > > > > examples/vhost_scsi: fix null-check for parameter > > > > > > > net/i40e: fix dereference before null check in mbuf > > > > > > > release > > > > > > > net/ixgbe: fix warning with GCC 9 > > > > > > > bus/fslmc: fix warning with GCC 9 > > > > > > > eal: tighten permissions on shared memory files > > > > > > > > > > > > > > Chaitanya Babu Talluri (2): > > > > > > > drivers/net: fix possible overflow using strlcat > > > > > > > cfgfile: replace strcat with strlcat > > > > > > > > > > > > > > David Christensen (2): > > > > > > > maintainers: update for IBM POWER > > > > > > > examples/vm_power_manager: fix PMD specific code > > > > > > > > > > > > > > David Marchand (7): > > > > > > > eal: fix check when retrieving current CPU affinity > > > > > > > eal: remove dead code in core list parsing > > > > > > > app/testpmd: remove unused field from port struct > > > > > > > doc: fix examples in bonding guide > > > > > > > net/bonding: fix port id types > > > > > > > net/bonding: fix queue index types > > > > > > > app/testpmd: remove useless casts on statistics > > > > > > > > > > > > > > Davide Caratti (1): > > > > > > > net/bnxt: support IOVA VA mode > > > > > > > > > > > > > > Dekel Peled (8): > > > > > > > net/mlx5: fix hex dump of error completion > > > > > > > net/mlx5: fix sync when handling Tx completions > > > > > > > eal/ppc: fix global memory barrier > > > > > > > eal: fix typo in comment of vector function > > > > > > > doc: fix links to doxygen and sphinx sites > > > > > > > app/testpmd: fix typo in comment > > > > > > > net/mlx5: fix comments mixing Rx and Tx > > > > > > > net/mlx5: fix release of Rx queue object > > > > > > > > > > > > > > Fan Zhang (1): > > > > > > > examples/ipsec-secgw: fix AES-CTR block size > > > > > > > > > > > > > > Ferruh Yigit (5): > > > > > > > kni: fix build with Linux 5.1 > > > > > > > build: fix crash by disabling AVX512 with binutils > > > > > > > 2.31 > > > > > > > net/ring: fix return value check > > > > > > > net/kni: fix return value check > > > > > > > app/testpmd: revert fixed flag for exact link speed > > > > > > > > > > > > > > Gage Eads (1): > > > > > > > ring: fix namesize macro documentation block > > > > > > > > > > > > > > Gavin Hu (3): > > > > > > > test/spinlock: remove delay for correct > > > > > > > benchmarking > > > > > > > test/spinlock: amortize the cost of getting time > > > > > > > spinlock: reimplement with atomic one-way barrier > > > > > > > > > > > > > > Hari Kumar Vemula (1): > > > > > > > net/bonding: fix reset active slave > > > > > > > > > > > > > > Harry van Haaren (1): > > > > > > > event/sw: fix enqueue checks in self-test > > > > > > > > > > > > > > Herakliusz Lipiec (1): > > > > > > > doc: fix broken link in LPM guide > > > > > > > > > > > > > > Hyong Youb Kim (4): > > > > > > > net/bonding: avoid warning for invalid port > > > > > > > net/enic: fix flow director SCTP matching > > > > > > > net/enic: fix SCTP match for flow API > > > > > > > net/enic: check for unsupported flow item types > > > > > > > > > > > > > > Igor Romanov (1): > > > > > > > app/testpmd: fix stdout flush after printing stats > > > > > > > > > > > > > > Ilya Maximets (2): > > > > > > > vhost: fix device leak on connection add failure > > > > > > > vhost: fix silent queue enabling with legacy guests > > > > > > > > > > > > > > Ivan Malov (1): > > > > > > > net/sfc: log port ID as 16-bit unsigned integer on > > > > > > > panic > > > > > > > > > > > > > > Jerin Jacob (1): > > > > > > > mk: fix AVX512 disabled warning on non x86 > > > > > > > > > > > > > > Jianfeng Tan (1): > > > > > > > drivers/net: do not use private ethdev data > > > > > > > > > > > > > > Joyce Kong (1): > > > > > > > test/rwlock: benchmark on all available cores > > > > > > > > > > > > > > Kevin Traynor (3): > > > > > > > net/qede: support IOVA VA mode > > > > > > > eal/linux: fix log levels for pagemap reading > > > > > > > failure > > > > > > > power: fix frequency list buffer validation > > > > > > > > > > > > > > Liang Zhang (1): > > > > > > > net/bonding: fix LACP negotiation > > > > > > > > > > > > > > Luo Gaoliang (1): > > > > > > > kni: fix build on RHEL8 > > > > > > > > > > > > > > Marcin Smoczynski (1): > > > > > > > examples/ipsec-secgw: fix build error log > > > > > > > > > > > > > > Natanael Copa (3): > > > > > > > bus/fslmc: remove unused include of error.h > > > > > > > bus/fslmc: fix build with musl libc > > > > > > > app/test: fix build with musl libc > > > > > > > > > > > > > > Pallantla Poornima (3): > > > > > > > app/test: fix sprintf with strlcat > > > > > > > test/distributor: replace sprintf with strlcpy > > > > > > > test/hash: replace sprintf with snprintf > > > > > > > > > > > > > > Qi Zhang (1): > > > > > > > net/i40e: fix time sync for 25G > > > > > > > > > > > > > > Radu Nicolau (3): > > > > > > > net/null: add MAC address setting fake operation > > > > > > > test/virtual_pmd: add MAC address setting fake op > > > > > > > test/bonding: assign non-zero MAC to null devices > > > > > > > > > > > > > > Rahul Lakkireddy (1): > > > > > > > net/cxgbe: update Chelsio T5/T6 NIC device ids > > > > > > > > > > > > > > Rami Rosen (8): > > > > > > > net/virtio: remove forward declaration > > > > > > > mbuf: fix a typo > > > > > > > doc: fix a minor typo in testpmd guide > > > > > > > doc: remove reference to rte.doc.mk in programmers > > > > > > > guide > > > > > > > examples/ethtool: fix two typos > > > > > > > doc: fix link in Linux getting started guide > > > > > > > app/testpmd: fix a typo in log message > > > > > > > ethdev: fix a typo > > > > > > > > > > > > > > Rasesh Mody (2): > > > > > > > net/bnx2x: fix race for periodic flags > > > > > > > net/bnx2x: fix optic module verification > > > > > > > > > > > > > > Shahaf Shuler (1): > > > > > > > net/mlx5: fix packet inline on Tx queue wraparound > > > > > > > > > > > > > > Shahed Shaikh (5): > > > > > > > net/bnx2x: fix segfaults due to stale interrupt > > > > > > > status > > > > > > > net/bnx2x: fix memory leak > > > > > > > net/bnx2x: fix ramrod timeout > > > > > > > net/bnx2x: fix DMAE timeout > > > > > > > net/qede: fix Tx packet prepare for tunnel packets > > > > > > > > > > > > > > Shreyansh Jain (1): > > > > > > > bus/dpaa: fix Rx discard register mask > > > > > > > > > > > > > > Stephen Hemminger (8): > > > > > > > net/octeontx: fix vdev name > > > > > > > net/bnxt: fix Rx VLAN offload flags > > > > > > > net/virtio: remove useless condition > > > > > > > ring: fix an error message > > > > > > > net/ring: avoid hard-coded length > > > > > > > net/ring: use calloc style where appropriate > > > > > > > net/ring: check length of ring name > > > > > > > net/virtio: fix buffer leak on VLAN insert > > > > > > > > > > > > > > Thomas Monjalon (2): > > > > > > > mk: fix build of shared library with libbsd > > > > > > > bus/vdev: fix debug message on probing > > > > > > > > > > > > > > Tiwei Bie (4): > > > > > > > net/virtio: add barrier in interrupt enable > > > > > > > vhost: restore mbuf first when freeing zmbuf > > > > > > > vhost: fix potential use-after-free for zero copy > > > > > > > mbuf > > > > > > > vhost: fix potential use-after-free for memory > > > > > > > region > > > > > > > > > > > > > > Vishal Kulkarni (1): > > > > > > > net/cxgbe: fix missing checksum flags and packet > > > > > > > type > > > > > > > > > > > > > > Xiao Wang (1): > > > > > > > net/fm10k: fix VLAN strip offload flag > > > > > > > > > > > > > > Yipeng Wang (1): > > > > > > > hash: fix doc about thread/process safety > > > > > > > > > > > > > > Yongseok Koh (4): > > > > > > > net/mlx5: fix instruction hotspot on replenishing > > > > > > > Rx > > > > > > > buffer > > > > > > > net/mlx5: check Tx queue size overflow > > > > > > > net/mlx5: fix max number of queues for NEON Tx > > > > > > > doc: fix typo in mlx5 guide > > > > > > > > > > > > > > Yunjian Wang (1): > > > > > > > net/ixgbe: fix crash on remove > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Kind regards, > > > > > Luca Boccassi > > > > > > > > > > > -- Kind regards, Luca Boccassi ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test 2019-09-24 20:08 ` Luca Boccassi @ 2019-09-26 7:34 ` Yu, PingX 2019-09-26 7:38 ` Ferruh Yigit 0 siblings, 1 reply; 19+ messages in thread From: Yu, PingX @ 2019-09-26 7:34 UTC (permalink / raw) To: Luca Boccassi, Kevin Traynor, Yigit, Ferruh, Mcnamara, John, Kusztal, ArkadiuszX Cc: Peng, Yuan, dev, Xu, Qian Q Luca, 1. Latest 17.11 branch is verified passed for feature PF. No issue now. 2. bugs 3/4/5 are fixed now by arkadiuszx.kusztal@intel.com 's patch. No issue now. Regards, Yu Ping -----Original Message----- From: Luca Boccassi [mailto:bluca@debian.org] Sent: Wednesday, September 25, 2019 4:08 AM To: Kevin Traynor <ktraynor@redhat.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Mcnamara, John <john.mcnamara@intel.com> Cc: Yu, PingX <pingx.yu@intel.com>; Peng, Yuan <yuan.peng@intel.com>; dev@dpdk.org; Xu, Qian Q <qian.q.xu@intel.com> Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test Yu Ping, Qian, I have pushed to the 17.11 branch with the fixes for 1 and 2, and for building with kernel 5.3 (just a change in the comments, nothing functional). Do you need to re-run the test suite, or are you confident enough with a quick check? This release is already quite late, is it OK if bugs 3/4/5 are postponed to the next release? On Tue, 2019-09-24 at 18:25 +0100, Luca Boccassi wrote: > On Tue, 2019-09-24 at 18:15 +0100, Kevin Traynor wrote: > > On 24/09/2019 17:36, Ferruh Yigit wrote: > > > On 9/24/2019 12:07 PM, Luca Boccassi wrote: > > > > Ping - any updates on these patches? The release of 17.11.7 is > > > > currently on hold waiting for a resolution here. > > > > > > Hi Luca, > > > > > > Test team provided some internal details: > > > > > > 1- Build issue on f30, > > > A patch has been sent to stable mail list to fix it, not sure if > > > it has been > > > merged: > > > https://mails.dpdk.org/archives/stable/2019-September/017122.html > > > > > > > > Thanks Ferruh, I am testing a build with that one. > > > > 2- "make -C test/" fails. > > > "Fix looks to be to add "#include <inttypes.h>" into > > > test_rwlock.c" > > > Not sure if there is a patch for this. > > > > Hi, this include was added in 18.11 as part of: > > > > commit 0d0dfaaff93cb599b2c58fd6fe405fd4f44b5710 > > Author: Joyce Kong < > > joyce.kong@arm.com > > > > > > Date: Tue Sep 10 11:36:58 2019 +0800 > > > > test/rwlock: benchmark on all available cores > > > > [ upstream commit fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] > > > > > > Note, the master commit would not apply and it was a custom backport > > for > > 18.11 by Joyce > > ( > > http://inbox.dpdk.org/stable/1568086619-5029-1-git-send-email-joyce. > > kong@arm.com > > > > ) > > Maybe it can work for 17.11 too? > > Hi, > > It was backported for 17.11 too, but it does not have the include. > I'll > test another commits that has it. > > > > 3- l2fwd-crypto, ERROR: Test Case test_qat_h_AES_XCBC_MAC_auto > > > Result FAILED Work in progress > > > > > > 4- ipsec-secgw, forwarding failed with null crypto QAT Work in > > > progress > > > > > > 5- Unit test "cryptodev_qat_autotest" failed Issue not analyzed > > > yet. > > > > > > > > > > Thanks! > > > > > > > > On Wed, 2019-09-18 at 10:03 +0000, Yu, PingX wrote: > > > > > Luca, > > > > > FYI. Currently there isn't reference for bug1 and bug2 and > > > > > also haven't send to mailing list yet. These bugs should be > > > > > fixed before release as they will block the basic PF test. > > > > > > > > > > Regards, > > > > > Yu Ping > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: dev [mailto: > > > > > dev-bounces@dpdk.org > > > > > > > > > > > > > > > ] On Behalf Of Luca Boccassi > > > > > Sent: Wednesday, September 18, 2019 5:18 PM > > > > > To: Peng, Yuan < > > > > > yuan.peng@intel.com > > > > > > > > > > > > > > > > ; > > > > > > > > > > dev@dpdk.org > > > > > > > > > > > > > > > > > > > > Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review > > > > > and test > > > > > > > > > > Hi, > > > > > > > > > > Ping - this is blocking the 17.11.7 release. > > > > > > > > > > Thanks! > > > > > > > > > > On Tue, 2019-09-17 at 10:53 +0100, Luca Boccassi wrote: > > > > > > Hello, > > > > > > > > > > > > Do you have a reference for the patches for bug 1 and 2? > > > > > > Have > > > > > > they > > > > > > been sent to the mailing list? > > > > > > > > > > > > On Thu, 2019-09-12 at 08:52 +0000, Peng, Yuan wrote: > > > > > > > Update the latest test status here. > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Yu, PingX > > > > > > > Sent: Thursday, September 12, 2019 2:37 PM > > > > > > > To: Yongseok Koh < > > > > > > > yskoh@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ananyev, Konstantin < > > > > > > > > > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > > > > > > > > asafp@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cc: Xu, Qian Q < > > > > > > > qian.q.xu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Lin, Xueqin < > > > > > > > > > > > > > > xueqin.lin@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > > > > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; O'Hare, Cathal < > > > > > > > > > > > > > > cathal.ohare@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Yigit, Ferruh < > > > > > > > > > > > > > > ferruh.yigit@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ma, LihongX < > > > > > > > > > > > > > > lihongx.ma@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Li, WenjieX A < > > > > > > > > > > > > > > wenjiex.a.li@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Wang, FengqinX < > > > > > > > > > > > > > > fengqinx.wang@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Peng, Yuan < > > > > > > > > > > > > > > yuan.peng@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > > > > > > > > > > > All, > > > > > > > Update the latest test status here. > > > > > > > The critical bug has been fixed and we have re-tested all > > > > > > > Intel > > > > > > > key > > > > > > > features. > > > > > > > > > > > > > > Intel(R) Testing result lists here. > > > > > > > # Basic Intel(R) NIC testing > > > > > > > * PF(i40e): One bug found in 1st round test. 2nd round > > > > > > > test > > > > > > > pass > > > > > > > after fixing the bug. (see Bug1) > > > > > > > * PF(ixgbe): the same as PF(i40e). > > > > > > > * VF: Pass and no issue. > > > > > > > * Build or compile: One bug found in 1st round test. 2nd > > > > > > > round > > > > > > > test > > > > > > > pass after fixing the bug. (see Bug2) > > > > > > > * Intel NIC single core/NIC performance: Pass and no > > > > > > > issue. > > > > > > > > > > > > > > #Basic cryptodev and virtio testing > > > > > > > * vhost/virtio basic loopback, PVP and performance test: > > > > > > > pass. > > > > > > > * cryptodev: 3 bugs are found(see bug statistic in > > > > > > > below). > > > > > > > (See > > > > > > > Bug3,4 and 5) > > > > > > > > > > > > > > Bugs statistic: > > > > > > > Bug1: make -C test/ failed. It blocked about 60 test > > > > > > > cases > > > > > > > for > > > > > > > both > > > > > > > PF(i40e) and PF(ixgbe). Resolved by adding "#include > > > > > > > <inttypes.h>" > > > > > > > into test_rwlock.c. Please decide whether submit a patch > > > > > > > to > > > > > > > DPDK > > > > > > > or > > > > > > > not. > > > > > > > Bug2: compile error on fc30. Patch is provided and > > > > > > > validated > > > > > > > pass. > > > > > > > Need to decide whether merge into DPDK or not. > > > > > > > Bug3: L2fwd: test_qat_h_AES_XCBC_MAC_auto failed. No > > > > > > > progress > > > > > > > yet. > > > > > > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > > > > > > Author: Arek Kusztal < > > > > > > > arkadiuszx.kusztal@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > > > > > > > > > > > Bug4: Ipsec-gw_test forwarding failed with null crypto > > > > > > > QAT. > > > > > > > No > > > > > > > progress yet. > > > > > > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > > > > > > Author: Arek Kusztal < > > > > > > > arkadiuszx.kusztal@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > > > > > > > > > > > Bug5: Crypto: cryptodev_qat_autotest test failed. No > > > > > > > progress > > > > > > > yet. > > > > > > > 39fb9500c42752a537588f7a203433ec4737fa1e is the first > > > > > > > bad > > > > > > > commit > > > > > > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > > > > > > Author: Arek Kusztal < > > > > > > > arkadiuszx.kusztal@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > > > > > > > > > > > Regards, > > > > > > > Yu Ping > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Wang, FengqinX > > > > > > > Sent: Monday, August 26, 2019 3:12 PM > > > > > > > To: Yongseok Koh < > > > > > > > yskoh@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ananyev, Konstantin < > > > > > > > > > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > > > > > > > > asafp@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cc: Xu, Qian Q < > > > > > > > qian.q.xu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Lin, Xueqin < > > > > > > > > > > > > > > xueqin.lin@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > > > > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; O'Hare, Cathal < > > > > > > > > > > > > > > cathal.ohare@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Yigit, Ferruh < > > > > > > > > > > > > > > ferruh.yigit@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Yu, PingX < > > > > > > > > > > > > > > pingx.yu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ma, LihongX < > > > > > > > > > > > > > > lihongx.ma@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Li, WenjieX A < > > > > > > > > > > > > > > wenjiex.a.li@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > > > > > > > > > > > Add asafp in the loop due to Yongseok is longer working > > > > > > > at > > > > > > > Mellanox. > > > > > > > > > > > > > > BRs, Vicky > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Wang, FengqinX > > > > > > > Sent: Monday, August 26, 2019 3:07 PM > > > > > > > To: 'Yongseok Koh' < > > > > > > > yskoh@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ananyev, Konstantin < > > > > > > > > > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cc: Xu, Qian Q < > > > > > > > qian.q.xu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Lin, Xueqin < > > > > > > > > > > > > > > xueqin.lin@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > > > > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; O'Hare, Cathal < > > > > > > > > > > > > > > cathal.ohare@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Yigit, Ferruh < > > > > > > > > > > > > > > ferruh.yigit@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Yu, PingX < > > > > > > > > > > > > > > pingx.yu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ma, LihongX < > > > > > > > > > > > > > > lihongx.ma@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Li, WenjieX A < > > > > > > > > > > > > > > wenjiex.a.li@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and test > > > > > > > > > > > > > > Hi Yongseok, Konstantin, > > > > > > > > > > > > > > There is one critical compile issue found, and below is > > > > > > > the > > > > > > > bad > > > > > > > commit related information, this issue has blocked most > > > > > > > of > > > > > > > unit > > > > > > > tests which have used dpdk/test/test, would you please > > > > > > > help > > > > > > > to > > > > > > > fix > > > > > > > this issue ASAP? > > > > > > > > > > > > > > commit 29e08d740ffc1e0ed9e7a9bd25fb95714fac1070 > > > > > > > Author: Joyce Kong < > > > > > > > joyce.kong@arm.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Thu Jul 25 14:50:21 2019 +0800 > > > > > > > > > > > > > > test/rwlock: benchmark on all available cores > > > > > > > > > > > > > > [ backported from upstream commit > > > > > > > fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] > > > > > > > > > > > > > > Add performance test on all available cores to > > > > > > > benchmark > > > > > > > the scaling up performance of rw_lock. > > > > > > > > > > > > > > Fixes: af75078fece3 ("first public release") > > > > > > > > > > > > > > Suggested-by: Gavin Hu < > > > > > > > gavin.hu@arm.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Joyce Kong < > > > > > > > joyce.kong@arm.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Acked-by: Konstantin Ananyev < > > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > And below is the error message output: > > > > > > > > > > > > > > test_rwlock.c: In function 'load_loop_fn': > > > > > > > test_rwlock.c:126:38: error: expected ')' before 'PRIu64' > > > > > > > printf("Core [%u] rwlock_data = %"PRIu64"\n", ^~~~~~ > > > > > > > ) > > > > > > > test_rwlock.c:126:19: error: format '%u' expects a > > > > > > > matching > > > > > > > 'unsigned int' argument [-Werror=format=] printf("Core > > > > > > > [%u] > > > > > > > rwlock_data = %"PRIu64"\n", ~^ > > > > > > > test_rwlock.c:126:36: error: spurious trailing '%' in > > > > > > > format [- > > > > > > > Werror=format=] printf("Core [%u] rwlock_data = > > > > > > > %"PRIu64"\n", ^ > > > > > > > test_rwlock.c: In function 'test_rwlock_perf': > > > > > > > test_rwlock.c:160:31: error: expected ')' before 'PRIu64' > > > > > > > printf("Core [%u] count = %"PRIu64"\n", i, > > > > > > > lock_count[i]); > > > > > > > ^~~~~~ > > > > > > > ) > > > > > > > test_rwlock.c:160:18: error: format '%u' expects a > > > > > > > matching > > > > > > > 'unsigned int' argument [-Werror=format=] printf("Core > > > > > > > [%u] > > > > > > > count > > > > > > > = > > > > > > > %"PRIu64"\n", i, lock_count[i]); ~^ > > > > > > > test_rwlock.c:160:29: error: spurious trailing '%' in > > > > > > > format [- > > > > > > > Werror=format=] printf("Core [%u] count = %"PRIu64"\n", > > > > > > > i, > > > > > > > lock_count[i]); ^ > > > > > > > test_rwlock.c:164:26: error: expected ')' before 'PRIu64' > > > > > > > printf("Total count = %"PRIu64"\n", total); ^~~~~~ > > > > > > > ) > > > > > > > test_rwlock.c:164:24: error: spurious trailing '%' in > > > > > > > format [- > > > > > > > Werror=format=] printf("Total count = %"PRIu64"\n", > > > > > > > total); > > > > > > > ^ > > > > > > > cc1: all warnings being treated as errors > > > > > > > > > > > > > > BRs, Vicky > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Yongseok Koh [mailto: > > > > > > > yskoh@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ] > > > > > > > Sent: Friday, August 16, 2019 2:05 AM > > > > > > > To: dpdk stable < > > > > > > > stable@dpdk.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cc: > > > > > > > dev@dpdk.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > pezhang@redhat.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > siliu@redhat.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Wang, FengqinX < > > > > > > > fengqinx.wang@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > > > > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Xu, Qian Q < > > > > > > > > > > > > > > qian.q.xu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > > > > > > > > alialnu@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > rasland@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Subject: 17.11.7-rc1 (LTS) patches review and test > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > Here is a list of patches targeted for LTS release > > > > > > > 17.11.7. > > > > > > > Please > > > > > > > help review and test. The planned date for the final > > > > > > > release is > > > > > > > Aug > > > > > > > 23, Before that, please shout if anyone has objections > > > > > > > with > > > > > > > these > > > > > > > patches being applied. > > > > > > > > > > > > > > Also for the companies committed to running regression > > > > > > > tests, > > > > > > > please > > > > > > > run the tests and report any issue before the release > > > > > > > date. > > > > > > > > > > > > > > A release candidate tarball can be found at: > > > > > > > > > > > > > > > > > > > > > https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > These patches are located at branch 17.11 of dpdk-stable > > > > > > > repo: > > > > > > > > > > > > > > https://dpdk.org/browse/dpdk-stable/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > Yongseok > > > > > > > > > > > > > > --- > > > > > > > > > > > > > > Aaron Conole (1): > > > > > > > net/virtio: fix dangling pointer on failure > > > > > > > > > > > > > > Agalya Babu RadhaKrishnan (1): > > > > > > > doc: fix interactive commands in testpmd guide > > > > > > > > > > > > > > Akhil Goyal (1): > > > > > > > crypto/dpaa2_sec: fix session clearing > > > > > > > > > > > > > > Alejandro Lucero (1): > > > > > > > net/nfp: fix RSS query > > > > > > > > > > > > > > Anatoly Burakov (2): > > > > > > > eal: improve musl compatibility of string functions > > > > > > > malloc: fix documentation of realloc function > > > > > > > > > > > > > > Andrew Rybchenko (2): > > > > > > > net/sfc: remove control path logging from Rx queue > > > > > > > count > > > > > > > app/testpmd: set fixed flag for exact link speed > > > > > > > > > > > > > > Andrius Sirvys (3): > > > > > > > net/virtio: fix duplicate naming of include guard > > > > > > > bitrate: fix unchecked return value > > > > > > > drivers/net: fix shifting 32-bit signed variable 31 > > > > > > > times > > > > > > > > > > > > > > Anoob Joseph (1): > > > > > > > cryptodev: fix driver name comparison > > > > > > > > > > > > > > Beilei Xing (1): > > > > > > > net/i40e: fix link speed for X722 > > > > > > > > > > > > > > Bernard Iremonger (1): > > > > > > > examples/ipsec-secgw: fix debug logs > > > > > > > > > > > > > > Bill Hong (1): > > > > > > > net: fix Tx VLAN flag for offload emulation > > > > > > > > > > > > > > Bruce Richardson (9): > > > > > > > eal: support strlcat function > > > > > > > net/bonding: fix buffer length when printing > > > > > > > strings > > > > > > > examples/l2fwd-cat: fix build on FreeBSD > > > > > > > app/crypto-perf: check range of socket id > > > > > > > examples/vhost_scsi: fix null-check for parameter > > > > > > > net/i40e: fix dereference before null check in mbuf > > > > > > > release > > > > > > > net/ixgbe: fix warning with GCC 9 > > > > > > > bus/fslmc: fix warning with GCC 9 > > > > > > > eal: tighten permissions on shared memory files > > > > > > > > > > > > > > Chaitanya Babu Talluri (2): > > > > > > > drivers/net: fix possible overflow using strlcat > > > > > > > cfgfile: replace strcat with strlcat > > > > > > > > > > > > > > David Christensen (2): > > > > > > > maintainers: update for IBM POWER > > > > > > > examples/vm_power_manager: fix PMD specific code > > > > > > > > > > > > > > David Marchand (7): > > > > > > > eal: fix check when retrieving current CPU affinity > > > > > > > eal: remove dead code in core list parsing > > > > > > > app/testpmd: remove unused field from port struct > > > > > > > doc: fix examples in bonding guide > > > > > > > net/bonding: fix port id types > > > > > > > net/bonding: fix queue index types > > > > > > > app/testpmd: remove useless casts on statistics > > > > > > > > > > > > > > Davide Caratti (1): > > > > > > > net/bnxt: support IOVA VA mode > > > > > > > > > > > > > > Dekel Peled (8): > > > > > > > net/mlx5: fix hex dump of error completion > > > > > > > net/mlx5: fix sync when handling Tx completions > > > > > > > eal/ppc: fix global memory barrier > > > > > > > eal: fix typo in comment of vector function > > > > > > > doc: fix links to doxygen and sphinx sites > > > > > > > app/testpmd: fix typo in comment > > > > > > > net/mlx5: fix comments mixing Rx and Tx > > > > > > > net/mlx5: fix release of Rx queue object > > > > > > > > > > > > > > Fan Zhang (1): > > > > > > > examples/ipsec-secgw: fix AES-CTR block size > > > > > > > > > > > > > > Ferruh Yigit (5): > > > > > > > kni: fix build with Linux 5.1 > > > > > > > build: fix crash by disabling AVX512 with binutils > > > > > > > 2.31 > > > > > > > net/ring: fix return value check > > > > > > > net/kni: fix return value check > > > > > > > app/testpmd: revert fixed flag for exact link speed > > > > > > > > > > > > > > Gage Eads (1): > > > > > > > ring: fix namesize macro documentation block > > > > > > > > > > > > > > Gavin Hu (3): > > > > > > > test/spinlock: remove delay for correct > > > > > > > benchmarking > > > > > > > test/spinlock: amortize the cost of getting time > > > > > > > spinlock: reimplement with atomic one-way barrier > > > > > > > > > > > > > > Hari Kumar Vemula (1): > > > > > > > net/bonding: fix reset active slave > > > > > > > > > > > > > > Harry van Haaren (1): > > > > > > > event/sw: fix enqueue checks in self-test > > > > > > > > > > > > > > Herakliusz Lipiec (1): > > > > > > > doc: fix broken link in LPM guide > > > > > > > > > > > > > > Hyong Youb Kim (4): > > > > > > > net/bonding: avoid warning for invalid port > > > > > > > net/enic: fix flow director SCTP matching > > > > > > > net/enic: fix SCTP match for flow API > > > > > > > net/enic: check for unsupported flow item types > > > > > > > > > > > > > > Igor Romanov (1): > > > > > > > app/testpmd: fix stdout flush after printing stats > > > > > > > > > > > > > > Ilya Maximets (2): > > > > > > > vhost: fix device leak on connection add failure > > > > > > > vhost: fix silent queue enabling with legacy guests > > > > > > > > > > > > > > Ivan Malov (1): > > > > > > > net/sfc: log port ID as 16-bit unsigned integer on > > > > > > > panic > > > > > > > > > > > > > > Jerin Jacob (1): > > > > > > > mk: fix AVX512 disabled warning on non x86 > > > > > > > > > > > > > > Jianfeng Tan (1): > > > > > > > drivers/net: do not use private ethdev data > > > > > > > > > > > > > > Joyce Kong (1): > > > > > > > test/rwlock: benchmark on all available cores > > > > > > > > > > > > > > Kevin Traynor (3): > > > > > > > net/qede: support IOVA VA mode > > > > > > > eal/linux: fix log levels for pagemap reading > > > > > > > failure > > > > > > > power: fix frequency list buffer validation > > > > > > > > > > > > > > Liang Zhang (1): > > > > > > > net/bonding: fix LACP negotiation > > > > > > > > > > > > > > Luo Gaoliang (1): > > > > > > > kni: fix build on RHEL8 > > > > > > > > > > > > > > Marcin Smoczynski (1): > > > > > > > examples/ipsec-secgw: fix build error log > > > > > > > > > > > > > > Natanael Copa (3): > > > > > > > bus/fslmc: remove unused include of error.h > > > > > > > bus/fslmc: fix build with musl libc > > > > > > > app/test: fix build with musl libc > > > > > > > > > > > > > > Pallantla Poornima (3): > > > > > > > app/test: fix sprintf with strlcat > > > > > > > test/distributor: replace sprintf with strlcpy > > > > > > > test/hash: replace sprintf with snprintf > > > > > > > > > > > > > > Qi Zhang (1): > > > > > > > net/i40e: fix time sync for 25G > > > > > > > > > > > > > > Radu Nicolau (3): > > > > > > > net/null: add MAC address setting fake operation > > > > > > > test/virtual_pmd: add MAC address setting fake op > > > > > > > test/bonding: assign non-zero MAC to null devices > > > > > > > > > > > > > > Rahul Lakkireddy (1): > > > > > > > net/cxgbe: update Chelsio T5/T6 NIC device ids > > > > > > > > > > > > > > Rami Rosen (8): > > > > > > > net/virtio: remove forward declaration > > > > > > > mbuf: fix a typo > > > > > > > doc: fix a minor typo in testpmd guide > > > > > > > doc: remove reference to rte.doc.mk in programmers > > > > > > > guide > > > > > > > examples/ethtool: fix two typos > > > > > > > doc: fix link in Linux getting started guide > > > > > > > app/testpmd: fix a typo in log message > > > > > > > ethdev: fix a typo > > > > > > > > > > > > > > Rasesh Mody (2): > > > > > > > net/bnx2x: fix race for periodic flags > > > > > > > net/bnx2x: fix optic module verification > > > > > > > > > > > > > > Shahaf Shuler (1): > > > > > > > net/mlx5: fix packet inline on Tx queue wraparound > > > > > > > > > > > > > > Shahed Shaikh (5): > > > > > > > net/bnx2x: fix segfaults due to stale interrupt > > > > > > > status > > > > > > > net/bnx2x: fix memory leak > > > > > > > net/bnx2x: fix ramrod timeout > > > > > > > net/bnx2x: fix DMAE timeout > > > > > > > net/qede: fix Tx packet prepare for tunnel packets > > > > > > > > > > > > > > Shreyansh Jain (1): > > > > > > > bus/dpaa: fix Rx discard register mask > > > > > > > > > > > > > > Stephen Hemminger (8): > > > > > > > net/octeontx: fix vdev name > > > > > > > net/bnxt: fix Rx VLAN offload flags > > > > > > > net/virtio: remove useless condition > > > > > > > ring: fix an error message > > > > > > > net/ring: avoid hard-coded length > > > > > > > net/ring: use calloc style where appropriate > > > > > > > net/ring: check length of ring name > > > > > > > net/virtio: fix buffer leak on VLAN insert > > > > > > > > > > > > > > Thomas Monjalon (2): > > > > > > > mk: fix build of shared library with libbsd > > > > > > > bus/vdev: fix debug message on probing > > > > > > > > > > > > > > Tiwei Bie (4): > > > > > > > net/virtio: add barrier in interrupt enable > > > > > > > vhost: restore mbuf first when freeing zmbuf > > > > > > > vhost: fix potential use-after-free for zero copy > > > > > > > mbuf > > > > > > > vhost: fix potential use-after-free for memory > > > > > > > region > > > > > > > > > > > > > > Vishal Kulkarni (1): > > > > > > > net/cxgbe: fix missing checksum flags and packet > > > > > > > type > > > > > > > > > > > > > > Xiao Wang (1): > > > > > > > net/fm10k: fix VLAN strip offload flag > > > > > > > > > > > > > > Yipeng Wang (1): > > > > > > > hash: fix doc about thread/process safety > > > > > > > > > > > > > > Yongseok Koh (4): > > > > > > > net/mlx5: fix instruction hotspot on replenishing > > > > > > > Rx > > > > > > > buffer > > > > > > > net/mlx5: check Tx queue size overflow > > > > > > > net/mlx5: fix max number of queues for NEON Tx > > > > > > > doc: fix typo in mlx5 guide > > > > > > > > > > > > > > Yunjian Wang (1): > > > > > > > net/ixgbe: fix crash on remove > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Kind regards, > > > > > Luca Boccassi > > > > > > > > > > > -- Kind regards, Luca Boccassi ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test 2019-09-26 7:34 ` Yu, PingX @ 2019-09-26 7:38 ` Ferruh Yigit 2019-09-26 8:15 ` Yu, PingX 0 siblings, 1 reply; 19+ messages in thread From: Ferruh Yigit @ 2019-09-26 7:38 UTC (permalink / raw) To: Yu, PingX, Luca Boccassi, Kevin Traynor, Mcnamara, John, Kusztal, ArkadiuszX Cc: Peng, Yuan, dev, Xu, Qian Q On 9/26/2019 8:34 AM, Yu, PingX wrote: > Luca, > 1. Latest 17.11 branch is verified passed for feature PF. No issue now. > 2. bugs 3/4/5 are fixed now by arkadiuszx.kusztal@intel.com 's patch. No issue now. Can you please share the link of the mentioned patch? > > Regards, > Yu Ping > > -----Original Message----- > From: Luca Boccassi [mailto:bluca@debian.org] > Sent: Wednesday, September 25, 2019 4:08 AM > To: Kevin Traynor <ktraynor@redhat.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Mcnamara, John <john.mcnamara@intel.com> > Cc: Yu, PingX <pingx.yu@intel.com>; Peng, Yuan <yuan.peng@intel.com>; dev@dpdk.org; Xu, Qian Q <qian.q.xu@intel.com> > Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test > > Yu Ping, Qian, > > I have pushed to the 17.11 branch with the fixes for 1 and 2, and for building with kernel 5.3 (just a change in the comments, nothing functional). Do you need to re-run the test suite, or are you confident enough with a quick check? > > This release is already quite late, is it OK if bugs 3/4/5 are postponed to the next release? > > On Tue, 2019-09-24 at 18:25 +0100, Luca Boccassi wrote: >> On Tue, 2019-09-24 at 18:15 +0100, Kevin Traynor wrote: >>> On 24/09/2019 17:36, Ferruh Yigit wrote: >>>> On 9/24/2019 12:07 PM, Luca Boccassi wrote: >>>>> Ping - any updates on these patches? The release of 17.11.7 is >>>>> currently on hold waiting for a resolution here. >>>> >>>> Hi Luca, >>>> >>>> Test team provided some internal details: >>>> >>>> 1- Build issue on f30, >>>> A patch has been sent to stable mail list to fix it, not sure if >>>> it has been >>>> merged: >>>> https://mails.dpdk.org/archives/stable/2019-September/017122.html >>>> >>>> >> >> Thanks Ferruh, I am testing a build with that one. >> >>>> 2- "make -C test/" fails. >>>> "Fix looks to be to add "#include <inttypes.h>" into >>>> test_rwlock.c" >>>> Not sure if there is a patch for this. >>> >>> Hi, this include was added in 18.11 as part of: >>> >>> commit 0d0dfaaff93cb599b2c58fd6fe405fd4f44b5710 >>> Author: Joyce Kong < >>> joyce.kong@arm.com >>> >>> >>> Date: Tue Sep 10 11:36:58 2019 +0800 >>> >>> test/rwlock: benchmark on all available cores >>> >>> [ upstream commit fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] >>> >>> >>> Note, the master commit would not apply and it was a custom backport >>> for >>> 18.11 by Joyce >>> ( >>> http://inbox.dpdk.org/stable/1568086619-5029-1-git-send-email-joyce. >>> kong@arm.com >>> >>> ) >>> Maybe it can work for 17.11 too? >> >> Hi, >> >> It was backported for 17.11 too, but it does not have the include. >> I'll >> test another commits that has it. >> >>>> 3- l2fwd-crypto, ERROR: Test Case test_qat_h_AES_XCBC_MAC_auto >>>> Result FAILED Work in progress >>>> >>>> 4- ipsec-secgw, forwarding failed with null crypto QAT Work in >>>> progress >>>> >>>> 5- Unit test "cryptodev_qat_autotest" failed Issue not analyzed >>>> yet. >>>> >>>> >>>>> Thanks! >>>>> >>>>> On Wed, 2019-09-18 at 10:03 +0000, Yu, PingX wrote: >>>>>> Luca, >>>>>> FYI. Currently there isn't reference for bug1 and bug2 and >>>>>> also haven't send to mailing list yet. These bugs should be >>>>>> fixed before release as they will block the basic PF test. >>>>>> >>>>>> Regards, >>>>>> Yu Ping >>>>>> >>>>>> >>>>>> -----Original Message----- >>>>>> From: dev [mailto: >>>>>> dev-bounces@dpdk.org >>>>>> >>>>>> >>>>>> ] On Behalf Of Luca Boccassi >>>>>> Sent: Wednesday, September 18, 2019 5:18 PM >>>>>> To: Peng, Yuan < >>>>>> yuan.peng@intel.com >>>>>> >>>>>> >>>>>>> ; >>>>>> >>>>>> dev@dpdk.org >>>>>> >>>>>> >>>>>> >>>>>> Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review >>>>>> and test >>>>>> >>>>>> Hi, >>>>>> >>>>>> Ping - this is blocking the 17.11.7 release. >>>>>> >>>>>> Thanks! >>>>>> >>>>>> On Tue, 2019-09-17 at 10:53 +0100, Luca Boccassi wrote: >>>>>>> Hello, >>>>>>> >>>>>>> Do you have a reference for the patches for bug 1 and 2? >>>>>>> Have >>>>>>> they >>>>>>> been sent to the mailing list? >>>>>>> >>>>>>> On Thu, 2019-09-12 at 08:52 +0000, Peng, Yuan wrote: >>>>>>>> Update the latest test status here. >>>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: Yu, PingX >>>>>>>> Sent: Thursday, September 12, 2019 2:37 PM >>>>>>>> To: Yongseok Koh < >>>>>>>> yskoh@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ananyev, Konstantin < >>>>>>>> >>>>>>>> konstantin.ananyev@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; >>>>>>>> >>>>>>>> asafp@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Cc: Xu, Qian Q < >>>>>>>> qian.q.xu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Lin, Xueqin < >>>>>>>> >>>>>>>> xueqin.lin@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Chen, Zhaoyan < >>>>>>>> >>>>>>>> zhaoyan.chen@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; O'Hare, Cathal < >>>>>>>> >>>>>>>> cathal.ohare@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Yigit, Ferruh < >>>>>>>> >>>>>>>> ferruh.yigit@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ma, LihongX < >>>>>>>> >>>>>>>> lihongx.ma@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Li, WenjieX A < >>>>>>>> >>>>>>>> wenjiex.a.li@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Wang, FengqinX < >>>>>>>> >>>>>>>> fengqinx.wang@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Peng, Yuan < >>>>>>>> >>>>>>>> yuan.peng@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Subject: RE: 17.11.7-rc1 (LTS) patches review and test >>>>>>>> >>>>>>>> All, >>>>>>>> Update the latest test status here. >>>>>>>> The critical bug has been fixed and we have re-tested all >>>>>>>> Intel >>>>>>>> key >>>>>>>> features. >>>>>>>> >>>>>>>> Intel(R) Testing result lists here. >>>>>>>> # Basic Intel(R) NIC testing >>>>>>>> * PF(i40e): One bug found in 1st round test. 2nd round >>>>>>>> test >>>>>>>> pass >>>>>>>> after fixing the bug. (see Bug1) >>>>>>>> * PF(ixgbe): the same as PF(i40e). >>>>>>>> * VF: Pass and no issue. >>>>>>>> * Build or compile: One bug found in 1st round test. 2nd >>>>>>>> round >>>>>>>> test >>>>>>>> pass after fixing the bug. (see Bug2) >>>>>>>> * Intel NIC single core/NIC performance: Pass and no >>>>>>>> issue. >>>>>>>> >>>>>>>> #Basic cryptodev and virtio testing >>>>>>>> * vhost/virtio basic loopback, PVP and performance test: >>>>>>>> pass. >>>>>>>> * cryptodev: 3 bugs are found(see bug statistic in >>>>>>>> below). >>>>>>>> (See >>>>>>>> Bug3,4 and 5) >>>>>>>> >>>>>>>> Bugs statistic: >>>>>>>> Bug1: make -C test/ failed. It blocked about 60 test >>>>>>>> cases >>>>>>>> for >>>>>>>> both >>>>>>>> PF(i40e) and PF(ixgbe). Resolved by adding "#include >>>>>>>> <inttypes.h>" >>>>>>>> into test_rwlock.c. Please decide whether submit a patch >>>>>>>> to >>>>>>>> DPDK >>>>>>>> or >>>>>>>> not. >>>>>>>> Bug2: compile error on fc30. Patch is provided and >>>>>>>> validated >>>>>>>> pass. >>>>>>>> Need to decide whether merge into DPDK or not. >>>>>>>> Bug3: L2fwd: test_qat_h_AES_XCBC_MAC_auto failed. No >>>>>>>> progress >>>>>>>> yet. >>>>>>>> commit 39fb9500c42752a537588f7a203433ec4737fa1e >>>>>>>> Author: Arek Kusztal < >>>>>>>> arkadiuszx.kusztal@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Date: Wed Dec 12 20:59:02 2018 +0100 >>>>>>>> >>>>>>>> Bug4: Ipsec-gw_test forwarding failed with null crypto >>>>>>>> QAT. >>>>>>>> No >>>>>>>> progress yet. >>>>>>>> commit 39fb9500c42752a537588f7a203433ec4737fa1e >>>>>>>> Author: Arek Kusztal < >>>>>>>> arkadiuszx.kusztal@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Date: Wed Dec 12 20:59:02 2018 +0100 >>>>>>>> >>>>>>>> Bug5: Crypto: cryptodev_qat_autotest test failed. No >>>>>>>> progress >>>>>>>> yet. >>>>>>>> 39fb9500c42752a537588f7a203433ec4737fa1e is the first >>>>>>>> bad >>>>>>>> commit >>>>>>>> commit 39fb9500c42752a537588f7a203433ec4737fa1e >>>>>>>> Author: Arek Kusztal < >>>>>>>> arkadiuszx.kusztal@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Date: Wed Dec 12 20:59:02 2018 +0100 >>>>>>>> >>>>>>>> Regards, >>>>>>>> Yu Ping >>>>>>>> >>>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: Wang, FengqinX >>>>>>>> Sent: Monday, August 26, 2019 3:12 PM >>>>>>>> To: Yongseok Koh < >>>>>>>> yskoh@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ananyev, Konstantin < >>>>>>>> >>>>>>>> konstantin.ananyev@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; >>>>>>>> >>>>>>>> asafp@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Cc: Xu, Qian Q < >>>>>>>> qian.q.xu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Lin, Xueqin < >>>>>>>> >>>>>>>> xueqin.lin@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Chen, Zhaoyan < >>>>>>>> >>>>>>>> zhaoyan.chen@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; O'Hare, Cathal < >>>>>>>> >>>>>>>> cathal.ohare@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Yigit, Ferruh < >>>>>>>> >>>>>>>> ferruh.yigit@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Yu, PingX < >>>>>>>> >>>>>>>> pingx.yu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ma, LihongX < >>>>>>>> >>>>>>>> lihongx.ma@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Li, WenjieX A < >>>>>>>> >>>>>>>> wenjiex.a.li@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Subject: RE: 17.11.7-rc1 (LTS) patches review and test >>>>>>>> >>>>>>>> Add asafp in the loop due to Yongseok is longer working >>>>>>>> at >>>>>>>> Mellanox. >>>>>>>> >>>>>>>> BRs, Vicky >>>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: Wang, FengqinX >>>>>>>> Sent: Monday, August 26, 2019 3:07 PM >>>>>>>> To: 'Yongseok Koh' < >>>>>>>> yskoh@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ananyev, Konstantin < >>>>>>>> >>>>>>>> konstantin.ananyev@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Cc: Xu, Qian Q < >>>>>>>> qian.q.xu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Lin, Xueqin < >>>>>>>> >>>>>>>> xueqin.lin@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Chen, Zhaoyan < >>>>>>>> >>>>>>>> zhaoyan.chen@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; O'Hare, Cathal < >>>>>>>> >>>>>>>> cathal.ohare@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Yigit, Ferruh < >>>>>>>> >>>>>>>> ferruh.yigit@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Yu, PingX < >>>>>>>> >>>>>>>> pingx.yu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ma, LihongX < >>>>>>>> >>>>>>>> lihongx.ma@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Li, WenjieX A < >>>>>>>> >>>>>>>> wenjiex.a.li@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Subject: RE: 17.11.7-rc1 (LTS) patches review and test >>>>>>>> >>>>>>>> Hi Yongseok, Konstantin, >>>>>>>> >>>>>>>> There is one critical compile issue found, and below is >>>>>>>> the >>>>>>>> bad >>>>>>>> commit related information, this issue has blocked most >>>>>>>> of >>>>>>>> unit >>>>>>>> tests which have used dpdk/test/test, would you please >>>>>>>> help >>>>>>>> to >>>>>>>> fix >>>>>>>> this issue ASAP? >>>>>>>> >>>>>>>> commit 29e08d740ffc1e0ed9e7a9bd25fb95714fac1070 >>>>>>>> Author: Joyce Kong < >>>>>>>> joyce.kong@arm.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Date: Thu Jul 25 14:50:21 2019 +0800 >>>>>>>> >>>>>>>> test/rwlock: benchmark on all available cores >>>>>>>> >>>>>>>> [ backported from upstream commit >>>>>>>> fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] >>>>>>>> >>>>>>>> Add performance test on all available cores to >>>>>>>> benchmark >>>>>>>> the scaling up performance of rw_lock. >>>>>>>> >>>>>>>> Fixes: af75078fece3 ("first public release") >>>>>>>> >>>>>>>> Suggested-by: Gavin Hu < >>>>>>>> gavin.hu@arm.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Signed-off-by: Joyce Kong < >>>>>>>> joyce.kong@arm.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Acked-by: Konstantin Ananyev < >>>>>>>> konstantin.ananyev@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> And below is the error message output: >>>>>>>> >>>>>>>> test_rwlock.c: In function 'load_loop_fn': >>>>>>>> test_rwlock.c:126:38: error: expected ')' before 'PRIu64' >>>>>>>> printf("Core [%u] rwlock_data = %"PRIu64"\n", ^~~~~~ >>>>>>>> ) >>>>>>>> test_rwlock.c:126:19: error: format '%u' expects a >>>>>>>> matching >>>>>>>> 'unsigned int' argument [-Werror=format=] printf("Core >>>>>>>> [%u] >>>>>>>> rwlock_data = %"PRIu64"\n", ~^ >>>>>>>> test_rwlock.c:126:36: error: spurious trailing '%' in >>>>>>>> format [- >>>>>>>> Werror=format=] printf("Core [%u] rwlock_data = >>>>>>>> %"PRIu64"\n", ^ >>>>>>>> test_rwlock.c: In function 'test_rwlock_perf': >>>>>>>> test_rwlock.c:160:31: error: expected ')' before 'PRIu64' >>>>>>>> printf("Core [%u] count = %"PRIu64"\n", i, >>>>>>>> lock_count[i]); >>>>>>>> ^~~~~~ >>>>>>>> ) >>>>>>>> test_rwlock.c:160:18: error: format '%u' expects a >>>>>>>> matching >>>>>>>> 'unsigned int' argument [-Werror=format=] printf("Core >>>>>>>> [%u] >>>>>>>> count >>>>>>>> = >>>>>>>> %"PRIu64"\n", i, lock_count[i]); ~^ >>>>>>>> test_rwlock.c:160:29: error: spurious trailing '%' in >>>>>>>> format [- >>>>>>>> Werror=format=] printf("Core [%u] count = %"PRIu64"\n", >>>>>>>> i, >>>>>>>> lock_count[i]); ^ >>>>>>>> test_rwlock.c:164:26: error: expected ')' before 'PRIu64' >>>>>>>> printf("Total count = %"PRIu64"\n", total); ^~~~~~ >>>>>>>> ) >>>>>>>> test_rwlock.c:164:24: error: spurious trailing '%' in >>>>>>>> format [- >>>>>>>> Werror=format=] printf("Total count = %"PRIu64"\n", >>>>>>>> total); >>>>>>>> ^ >>>>>>>> cc1: all warnings being treated as errors >>>>>>>> >>>>>>>> BRs, Vicky >>>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: Yongseok Koh [mailto: >>>>>>>> yskoh@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> ] >>>>>>>> Sent: Friday, August 16, 2019 2:05 AM >>>>>>>> To: dpdk stable < >>>>>>>> stable@dpdk.org >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Cc: >>>>>>>> dev@dpdk.org >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> ; >>>>>>>> pezhang@redhat.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> ; >>>>>>>> siliu@redhat.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> ; Wang, FengqinX < >>>>>>>> fengqinx.wang@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Chen, Zhaoyan < >>>>>>>> >>>>>>>> zhaoyan.chen@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Xu, Qian Q < >>>>>>>> >>>>>>>> qian.q.xu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; >>>>>>>> >>>>>>>> alialnu@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> ; >>>>>>>> rasland@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Subject: 17.11.7-rc1 (LTS) patches review and test >>>>>>>> >>>>>>>> Hi all, >>>>>>>> >>>>>>>> Here is a list of patches targeted for LTS release >>>>>>>> 17.11.7. >>>>>>>> Please >>>>>>>> help review and test. The planned date for the final >>>>>>>> release is >>>>>>>> Aug >>>>>>>> 23, Before that, please shout if anyone has objections >>>>>>>> with >>>>>>>> these >>>>>>>> patches being applied. >>>>>>>> >>>>>>>> Also for the companies committed to running regression >>>>>>>> tests, >>>>>>>> please >>>>>>>> run the tests and report any issue before the release >>>>>>>> date. >>>>>>>> >>>>>>>> A release candidate tarball can be found at: >>>>>>>> >>>>>>>> >>>>>>>> https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> These patches are located at branch 17.11 of dpdk-stable >>>>>>>> repo: >>>>>>>> >>>>>>>> https://dpdk.org/browse/dpdk-stable/ >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Yongseok >>>>>>>> >>>>>>>> --- >>>>>>>> >>>>>>>> Aaron Conole (1): >>>>>>>> net/virtio: fix dangling pointer on failure >>>>>>>> >>>>>>>> Agalya Babu RadhaKrishnan (1): >>>>>>>> doc: fix interactive commands in testpmd guide >>>>>>>> >>>>>>>> Akhil Goyal (1): >>>>>>>> crypto/dpaa2_sec: fix session clearing >>>>>>>> >>>>>>>> Alejandro Lucero (1): >>>>>>>> net/nfp: fix RSS query >>>>>>>> >>>>>>>> Anatoly Burakov (2): >>>>>>>> eal: improve musl compatibility of string functions >>>>>>>> malloc: fix documentation of realloc function >>>>>>>> >>>>>>>> Andrew Rybchenko (2): >>>>>>>> net/sfc: remove control path logging from Rx queue >>>>>>>> count >>>>>>>> app/testpmd: set fixed flag for exact link speed >>>>>>>> >>>>>>>> Andrius Sirvys (3): >>>>>>>> net/virtio: fix duplicate naming of include guard >>>>>>>> bitrate: fix unchecked return value >>>>>>>> drivers/net: fix shifting 32-bit signed variable 31 >>>>>>>> times >>>>>>>> >>>>>>>> Anoob Joseph (1): >>>>>>>> cryptodev: fix driver name comparison >>>>>>>> >>>>>>>> Beilei Xing (1): >>>>>>>> net/i40e: fix link speed for X722 >>>>>>>> >>>>>>>> Bernard Iremonger (1): >>>>>>>> examples/ipsec-secgw: fix debug logs >>>>>>>> >>>>>>>> Bill Hong (1): >>>>>>>> net: fix Tx VLAN flag for offload emulation >>>>>>>> >>>>>>>> Bruce Richardson (9): >>>>>>>> eal: support strlcat function >>>>>>>> net/bonding: fix buffer length when printing >>>>>>>> strings >>>>>>>> examples/l2fwd-cat: fix build on FreeBSD >>>>>>>> app/crypto-perf: check range of socket id >>>>>>>> examples/vhost_scsi: fix null-check for parameter >>>>>>>> net/i40e: fix dereference before null check in mbuf >>>>>>>> release >>>>>>>> net/ixgbe: fix warning with GCC 9 >>>>>>>> bus/fslmc: fix warning with GCC 9 >>>>>>>> eal: tighten permissions on shared memory files >>>>>>>> >>>>>>>> Chaitanya Babu Talluri (2): >>>>>>>> drivers/net: fix possible overflow using strlcat >>>>>>>> cfgfile: replace strcat with strlcat >>>>>>>> >>>>>>>> David Christensen (2): >>>>>>>> maintainers: update for IBM POWER >>>>>>>> examples/vm_power_manager: fix PMD specific code >>>>>>>> >>>>>>>> David Marchand (7): >>>>>>>> eal: fix check when retrieving current CPU affinity >>>>>>>> eal: remove dead code in core list parsing >>>>>>>> app/testpmd: remove unused field from port struct >>>>>>>> doc: fix examples in bonding guide >>>>>>>> net/bonding: fix port id types >>>>>>>> net/bonding: fix queue index types >>>>>>>> app/testpmd: remove useless casts on statistics >>>>>>>> >>>>>>>> Davide Caratti (1): >>>>>>>> net/bnxt: support IOVA VA mode >>>>>>>> >>>>>>>> Dekel Peled (8): >>>>>>>> net/mlx5: fix hex dump of error completion >>>>>>>> net/mlx5: fix sync when handling Tx completions >>>>>>>> eal/ppc: fix global memory barrier >>>>>>>> eal: fix typo in comment of vector function >>>>>>>> doc: fix links to doxygen and sphinx sites >>>>>>>> app/testpmd: fix typo in comment >>>>>>>> net/mlx5: fix comments mixing Rx and Tx >>>>>>>> net/mlx5: fix release of Rx queue object >>>>>>>> >>>>>>>> Fan Zhang (1): >>>>>>>> examples/ipsec-secgw: fix AES-CTR block size >>>>>>>> >>>>>>>> Ferruh Yigit (5): >>>>>>>> kni: fix build with Linux 5.1 >>>>>>>> build: fix crash by disabling AVX512 with binutils >>>>>>>> 2.31 >>>>>>>> net/ring: fix return value check >>>>>>>> net/kni: fix return value check >>>>>>>> app/testpmd: revert fixed flag for exact link speed >>>>>>>> >>>>>>>> Gage Eads (1): >>>>>>>> ring: fix namesize macro documentation block >>>>>>>> >>>>>>>> Gavin Hu (3): >>>>>>>> test/spinlock: remove delay for correct >>>>>>>> benchmarking >>>>>>>> test/spinlock: amortize the cost of getting time >>>>>>>> spinlock: reimplement with atomic one-way barrier >>>>>>>> >>>>>>>> Hari Kumar Vemula (1): >>>>>>>> net/bonding: fix reset active slave >>>>>>>> >>>>>>>> Harry van Haaren (1): >>>>>>>> event/sw: fix enqueue checks in self-test >>>>>>>> >>>>>>>> Herakliusz Lipiec (1): >>>>>>>> doc: fix broken link in LPM guide >>>>>>>> >>>>>>>> Hyong Youb Kim (4): >>>>>>>> net/bonding: avoid warning for invalid port >>>>>>>> net/enic: fix flow director SCTP matching >>>>>>>> net/enic: fix SCTP match for flow API >>>>>>>> net/enic: check for unsupported flow item types >>>>>>>> >>>>>>>> Igor Romanov (1): >>>>>>>> app/testpmd: fix stdout flush after printing stats >>>>>>>> >>>>>>>> Ilya Maximets (2): >>>>>>>> vhost: fix device leak on connection add failure >>>>>>>> vhost: fix silent queue enabling with legacy guests >>>>>>>> >>>>>>>> Ivan Malov (1): >>>>>>>> net/sfc: log port ID as 16-bit unsigned integer on >>>>>>>> panic >>>>>>>> >>>>>>>> Jerin Jacob (1): >>>>>>>> mk: fix AVX512 disabled warning on non x86 >>>>>>>> >>>>>>>> Jianfeng Tan (1): >>>>>>>> drivers/net: do not use private ethdev data >>>>>>>> >>>>>>>> Joyce Kong (1): >>>>>>>> test/rwlock: benchmark on all available cores >>>>>>>> >>>>>>>> Kevin Traynor (3): >>>>>>>> net/qede: support IOVA VA mode >>>>>>>> eal/linux: fix log levels for pagemap reading >>>>>>>> failure >>>>>>>> power: fix frequency list buffer validation >>>>>>>> >>>>>>>> Liang Zhang (1): >>>>>>>> net/bonding: fix LACP negotiation >>>>>>>> >>>>>>>> Luo Gaoliang (1): >>>>>>>> kni: fix build on RHEL8 >>>>>>>> >>>>>>>> Marcin Smoczynski (1): >>>>>>>> examples/ipsec-secgw: fix build error log >>>>>>>> >>>>>>>> Natanael Copa (3): >>>>>>>> bus/fslmc: remove unused include of error.h >>>>>>>> bus/fslmc: fix build with musl libc >>>>>>>> app/test: fix build with musl libc >>>>>>>> >>>>>>>> Pallantla Poornima (3): >>>>>>>> app/test: fix sprintf with strlcat >>>>>>>> test/distributor: replace sprintf with strlcpy >>>>>>>> test/hash: replace sprintf with snprintf >>>>>>>> >>>>>>>> Qi Zhang (1): >>>>>>>> net/i40e: fix time sync for 25G >>>>>>>> >>>>>>>> Radu Nicolau (3): >>>>>>>> net/null: add MAC address setting fake operation >>>>>>>> test/virtual_pmd: add MAC address setting fake op >>>>>>>> test/bonding: assign non-zero MAC to null devices >>>>>>>> >>>>>>>> Rahul Lakkireddy (1): >>>>>>>> net/cxgbe: update Chelsio T5/T6 NIC device ids >>>>>>>> >>>>>>>> Rami Rosen (8): >>>>>>>> net/virtio: remove forward declaration >>>>>>>> mbuf: fix a typo >>>>>>>> doc: fix a minor typo in testpmd guide >>>>>>>> doc: remove reference to rte.doc.mk in programmers >>>>>>>> guide >>>>>>>> examples/ethtool: fix two typos >>>>>>>> doc: fix link in Linux getting started guide >>>>>>>> app/testpmd: fix a typo in log message >>>>>>>> ethdev: fix a typo >>>>>>>> >>>>>>>> Rasesh Mody (2): >>>>>>>> net/bnx2x: fix race for periodic flags >>>>>>>> net/bnx2x: fix optic module verification >>>>>>>> >>>>>>>> Shahaf Shuler (1): >>>>>>>> net/mlx5: fix packet inline on Tx queue wraparound >>>>>>>> >>>>>>>> Shahed Shaikh (5): >>>>>>>> net/bnx2x: fix segfaults due to stale interrupt >>>>>>>> status >>>>>>>> net/bnx2x: fix memory leak >>>>>>>> net/bnx2x: fix ramrod timeout >>>>>>>> net/bnx2x: fix DMAE timeout >>>>>>>> net/qede: fix Tx packet prepare for tunnel packets >>>>>>>> >>>>>>>> Shreyansh Jain (1): >>>>>>>> bus/dpaa: fix Rx discard register mask >>>>>>>> >>>>>>>> Stephen Hemminger (8): >>>>>>>> net/octeontx: fix vdev name >>>>>>>> net/bnxt: fix Rx VLAN offload flags >>>>>>>> net/virtio: remove useless condition >>>>>>>> ring: fix an error message >>>>>>>> net/ring: avoid hard-coded length >>>>>>>> net/ring: use calloc style where appropriate >>>>>>>> net/ring: check length of ring name >>>>>>>> net/virtio: fix buffer leak on VLAN insert >>>>>>>> >>>>>>>> Thomas Monjalon (2): >>>>>>>> mk: fix build of shared library with libbsd >>>>>>>> bus/vdev: fix debug message on probing >>>>>>>> >>>>>>>> Tiwei Bie (4): >>>>>>>> net/virtio: add barrier in interrupt enable >>>>>>>> vhost: restore mbuf first when freeing zmbuf >>>>>>>> vhost: fix potential use-after-free for zero copy >>>>>>>> mbuf >>>>>>>> vhost: fix potential use-after-free for memory >>>>>>>> region >>>>>>>> >>>>>>>> Vishal Kulkarni (1): >>>>>>>> net/cxgbe: fix missing checksum flags and packet >>>>>>>> type >>>>>>>> >>>>>>>> Xiao Wang (1): >>>>>>>> net/fm10k: fix VLAN strip offload flag >>>>>>>> >>>>>>>> Yipeng Wang (1): >>>>>>>> hash: fix doc about thread/process safety >>>>>>>> >>>>>>>> Yongseok Koh (4): >>>>>>>> net/mlx5: fix instruction hotspot on replenishing >>>>>>>> Rx >>>>>>>> buffer >>>>>>>> net/mlx5: check Tx queue size overflow >>>>>>>> net/mlx5: fix max number of queues for NEON Tx >>>>>>>> doc: fix typo in mlx5 guide >>>>>>>> >>>>>>>> Yunjian Wang (1): >>>>>>>> net/ixgbe: fix crash on remove >>>>>>>> >>>>>>>> >>>>>> >>>>>> -- >>>>>> Kind regards, >>>>>> Luca Boccassi >>>>>> >>> >>> >>> ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test 2019-09-26 7:38 ` Ferruh Yigit @ 2019-09-26 8:15 ` Yu, PingX 2019-09-26 8:19 ` Luca Boccassi 0 siblings, 1 reply; 19+ messages in thread From: Yu, PingX @ 2019-09-26 8:15 UTC (permalink / raw) To: Yigit, Ferruh, Luca Boccassi, Kevin Traynor, Mcnamara, John, Kusztal, ArkadiuszX Cc: Peng, Yuan, dev, Xu, Qian Q Ferruh, Kusztal, ArkadiuszX will send the patch to 17.11 and paste the patch link later. Regards, Yu Ping -----Original Message----- From: Yigit, Ferruh Sent: Thursday, September 26, 2019 3:38 PM To: Yu, PingX <pingx.yu@intel.com>; Luca Boccassi <bluca@debian.org>; Kevin Traynor <ktraynor@redhat.com>; Mcnamara, John <john.mcnamara@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com> Cc: Peng, Yuan <yuan.peng@intel.com>; dev@dpdk.org; Xu, Qian Q <qian.q.xu@intel.com> Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test On 9/26/2019 8:34 AM, Yu, PingX wrote: > Luca, > 1. Latest 17.11 branch is verified passed for feature PF. No issue now. > 2. bugs 3/4/5 are fixed now by arkadiuszx.kusztal@intel.com 's patch. No issue now. Can you please share the link of the mentioned patch? > > Regards, > Yu Ping > > -----Original Message----- > From: Luca Boccassi [mailto:bluca@debian.org] > Sent: Wednesday, September 25, 2019 4:08 AM > To: Kevin Traynor <ktraynor@redhat.com>; Yigit, Ferruh > <ferruh.yigit@intel.com>; Mcnamara, John <john.mcnamara@intel.com> > Cc: Yu, PingX <pingx.yu@intel.com>; Peng, Yuan <yuan.peng@intel.com>; > dev@dpdk.org; Xu, Qian Q <qian.q.xu@intel.com> > Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test > > Yu Ping, Qian, > > I have pushed to the 17.11 branch with the fixes for 1 and 2, and for building with kernel 5.3 (just a change in the comments, nothing functional). Do you need to re-run the test suite, or are you confident enough with a quick check? > > This release is already quite late, is it OK if bugs 3/4/5 are postponed to the next release? > > On Tue, 2019-09-24 at 18:25 +0100, Luca Boccassi wrote: >> On Tue, 2019-09-24 at 18:15 +0100, Kevin Traynor wrote: >>> On 24/09/2019 17:36, Ferruh Yigit wrote: >>>> On 9/24/2019 12:07 PM, Luca Boccassi wrote: >>>>> Ping - any updates on these patches? The release of 17.11.7 is >>>>> currently on hold waiting for a resolution here. >>>> >>>> Hi Luca, >>>> >>>> Test team provided some internal details: >>>> >>>> 1- Build issue on f30, >>>> A patch has been sent to stable mail list to fix it, not sure if it >>>> has been >>>> merged: >>>> https://mails.dpdk.org/archives/stable/2019-September/017122.html >>>> >>>> >> >> Thanks Ferruh, I am testing a build with that one. >> >>>> 2- "make -C test/" fails. >>>> "Fix looks to be to add "#include <inttypes.h>" into test_rwlock.c" >>>> Not sure if there is a patch for this. >>> >>> Hi, this include was added in 18.11 as part of: >>> >>> commit 0d0dfaaff93cb599b2c58fd6fe405fd4f44b5710 >>> Author: Joyce Kong < >>> joyce.kong@arm.com >>> >>> >>> Date: Tue Sep 10 11:36:58 2019 +0800 >>> >>> test/rwlock: benchmark on all available cores >>> >>> [ upstream commit fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] >>> >>> >>> Note, the master commit would not apply and it was a custom backport >>> for >>> 18.11 by Joyce >>> ( >>> http://inbox.dpdk.org/stable/1568086619-5029-1-git-send-email-joyce. >>> kong@arm.com >>> >>> ) >>> Maybe it can work for 17.11 too? >> >> Hi, >> >> It was backported for 17.11 too, but it does not have the include. >> I'll >> test another commits that has it. >> >>>> 3- l2fwd-crypto, ERROR: Test Case test_qat_h_AES_XCBC_MAC_auto >>>> Result FAILED Work in progress >>>> >>>> 4- ipsec-secgw, forwarding failed with null crypto QAT Work in >>>> progress >>>> >>>> 5- Unit test "cryptodev_qat_autotest" failed Issue not analyzed >>>> yet. >>>> >>>> >>>>> Thanks! >>>>> >>>>> On Wed, 2019-09-18 at 10:03 +0000, Yu, PingX wrote: >>>>>> Luca, >>>>>> FYI. Currently there isn't reference for bug1 and bug2 and also >>>>>> haven't send to mailing list yet. These bugs should be fixed >>>>>> before release as they will block the basic PF test. >>>>>> >>>>>> Regards, >>>>>> Yu Ping >>>>>> >>>>>> >>>>>> -----Original Message----- >>>>>> From: dev [mailto: >>>>>> dev-bounces@dpdk.org >>>>>> >>>>>> >>>>>> ] On Behalf Of Luca Boccassi >>>>>> Sent: Wednesday, September 18, 2019 5:18 PM >>>>>> To: Peng, Yuan < >>>>>> yuan.peng@intel.com >>>>>> >>>>>> >>>>>>> ; >>>>>> >>>>>> dev@dpdk.org >>>>>> >>>>>> >>>>>> >>>>>> Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and >>>>>> test >>>>>> >>>>>> Hi, >>>>>> >>>>>> Ping - this is blocking the 17.11.7 release. >>>>>> >>>>>> Thanks! >>>>>> >>>>>> On Tue, 2019-09-17 at 10:53 +0100, Luca Boccassi wrote: >>>>>>> Hello, >>>>>>> >>>>>>> Do you have a reference for the patches for bug 1 and 2? >>>>>>> Have >>>>>>> they >>>>>>> been sent to the mailing list? >>>>>>> >>>>>>> On Thu, 2019-09-12 at 08:52 +0000, Peng, Yuan wrote: >>>>>>>> Update the latest test status here. >>>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: Yu, PingX >>>>>>>> Sent: Thursday, September 12, 2019 2:37 PM >>>>>>>> To: Yongseok Koh < >>>>>>>> yskoh@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ananyev, Konstantin < >>>>>>>> >>>>>>>> konstantin.ananyev@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; >>>>>>>> >>>>>>>> asafp@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Cc: Xu, Qian Q < >>>>>>>> qian.q.xu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Lin, Xueqin < >>>>>>>> >>>>>>>> xueqin.lin@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Chen, Zhaoyan < >>>>>>>> >>>>>>>> zhaoyan.chen@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; O'Hare, Cathal < >>>>>>>> >>>>>>>> cathal.ohare@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Yigit, Ferruh < >>>>>>>> >>>>>>>> ferruh.yigit@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ma, LihongX < >>>>>>>> >>>>>>>> lihongx.ma@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Li, WenjieX A < >>>>>>>> >>>>>>>> wenjiex.a.li@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Wang, FengqinX < >>>>>>>> >>>>>>>> fengqinx.wang@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Peng, Yuan < >>>>>>>> >>>>>>>> yuan.peng@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Subject: RE: 17.11.7-rc1 (LTS) patches review and test >>>>>>>> >>>>>>>> All, >>>>>>>> Update the latest test status here. >>>>>>>> The critical bug has been fixed and we have re-tested all Intel >>>>>>>> key features. >>>>>>>> >>>>>>>> Intel(R) Testing result lists here. >>>>>>>> # Basic Intel(R) NIC testing >>>>>>>> * PF(i40e): One bug found in 1st round test. 2nd round test >>>>>>>> pass after fixing the bug. (see Bug1) >>>>>>>> * PF(ixgbe): the same as PF(i40e). >>>>>>>> * VF: Pass and no issue. >>>>>>>> * Build or compile: One bug found in 1st round test. 2nd round >>>>>>>> test pass after fixing the bug. (see Bug2) >>>>>>>> * Intel NIC single core/NIC performance: Pass and no issue. >>>>>>>> >>>>>>>> #Basic cryptodev and virtio testing >>>>>>>> * vhost/virtio basic loopback, PVP and performance test: >>>>>>>> pass. >>>>>>>> * cryptodev: 3 bugs are found(see bug statistic in >>>>>>>> below). >>>>>>>> (See >>>>>>>> Bug3,4 and 5) >>>>>>>> >>>>>>>> Bugs statistic: >>>>>>>> Bug1: make -C test/ failed. It blocked about 60 test >>>>>>>> cases >>>>>>>> for >>>>>>>> both >>>>>>>> PF(i40e) and PF(ixgbe). Resolved by adding "#include >>>>>>>> <inttypes.h>" >>>>>>>> into test_rwlock.c. Please decide whether submit a patch >>>>>>>> to >>>>>>>> DPDK >>>>>>>> or >>>>>>>> not. >>>>>>>> Bug2: compile error on fc30. Patch is provided and >>>>>>>> validated >>>>>>>> pass. >>>>>>>> Need to decide whether merge into DPDK or not. >>>>>>>> Bug3: L2fwd: test_qat_h_AES_XCBC_MAC_auto failed. No >>>>>>>> progress >>>>>>>> yet. >>>>>>>> commit 39fb9500c42752a537588f7a203433ec4737fa1e >>>>>>>> Author: Arek Kusztal < >>>>>>>> arkadiuszx.kusztal@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Date: Wed Dec 12 20:59:02 2018 +0100 >>>>>>>> >>>>>>>> Bug4: Ipsec-gw_test forwarding failed with null crypto >>>>>>>> QAT. >>>>>>>> No >>>>>>>> progress yet. >>>>>>>> commit 39fb9500c42752a537588f7a203433ec4737fa1e >>>>>>>> Author: Arek Kusztal < >>>>>>>> arkadiuszx.kusztal@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Date: Wed Dec 12 20:59:02 2018 +0100 >>>>>>>> >>>>>>>> Bug5: Crypto: cryptodev_qat_autotest test failed. No >>>>>>>> progress >>>>>>>> yet. >>>>>>>> 39fb9500c42752a537588f7a203433ec4737fa1e is the first >>>>>>>> bad >>>>>>>> commit >>>>>>>> commit 39fb9500c42752a537588f7a203433ec4737fa1e >>>>>>>> Author: Arek Kusztal < >>>>>>>> arkadiuszx.kusztal@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Date: Wed Dec 12 20:59:02 2018 +0100 >>>>>>>> >>>>>>>> Regards, >>>>>>>> Yu Ping >>>>>>>> >>>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: Wang, FengqinX >>>>>>>> Sent: Monday, August 26, 2019 3:12 PM >>>>>>>> To: Yongseok Koh < >>>>>>>> yskoh@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ananyev, Konstantin < >>>>>>>> >>>>>>>> konstantin.ananyev@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; >>>>>>>> >>>>>>>> asafp@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Cc: Xu, Qian Q < >>>>>>>> qian.q.xu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Lin, Xueqin < >>>>>>>> >>>>>>>> xueqin.lin@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Chen, Zhaoyan < >>>>>>>> >>>>>>>> zhaoyan.chen@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; O'Hare, Cathal < >>>>>>>> >>>>>>>> cathal.ohare@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Yigit, Ferruh < >>>>>>>> >>>>>>>> ferruh.yigit@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Yu, PingX < >>>>>>>> >>>>>>>> pingx.yu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ma, LihongX < >>>>>>>> >>>>>>>> lihongx.ma@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Li, WenjieX A < >>>>>>>> >>>>>>>> wenjiex.a.li@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Subject: RE: 17.11.7-rc1 (LTS) patches review and test >>>>>>>> >>>>>>>> Add asafp in the loop due to Yongseok is longer working >>>>>>>> at >>>>>>>> Mellanox. >>>>>>>> >>>>>>>> BRs, Vicky >>>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: Wang, FengqinX >>>>>>>> Sent: Monday, August 26, 2019 3:07 PM >>>>>>>> To: 'Yongseok Koh' < >>>>>>>> yskoh@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ananyev, Konstantin < >>>>>>>> >>>>>>>> konstantin.ananyev@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Cc: Xu, Qian Q < >>>>>>>> qian.q.xu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Lin, Xueqin < >>>>>>>> >>>>>>>> xueqin.lin@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Chen, Zhaoyan < >>>>>>>> >>>>>>>> zhaoyan.chen@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; O'Hare, Cathal < >>>>>>>> >>>>>>>> cathal.ohare@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Yigit, Ferruh < >>>>>>>> >>>>>>>> ferruh.yigit@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Yu, PingX < >>>>>>>> >>>>>>>> pingx.yu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ma, LihongX < >>>>>>>> >>>>>>>> lihongx.ma@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Li, WenjieX A < >>>>>>>> >>>>>>>> wenjiex.a.li@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Subject: RE: 17.11.7-rc1 (LTS) patches review and test >>>>>>>> >>>>>>>> Hi Yongseok, Konstantin, >>>>>>>> >>>>>>>> There is one critical compile issue found, and below is >>>>>>>> the >>>>>>>> bad >>>>>>>> commit related information, this issue has blocked most >>>>>>>> of >>>>>>>> unit >>>>>>>> tests which have used dpdk/test/test, would you please >>>>>>>> help >>>>>>>> to >>>>>>>> fix >>>>>>>> this issue ASAP? >>>>>>>> >>>>>>>> commit 29e08d740ffc1e0ed9e7a9bd25fb95714fac1070 >>>>>>>> Author: Joyce Kong < >>>>>>>> joyce.kong@arm.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Date: Thu Jul 25 14:50:21 2019 +0800 >>>>>>>> >>>>>>>> test/rwlock: benchmark on all available cores >>>>>>>> >>>>>>>> [ backported from upstream commit >>>>>>>> fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] >>>>>>>> >>>>>>>> Add performance test on all available cores to >>>>>>>> benchmark >>>>>>>> the scaling up performance of rw_lock. >>>>>>>> >>>>>>>> Fixes: af75078fece3 ("first public release") >>>>>>>> >>>>>>>> Suggested-by: Gavin Hu < >>>>>>>> gavin.hu@arm.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Signed-off-by: Joyce Kong < >>>>>>>> joyce.kong@arm.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Acked-by: Konstantin Ananyev < >>>>>>>> konstantin.ananyev@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> And below is the error message output: >>>>>>>> >>>>>>>> test_rwlock.c: In function 'load_loop_fn': >>>>>>>> test_rwlock.c:126:38: error: expected ')' before 'PRIu64' >>>>>>>> printf("Core [%u] rwlock_data = %"PRIu64"\n", ^~~~~~ >>>>>>>> ) >>>>>>>> test_rwlock.c:126:19: error: format '%u' expects a >>>>>>>> matching >>>>>>>> 'unsigned int' argument [-Werror=format=] printf("Core >>>>>>>> [%u] >>>>>>>> rwlock_data = %"PRIu64"\n", ~^ >>>>>>>> test_rwlock.c:126:36: error: spurious trailing '%' in >>>>>>>> format [- >>>>>>>> Werror=format=] printf("Core [%u] rwlock_data = >>>>>>>> %"PRIu64"\n", ^ >>>>>>>> test_rwlock.c: In function 'test_rwlock_perf': >>>>>>>> test_rwlock.c:160:31: error: expected ')' before 'PRIu64' >>>>>>>> printf("Core [%u] count = %"PRIu64"\n", i, >>>>>>>> lock_count[i]); >>>>>>>> ^~~~~~ >>>>>>>> ) >>>>>>>> test_rwlock.c:160:18: error: format '%u' expects a >>>>>>>> matching >>>>>>>> 'unsigned int' argument [-Werror=format=] printf("Core >>>>>>>> [%u] >>>>>>>> count >>>>>>>> = >>>>>>>> %"PRIu64"\n", i, lock_count[i]); ~^ >>>>>>>> test_rwlock.c:160:29: error: spurious trailing '%' in >>>>>>>> format [- >>>>>>>> Werror=format=] printf("Core [%u] count = %"PRIu64"\n", >>>>>>>> i, >>>>>>>> lock_count[i]); ^ >>>>>>>> test_rwlock.c:164:26: error: expected ')' before 'PRIu64' >>>>>>>> printf("Total count = %"PRIu64"\n", total); ^~~~~~ >>>>>>>> ) >>>>>>>> test_rwlock.c:164:24: error: spurious trailing '%' in >>>>>>>> format [- >>>>>>>> Werror=format=] printf("Total count = %"PRIu64"\n", >>>>>>>> total); >>>>>>>> ^ >>>>>>>> cc1: all warnings being treated as errors >>>>>>>> >>>>>>>> BRs, Vicky >>>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: Yongseok Koh [mailto: >>>>>>>> yskoh@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> ] >>>>>>>> Sent: Friday, August 16, 2019 2:05 AM >>>>>>>> To: dpdk stable < >>>>>>>> stable@dpdk.org >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Cc: >>>>>>>> dev@dpdk.org >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> ; >>>>>>>> pezhang@redhat.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> ; >>>>>>>> siliu@redhat.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> ; Wang, FengqinX < >>>>>>>> fengqinx.wang@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Chen, Zhaoyan < >>>>>>>> >>>>>>>> zhaoyan.chen@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Xu, Qian Q < >>>>>>>> >>>>>>>> qian.q.xu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; >>>>>>>> >>>>>>>> alialnu@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> ; >>>>>>>> rasland@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Subject: 17.11.7-rc1 (LTS) patches review and test >>>>>>>> >>>>>>>> Hi all, >>>>>>>> >>>>>>>> Here is a list of patches targeted for LTS release >>>>>>>> 17.11.7. >>>>>>>> Please >>>>>>>> help review and test. The planned date for the final >>>>>>>> release is >>>>>>>> Aug >>>>>>>> 23, Before that, please shout if anyone has objections >>>>>>>> with >>>>>>>> these >>>>>>>> patches being applied. >>>>>>>> >>>>>>>> Also for the companies committed to running regression >>>>>>>> tests, >>>>>>>> please >>>>>>>> run the tests and report any issue before the release >>>>>>>> date. >>>>>>>> >>>>>>>> A release candidate tarball can be found at: >>>>>>>> >>>>>>>> >>>>>>>> https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> These patches are located at branch 17.11 of dpdk-stable >>>>>>>> repo: >>>>>>>> >>>>>>>> https://dpdk.org/browse/dpdk-stable/ >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Yongseok >>>>>>>> >>>>>>>> --- >>>>>>>> >>>>>>>> Aaron Conole (1): >>>>>>>> net/virtio: fix dangling pointer on failure >>>>>>>> >>>>>>>> Agalya Babu RadhaKrishnan (1): >>>>>>>> doc: fix interactive commands in testpmd guide >>>>>>>> >>>>>>>> Akhil Goyal (1): >>>>>>>> crypto/dpaa2_sec: fix session clearing >>>>>>>> >>>>>>>> Alejandro Lucero (1): >>>>>>>> net/nfp: fix RSS query >>>>>>>> >>>>>>>> Anatoly Burakov (2): >>>>>>>> eal: improve musl compatibility of string functions >>>>>>>> malloc: fix documentation of realloc function >>>>>>>> >>>>>>>> Andrew Rybchenko (2): >>>>>>>> net/sfc: remove control path logging from Rx queue >>>>>>>> count >>>>>>>> app/testpmd: set fixed flag for exact link speed >>>>>>>> >>>>>>>> Andrius Sirvys (3): >>>>>>>> net/virtio: fix duplicate naming of include guard >>>>>>>> bitrate: fix unchecked return value >>>>>>>> drivers/net: fix shifting 32-bit signed variable 31 >>>>>>>> times >>>>>>>> >>>>>>>> Anoob Joseph (1): >>>>>>>> cryptodev: fix driver name comparison >>>>>>>> >>>>>>>> Beilei Xing (1): >>>>>>>> net/i40e: fix link speed for X722 >>>>>>>> >>>>>>>> Bernard Iremonger (1): >>>>>>>> examples/ipsec-secgw: fix debug logs >>>>>>>> >>>>>>>> Bill Hong (1): >>>>>>>> net: fix Tx VLAN flag for offload emulation >>>>>>>> >>>>>>>> Bruce Richardson (9): >>>>>>>> eal: support strlcat function >>>>>>>> net/bonding: fix buffer length when printing >>>>>>>> strings >>>>>>>> examples/l2fwd-cat: fix build on FreeBSD >>>>>>>> app/crypto-perf: check range of socket id >>>>>>>> examples/vhost_scsi: fix null-check for parameter >>>>>>>> net/i40e: fix dereference before null check in mbuf >>>>>>>> release >>>>>>>> net/ixgbe: fix warning with GCC 9 >>>>>>>> bus/fslmc: fix warning with GCC 9 >>>>>>>> eal: tighten permissions on shared memory files >>>>>>>> >>>>>>>> Chaitanya Babu Talluri (2): >>>>>>>> drivers/net: fix possible overflow using strlcat >>>>>>>> cfgfile: replace strcat with strlcat >>>>>>>> >>>>>>>> David Christensen (2): >>>>>>>> maintainers: update for IBM POWER >>>>>>>> examples/vm_power_manager: fix PMD specific code >>>>>>>> >>>>>>>> David Marchand (7): >>>>>>>> eal: fix check when retrieving current CPU affinity >>>>>>>> eal: remove dead code in core list parsing >>>>>>>> app/testpmd: remove unused field from port struct >>>>>>>> doc: fix examples in bonding guide >>>>>>>> net/bonding: fix port id types >>>>>>>> net/bonding: fix queue index types >>>>>>>> app/testpmd: remove useless casts on statistics >>>>>>>> >>>>>>>> Davide Caratti (1): >>>>>>>> net/bnxt: support IOVA VA mode >>>>>>>> >>>>>>>> Dekel Peled (8): >>>>>>>> net/mlx5: fix hex dump of error completion >>>>>>>> net/mlx5: fix sync when handling Tx completions >>>>>>>> eal/ppc: fix global memory barrier >>>>>>>> eal: fix typo in comment of vector function >>>>>>>> doc: fix links to doxygen and sphinx sites >>>>>>>> app/testpmd: fix typo in comment >>>>>>>> net/mlx5: fix comments mixing Rx and Tx >>>>>>>> net/mlx5: fix release of Rx queue object >>>>>>>> >>>>>>>> Fan Zhang (1): >>>>>>>> examples/ipsec-secgw: fix AES-CTR block size >>>>>>>> >>>>>>>> Ferruh Yigit (5): >>>>>>>> kni: fix build with Linux 5.1 >>>>>>>> build: fix crash by disabling AVX512 with binutils >>>>>>>> 2.31 >>>>>>>> net/ring: fix return value check >>>>>>>> net/kni: fix return value check >>>>>>>> app/testpmd: revert fixed flag for exact link speed >>>>>>>> >>>>>>>> Gage Eads (1): >>>>>>>> ring: fix namesize macro documentation block >>>>>>>> >>>>>>>> Gavin Hu (3): >>>>>>>> test/spinlock: remove delay for correct >>>>>>>> benchmarking >>>>>>>> test/spinlock: amortize the cost of getting time >>>>>>>> spinlock: reimplement with atomic one-way barrier >>>>>>>> >>>>>>>> Hari Kumar Vemula (1): >>>>>>>> net/bonding: fix reset active slave >>>>>>>> >>>>>>>> Harry van Haaren (1): >>>>>>>> event/sw: fix enqueue checks in self-test >>>>>>>> >>>>>>>> Herakliusz Lipiec (1): >>>>>>>> doc: fix broken link in LPM guide >>>>>>>> >>>>>>>> Hyong Youb Kim (4): >>>>>>>> net/bonding: avoid warning for invalid port >>>>>>>> net/enic: fix flow director SCTP matching >>>>>>>> net/enic: fix SCTP match for flow API >>>>>>>> net/enic: check for unsupported flow item types >>>>>>>> >>>>>>>> Igor Romanov (1): >>>>>>>> app/testpmd: fix stdout flush after printing stats >>>>>>>> >>>>>>>> Ilya Maximets (2): >>>>>>>> vhost: fix device leak on connection add failure >>>>>>>> vhost: fix silent queue enabling with legacy guests >>>>>>>> >>>>>>>> Ivan Malov (1): >>>>>>>> net/sfc: log port ID as 16-bit unsigned integer on >>>>>>>> panic >>>>>>>> >>>>>>>> Jerin Jacob (1): >>>>>>>> mk: fix AVX512 disabled warning on non x86 >>>>>>>> >>>>>>>> Jianfeng Tan (1): >>>>>>>> drivers/net: do not use private ethdev data >>>>>>>> >>>>>>>> Joyce Kong (1): >>>>>>>> test/rwlock: benchmark on all available cores >>>>>>>> >>>>>>>> Kevin Traynor (3): >>>>>>>> net/qede: support IOVA VA mode >>>>>>>> eal/linux: fix log levels for pagemap reading >>>>>>>> failure >>>>>>>> power: fix frequency list buffer validation >>>>>>>> >>>>>>>> Liang Zhang (1): >>>>>>>> net/bonding: fix LACP negotiation >>>>>>>> >>>>>>>> Luo Gaoliang (1): >>>>>>>> kni: fix build on RHEL8 >>>>>>>> >>>>>>>> Marcin Smoczynski (1): >>>>>>>> examples/ipsec-secgw: fix build error log >>>>>>>> >>>>>>>> Natanael Copa (3): >>>>>>>> bus/fslmc: remove unused include of error.h >>>>>>>> bus/fslmc: fix build with musl libc >>>>>>>> app/test: fix build with musl libc >>>>>>>> >>>>>>>> Pallantla Poornima (3): >>>>>>>> app/test: fix sprintf with strlcat >>>>>>>> test/distributor: replace sprintf with strlcpy >>>>>>>> test/hash: replace sprintf with snprintf >>>>>>>> >>>>>>>> Qi Zhang (1): >>>>>>>> net/i40e: fix time sync for 25G >>>>>>>> >>>>>>>> Radu Nicolau (3): >>>>>>>> net/null: add MAC address setting fake operation >>>>>>>> test/virtual_pmd: add MAC address setting fake op >>>>>>>> test/bonding: assign non-zero MAC to null devices >>>>>>>> >>>>>>>> Rahul Lakkireddy (1): >>>>>>>> net/cxgbe: update Chelsio T5/T6 NIC device ids >>>>>>>> >>>>>>>> Rami Rosen (8): >>>>>>>> net/virtio: remove forward declaration >>>>>>>> mbuf: fix a typo >>>>>>>> doc: fix a minor typo in testpmd guide >>>>>>>> doc: remove reference to rte.doc.mk in programmers >>>>>>>> guide >>>>>>>> examples/ethtool: fix two typos >>>>>>>> doc: fix link in Linux getting started guide >>>>>>>> app/testpmd: fix a typo in log message >>>>>>>> ethdev: fix a typo >>>>>>>> >>>>>>>> Rasesh Mody (2): >>>>>>>> net/bnx2x: fix race for periodic flags >>>>>>>> net/bnx2x: fix optic module verification >>>>>>>> >>>>>>>> Shahaf Shuler (1): >>>>>>>> net/mlx5: fix packet inline on Tx queue wraparound >>>>>>>> >>>>>>>> Shahed Shaikh (5): >>>>>>>> net/bnx2x: fix segfaults due to stale interrupt >>>>>>>> status >>>>>>>> net/bnx2x: fix memory leak >>>>>>>> net/bnx2x: fix ramrod timeout >>>>>>>> net/bnx2x: fix DMAE timeout >>>>>>>> net/qede: fix Tx packet prepare for tunnel packets >>>>>>>> >>>>>>>> Shreyansh Jain (1): >>>>>>>> bus/dpaa: fix Rx discard register mask >>>>>>>> >>>>>>>> Stephen Hemminger (8): >>>>>>>> net/octeontx: fix vdev name >>>>>>>> net/bnxt: fix Rx VLAN offload flags >>>>>>>> net/virtio: remove useless condition >>>>>>>> ring: fix an error message >>>>>>>> net/ring: avoid hard-coded length >>>>>>>> net/ring: use calloc style where appropriate >>>>>>>> net/ring: check length of ring name >>>>>>>> net/virtio: fix buffer leak on VLAN insert >>>>>>>> >>>>>>>> Thomas Monjalon (2): >>>>>>>> mk: fix build of shared library with libbsd >>>>>>>> bus/vdev: fix debug message on probing >>>>>>>> >>>>>>>> Tiwei Bie (4): >>>>>>>> net/virtio: add barrier in interrupt enable >>>>>>>> vhost: restore mbuf first when freeing zmbuf >>>>>>>> vhost: fix potential use-after-free for zero copy >>>>>>>> mbuf >>>>>>>> vhost: fix potential use-after-free for memory >>>>>>>> region >>>>>>>> >>>>>>>> Vishal Kulkarni (1): >>>>>>>> net/cxgbe: fix missing checksum flags and packet >>>>>>>> type >>>>>>>> >>>>>>>> Xiao Wang (1): >>>>>>>> net/fm10k: fix VLAN strip offload flag >>>>>>>> >>>>>>>> Yipeng Wang (1): >>>>>>>> hash: fix doc about thread/process safety >>>>>>>> >>>>>>>> Yongseok Koh (4): >>>>>>>> net/mlx5: fix instruction hotspot on replenishing >>>>>>>> Rx >>>>>>>> buffer >>>>>>>> net/mlx5: check Tx queue size overflow >>>>>>>> net/mlx5: fix max number of queues for NEON Tx >>>>>>>> doc: fix typo in mlx5 guide >>>>>>>> >>>>>>>> Yunjian Wang (1): >>>>>>>> net/ixgbe: fix crash on remove >>>>>>>> >>>>>>>> >>>>>> >>>>>> -- >>>>>> Kind regards, >>>>>> Luca Boccassi >>>>>> >>> >>> >>> ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test 2019-09-26 8:15 ` Yu, PingX @ 2019-09-26 8:19 ` Luca Boccassi 0 siblings, 0 replies; 19+ messages in thread From: Luca Boccassi @ 2019-09-26 8:19 UTC (permalink / raw) To: Yu, PingX, Yigit, Ferruh, Kevin Traynor, Mcnamara, John, Kusztal, ArkadiuszX Cc: Peng, Yuan, dev, Xu, Qian Q Hello, The patch was just sent to the stable mailing list minutes ago. I have applied it and I'll do a quick build test. We can discuss in the release meeting whether we should do an rc2 or go straight to release. Thank you all for your help! On Thu, 2019-09-26 at 08:15 +0000, Yu, PingX wrote: > Ferruh, > Kusztal, ArkadiuszX will send the patch to 17.11 and paste the patch > link later. > > Regards, > Yu Ping > > > -----Original Message----- > From: Yigit, Ferruh > Sent: Thursday, September 26, 2019 3:38 PM > To: Yu, PingX < > pingx.yu@intel.com > >; Luca Boccassi < > bluca@debian.org > >; Kevin Traynor < > ktraynor@redhat.com > >; Mcnamara, John < > john.mcnamara@intel.com > >; Kusztal, ArkadiuszX < > arkadiuszx.kusztal@intel.com > > > Cc: Peng, Yuan < > yuan.peng@intel.com > >; > dev@dpdk.org > ; Xu, Qian Q < > qian.q.xu@intel.com > > > Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test > > On 9/26/2019 8:34 AM, Yu, PingX wrote: > > Luca, > > 1. Latest 17.11 branch is verified passed for feature PF. No issue > > now. > > 2. bugs 3/4/5 are fixed now by > > arkadiuszx.kusztal@intel.com > > 's patch. No issue now. > > Can you please share the link of the mentioned patch? > > > Regards, > > Yu Ping > > > > -----Original Message----- > > From: Luca Boccassi [mailto: > > bluca@debian.org > > ] > > Sent: Wednesday, September 25, 2019 4:08 AM > > To: Kevin Traynor < > > ktraynor@redhat.com > > >; Yigit, Ferruh > > < > > ferruh.yigit@intel.com > > >; Mcnamara, John < > > john.mcnamara@intel.com > > > > > Cc: Yu, PingX < > > pingx.yu@intel.com > > >; Peng, Yuan < > > yuan.peng@intel.com > > >; > > dev@dpdk.org > > ; Xu, Qian Q < > > qian.q.xu@intel.com > > > > > Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and > > test > > > > Yu Ping, Qian, > > > > I have pushed to the 17.11 branch with the fixes for 1 and 2, and > > for building with kernel 5.3 (just a change in the comments, > > nothing functional). Do you need to re-run the test suite, or are > > you confident enough with a quick check? > > > > This release is already quite late, is it OK if bugs 3/4/5 are > > postponed to the next release? > > > > On Tue, 2019-09-24 at 18:25 +0100, Luca Boccassi wrote: > > > On Tue, 2019-09-24 at 18:15 +0100, Kevin Traynor wrote: > > > > On 24/09/2019 17:36, Ferruh Yigit wrote: > > > > > On 9/24/2019 12:07 PM, Luca Boccassi wrote: > > > > > > Ping - any updates on these patches? The release of 17.11.7 > > > > > > is > > > > > > currently on hold waiting for a resolution here. > > > > > > > > > > Hi Luca, > > > > > > > > > > Test team provided some internal details: > > > > > > > > > > 1- Build issue on f30, > > > > > A patch has been sent to stable mail list to fix it, not sure > > > > > if it > > > > > has been > > > > > merged: > > > > > https://mails.dpdk.org/archives/stable/2019-September/017122.html > > > > > > > > > > > > > > > > > > > > > Thanks Ferruh, I am testing a build with that one. > > > > > > > > 2- "make -C test/" fails. > > > > > "Fix looks to be to add "#include <inttypes.h>" into > > > > > test_rwlock.c" > > > > > Not sure if there is a patch for this. > > > > > > > > Hi, this include was added in 18.11 as part of: > > > > > > > > commit 0d0dfaaff93cb599b2c58fd6fe405fd4f44b5710 > > > > Author: Joyce Kong < > > > > joyce.kong@arm.com > > > > > > > > > > > > > > > > Date: Tue Sep 10 11:36:58 2019 +0800 > > > > > > > > test/rwlock: benchmark on all available cores > > > > > > > > [ upstream commit fe252fb695efa9deb95f2e6b7baf6f805996a5b0 > > > > ] > > > > > > > > > > > > Note, the master commit would not apply and it was a custom > > > > backport > > > > for > > > > 18.11 by Joyce > > > > ( > > > > http://inbox.dpdk.org/stable/1568086619-5029-1-git-send-email-joyce > > > > . > > > > kong@arm.com > > > > > > > > > > > > ) > > > > Maybe it can work for 17.11 too? > > > > > > Hi, > > > > > > It was backported for 17.11 too, but it does not have the > > > include. > > > I'll > > > test another commits that has it. > > > > > > > > 3- l2fwd-crypto, ERROR: Test Case > > > > > test_qat_h_AES_XCBC_MAC_auto > > > > > Result FAILED Work in progress > > > > > > > > > > 4- ipsec-secgw, forwarding failed with null crypto QAT Work > > > > > in > > > > > progress > > > > > > > > > > 5- Unit test "cryptodev_qat_autotest" failed Issue not > > > > > analyzed > > > > > yet. > > > > > > > > > > > > > > > > Thanks! > > > > > > > > > > > > On Wed, 2019-09-18 at 10:03 +0000, Yu, PingX wrote: > > > > > > > Luca, > > > > > > > FYI. Currently there isn't reference for bug1 and bug2 > > > > > > > and also > > > > > > > haven't send to mailing list yet. These bugs should be > > > > > > > fixed > > > > > > > before release as they will block the basic PF test. > > > > > > > > > > > > > > Regards, > > > > > > > Yu Ping > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: dev [mailto: > > > > > > > dev-bounces@dpdk.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > ] On Behalf Of Luca Boccassi > > > > > > > Sent: Wednesday, September 18, 2019 5:18 PM > > > > > > > To: Peng, Yuan < > > > > > > > yuan.peng@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > > > > > > > > dev@dpdk.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches > > > > > > > review and > > > > > > > test > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > Ping - this is blocking the 17.11.7 release. > > > > > > > > > > > > > > Thanks! > > > > > > > > > > > > > > On Tue, 2019-09-17 at 10:53 +0100, Luca Boccassi wrote: > > > > > > > > Hello, > > > > > > > > > > > > > > > > Do you have a reference for the patches for bug 1 and > > > > > > > > 2? > > > > > > > > Have > > > > > > > > they > > > > > > > > been sent to the mailing list? > > > > > > > > > > > > > > > > On Thu, 2019-09-12 at 08:52 +0000, Peng, Yuan wrote: > > > > > > > > > Update the latest test status here. > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > From: Yu, PingX > > > > > > > > > Sent: Thursday, September 12, 2019 2:37 PM > > > > > > > > > To: Yongseok Koh < > > > > > > > > > yskoh@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ananyev, Konstantin < > > > > > > > > > > > > > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > > > > > > > > > > > > asafp@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cc: Xu, Qian Q < > > > > > > > > > qian.q.xu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Lin, Xueqin < > > > > > > > > > > > > > > > > > > xueqin.lin@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > > > > > > > > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; O'Hare, Cathal < > > > > > > > > > > > > > > > > > > cathal.ohare@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Yigit, Ferruh < > > > > > > > > > > > > > > > > > > ferruh.yigit@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ma, LihongX < > > > > > > > > > > > > > > > > > > lihongx.ma@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Li, WenjieX A < > > > > > > > > > > > > > > > > > > wenjiex.a.li@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Wang, FengqinX < > > > > > > > > > > > > > > > > > > fengqinx.wang@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Peng, Yuan < > > > > > > > > > > > > > > > > > > yuan.peng@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and > > > > > > > > > test > > > > > > > > > > > > > > > > > > All, > > > > > > > > > Update the latest test status here. > > > > > > > > > The critical bug has been fixed and we have re-tested > > > > > > > > > all Intel > > > > > > > > > key features. > > > > > > > > > > > > > > > > > > Intel(R) Testing result lists here. > > > > > > > > > # Basic Intel(R) NIC testing > > > > > > > > > * PF(i40e): One bug found in 1st round test. 2nd > > > > > > > > > round test > > > > > > > > > pass after fixing the bug. (see Bug1) > > > > > > > > > * PF(ixgbe): the same as PF(i40e). > > > > > > > > > * VF: Pass and no issue. > > > > > > > > > * Build or compile: One bug found in 1st round test. > > > > > > > > > 2nd round > > > > > > > > > test pass after fixing the bug. (see Bug2) > > > > > > > > > * Intel NIC single core/NIC performance: Pass and no > > > > > > > > > issue. > > > > > > > > > > > > > > > > > > #Basic cryptodev and virtio testing > > > > > > > > > * vhost/virtio basic loopback, PVP and performance > > > > > > > > > test: > > > > > > > > > pass. > > > > > > > > > * cryptodev: 3 bugs are found(see bug statistic in > > > > > > > > > below). > > > > > > > > > (See > > > > > > > > > Bug3,4 and 5) > > > > > > > > > > > > > > > > > > Bugs statistic: > > > > > > > > > Bug1: make -C test/ failed. It blocked about 60 test > > > > > > > > > cases > > > > > > > > > for > > > > > > > > > both > > > > > > > > > PF(i40e) and PF(ixgbe). Resolved by adding "#include > > > > > > > > > <inttypes.h>" > > > > > > > > > into test_rwlock.c. Please decide whether submit a > > > > > > > > > patch > > > > > > > > > to > > > > > > > > > DPDK > > > > > > > > > or > > > > > > > > > not. > > > > > > > > > Bug2: compile error on fc30. Patch is provided and > > > > > > > > > validated > > > > > > > > > pass. > > > > > > > > > Need to decide whether merge into DPDK or not. > > > > > > > > > Bug3: L2fwd: test_qat_h_AES_XCBC_MAC_auto failed. No > > > > > > > > > progress > > > > > > > > > yet. > > > > > > > > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > > > > > > > > Author: Arek Kusztal < > > > > > > > > > arkadiuszx.kusztal@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > > > > > > > > > > > > > > > Bug4: Ipsec-gw_test forwarding failed with null > > > > > > > > > crypto > > > > > > > > > QAT. > > > > > > > > > No > > > > > > > > > progress yet. > > > > > > > > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > > > > > > > > Author: Arek Kusztal < > > > > > > > > > arkadiuszx.kusztal@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > > > > > > > > > > > > > > > Bug5: Crypto: cryptodev_qat_autotest test failed. No > > > > > > > > > progress > > > > > > > > > yet. > > > > > > > > > 39fb9500c42752a537588f7a203433ec4737fa1e is the > > > > > > > > > first > > > > > > > > > bad > > > > > > > > > commit > > > > > > > > > commit 39fb9500c42752a537588f7a203433ec4737fa1e > > > > > > > > > Author: Arek Kusztal < > > > > > > > > > arkadiuszx.kusztal@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Wed Dec 12 20:59:02 2018 +0100 > > > > > > > > > > > > > > > > > > Regards, > > > > > > > > > Yu Ping > > > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > From: Wang, FengqinX > > > > > > > > > Sent: Monday, August 26, 2019 3:12 PM > > > > > > > > > To: Yongseok Koh < > > > > > > > > > yskoh@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ananyev, Konstantin < > > > > > > > > > > > > > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > > > > > > > > > > > > asafp@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cc: Xu, Qian Q < > > > > > > > > > qian.q.xu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Lin, Xueqin < > > > > > > > > > > > > > > > > > > xueqin.lin@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > > > > > > > > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; O'Hare, Cathal < > > > > > > > > > > > > > > > > > > cathal.ohare@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Yigit, Ferruh < > > > > > > > > > > > > > > > > > > ferruh.yigit@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Yu, PingX < > > > > > > > > > > > > > > > > > > pingx.yu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ma, LihongX < > > > > > > > > > > > > > > > > > > lihongx.ma@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Li, WenjieX A < > > > > > > > > > > > > > > > > > > wenjiex.a.li@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and > > > > > > > > > test > > > > > > > > > > > > > > > > > > Add asafp in the loop due to Yongseok is longer > > > > > > > > > working > > > > > > > > > at > > > > > > > > > Mellanox. > > > > > > > > > > > > > > > > > > BRs, Vicky > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > From: Wang, FengqinX > > > > > > > > > Sent: Monday, August 26, 2019 3:07 PM > > > > > > > > > To: 'Yongseok Koh' < > > > > > > > > > yskoh@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ananyev, Konstantin < > > > > > > > > > > > > > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cc: Xu, Qian Q < > > > > > > > > > qian.q.xu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Lin, Xueqin < > > > > > > > > > > > > > > > > > > xueqin.lin@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > > > > > > > > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; O'Hare, Cathal < > > > > > > > > > > > > > > > > > > cathal.ohare@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Yigit, Ferruh < > > > > > > > > > > > > > > > > > > ferruh.yigit@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Yu, PingX < > > > > > > > > > > > > > > > > > > pingx.yu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Ma, LihongX < > > > > > > > > > > > > > > > > > > lihongx.ma@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Li, WenjieX A < > > > > > > > > > > > > > > > > > > wenjiex.a.li@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Subject: RE: 17.11.7-rc1 (LTS) patches review and > > > > > > > > > test > > > > > > > > > > > > > > > > > > Hi Yongseok, Konstantin, > > > > > > > > > > > > > > > > > > There is one critical compile issue found, and below > > > > > > > > > is > > > > > > > > > the > > > > > > > > > bad > > > > > > > > > commit related information, this issue has blocked > > > > > > > > > most > > > > > > > > > of > > > > > > > > > unit > > > > > > > > > tests which have used dpdk/test/test, would you > > > > > > > > > please > > > > > > > > > help > > > > > > > > > to > > > > > > > > > fix > > > > > > > > > this issue ASAP? > > > > > > > > > > > > > > > > > > commit 29e08d740ffc1e0ed9e7a9bd25fb95714fac1070 > > > > > > > > > Author: Joyce Kong < > > > > > > > > > joyce.kong@arm.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Date: Thu Jul 25 14:50:21 2019 +0800 > > > > > > > > > > > > > > > > > > test/rwlock: benchmark on all available cores > > > > > > > > > > > > > > > > > > [ backported from upstream commit > > > > > > > > > fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] > > > > > > > > > > > > > > > > > > Add performance test on all available cores to > > > > > > > > > benchmark > > > > > > > > > the scaling up performance of rw_lock. > > > > > > > > > > > > > > > > > > Fixes: af75078fece3 ("first public release") > > > > > > > > > > > > > > > > > > Suggested-by: Gavin Hu < > > > > > > > > > gavin.hu@arm.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Joyce Kong < > > > > > > > > > joyce.kong@arm.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Acked-by: Konstantin Ananyev < > > > > > > > > > konstantin.ananyev@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > And below is the error message output: > > > > > > > > > > > > > > > > > > test_rwlock.c: In function 'load_loop_fn': > > > > > > > > > test_rwlock.c:126:38: error: expected ')' before > > > > > > > > > 'PRIu64' > > > > > > > > > printf("Core [%u] rwlock_data = %"PRIu64"\n", ^~~~~~ > > > > > > > > > ) > > > > > > > > > test_rwlock.c:126:19: error: format '%u' expects a > > > > > > > > > matching > > > > > > > > > 'unsigned int' argument [-Werror=format=] > > > > > > > > > printf("Core > > > > > > > > > [%u] > > > > > > > > > rwlock_data = %"PRIu64"\n", ~^ > > > > > > > > > test_rwlock.c:126:36: error: spurious trailing '%' in > > > > > > > > > format [- > > > > > > > > > Werror=format=] printf("Core [%u] rwlock_data = > > > > > > > > > %"PRIu64"\n", ^ > > > > > > > > > test_rwlock.c: In function 'test_rwlock_perf': > > > > > > > > > test_rwlock.c:160:31: error: expected ')' before > > > > > > > > > 'PRIu64' > > > > > > > > > printf("Core [%u] count = %"PRIu64"\n", i, > > > > > > > > > lock_count[i]); > > > > > > > > > ^~~~~~ > > > > > > > > > ) > > > > > > > > > test_rwlock.c:160:18: error: format '%u' expects a > > > > > > > > > matching > > > > > > > > > 'unsigned int' argument [-Werror=format=] > > > > > > > > > printf("Core > > > > > > > > > [%u] > > > > > > > > > count > > > > > > > > > = > > > > > > > > > %"PRIu64"\n", i, lock_count[i]); ~^ > > > > > > > > > test_rwlock.c:160:29: error: spurious trailing '%' in > > > > > > > > > format [- > > > > > > > > > Werror=format=] printf("Core [%u] count = > > > > > > > > > %"PRIu64"\n", > > > > > > > > > i, > > > > > > > > > lock_count[i]); ^ > > > > > > > > > test_rwlock.c:164:26: error: expected ')' before > > > > > > > > > 'PRIu64' > > > > > > > > > printf("Total count = %"PRIu64"\n", total); ^~~~~~ > > > > > > > > > ) > > > > > > > > > test_rwlock.c:164:24: error: spurious trailing '%' in > > > > > > > > > format [- > > > > > > > > > Werror=format=] printf("Total count = %"PRIu64"\n", > > > > > > > > > total); > > > > > > > > > ^ > > > > > > > > > cc1: all warnings being treated as errors > > > > > > > > > > > > > > > > > > BRs, Vicky > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > From: Yongseok Koh [mailto: > > > > > > > > > yskoh@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ] > > > > > > > > > Sent: Friday, August 16, 2019 2:05 AM > > > > > > > > > To: dpdk stable < > > > > > > > > > stable@dpdk.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Cc: > > > > > > > > > dev@dpdk.org > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > > > pezhang@redhat.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > > > siliu@redhat.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Wang, FengqinX < > > > > > > > > > fengqinx.wang@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Chen, Zhaoyan < > > > > > > > > > > > > > > > > > > zhaoyan.chen@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; Xu, Qian Q < > > > > > > > > > > > > > > > > > > qian.q.xu@intel.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > > > > > > > > > > > > alialnu@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ; > > > > > > > > > rasland@mellanox.com > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Subject: 17.11.7-rc1 (LTS) patches review and test > > > > > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > > > Here is a list of patches targeted for LTS release > > > > > > > > > 17.11.7. > > > > > > > > > Please > > > > > > > > > help review and test. The planned date for the final > > > > > > > > > release is > > > > > > > > > Aug > > > > > > > > > 23, Before that, please shout if anyone has > > > > > > > > > objections > > > > > > > > > with > > > > > > > > > these > > > > > > > > > patches being applied. > > > > > > > > > > > > > > > > > > Also for the companies committed to running > > > > > > > > > regression > > > > > > > > > tests, > > > > > > > > > please > > > > > > > > > run the tests and report any issue before the release > > > > > > > > > date. > > > > > > > > > > > > > > > > > > A release candidate tarball can be found at: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > These patches are located at branch 17.11 of dpdk- > > > > > > > > > stable > > > > > > > > > repo: > > > > > > > > > > > > > > > > > > https://dpdk.org/browse/dpdk-stable/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > Yongseok > > > > > > > > > > > > > > > > > > --- > > > > > > > > > > > > > > > > > > Aaron Conole (1): > > > > > > > > > net/virtio: fix dangling pointer on failure > > > > > > > > > > > > > > > > > > Agalya Babu RadhaKrishnan (1): > > > > > > > > > doc: fix interactive commands in testpmd guide > > > > > > > > > > > > > > > > > > Akhil Goyal (1): > > > > > > > > > crypto/dpaa2_sec: fix session clearing > > > > > > > > > > > > > > > > > > Alejandro Lucero (1): > > > > > > > > > net/nfp: fix RSS query > > > > > > > > > > > > > > > > > > Anatoly Burakov (2): > > > > > > > > > eal: improve musl compatibility of string > > > > > > > > > functions > > > > > > > > > malloc: fix documentation of realloc function > > > > > > > > > > > > > > > > > > Andrew Rybchenko (2): > > > > > > > > > net/sfc: remove control path logging from Rx > > > > > > > > > queue > > > > > > > > > count > > > > > > > > > app/testpmd: set fixed flag for exact link > > > > > > > > > speed > > > > > > > > > > > > > > > > > > Andrius Sirvys (3): > > > > > > > > > net/virtio: fix duplicate naming of include > > > > > > > > > guard > > > > > > > > > bitrate: fix unchecked return value > > > > > > > > > drivers/net: fix shifting 32-bit signed > > > > > > > > > variable 31 > > > > > > > > > times > > > > > > > > > > > > > > > > > > Anoob Joseph (1): > > > > > > > > > cryptodev: fix driver name comparison > > > > > > > > > > > > > > > > > > Beilei Xing (1): > > > > > > > > > net/i40e: fix link speed for X722 > > > > > > > > > > > > > > > > > > Bernard Iremonger (1): > > > > > > > > > examples/ipsec-secgw: fix debug logs > > > > > > > > > > > > > > > > > > Bill Hong (1): > > > > > > > > > net: fix Tx VLAN flag for offload emulation > > > > > > > > > > > > > > > > > > Bruce Richardson (9): > > > > > > > > > eal: support strlcat function > > > > > > > > > net/bonding: fix buffer length when printing > > > > > > > > > strings > > > > > > > > > examples/l2fwd-cat: fix build on FreeBSD > > > > > > > > > app/crypto-perf: check range of socket id > > > > > > > > > examples/vhost_scsi: fix null-check for > > > > > > > > > parameter > > > > > > > > > net/i40e: fix dereference before null check in > > > > > > > > > mbuf > > > > > > > > > release > > > > > > > > > net/ixgbe: fix warning with GCC 9 > > > > > > > > > bus/fslmc: fix warning with GCC 9 > > > > > > > > > eal: tighten permissions on shared memory files > > > > > > > > > > > > > > > > > > Chaitanya Babu Talluri (2): > > > > > > > > > drivers/net: fix possible overflow using > > > > > > > > > strlcat > > > > > > > > > cfgfile: replace strcat with strlcat > > > > > > > > > > > > > > > > > > David Christensen (2): > > > > > > > > > maintainers: update for IBM POWER > > > > > > > > > examples/vm_power_manager: fix PMD specific > > > > > > > > > code > > > > > > > > > > > > > > > > > > David Marchand (7): > > > > > > > > > eal: fix check when retrieving current CPU > > > > > > > > > affinity > > > > > > > > > eal: remove dead code in core list parsing > > > > > > > > > app/testpmd: remove unused field from port > > > > > > > > > struct > > > > > > > > > doc: fix examples in bonding guide > > > > > > > > > net/bonding: fix port id types > > > > > > > > > net/bonding: fix queue index types > > > > > > > > > app/testpmd: remove useless casts on statistics > > > > > > > > > > > > > > > > > > Davide Caratti (1): > > > > > > > > > net/bnxt: support IOVA VA mode > > > > > > > > > > > > > > > > > > Dekel Peled (8): > > > > > > > > > net/mlx5: fix hex dump of error completion > > > > > > > > > net/mlx5: fix sync when handling Tx completions > > > > > > > > > eal/ppc: fix global memory barrier > > > > > > > > > eal: fix typo in comment of vector function > > > > > > > > > doc: fix links to doxygen and sphinx sites > > > > > > > > > app/testpmd: fix typo in comment > > > > > > > > > net/mlx5: fix comments mixing Rx and Tx > > > > > > > > > net/mlx5: fix release of Rx queue object > > > > > > > > > > > > > > > > > > Fan Zhang (1): > > > > > > > > > examples/ipsec-secgw: fix AES-CTR block size > > > > > > > > > > > > > > > > > > Ferruh Yigit (5): > > > > > > > > > kni: fix build with Linux 5.1 > > > > > > > > > build: fix crash by disabling AVX512 with > > > > > > > > > binutils > > > > > > > > > 2.31 > > > > > > > > > net/ring: fix return value check > > > > > > > > > net/kni: fix return value check > > > > > > > > > app/testpmd: revert fixed flag for exact link > > > > > > > > > speed > > > > > > > > > > > > > > > > > > Gage Eads (1): > > > > > > > > > ring: fix namesize macro documentation block > > > > > > > > > > > > > > > > > > Gavin Hu (3): > > > > > > > > > test/spinlock: remove delay for correct > > > > > > > > > benchmarking > > > > > > > > > test/spinlock: amortize the cost of getting > > > > > > > > > time > > > > > > > > > spinlock: reimplement with atomic one-way > > > > > > > > > barrier > > > > > > > > > > > > > > > > > > Hari Kumar Vemula (1): > > > > > > > > > net/bonding: fix reset active slave > > > > > > > > > > > > > > > > > > Harry van Haaren (1): > > > > > > > > > event/sw: fix enqueue checks in self-test > > > > > > > > > > > > > > > > > > Herakliusz Lipiec (1): > > > > > > > > > doc: fix broken link in LPM guide > > > > > > > > > > > > > > > > > > Hyong Youb Kim (4): > > > > > > > > > net/bonding: avoid warning for invalid port > > > > > > > > > net/enic: fix flow director SCTP matching > > > > > > > > > net/enic: fix SCTP match for flow API > > > > > > > > > net/enic: check for unsupported flow item types > > > > > > > > > > > > > > > > > > Igor Romanov (1): > > > > > > > > > app/testpmd: fix stdout flush after printing > > > > > > > > > stats > > > > > > > > > > > > > > > > > > Ilya Maximets (2): > > > > > > > > > vhost: fix device leak on connection add > > > > > > > > > failure > > > > > > > > > vhost: fix silent queue enabling with legacy > > > > > > > > > guests > > > > > > > > > > > > > > > > > > Ivan Malov (1): > > > > > > > > > net/sfc: log port ID as 16-bit unsigned integer > > > > > > > > > on > > > > > > > > > panic > > > > > > > > > > > > > > > > > > Jerin Jacob (1): > > > > > > > > > mk: fix AVX512 disabled warning on non x86 > > > > > > > > > > > > > > > > > > Jianfeng Tan (1): > > > > > > > > > drivers/net: do not use private ethdev data > > > > > > > > > > > > > > > > > > Joyce Kong (1): > > > > > > > > > test/rwlock: benchmark on all available cores > > > > > > > > > > > > > > > > > > Kevin Traynor (3): > > > > > > > > > net/qede: support IOVA VA mode > > > > > > > > > eal/linux: fix log levels for pagemap reading > > > > > > > > > failure > > > > > > > > > power: fix frequency list buffer validation > > > > > > > > > > > > > > > > > > Liang Zhang (1): > > > > > > > > > net/bonding: fix LACP negotiation > > > > > > > > > > > > > > > > > > Luo Gaoliang (1): > > > > > > > > > kni: fix build on RHEL8 > > > > > > > > > > > > > > > > > > Marcin Smoczynski (1): > > > > > > > > > examples/ipsec-secgw: fix build error log > > > > > > > > > > > > > > > > > > Natanael Copa (3): > > > > > > > > > bus/fslmc: remove unused include of error.h > > > > > > > > > bus/fslmc: fix build with musl libc > > > > > > > > > app/test: fix build with musl libc > > > > > > > > > > > > > > > > > > Pallantla Poornima (3): > > > > > > > > > app/test: fix sprintf with strlcat > > > > > > > > > test/distributor: replace sprintf with strlcpy > > > > > > > > > test/hash: replace sprintf with snprintf > > > > > > > > > > > > > > > > > > Qi Zhang (1): > > > > > > > > > net/i40e: fix time sync for 25G > > > > > > > > > > > > > > > > > > Radu Nicolau (3): > > > > > > > > > net/null: add MAC address setting fake > > > > > > > > > operation > > > > > > > > > test/virtual_pmd: add MAC address setting fake > > > > > > > > > op > > > > > > > > > test/bonding: assign non-zero MAC to null > > > > > > > > > devices > > > > > > > > > > > > > > > > > > Rahul Lakkireddy (1): > > > > > > > > > net/cxgbe: update Chelsio T5/T6 NIC device ids > > > > > > > > > > > > > > > > > > Rami Rosen (8): > > > > > > > > > net/virtio: remove forward declaration > > > > > > > > > mbuf: fix a typo > > > > > > > > > doc: fix a minor typo in testpmd guide > > > > > > > > > doc: remove reference to rte.doc.mk in > > > > > > > > > programmers > > > > > > > > > guide > > > > > > > > > examples/ethtool: fix two typos > > > > > > > > > doc: fix link in Linux getting started guide > > > > > > > > > app/testpmd: fix a typo in log message > > > > > > > > > ethdev: fix a typo > > > > > > > > > > > > > > > > > > Rasesh Mody (2): > > > > > > > > > net/bnx2x: fix race for periodic flags > > > > > > > > > net/bnx2x: fix optic module verification > > > > > > > > > > > > > > > > > > Shahaf Shuler (1): > > > > > > > > > net/mlx5: fix packet inline on Tx queue > > > > > > > > > wraparound > > > > > > > > > > > > > > > > > > Shahed Shaikh (5): > > > > > > > > > net/bnx2x: fix segfaults due to stale interrupt > > > > > > > > > status > > > > > > > > > net/bnx2x: fix memory leak > > > > > > > > > net/bnx2x: fix ramrod timeout > > > > > > > > > net/bnx2x: fix DMAE timeout > > > > > > > > > net/qede: fix Tx packet prepare for tunnel > > > > > > > > > packets > > > > > > > > > > > > > > > > > > Shreyansh Jain (1): > > > > > > > > > bus/dpaa: fix Rx discard register mask > > > > > > > > > > > > > > > > > > Stephen Hemminger (8): > > > > > > > > > net/octeontx: fix vdev name > > > > > > > > > net/bnxt: fix Rx VLAN offload flags > > > > > > > > > net/virtio: remove useless condition > > > > > > > > > ring: fix an error message > > > > > > > > > net/ring: avoid hard-coded length > > > > > > > > > net/ring: use calloc style where appropriate > > > > > > > > > net/ring: check length of ring name > > > > > > > > > net/virtio: fix buffer leak on VLAN insert > > > > > > > > > > > > > > > > > > Thomas Monjalon (2): > > > > > > > > > mk: fix build of shared library with libbsd > > > > > > > > > bus/vdev: fix debug message on probing > > > > > > > > > > > > > > > > > > Tiwei Bie (4): > > > > > > > > > net/virtio: add barrier in interrupt enable > > > > > > > > > vhost: restore mbuf first when freeing zmbuf > > > > > > > > > vhost: fix potential use-after-free for zero > > > > > > > > > copy > > > > > > > > > mbuf > > > > > > > > > vhost: fix potential use-after-free for memory > > > > > > > > > region > > > > > > > > > > > > > > > > > > Vishal Kulkarni (1): > > > > > > > > > net/cxgbe: fix missing checksum flags and > > > > > > > > > packet > > > > > > > > > type > > > > > > > > > > > > > > > > > > Xiao Wang (1): > > > > > > > > > net/fm10k: fix VLAN strip offload flag > > > > > > > > > > > > > > > > > > Yipeng Wang (1): > > > > > > > > > hash: fix doc about thread/process safety > > > > > > > > > > > > > > > > > > Yongseok Koh (4): > > > > > > > > > net/mlx5: fix instruction hotspot on > > > > > > > > > replenishing > > > > > > > > > Rx > > > > > > > > > buffer > > > > > > > > > net/mlx5: check Tx queue size overflow > > > > > > > > > net/mlx5: fix max number of queues for NEON Tx > > > > > > > > > doc: fix typo in mlx5 guide > > > > > > > > > > > > > > > > > > Yunjian Wang (1): > > > > > > > > > net/ixgbe: fix crash on remove > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Kind regards, > > > > > > > Luca Boccassi > > > > > > > > > > > > > > > > > > > > > -- Kind regards, Luca Boccassi ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [dpdk-dev] 17.11.7-rc1 (LTS) patches review and test [not found] ` <FD56CD4A6C7E9841B5CD62946D45F34C01B18CF1@SHSMSX104.ccr.corp.intel.com> 2019-09-12 8:52 ` [dpdk-dev] FW: " Peng, Yuan @ 2019-09-12 8:59 ` Peng, Yuan 1 sibling, 0 replies; 19+ messages in thread From: Peng, Yuan @ 2019-09-12 8:59 UTC (permalink / raw) To: dev Bug 3-5 which are not fixed are medium. Bug1 and bug2(high priority) have been fixed and verified, will the patches be submitted? -----Original Message----- From: Peng, Yuan Sent: Thursday, September 12, 2019 4:53 PM To: dev@dpdk.org Subject: FW: 17.11.7-rc1 (LTS) patches review and test Update the latest test status here. -----Original Message----- From: Yu, PingX Sent: Thursday, September 12, 2019 2:37 PM To: Yongseok Koh <yskoh@mellanox.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>; asafp@mellanox.com Cc: Xu, Qian Q <qian.q.xu@intel.com>; Lin, Xueqin <xueqin.lin@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>; O'Hare, Cathal <cathal.ohare@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Ma, LihongX <lihongx.ma@intel.com>; Li, WenjieX A <wenjiex.a.li@intel.com>; Wang, FengqinX <fengqinx.wang@intel.com>; Peng, Yuan <yuan.peng@intel.com> Subject: RE: 17.11.7-rc1 (LTS) patches review and test All, Update the latest test status here. The critical bug has been fixed and we have re-tested all Intel key features. Intel(R) Testing result lists here. # Basic Intel(R) NIC testing * PF(i40e): One bug found in 1st round test. 2nd round test pass after fixing the bug. (see Bug1) * PF(ixgbe): the same as PF(i40e). * VF: Pass and no issue. * Build or compile: One bug found in 1st round test. 2nd round test pass after fixing the bug. (see Bug2) * Intel NIC single core/NIC performance: Pass and no issue. #Basic cryptodev and virtio testing * vhost/virtio basic loopback, PVP and performance test: pass. * cryptodev: 3 bugs are found(see bug statistic in below). (See Bug3,4 and 5) Bugs statistic: Bug1: make -C test/ failed. It blocked about 60 test cases for both PF(i40e) and PF(ixgbe). Resolved by adding "#include <inttypes.h>" into test_rwlock.c. Please decide whether submit a patch to DPDK or not. Bug2: compile error on fc30. Patch is provided and validated pass. Need to decide whether merge into DPDK or not. Bug3: L2fwd: test_qat_h_AES_XCBC_MAC_auto failed. No progress yet. commit 39fb9500c42752a537588f7a203433ec4737fa1e Author: Arek Kusztal <arkadiuszx.kusztal@intel.com> Date: Wed Dec 12 20:59:02 2018 +0100 Bug4: Ipsec-gw_test forwarding failed with null crypto QAT. No progress yet. commit 39fb9500c42752a537588f7a203433ec4737fa1e Author: Arek Kusztal <arkadiuszx.kusztal@intel.com> Date: Wed Dec 12 20:59:02 2018 +0100 Bug5: Crypto: cryptodev_qat_autotest test failed. No progress yet. 39fb9500c42752a537588f7a203433ec4737fa1e is the first bad commit commit 39fb9500c42752a537588f7a203433ec4737fa1e Author: Arek Kusztal <arkadiuszx.kusztal@intel.com> Date: Wed Dec 12 20:59:02 2018 +0100 Regards, Yu Ping -----Original Message----- From: Wang, FengqinX Sent: Monday, August 26, 2019 3:12 PM To: Yongseok Koh <yskoh@mellanox.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>; asafp@mellanox.com Cc: Xu, Qian Q <qian.q.xu@intel.com>; Lin, Xueqin <xueqin.lin@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>; O'Hare, Cathal <cathal.ohare@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Yu, PingX <pingx.yu@intel.com>; Ma, LihongX <lihongx.ma@intel.com>; Li, WenjieX A <wenjiex.a.li@intel.com> Subject: RE: 17.11.7-rc1 (LTS) patches review and test Add asafp in the loop due to Yongseok is longer working at Mellanox. BRs, Vicky -----Original Message----- From: Wang, FengqinX Sent: Monday, August 26, 2019 3:07 PM To: 'Yongseok Koh' <yskoh@mellanox.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com> Cc: Xu, Qian Q <qian.q.xu@intel.com>; Lin, Xueqin <xueqin.lin@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>; O'Hare, Cathal <cathal.ohare@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Yu, PingX <pingx.yu@intel.com>; Ma, LihongX <lihongx.ma@intel.com>; Li, WenjieX A <wenjiex.a.li@intel.com> Subject: RE: 17.11.7-rc1 (LTS) patches review and test Hi Yongseok, Konstantin, There is one critical compile issue found, and below is the bad commit related information, this issue has blocked most of unit tests which have used dpdk/test/test, would you please help to fix this issue ASAP? commit 29e08d740ffc1e0ed9e7a9bd25fb95714fac1070 Author: Joyce Kong <joyce.kong@arm.com> Date: Thu Jul 25 14:50:21 2019 +0800 test/rwlock: benchmark on all available cores [ backported from upstream commit fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] Add performance test on all available cores to benchmark the scaling up performance of rw_lock. Fixes: af75078fece3 ("first public release") Suggested-by: Gavin Hu <gavin.hu@arm.com> Signed-off-by: Joyce Kong <joyce.kong@arm.com> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> And below is the error message output: test_rwlock.c: In function 'load_loop_fn': test_rwlock.c:126:38: error: expected ')' before 'PRIu64' printf("Core [%u] rwlock_data = %"PRIu64"\n", ^~~~~~ ) test_rwlock.c:126:19: error: format '%u' expects a matching 'unsigned int' argument [-Werror=format=] printf("Core [%u] rwlock_data = %"PRIu64"\n", ~^ test_rwlock.c:126:36: error: spurious trailing '%' in format [-Werror=format=] printf("Core [%u] rwlock_data = %"PRIu64"\n", ^ test_rwlock.c: In function 'test_rwlock_perf': test_rwlock.c:160:31: error: expected ')' before 'PRIu64' printf("Core [%u] count = %"PRIu64"\n", i, lock_count[i]); ^~~~~~ ) test_rwlock.c:160:18: error: format '%u' expects a matching 'unsigned int' argument [-Werror=format=] printf("Core [%u] count = %"PRIu64"\n", i, lock_count[i]); ~^ test_rwlock.c:160:29: error: spurious trailing '%' in format [-Werror=format=] printf("Core [%u] count = %"PRIu64"\n", i, lock_count[i]); ^ test_rwlock.c:164:26: error: expected ')' before 'PRIu64' printf("Total count = %"PRIu64"\n", total); ^~~~~~ ) test_rwlock.c:164:24: error: spurious trailing '%' in format [-Werror=format=] printf("Total count = %"PRIu64"\n", total); ^ cc1: all warnings being treated as errors BRs, Vicky -----Original Message----- From: Yongseok Koh [mailto:yskoh@mellanox.com] Sent: Friday, August 16, 2019 2:05 AM To: dpdk stable <stable@dpdk.org> Cc: dev@dpdk.org; pezhang@redhat.com; siliu@redhat.com; Wang, FengqinX <fengqinx.wang@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; alialnu@mellanox.com; rasland@mellanox.com Subject: 17.11.7-rc1 (LTS) patches review and test Hi all, Here is a list of patches targeted for LTS release 17.11.7. Please help review and test. The planned date for the final release is Aug 23, Before that, please shout if anyone has objections with these patches being applied. Also for the companies committed to running regression tests, please run the tests and report any issue before the release date. A release candidate tarball can be found at: https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 These patches are located at branch 17.11 of dpdk-stable repo: https://dpdk.org/browse/dpdk-stable/ Thanks, Yongseok --- Aaron Conole (1): net/virtio: fix dangling pointer on failure Agalya Babu RadhaKrishnan (1): doc: fix interactive commands in testpmd guide Akhil Goyal (1): crypto/dpaa2_sec: fix session clearing Alejandro Lucero (1): net/nfp: fix RSS query Anatoly Burakov (2): eal: improve musl compatibility of string functions malloc: fix documentation of realloc function Andrew Rybchenko (2): net/sfc: remove control path logging from Rx queue count app/testpmd: set fixed flag for exact link speed Andrius Sirvys (3): net/virtio: fix duplicate naming of include guard bitrate: fix unchecked return value drivers/net: fix shifting 32-bit signed variable 31 times Anoob Joseph (1): cryptodev: fix driver name comparison Beilei Xing (1): net/i40e: fix link speed for X722 Bernard Iremonger (1): examples/ipsec-secgw: fix debug logs Bill Hong (1): net: fix Tx VLAN flag for offload emulation Bruce Richardson (9): eal: support strlcat function net/bonding: fix buffer length when printing strings examples/l2fwd-cat: fix build on FreeBSD app/crypto-perf: check range of socket id examples/vhost_scsi: fix null-check for parameter net/i40e: fix dereference before null check in mbuf release net/ixgbe: fix warning with GCC 9 bus/fslmc: fix warning with GCC 9 eal: tighten permissions on shared memory files Chaitanya Babu Talluri (2): drivers/net: fix possible overflow using strlcat cfgfile: replace strcat with strlcat David Christensen (2): maintainers: update for IBM POWER examples/vm_power_manager: fix PMD specific code David Marchand (7): eal: fix check when retrieving current CPU affinity eal: remove dead code in core list parsing app/testpmd: remove unused field from port struct doc: fix examples in bonding guide net/bonding: fix port id types net/bonding: fix queue index types app/testpmd: remove useless casts on statistics Davide Caratti (1): net/bnxt: support IOVA VA mode Dekel Peled (8): net/mlx5: fix hex dump of error completion net/mlx5: fix sync when handling Tx completions eal/ppc: fix global memory barrier eal: fix typo in comment of vector function doc: fix links to doxygen and sphinx sites app/testpmd: fix typo in comment net/mlx5: fix comments mixing Rx and Tx net/mlx5: fix release of Rx queue object Fan Zhang (1): examples/ipsec-secgw: fix AES-CTR block size Ferruh Yigit (5): kni: fix build with Linux 5.1 build: fix crash by disabling AVX512 with binutils 2.31 net/ring: fix return value check net/kni: fix return value check app/testpmd: revert fixed flag for exact link speed Gage Eads (1): ring: fix namesize macro documentation block Gavin Hu (3): test/spinlock: remove delay for correct benchmarking test/spinlock: amortize the cost of getting time spinlock: reimplement with atomic one-way barrier Hari Kumar Vemula (1): net/bonding: fix reset active slave Harry van Haaren (1): event/sw: fix enqueue checks in self-test Herakliusz Lipiec (1): doc: fix broken link in LPM guide Hyong Youb Kim (4): net/bonding: avoid warning for invalid port net/enic: fix flow director SCTP matching net/enic: fix SCTP match for flow API net/enic: check for unsupported flow item types Igor Romanov (1): app/testpmd: fix stdout flush after printing stats Ilya Maximets (2): vhost: fix device leak on connection add failure vhost: fix silent queue enabling with legacy guests Ivan Malov (1): net/sfc: log port ID as 16-bit unsigned integer on panic Jerin Jacob (1): mk: fix AVX512 disabled warning on non x86 Jianfeng Tan (1): drivers/net: do not use private ethdev data Joyce Kong (1): test/rwlock: benchmark on all available cores Kevin Traynor (3): net/qede: support IOVA VA mode eal/linux: fix log levels for pagemap reading failure power: fix frequency list buffer validation Liang Zhang (1): net/bonding: fix LACP negotiation Luo Gaoliang (1): kni: fix build on RHEL8 Marcin Smoczynski (1): examples/ipsec-secgw: fix build error log Natanael Copa (3): bus/fslmc: remove unused include of error.h bus/fslmc: fix build with musl libc app/test: fix build with musl libc Pallantla Poornima (3): app/test: fix sprintf with strlcat test/distributor: replace sprintf with strlcpy test/hash: replace sprintf with snprintf Qi Zhang (1): net/i40e: fix time sync for 25G Radu Nicolau (3): net/null: add MAC address setting fake operation test/virtual_pmd: add MAC address setting fake op test/bonding: assign non-zero MAC to null devices Rahul Lakkireddy (1): net/cxgbe: update Chelsio T5/T6 NIC device ids Rami Rosen (8): net/virtio: remove forward declaration mbuf: fix a typo doc: fix a minor typo in testpmd guide doc: remove reference to rte.doc.mk in programmers guide examples/ethtool: fix two typos doc: fix link in Linux getting started guide app/testpmd: fix a typo in log message ethdev: fix a typo Rasesh Mody (2): net/bnx2x: fix race for periodic flags net/bnx2x: fix optic module verification Shahaf Shuler (1): net/mlx5: fix packet inline on Tx queue wraparound Shahed Shaikh (5): net/bnx2x: fix segfaults due to stale interrupt status net/bnx2x: fix memory leak net/bnx2x: fix ramrod timeout net/bnx2x: fix DMAE timeout net/qede: fix Tx packet prepare for tunnel packets Shreyansh Jain (1): bus/dpaa: fix Rx discard register mask Stephen Hemminger (8): net/octeontx: fix vdev name net/bnxt: fix Rx VLAN offload flags net/virtio: remove useless condition ring: fix an error message net/ring: avoid hard-coded length net/ring: use calloc style where appropriate net/ring: check length of ring name net/virtio: fix buffer leak on VLAN insert Thomas Monjalon (2): mk: fix build of shared library with libbsd bus/vdev: fix debug message on probing Tiwei Bie (4): net/virtio: add barrier in interrupt enable vhost: restore mbuf first when freeing zmbuf vhost: fix potential use-after-free for zero copy mbuf vhost: fix potential use-after-free for memory region Vishal Kulkarni (1): net/cxgbe: fix missing checksum flags and packet type Xiao Wang (1): net/fm10k: fix VLAN strip offload flag Yipeng Wang (1): hash: fix doc about thread/process safety Yongseok Koh (4): net/mlx5: fix instruction hotspot on replenishing Rx buffer net/mlx5: check Tx queue size overflow net/mlx5: fix max number of queues for NEON Tx doc: fix typo in mlx5 guide Yunjian Wang (1): net/ixgbe: fix crash on remove ^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2019-09-26 8:21 UTC | newest] Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-08-15 18:05 [dpdk-dev] 17.11.7-rc1 (LTS) patches review and test Yongseok Koh 2019-08-19 6:37 ` Pei Zhang 2019-08-25 10:30 ` Ali Alnubani 2019-08-29 16:10 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit [not found] ` <4A3FBC67CD7DCF48BECD235A28B050330ADA95BA@SHSMSX101.ccr.corp.intel.com> 2019-08-30 12:58 ` Ferruh Yigit [not found] ` <4A3FBC67CD7DCF48BECD235A28B050330ADA8312@SHSMSX101.ccr.corp.intel.com> [not found] ` <FD56CD4A6C7E9841B5CD62946D45F34C01B18CF1@SHSMSX104.ccr.corp.intel.com> 2019-09-12 8:52 ` [dpdk-dev] FW: " Peng, Yuan 2019-09-17 9:53 ` Luca Boccassi 2019-09-18 9:17 ` Luca Boccassi 2019-09-18 10:03 ` Yu, PingX 2019-09-24 11:07 ` Luca Boccassi 2019-09-24 16:36 ` Ferruh Yigit 2019-09-24 17:15 ` Kevin Traynor 2019-09-24 17:25 ` Luca Boccassi 2019-09-24 20:08 ` Luca Boccassi 2019-09-26 7:34 ` Yu, PingX 2019-09-26 7:38 ` Ferruh Yigit 2019-09-26 8:15 ` Yu, PingX 2019-09-26 8:19 ` Luca Boccassi 2019-09-12 8:59 ` [dpdk-dev] " Peng, Yuan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).