From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 052812BA7 for ; Tue, 5 Mar 2019 10:59:10 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9902523145; Tue, 5 Mar 2019 04:59:09 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 05 Mar 2019 04:59:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=sb7u4utKYvClBO7Gvlv9DrRTv23dMneESWSI3AgkH4E=; b=Ue3VrAqwXxRI YozF3VZ0REQiFcmD84w0d9zFBra1Efk2JRgS3en4kN33THs9D9RwGtHwVuguVHjV 91lUlcyra9WhgL27tj78zvy3Y0I2Y5CzQkeP9JyYwtrcB69lPfZBvlT1EK3x21aS UAYletKCZI4PY1OUmdimZkT4CG11Qf4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=sb7u4utKYvClBO7Gvlv9DrRTv23dMneESWSI3AgkH 4E=; b=HpzTMfgod07oYHxfd1HReoV9Ho5+23UDO1d7TKa1jon84qwSeW5EXuqUL jYBevvEaK1RbfAcWshJALOgHZ0W7eRFZfBotuCl2POaHUXmgCvUU4mv+TguADmhn L+mPNgyVNO47ed2qmS5X1cDGRKCTW+yJvSdkVysNJtzfX5o/+1gOmIOgI/QVFsB3 WxzA4Fxg2kk7pL01cVRyutQ0RQtYffF2cMjnd+gpaVJF7UpIQUOUrJU0uWrzKZ9E Q5BkRI1YubM1kmouBvSh4ZneoHxnKQrc9VM5RaOWsujBuJdV0BWNm1ghr8WN9PXI jwSk9VEvjRgQeN2hQgtLx4FzHMqWA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrfeefgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2DACA10310; Tue, 5 Mar 2019 04:59:08 -0500 (EST) From: Thomas Monjalon To: Raslan Darawsheh Cc: "gaetan.rivet@6wind.com" , "dev@dpdk.org" , "stephen@networkplumber.org" Date: Tue, 05 Mar 2019 10:59:04 +0100 Message-ID: <1800287.8gbLoiznbb@xps> In-Reply-To: <1551779507-10857-3-git-send-email-rasland@mellanox.com> References: <1551779507-10857-1-git-send-email-rasland@mellanox.com> <1551779507-10857-3-git-send-email-rasland@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/failsafe: replace local sub-device with shared data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2019 09:59:11 -0000 05/03/2019 10:52, Raslan Darawsheh: > +/* > + * Allocated in shared memory. > + */ > struct sub_device { > /* Exhaustive DPDK device description */ > struct sub_device *next; > struct rte_devargs devargs; > - struct rte_bus *bus; > - struct rte_device *dev; > - struct rte_eth_dev *edev; > + struct rte_bus *bus; /* per process. */ > + struct rte_device *dev; /* per process. */ Thinking again about these comments. Given it is in a shared struct, it would be more precise to say "only for primary process". > + struct rte_eth_dev_data *data; /* shared between processes */