From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 77C381B7A2 for ; Wed, 31 Jan 2018 15:02:33 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0F1CD20D73; Wed, 31 Jan 2018 09:02:33 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 31 Jan 2018 09:02:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=LZfUnWvqQuQN6wEKLI7D3cXeTr PsGmonZTRhKYmfAqc=; b=LFC/rfaE2GkOJGH+zFElBXvvrEkZeyG1EXEAc1xN05 26arwB52E7j+JX91jlDQGNSEwgyGt2w84ExegxG8j1AKKnguRQxwQdLDgVNSUhPN wFiPF/S2MGUSPzxQqjmD+sQxOKLLCrAgEDUgALQFE2X9gVbDZUDj9ou7dLvj6+77 Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=LZfUnW vqQuQN6wEKLI7D3cXeTrPsGmonZTRhKYmfAqc=; b=dsj7rJ+965QZVgP24E1ZZH kXvxDT2FRUbY6aWjg/AoAwWzXmWxnXJDq8HLk92szzBQPJtstkNA1B2JWGtbB9HE oWT1aRgYCYAHOGhUK43UitSft2a6zAIXf3V0vpxebSfFpD0wTMdkH4fRMvliFfIK HAoUwhjVdb79P4wLpRiTLBWCe4LDc4qj44kEXI7P2eggP5Uzz6ciECbqepnraOPI cOVNUgmJSb0wPCttzYz8Hr5e8px3C+theugxQTXbgH+jAUDynIAmkDnQUDkMxawu yhIk0azFn3qnfcQdfV3HkBzRdb++1WFJJP1RIW7417SzeMx1fMsosvJJ8RIwFaWw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A53347E12E; Wed, 31 Jan 2018 09:02:32 -0500 (EST) From: Thomas Monjalon To: Shreyansh Jain Cc: dev@dpdk.org, hemant.agrawal@nxp.com, fiona.trahe@intel.com, rosen.xu@intel.com Date: Wed, 31 Jan 2018 15:01:46 +0100 Message-ID: <1801450.3p9ufv1Kd3@xps> In-Reply-To: <20180131091318.7894-9-shreyansh.jain@nxp.com> References: <20180130145710.24757-1-shreyansh.jain@nxp.com> <20180131091318.7894-1-shreyansh.jain@nxp.com> <20180131091318.7894-9-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 08/10] drivers/raw: support for rawdev testcases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2018 14:02:33 -0000 31/01/2018 10:13, Shreyansh Jain: > Patch introduces rawdev unit testcase for validation against the > Skeleton rawdev dummy PMD implementation. >=20 > Test cases are added along with the skeleton driver implementation. > It can be enabled by using vdev argument to any DPDK binary: >=20 > --vdev=3D"rawdev_skeleton,self_test=3D1" >=20 > In case 'self_test=3D1' is not provided, autotest doesn't execute the > test cases but the vdev is still available for application use. >=20 > Signed-off-by: Shreyansh Jain More compilation errors on 32-bit: drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c:277:50: error: cast from pointer to integer of different size [-Werror=3Dpointer-to-int-ca= st] ret =3D rte_rawdev_set_attr(TEST_DEV_ID, "Test2", (uint64_t)dummy_value); drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c:283:19: error: format =E2=80=98%lu=E2=80=99 expects argument of type =E2=80=98long unsigne= d int=E2=80=99, but argument 6 has type =E2=80=98uint64_t {aka long long un= signed int}=E2=80=99 [-Werror=3Dformat=3D] ret_value); skeleton_rawdev.o: In function `skeleton_rawdev_probe': skeleton_rawdev.c:(.text+0x75c): undefined reference to `rte_kvargs_parse' skeleton_rawdev.c:(.text+0x782): undefined reference to `rte_kvargs_process' skeleton_rawdev.c:(.text+0x799): undefined reference to `rte_kvargs_free' skeleton_rawdev.c:(.text+0x814): undefined reference to `rte_kvargs_free' =46ixed: =2D-- a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c +++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c @@ -274,18 +274,18 @@ test_rawdev_attr_set_get(void) RTE_TEST_ASSERT(1, "Unable to allocate memory (dummy_value)= "); =20 *dummy_value =3D 200; =2D ret =3D rte_rawdev_set_attr(TEST_DEV_ID, "Test2", (uint64_t)dummy= _value); + ret =3D rte_rawdev_set_attr(TEST_DEV_ID, "Test2", (uintptr_t)dummy_= value); =20 /* Check if attributes have been set */ ret =3D rte_rawdev_get_attr(TEST_DEV_ID, "Test1", &ret_value); RTE_TEST_ASSERT_EQUAL(ret_value, 100, =2D "Attribute (Test1) not set correctly (%lu)", + "Attribute (Test1) not set correctly (%" PRIu= 64 ")", ret_value); =20 ret_value =3D 0; ret =3D rte_rawdev_get_attr(TEST_DEV_ID, "Test2", &ret_value); =2D RTE_TEST_ASSERT_EQUAL(*((int *)ret_value), 200, =2D "Attribute (Test2) not set correctly (%lu)", + RTE_TEST_ASSERT_EQUAL(*((int *)(uintptr_t)ret_value), 200, + "Attribute (Test2) not set correctly (%" PRIu= 64 ")", ret_value); And in previous patch: =2D-- a/drivers/raw/skeleton_rawdev/Makefile +++ b/drivers/raw/skeleton_rawdev/Makefile @@ -14,6 +14,7 @@ CFLAGS +=3D $(WERROR_FLAGS) LDLIBS +=3D -lrte_eal LDLIBS +=3D -lrte_rawdev LDLIBS +=3D -lrte_bus_vdev +LDLIBS +=3D -lrte_kvargs