* [dpdk-dev] [PATCH] devtools: recommend new logtype helpers
@ 2021-07-01 14:11 David Marchand
2021-07-01 19:57 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: David Marchand @ 2021-07-01 14:11 UTC (permalink / raw)
To: dev; +Cc: Thomas Monjalon
Following commit eeded2044af5 ("log: register with standardized names"),
the new helpers should be preferred so that we can maintain a consistent
naming for logtypes.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/checkpatches.sh | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index c30dadd962..c314d83a29 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -126,6 +126,14 @@ check_forbidden_additions() { # <patch>
-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
"$1" || res=1
+ # refrain from using RTE_LOG_REGISTER for drivers and libs
+ awk -v FOLDERS='lib drivers' \
+ -v EXPRESSIONS='\\<RTE_LOG_REGISTER\\>' \
+ -v RET_ON_FAIL=1 \
+ -v MESSAGE='Using RTE_LOG_REGISTER, prefer RTE_LOG_REGISTER_(DEFAULT|SUFFIX)' \
+ -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+ "$1" || res=1
+
# SVG must be included with wildcard extension to allow conversion
awk -v FOLDERS='doc' \
-v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\.svg' \
--
2.23.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: recommend new logtype helpers
2021-07-01 14:11 [dpdk-dev] [PATCH] devtools: recommend new logtype helpers David Marchand
@ 2021-07-01 19:57 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2021-07-01 19:57 UTC (permalink / raw)
To: David Marchand; +Cc: dev
01/07/2021 16:11, David Marchand:
> Following commit eeded2044af5 ("log: register with standardized names"),
> the new helpers should be preferred so that we can maintain a consistent
> naming for logtypes.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-01 19:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-01 14:11 [dpdk-dev] [PATCH] devtools: recommend new logtype helpers David Marchand
2021-07-01 19:57 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).