From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A8C341C2D; Tue, 7 Feb 2023 12:31:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A8C040ED9; Tue, 7 Feb 2023 12:31:59 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 3740640E6E; Tue, 7 Feb 2023 12:31:57 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 6B135320016F; Tue, 7 Feb 2023 06:31:51 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 07 Feb 2023 06:31:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675769510; x= 1675855910; bh=GftswGOiBB/nvKHW5pyTo1al+Cm0rn44qCHPy/zR4HU=; b=C cLLWxnVEn+x2CbnNvRRyv7f8ywl3CarQRprphl5s5IW17UfjkUyO2QCanRBe8C5p tjn2JWkg1nev77VJ6DiZQmG8XBRRerLHjjNgUe5Uj//xjMXB+bI/c0zbhlA5/EiU WtM0g8QopVVToD4ftsoh0ovE1s3pOwpjltJooPaegxZPp08sFrSWRfeu2Id/meZN AVSf06+0fultGrIEaFgJe/foY4oxkssmq1+XkFjWbxp1wV2JH8k8JTYkm58lJ6L2 ssSJizBLV8I0PesegP6sBJHmMws6Z4bA5q0H/tyMjzC3cgL9IQauFANf3Sx7Kz1c GHD0BUpRCiylPLmtyCC3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675769510; x= 1675855910; bh=GftswGOiBB/nvKHW5pyTo1al+Cm0rn44qCHPy/zR4HU=; b=Y aUoNydjaI6Yl5lSbxMqq9oeFUvYmgpSdGSdQmBp6WrZ2YuRyFNX1ZjXv9v3x+UvD CEBqr5J5Yb4HpzW3s8O8xpLHf46hDF6vYB+6Cmv9VOJ4v4hObpYMhoTYWg/rD0Th uC1QRlEM0hGKUfberqaLQuRbnEfq9V+i428Eoojnz4Zu1Xip/hNUb95DbvebvRVK 5+ccJZYMM0zmqS2fgQZ6bLaUY697ZuEGgDJSVrsrlfp65SzrtiybRIcTDEUzvev1 kPcxnsPfZj2/wpzN2lHIdf19KM0vopuPpRp0wPzzubH6OmZ5IQewDlQffd0hoK5F s1pZzKOW1D9/7sjyro3LA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegkedgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejjefffffgffekfefflefgkeelteejffelledugefhheelffet heevudffudfgvdenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Feb 2023 06:31:49 -0500 (EST) From: Thomas Monjalon To: "Zhang, Helin" , "Su, Simei" Cc: David Marchand , dev@dpdk.org, "Zhang, Yuying" , "Xing, Beilei" , "Mcnamara, John" , "stable@dpdk.org" , "Zhang, Qi Z" , Dapeng Yu , Wenxuan Wu Subject: Re: [PATCH v2] net/i40e: don't check link status on device start Date: Tue, 07 Feb 2023 12:31:47 +0100 Message-ID: <18020950.sWSEgdgrri@thomas> In-Reply-To: References: <20221212143715.29649-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/01/2023 12:02, Su, Simei: > From: David Marchand > > On Fri, Jan 13, 2023 at 2:51 PM Zhang, Helin wrote: > > > From: David Marchand > > > > On Fri, Jan 13, 2023 at 2:39 PM Zhang, Helin > > > > > From: David Marchand > > > > > > Hello i40e maintainers, John, > > > > > > > > > > > > On Mon, Jan 9, 2023 at 10:21 AM David Marchand > > > > > > wrote: > > > > > > > On Tue, Jan 3, 2023 at 3:02 PM David Marchand > > > > > > wrote: > > > > > > > > Hi i40e maintainers, > > > > > > > > > > > > > > > > On Tue, Dec 13, 2022 at 10:19 AM David Marchand > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > The mentioned changes broke existing applications when the > > > > > > > > > link status of i40e ports is down at the time the port is started. > > > > > > > > > Revert those changes, the original issue will need a different fix. > > > > > Hi David > > > > > > > > > > Does it break all the application or just a specific application? > > > > > > > > I don't see how it would not affect all applications seeing how the > > > > original patch is dumb. > > > > > > > > > We may need to understand the issue you met, and try to fix it later. > > > > > > > > Just unplug the cable or fake a link down on your i40e port, start > > > > your application or port, then plug the cable back. > > > > The max frame size will never get applied to hw. > > > > > > Got it, I will forward to a right expert to check. Thank you very much for > > reaching out to us! > > > > I hope I get a reply _soon_. > > Or I will just apply those reverts. > > If applying those reverts, some issues still exist on our side. I sent one patch to patchwork: > https://patchwork.dpdk.org/project/dpdk/patch/20230116105318.19412-1-simei.su@intel.com/. > You can try this patch to see whether it can solve the issue on your side. > At the same time, on our side, we need to do regression test further to check if this patch will affect other > cases, the regression takes some time. > > Thanks, > Simei Simei, do you have any update in this thread? Last reply was 3 weeks ago. I hope regression test don't take so much time.