[dpdk-dev] fast red autotest

[dpdk-dev] fast red autotest

[Thomas Monjalon]

The autotest for librte_sched red takes more than a minute.
Would it be possible to reduce it to a second please?
If it is really impossible, it must be removed from fast_test.

Re: [dpdk-dev] fast red autotest

[Dumitrescu, Cristian]

CC-ing Tomasz, who is the original author of RED implementation and its autotest. Tomasz, what do you think?

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, May 11, 2016 8:45 AM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org
> Subject: fast red autotest
> 
> The autotest for librte_sched red takes more than a minute.
> Would it be possible to reduce it to a second please?
> If it is really impossible, it must be removed from fast_test.

Re: [dpdk-dev] fast red autotest

[Thomas Monjalon]

Any news Tomasz, Cristian?

2016-05-11 10:15, Dumitrescu, Cristian:
> CC-ing Tomasz, who is the original author of RED implementation and its autotest. Tomasz, what do you think?
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > Sent: Wednesday, May 11, 2016 8:45 AM
> > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> > Cc: dev@dpdk.org
> > Subject: fast red autotest
> > 
> > The autotest for librte_sched red takes more than a minute.
> > Would it be possible to reduce it to a second please?
> > If it is really impossible, it must be removed from fast_test.

Re: [dpdk-dev] fast red autotest

[Dumitrescu, Cristian]

Hi Thomas,

>From my side, I am OK to remove RED from the fast autotest, as long as it is kept available as part of the normal/full autotest of DPDK.

Some of the RED autotests need a long time to run in order to train the history for the average queue size stochastic variable, therefore it is difficult to shorten them. However, some tests are quick to execute, so those tests can still be included into the fast autotest. Tomazs, any comments/proposal?

Regards,
Cristian

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, May 24, 2016 4:24 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Kantecki, Tomasz
> <tomasz.kantecki@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: fast red autotest
> 
> Any news Tomasz, Cristian?
> 
> 2016-05-11 10:15, Dumitrescu, Cristian:
> > CC-ing Tomasz, who is the original author of RED implementation and its
> autotest. Tomasz, what do you think?
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > Sent: Wednesday, May 11, 2016 8:45 AM
> > > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> > > Cc: dev@dpdk.org
> > > Subject: fast red autotest
> > >
> > > The autotest for librte_sched red takes more than a minute.
> > > Would it be possible to reduce it to a second please?
> > > If it is really impossible, it must be removed from fast_test.
> 

Re: [dpdk-dev] fast red autotest

[Kantecki, Tomasz]

Hi Thomas,

I had a quick look through these tests and it will need some effort to rework them to run in shorter time.
I agree to remove this suite from the fast_test as long as it gets exercised in other test paths.

Regards,
Tomasz

> -----Original Message-----
> From: Dumitrescu, Cristian
> Sent: Tuesday, May 24, 2016 6:08 PM
> To: Thomas Monjalon <thomas.monjalon@6wind.com>; Kantecki, Tomasz
> <tomasz.kantecki@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: fast red autotest
> 
> Hi Thomas,
> 
> From my side, I am OK to remove RED from the fast autotest, as long as it is
> kept available as part of the normal/full autotest of DPDK.
> 
> Some of the RED autotests need a long time to run in order to train the
> history for the average queue size stochastic variable, therefore it is difficult
> to shorten them. However, some tests are quick to execute, so those tests
> can still be included into the fast autotest. Tomazs, any comments/proposal?
> 
> Regards,
> Cristian
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > Sent: Tuesday, May 24, 2016 4:24 PM
> > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Kantecki,
> > Tomasz <tomasz.kantecki@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: fast red autotest
> >
> > Any news Tomasz, Cristian?
> >
> > 2016-05-11 10:15, Dumitrescu, Cristian:
> > > CC-ing Tomasz, who is the original author of RED implementation and
> > > its
> > autotest. Tomasz, what do you think?
> > >
> > > > -----Original Message-----
> > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > > Sent: Wednesday, May 11, 2016 8:45 AM
> > > > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> > > > Cc: dev@dpdk.org
> > > > Subject: fast red autotest
> > > >
> > > > The autotest for librte_sched red takes more than a minute.
> > > > Would it be possible to reduce it to a second please?
> > > > If it is really impossible, it must be removed from fast_test.
> >

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.

Re: [dpdk-dev] fast red autotest

[Thomas Monjalon]

2016-05-25 11:06, Kantecki, Tomasz:
> I had a quick look through these tests and it will need some effort to rework them to run in shorter time.
> I agree to remove this suite from the fast_test as long as it gets exercised in other test paths.

Is it possible to split them in
	- short functional tests
	- long run / perf tests
?
So we could keep some basic tests in fast_test.
I expect that tests which are not part of fast_test won't be run often
or in enough various environments.

Re: [dpdk-dev] fast red autotest

[Kantecki, Tomasz]

> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Is it possible to split them in
> 	- short functional tests
> 	- long run / perf tests
> ?
> So we could keep some basic tests in fast_test.
> I expect that tests which are not part of fast_test won't be run often or in
> enough various environments.

It sounds like a good idea Thomas.  I ran the test couple of times and it seems that functional test #4 takes most of the time and could be removed to long run scenario. Other functional tests run rather promptly. 
Next week, I can prepare patch to implement long and short run commands for this test suite. Would it be OK?
Tomasz
--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.

Re: [dpdk-dev] fast red autotest

[Thomas Monjalon]

2016-05-27 14:04, Kantecki, Tomasz:
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > Is it possible to split them in
> > 	- short functional tests
> > 	- long run / perf tests
> > ?
> > So we could keep some basic tests in fast_test.
> > I expect that tests which are not part of fast_test won't be run often or in
> > enough various environments.
> 
> It sounds like a good idea Thomas.  I ran the test couple of times and it seems that functional test #4 takes most of the time and could be removed to long run scenario. Other functional tests run rather promptly. 
> Next week, I can prepare patch to implement long and short run commands for this test suite. Would it be OK?

Yes. The goal is to have "make fast_test" really fast.
Thanks