From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 9E807559A for ; Wed, 1 Mar 2017 15:14:59 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id n11so299452wma.0 for ; Wed, 01 Mar 2017 06:14:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Pwoek4eJz7XptbkIrzvVsA0XNOltqdB+vxUxRF45CS4=; b=MZTe0t3D1bC1M+T7Whsa4CTtA4I7NjMckJdH62nylI2FK3xuuNGHb1W50cYXvpAO6l gLAGw00ijej7nive7Xfe9mGvzfBhpkwMf+DaHYLwHO2p1i7dfb2a0BsGUv2wzzesPyNb cJ3HZsh8XTBS6YzoymMnQtk63tgRlzUBCceyVnBJcenHgOdPluv+pfdPBqkGwRvvGSEq hxrHVUSOQbz9Lc1miodf4zdGH+6hxbZl88QKcvk7JYitjVEbqHT3KWSmyGTRTQZsLa6b 7+QMOy6E2LgnGtr0NGRKtbRo2oU+fDHeoclOE9p1Pn3Bugr3VBIJTBxupQFdQwzsy3hR tMOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Pwoek4eJz7XptbkIrzvVsA0XNOltqdB+vxUxRF45CS4=; b=ud+aFlO6GM5IemlPg+UnU0Rv5cJah9L+pkZDL1gFH6WzOFLDfRMTJalKEyrdrUbAbO 2y3FbfmWjiBCD950AH5PvdcRims5ArOyyk61ARkFgnMJKNOWdVJVZ5TedB2Ouuri+oqG 2XsmRnIDrh2xxnzd021mp6t5SiT/G1BdbkrSeX5BSn4V7yvdz3ro0sjbSzLS2FBxoj+0 9tR21UsF22BEi2RIYAVsk7Gk+5ZttochJ336jPEdXOMer5uJPV4lrQ8vzL/2Pr+VxiT1 Gx4axonMnG2xo9jW7OBZVoES2WSTVWDkAB8i5YqNTYW5pKhiaNJlfA3Bo4qDBxVWoNz2 g4NA== X-Gm-Message-State: AMke39kVEANbn1wMI/JRmM93vSAilczXlF5gm9z2Qms1XvG3xEq4J/ReRk6EtTlrwH6fLWY+ X-Received: by 10.28.46.74 with SMTP id u71mr3454193wmu.136.1488377699276; Wed, 01 Mar 2017 06:14:59 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id d6sm23048782wmd.6.2017.03.01.06.14.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Mar 2017 06:14:58 -0800 (PST) From: Thomas Monjalon To: "Legacy, Allain" Cc: dev@dpdk.org, "RICHARDSON, BRUCE" , Stephen Hemminger , "YIGIT, FERRUH" Date: Wed, 01 Mar 2017 15:14:57 +0100 Message-ID: <1802328.ieTeZWi1ce@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <70A7408C6E1BFB41B192A929744D85238A75943B@ALA-MBC.corp.ad.wrs.com> References: <1487985795-136044-1-git-send-email-allain.legacy@windriver.com> <20170228102701.GA141940@bricha3-MOBL3.ger.corp.intel.com> <70A7408C6E1BFB41B192A929744D85238A75943B@ALA-MBC.corp.ad.wrs.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 14:14:59 -0000 2017-03-01 13:23, Legacy, Allain: > > -----Original Message----- > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > In my experience, checkpatch ignores long lines that are due to error > > messages. Perhaps you need to put the error message on a separate line, > > if other things before the message are of significant size. > I have gone through the entire patchset and reverted my previous changes to reduce line length on any occurrences of debug log strings. I kept the error message on the first line and all input variables on subsequent lines (and no longer than 80). checkpatches.sh flags most of them as warnings, but since unbroken strings seems more important I will submit my next patchset version (v3) like this. > > WARNING:LONG_LINE_STRING: line over 80 characters > #120: FILE: drivers/net/avp/avp_ethdev.c:236: > + PMD_DRV_LOG(ERR, "Timeout while waiting for a response for %u\n", > There is maybe something to fix in the checkpatches.sh options. Please could you look at SPLIT_STRING and LONG_LINE_STRING?