From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E8F6D2B92 for ; Tue, 24 Apr 2018 18:38:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 53D0321ADF; Tue, 24 Apr 2018 12:38:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 24 Apr 2018 12:38:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=X0MpGACjNZ6jiTFNkj7hSaQ71V 9ivMw2BRrKi3qVNTw=; b=Z6Ozv691xWGz8P6ABAydyfId/w5qgu7sXEnpoadU/Y lr2IAKztzbqJgwYRR4gTM4kayVZDpqG0fH+u2ZyQhtqbCDUDBUuQw9k5ms+mm+ez tXjpfYMdtn1EL3P/9AooS1oTbZOBFqk2Tn/I1Hmbyo1bz0qbe3NCbgwfcd3I8S8R I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=X0MpGA CjNZ6jiTFNkj7hSaQ71V9ivMw2BRrKi3qVNTw=; b=WSgSNNZg0ZtljZ1c937UsD sVlxnl/K/9jrXs/kbwR4kCBiy1U+3ufwA09WdceqDTjJbu3NjZMLMuEKvhvzjKfy brBwRhqUiYCbU+RKGOxbKyUOUFP+of+KJJd4Q0TjTkSs08VQaQdp+ovdqvxw5zjy aZAlMRjEuQub/Kb38jkFlYCsdeFXHMdHGYkLcrzRgdLQgjo08KdHy0qvWZuS1DpS R53CyLxfYqdyD7NyekeYyz3AiTofp8o08uNBBXAfD8CIhqEHAbqpP+FhO8/ENmdF nfuQD65Cwpf0M1D8ZhqR5WrCaE0LaBedQJy7yppX4SbOWnnzxrIE6RU3L+zCREMQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 598CEE5036; Tue, 24 Apr 2018 12:38:52 -0400 (EDT) From: Thomas Monjalon To: Declan Doherty Cc: dev@dpdk.org, Adrien Mazarguil , Ferruh Yigit , Shahaf Shuler Date: Tue, 24 Apr 2018 18:38:50 +0200 Message-ID: <1803181.YsptMJqBZT@xps> In-Reply-To: <20180416130605.6509-3-declan.doherty@intel.com> References: <20180328135433.20203-1-declan.doherty@intel.com> <20180416130605.6509-1-declan.doherty@intel.com> <20180416130605.6509-3-declan.doherty@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 2/9] ethdev: add switch identifier parameter to port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 16:38:54 -0000 16/04/2018 15:05, Declan Doherty: > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > +/** > + * Default values for switch domain id when ethdev does not support switch > + * domain definitions. values -> value > + */ > +#define RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID (0) > + > +/** > + * Ethernet device associated switch information > + */ > +struct rte_eth_switch_info { > + const char *name; /**< switch name */ > + uint16_t domain_id; /**< switch domain id */ > + uint16_t port_id; /**< switch port id */ I feel we need more details about what is the "switch port id". [...] > @@ -1054,6 +1069,8 @@ struct rte_eth_dev_info { > struct rte_eth_dev_portconf default_rxportconf; > /** Tx parameter recommendations */ > struct rte_eth_dev_portconf default_txportconf; > + /** ethdev switch information */ Can we reword it to express that it is about the hardware built-in switch hard wired to this port? > + struct rte_eth_switch_info switch_info; > };