* [dpdk-dev] [PATCH] app/test: fix refcnt_mbuf_ring size
@ 2016-07-18 5:55 Jerin Jacob
2016-07-21 13:41 ` Olivier Matz
0 siblings, 1 reply; 3+ messages in thread
From: Jerin Jacob @ 2016-07-18 5:55 UTC (permalink / raw)
To: dev; +Cc: thomas.monjalon, olivier.matz, Jerin Jacob
rte_ring_create expects the size of the ring to
be a power of 2. REFCNT_RING_SIZE value is not
power of 2 in-case if RTE_MAX_LCORE == 96.
Fix it by aligning the size to next power of 2 value.
Fixes: af75078f ("first public release")
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
app/test/test_mbuf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
index 684ad80..c0823ea 100644
--- a/app/test/test_mbuf.c
+++ b/app/test/test_mbuf.c
@@ -809,7 +809,7 @@ test_refcnt_mbuf(void)
if (refcnt_mbuf_ring == NULL &&
(refcnt_mbuf_ring = rte_ring_create("refcnt_mbuf_ring",
- REFCNT_RING_SIZE, SOCKET_ID_ANY,
+ rte_align32pow2(REFCNT_RING_SIZE), SOCKET_ID_ANY,
RING_F_SP_ENQ)) == NULL) {
printf("%s: cannot allocate " MAKE_STRING(refcnt_mbuf_ring)
"\n", __func__);
--
2.5.5
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] app/test: fix refcnt_mbuf_ring size
2016-07-18 5:55 [dpdk-dev] [PATCH] app/test: fix refcnt_mbuf_ring size Jerin Jacob
@ 2016-07-21 13:41 ` Olivier Matz
2016-07-21 21:51 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Olivier Matz @ 2016-07-21 13:41 UTC (permalink / raw)
To: Jerin Jacob, dev; +Cc: thomas.monjalon
Hi Jerin,
On 07/18/2016 07:55 AM, Jerin Jacob wrote:
> rte_ring_create expects the size of the ring to
> be a power of 2. REFCNT_RING_SIZE value is not
> power of 2 in-case if RTE_MAX_LCORE == 96.
> Fix it by aligning the size to next power of 2 value.
>
> Fixes: af75078f ("first public release")
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> app/test/test_mbuf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c
> index 684ad80..c0823ea 100644
> --- a/app/test/test_mbuf.c
> +++ b/app/test/test_mbuf.c
> @@ -809,7 +809,7 @@ test_refcnt_mbuf(void)
>
> if (refcnt_mbuf_ring == NULL &&
> (refcnt_mbuf_ring = rte_ring_create("refcnt_mbuf_ring",
> - REFCNT_RING_SIZE, SOCKET_ID_ANY,
> + rte_align32pow2(REFCNT_RING_SIZE), SOCKET_ID_ANY,
> RING_F_SP_ENQ)) == NULL) {
> printf("%s: cannot allocate " MAKE_STRING(refcnt_mbuf_ring)
> "\n", __func__);
>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] app/test: fix refcnt_mbuf_ring size
2016-07-21 13:41 ` Olivier Matz
@ 2016-07-21 21:51 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-07-21 21:51 UTC (permalink / raw)
To: Jerin Jacob; +Cc: Olivier Matz, dev
> > rte_ring_create expects the size of the ring to
> > be a power of 2. REFCNT_RING_SIZE value is not
> > power of 2 in-case if RTE_MAX_LCORE == 96.
> > Fix it by aligning the size to next power of 2 value.
> >
> > Fixes: af75078f ("first public release")
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-21 21:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-18 5:55 [dpdk-dev] [PATCH] app/test: fix refcnt_mbuf_ring size Jerin Jacob
2016-07-21 13:41 ` Olivier Matz
2016-07-21 21:51 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).