From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 3EF0BC7E6 for ; Mon, 22 Jun 2015 12:18:48 +0200 (CEST) Received: by wgck11 with SMTP id k11so9815108wgc.0 for ; Mon, 22 Jun 2015 03:18:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=y7J2IAe+/FzKTdeeWUnYo/D/lSy1PBShn4TmeQ1ymjM=; b=Je6d1IFZGCiTMYmtB/AryP781+5T27IWRFFa6eGTeYT36W3aEcY7IsY0Bd1okrnFe+ b636D3zJQjfW1ywIvjwA6FkUlxQ+WVXVzfFUo/bJtUIx0lwDWYRxtPXcAA8q9w4GKDjx haTe6U+q4sthWQlooZFT0GV2drMFcF52017LOL715u6R8j8cZI+vSgOYr07pMbcxq/RZ sQeUcqM5ICzjgmJtCH/FFbOki9M6UQaBfvbcP5SkAW8wD/N+7JL5d7uJOb3bnkvmEiAq QCCI7T3/uzy3NKqtaskO0asnuVWpTS+sS1ujPztZ/lCVaFTqFR81eZkSTpa7PB6TkCeP H43Q== X-Gm-Message-State: ALoCoQlnW2RukhGP/WG02k2VrHWGqUWAXw0ad38gga3/IU6aEAbVNIPhd+LhHF9riL9zb2apvkgU X-Received: by 10.180.78.136 with SMTP id b8mr29764198wix.44.1434968328159; Mon, 22 Jun 2015 03:18:48 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id a19sm16528903wiv.2.2015.06.22.03.18.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jun 2015 03:18:47 -0700 (PDT) From: Thomas Monjalon To: Sergio Gonzalez Monroy Date: Mon, 22 Jun 2015 12:17:46 +0200 Message-ID: <1804687.NP6EMIYIdi@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1434465528-12907-1-git-send-email-sergio.gonzalez.monroy@intel.com> References: <1434465528-12907-1-git-send-email-sergio.gonzalez.monroy@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ixgbevf: fix link status for PF up/down events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2015 10:18:48 -0000 2015-06-16 15:38, Sergio Gonzalez Monroy: > Current ixgbe VF base driver only really read the status register when: > - get_link_status is true > - link reset > - mailbox timeout. > > We only set get_link_status to true when we start the PF/VF, so > following calls to ixgbe_dev_link_update will just keep the old link > status unless the link has been reset. > > Because of this behaviour, when the link status of the PF changes after > the VF has been initialized, we do not read the current status register > from the nic and instead we just keep the old link status. > > Fix the problem by setting this field to true before calling > ixgbe_check_link function from base driver. We don't need to check after > this call for get_link_status anymore, so remove it. > > Signed-off-by: Sergio Gonzalez Monroy Applied, thanks