From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 7EEAA239 for ; Wed, 6 Mar 2019 12:36:29 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 16F9A21E5F; Wed, 6 Mar 2019 06:36:29 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 06 Mar 2019 06:36:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=tXF8x40iSHohg0rZkeiKmVAizKfE2S8u6GGRs43lPtg=; b=czSE+jUM3sa/ BWO0qboU80kaUoDcDmFGCN91C/orf2m7xVykpBz+eYDSZAFOo/4geWDtjdRwB1AS F/igIgJlykWDoMOH4xGhaz23Z+gS9gDeWCpE+HcqmFPuKKLlasbMyI34iyhrw3ZT 6Qe+SkHboTUZ5hnPvjjyI7meHlD4cNM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=tXF8x40iSHohg0rZkeiKmVAizKfE2S8u6GGRs43lP tg=; b=X/h4f839dblXg064lAt66nkJdqocF+l155KAlCiLURu/Vj7DB6tkQZPq5 bCBi6TyEefzqnhKOW9Xti90GpaEGE7HuIdxXGgeq/CLRS78dKWH/MfaWijZTaiFF FcNbkG0od8cNWjPV+lORvP8MjOAlciesJp/dyYR6K9gmItQXRgBsFuBfTvnToyg7 +u6eipfp2vJUYwqbKDps43Nn36f1sfU9DCdR2y1XFsLcb8tSKz04hIk2bf2GAP5h PBs1ghDANxk/PrwOxggLn6SMeODQnkhxyddv1b95Aw7ENb98qzMUIioWQowmCOZn tQZAUcFcQl0uNj4gCyWrbWmd2WgaQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrfeehgdeftdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepfihikhhiphgvughirgdrohhrghenucfkphepjeejrddufeegrddvtdefrddu keegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrd hnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9CB15E4519; Wed, 6 Mar 2019 06:36:27 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Anand Rawat , pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com Date: Wed, 06 Mar 2019 12:36:23 +0100 Message-ID: <1806536.Q1iGtk73nC@xps> In-Reply-To: <20190306112006.GA134252@bricha3-MOBL.ger.corp.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <37871127.gZq9nUeyVu@xps> <20190306112006.GA134252@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/6] eal: eal stub to add windows support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2019 11:36:29 -0000 06/03/2019 12:20, Bruce Richardson: > On Wed, Mar 06, 2019 at 11:03:24AM +0100, Thomas Monjalon wrote: > > Hi, > > > > 06/03/2019 05:16, Anand Rawat: > > > -# some libs depend on maths lib > > > -add_project_link_arguments('-lm', language: 'c') > > > -dpdk_extra_ldflags += '-lm' > > > +if cc.find_library('lm', required : false).found() > > > + # some libs depend on maths lib > > > + add_project_link_arguments('-lm', language: 'c') > > > + dpdk_extra_ldflags += '-lm' > > > +endif > > > > Either libmath is required or not. > > I don't think it can be optional. > > Why is it changed? > > > > I think these come as part of libc, it's just on Linux they are not in the > main libc library but need to be linked in separately. > > https://en.wikipedia.org/wiki/C_mathematical_functions#libm > > Therefore, this looks the best way of dealing with this. If it's the only solution, at least it deserves a comment. > > > +if host_machine.system() != 'windows' > > > + common_sources = files( > > > > The definitive solution should be to compile all common EAL files. > > Please explain what are the issues in the common files. > > I think we should not remove them and fix them one by one. > > You could provide a separate patch to skip some files for > > making helloworld working. > > > > I believe that is exactly what this patch is trying to do - it's skipping > the files unneeded to get helloworld working, and the intention is to fix > them one by one and add them back in later. Perhaps this sort of change > should be a separate (precursor) patch where the cover letter can call this > out explicitly? > > > > -deps += 'kvargs' > > > +if host_machine.system() != 'windows' > > > + deps += 'kvargs' > > > +endif > > > > Why kvargs is removed? > > Again, I believe these actions are to disable the parts of DPDK that are > not needed to enable helloworld, allowing later patches to come in and fix > them. They are workarounds to build helloworld. It is good to have progress in the draft tree, but I see no point in merging this in master. I think we should separate patches which are doing definitive changes from temporary workaround patches disabling some files. It is not an issue to merge some patches for Windows which are not compiling.