From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com [209.85.128.173]) by dpdk.org (Postfix) with ESMTP id 0EC61234 for ; Wed, 5 Apr 2017 19:49:46 +0200 (CEST) Received: by mail-wr0-f173.google.com with SMTP id w43so24438101wrb.0 for ; Wed, 05 Apr 2017 10:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Umx95O77JLN8HKd6rnPYncy/0zs+Y3eSA4Mpw7QWG2Q=; b=ypycmAL7lq0+dm3eyITeoiSoby+p8URBVUyEh3V93vO/EfHuAjlqC+cUD1C1S3jmM8 h3EpqLu/Vyp/mf4zGlJgiH2lCmt4DIC+gG9i/3VSc/u2ontdn8BHFRXOhhL6H+K1y9b0 4JjPvjnsq81BrTUI/lzKPLWm1J4H3mDK/I3RBpaVyQElW36rEW6b3H/Kwi3NPH/ZW7oW 3oWOzDrFadszkIJRswFZ8ZqCH9pCHzzU9SJkhFRoIYoT+dvOixHxDPzAizxpG0FGZxvw dVvv02kGsQh7paYedeGRL8zzeFgTlqrJ7htuJMAC5SIyf0j5H1Asrzasuk1raVwznW1w y32g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Umx95O77JLN8HKd6rnPYncy/0zs+Y3eSA4Mpw7QWG2Q=; b=VgsRcS79dJeBsKSlKlJi1cssP6Yu9it4caNBXOn3cmnrYJMyWyPNf/xciURNJ9HGNX qFAgXPxGK+tABIPDEi78bUuyhEEMxYsIb3FqhoIe9L5/160CAWp3SsG+ckIiUxIXbij8 Ywg0lXPu6aVLVIvsv1GabIE3HBPzqD+fM/ZMhWWvadRgQyYx0CDixH179CNpy0CsEjmk getrJenzne72R6uCtxkUzDRAawn/M0mKLmf6GbD6cU6vB4gwCYjB70+SQW5Lk1bQ5maa zutY21luYbNa0LPwh2z4d3KZaSaMSy4P9yLpp0zZ9GDcMiSzIQOYiDrw+HiKddD+I2hX 6JMg== X-Gm-Message-State: AFeK/H3SOf6thinkYICvJGw06SmSNCJWcQW09lUcZmLEp8aGCtAWvRC3LNPreKUn76E1JRSF X-Received: by 10.223.176.88 with SMTP id g24mr26726549wra.53.1491414585695; Wed, 05 Apr 2017 10:49:45 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id l141sm23257962wma.32.2017.04.05.10.49.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 10:49:44 -0700 (PDT) From: Thomas Monjalon To: Jasvinder Singh Cc: dev@dpdk.org, olivier.matz@6wind.com, declan.doherty@intel.com, pablo.de.lara.guarch@intel.com Date: Wed, 05 Apr 2017 19:49:43 +0200 Message-ID: <1806652.2aVc4LrPS0@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1491404326-89256-2-git-send-email-jasvinder.singh@intel.com> References: <1490890533-92231-2-git-send-email-jasvinder.singh@intel.com> <1491404326-89256-1-git-send-email-jasvinder.singh@intel.com> <1491404326-89256-2-git-send-email-jasvinder.singh@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v10 1/2] librte_net: add crc compute APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 17:49:46 -0000 2017-04-05 15:58, Jasvinder Singh: > APIs for selecting the architecure specific implementation and computing > the crc (16-bit and 32-bit CRCs) are added. For CRCs calculation, scalar > as well as x86 intrinsic(sse4.2) versions are implemented. > > The scalar version is based on generic Look-Up Table(LUT) algorithm, > while x86 intrinsic version uses carry-less multiplication for > fast CRC computation. > > Signed-off-by: Jasvinder Singh > Acked-by: Pablo de Lara There is a remaining error with doxygen: lib/librte_net/rte_net_crc_sse.h:153: warning: documented symbol `static const uint8_t crc_xmm_shift_tab' was not declared or defined. > --- a/lib/librte_net/Makefile > +++ b/lib/librte_net/Makefile > @@ -39,10 +39,12 @@ EXPORT_MAP := rte_net_version.map > LIBABIVER := 1 > > SRCS-$(CONFIG_RTE_LIBRTE_NET) := rte_net.c > +SRCS-$(CONFIG_RTE_LIBRTE_NET) += rte_net_crc.c > > # install includes > SYMLINK-$(CONFIG_RTE_LIBRTE_NET)-include := rte_ip.h rte_tcp.h rte_udp.h > SYMLINK-$(CONFIG_RTE_LIBRTE_NET)-include += rte_sctp.h rte_icmp.h rte_arp.h > SYMLINK-$(CONFIG_RTE_LIBRTE_NET)-include += rte_ether.h rte_gre.h rte_net.h > +SYMLINK-$(CONFIG_RTE_LIBRTE_NET)-include += rte_net_crc.h As rte_net_crc_sse.h is not exported, you should avoid doxygen generation. I suggest removing the rte_ prefix of the filename, so it will make clear that it is a private header and doxygen should ignore it (because of FILE_PATTERNS = rte_*.h).