From: Thomas Monjalon <thomas@monjalon.net>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: dev@dpdk.org, "Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] crypto/scheduler: fix strncpy
Date: Wed, 31 Jan 2018 19:01:20 +0100 [thread overview]
Message-ID: <1807850.sLrRnkPxLN@xps> (raw)
In-Reply-To: <9F7182E3F746AB4EA17801C148F3C604330AC4E9@IRSMSX101.ger.corp.intel.com>
> > The coverity issue was not completely fixed, since strncpy should not be
> > called with max length.
> > Instead, snprintf is used as a safer option.
> >
> > Coverity issue: 143431
> > Fixes: d040aca67170 ("crypto/scheduler: fix strings not null terminated")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> >
> > v2:
> > - Replaced strncpy with snprintf
>
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-01-31 18:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 14:44 [dpdk-dev] [PATCH] crypto/scheduler: fix strncpy length Pablo de Lara
2018-01-26 14:49 ` Richardson, Bruce
2018-01-29 9:14 ` De Lara Guarch, Pablo
2018-01-29 9:22 ` [dpdk-dev] [PATCH v2] crypto/scheduler: fix strncpy Pablo de Lara
2018-01-30 12:17 ` Zhang, Roy Fan
2018-01-31 18:01 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1807850.sLrRnkPxLN@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).