From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E7B78994F; Mon, 31 Jul 2017 19:17:03 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8F973206C2; Mon, 31 Jul 2017 13:17:03 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 31 Jul 2017 13:17:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=8hj33HWHGka2j1B ODTsg8t+2c0ENan9eG0QrFxs8Azo=; b=TRcfyfntJiBqFBSO0Dn78iVBYdUVYlV 89k1Na67yANLbLij85BPNeYWwLAqPLRDxixslIMcxzVopeak8z8AEWn8vom8X4XX kpegFwA+v+dGM6Hpsa3nKa7xsRnb64V0PUFBsWPtfdunurrAt/O1EJqdqmA0WtKA 704GMvjeDtAM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=8hj33HWHGka2j1BODTsg8t+2c0ENan9eG0QrFxs8Azo=; b=jkCGU7/U InbO7wDz56Qa6hBjMlE/1JKsycf3KPFIhM4cJdYshRxTjvjfLh0P2Ue3juU0JyQl RHYBrWc8jZsBUL5XJSWxptU9GXOPYKNbhn3y54eM7JRVt+s3OwMogs8f/frTkELt QUuTRixoFMk8nqkh4FGFW2GXYGLH0JkogXj1CDOzRoX6hLDSzGZS3qmxeqvqtton 8a3KB/C2sl3RaJKpa9SXx8t+eTpHJFBBzj+Ob7/znuzWej+JiPhDjmh8nCjsJFM0 tV9z0Xm3GlJ6g/NifkXt/g+v7iimKQZkJDxwvxWvmtSk6zOqjWT1HQkf9uQ+PH4A KQDJ9kqaCh1GbA== X-ME-Sender: X-Sasl-enc: rbhPqCUUxrw1seIfy8VED1REXzCZgQ0sgXaJ0nbeVkof 1501521423 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 42A7D24604; Mon, 31 Jul 2017 13:17:03 -0400 (EDT) From: Thomas Monjalon To: Jiayu Hu Cc: dev@dpdk.org, Maxime Coquelin , yliu@fridaylinux.org, jianfeng.tan@intel.com, lei.a.yao@intel.com, stable@dpdk.org Date: Mon, 31 Jul 2017 19:17:02 +0200 Message-ID: <1809635.Jmt8xPdXRU@xps> In-Reply-To: <4732e2c6-0bef-b45a-fe57-0906d72ac661@redhat.com> References: <1500434303-12975-1-git-send-email-jiayu.hu@intel.com> <1501487804-50970-1-git-send-email-jiayu.hu@intel.com> <4732e2c6-0bef-b45a-fe57-0906d72ac661@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: fix fail to configure rxq interrupt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2017 17:17:04 -0000 31/07/2017 19:01, Maxime Coquelin: > On 07/31/2017 09:56 AM, Jiayu Hu wrote: > > When use rte_eth_dev_configure() to enable rx queue interrupt for virtio > > devices, virtio_init_device() isn't called to set up the interrupt > > environment, which causes rx queue interrupt setup failed. This patch is > > to fix this issue. > > > > Fixes: 26b683b4f7d0 ("net/virtio: setup Rx queue interrupts") > > Cc: stable@dpdk.org > > > > Signed-off-by: Jiayu Hu > > Looking at v1's discussions, it seems to be the right fix. > I haven't tried it myself, but it looks good to me: > Reviewed-by: Maxime Coquelin Applied, thanks