From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
dev@dpdk.org, Chas Williams <chas3@att.com>
Subject: Re: [dpdk-dev] [PATCH] net/af_packet: fix build failure because of unused parameter
Date: Mon, 25 Sep 2017 16:24:21 +0200 [thread overview]
Message-ID: <1809804.5fyl0q0CTl@xps> (raw)
In-Reply-To: <e987c543-fb5c-6143-87b2-f9d7c205ba59@intel.com>
25/09/2017 12:06, Ferruh Yigit:
> On 9/25/2017 10:53 AM, Ferruh Yigit wrote:
> > On 9/25/2017 10:40 AM, Bruce Richardson wrote:
> >> On Mon, Sep 25, 2017 at 09:42:56AM +0100, Ferruh Yigit wrote:
> >>> It is a little to late for this, I already sent a pull-request with this
> >>> patch. So fix will need to be a separate patch.
> >>>
> >> Pull request hasn't actually been pulled yet, so you should be able to
> >> supercede it by a later one, right?
> >
> > Technically yes, and easy to do, but it will be confusing. I was taking
> > pull-request as code freeze in sub-tree.
> >
> > If there are multiple pull-request for a tree, how can one be sure which
> > ones has been pulled and what to expect in main repo, and verify what
> > has been merged?
> >
> > As above said, if Thomas thinks this is OK, I can send another pull request?
>
> What about Thomas doing the squash while applying to the main repo, so
> that main repo won't be broken and there won't be multiple pull requests
> around?
Yes, no need of sending a new pull request.
next prev parent reply other threads:[~2017-09-25 14:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 6:50 Andrew Rybchenko
2017-09-25 8:42 ` Ferruh Yigit
2017-09-25 9:04 ` Andrew Rybchenko
2017-09-25 9:40 ` Bruce Richardson
2017-09-25 9:53 ` Ferruh Yigit
2017-09-25 10:06 ` Ferruh Yigit
2017-09-25 12:49 ` Ferruh Yigit
2017-09-25 14:24 ` Thomas Monjalon [this message]
2017-09-25 12:52 ` Ferruh Yigit
2017-09-25 12:53 ` Ferruh Yigit
2017-10-05 18:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1809804.5fyl0q0CTl@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).