From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 0AA402BD3 for ; Tue, 27 Mar 2018 18:15:59 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A470020D89; Tue, 27 Mar 2018 12:15:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 27 Mar 2018 12:15:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=zYmkbpExkBsOXY24yZulE1wBEL jNRHdAYlDlNllhAfA=; b=GMNQqv/4ns1XPfLfiHx68fpznoZsSJUfy9dULeKpnN xO4XYPKQQ2SfSAqWhn1tQ2wxHrn10ko+ATL7o299TTfpmzyR0QiVVD1YI1tGf/ZA 8KKVvsakl56987GPF2QpljZELgiE2COI9kGIxXExqlhqPuKXtaG8YztfK3otjxor E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=zYmkbp ExkBsOXY24yZulE1wBELjNRHdAYlDlNllhAfA=; b=awGvs3JKDyrjZfwlALtdcu 2PbxP6f5/yrxzkYAIiMIdbKY48LRYrfJaB/ga5N+xh1bKWm2t+JZiKCJ4HQWmIWs yjJx4+KnCpUEB+4VqT2piEBU5Cp8cKQsYbMZ2wTx/38cY2ZOUogE0SHFaaBKntRW vyZyjWG3XV7TT+TY3vRZgJ0LXfEsHQrQ/XXl/bQZJlc6J3o17J1TnHzH6/G+SE4P X30Yp3+bRFBUuLAm4WBE5aW123EzvR94l7z+bbOBi6NhzcnKbERGunN0XO/Ebk8v 0MGb2RiAsp453tZSfrWK5kF3FtbgSenGVib+rlpyupjS+0Et3e5bHpQde++XrATw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7788A1025D; Tue, 27 Mar 2018 12:15:57 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com, anatoly.burakov@intel.com, lironh@marvell.com, bruce.richardson@intel.com, fiona.trahe@intel.com, shreyansh.jain@nxp.com, hemant.agrawal@nxp.com Date: Tue, 27 Mar 2018 18:15:56 +0200 Message-ID: <1810472.xOB8M7Gf6E@xps> In-Reply-To: <20180326075344.2209-2-pbhagavatula@caviumnetworks.com> References: <20180319092726.10153-1-pbhagavatula@caviumnetworks.com> <20180326075344.2209-1-pbhagavatula@caviumnetworks.com> <20180326075344.2209-2-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 2/2] octeontx: move mbox to common folder X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 16:15:59 -0000 Hi, 26/03/2018 09:53, Pavan Nikhilesh: > Move commonly used functions across mempool, event and net devices to a > common folder in drivers. > > Signed-off-by: Pavan Nikhilesh > --- > drivers/common/Makefile | 4 ++ > drivers/common/meson.build | 1 + > drivers/common/octeontx/Makefile | 24 ++++++++ > drivers/common/octeontx/meson.build | 6 ++ > .../{mempool => common}/octeontx/octeontx_mbox.c | 65 +++++++++++++++++----- > .../{mempool => common}/octeontx/octeontx_mbox.h | 14 +++++ > .../octeontx/rte_common_octeontx_version.map | 9 +++ > drivers/event/octeontx/Makefile | 4 +- > drivers/event/octeontx/meson.build | 5 +- > .../{mempool => event}/octeontx/octeontx_ssovf.c | 20 ++++++- > drivers/mempool/octeontx/Makefile | 5 +- > drivers/mempool/octeontx/meson.build | 6 +- > drivers/mempool/octeontx/octeontx_fpavf.c | 4 -- > drivers/mempool/octeontx/octeontx_pool_logs.h | 9 --- > .../octeontx/rte_mempool_octeontx_version.map | 6 -- > drivers/net/octeontx/Makefile | 3 +- You need to update MAINTAINERS for this new directory. > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -217,6 +217,10 @@ endif # CONFIG_RTE_LIBRTE_DPAA_BUS > > endif # CONFIG_RTE_LIBRTE_CRYPTODEV > > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF)$(CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL),yy) > +_LDLIBS-y += -lrte_common_octeontx > +endif > + > ifeq ($(CONFIG_RTE_LIBRTE_EVENTDEV),y) > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_EVENTDEV) += -lrte_pmd_skeleton_event > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SW_EVENTDEV) += -lrte_pmd_sw_event It is strange to insert common lib in the middle of PMDs after crypto and before eventdev, in the "static-only" section. I think it should be just after bus libs. Please test static and shared library compilation. Thanks