From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 225631BB5A; Thu, 21 Jun 2018 10:25:15 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C7A5B21B68; Thu, 21 Jun 2018 04:25:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 21 Jun 2018 04:25:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Lt3/6rJFQC8aUy7kRAMUvirz1s 7L6nfq5wYGkAlNPnw=; b=DWkrJzjnCkKejO6+ODTL63QoPEy2ZwHEYEoDxYEOts q1djlWYs7oEnk/enVUxVpjDz9cWCY03D4j659fIFdYwRuOwdWQ1o0cEfxX46vmlc 6wbujWncQGPyz5ZGZiGe46UKUgtYeHTeMxlAi7Clc+11PFWUoMWeIH8zA2DLIL4Q I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Lt3/6r JFQC8aUy7kRAMUvirz1s7L6nfq5wYGkAlNPnw=; b=JwiXL9bKvjMPJdKBSmC8ml ANtaJBBx08VsbM/cH2eQ85RUWPEa/HUt68WKzCbeoMsAKFllETfOI167b4GY597N BIAMl4YulIGB8R7EyyC+0mjVbNFFLa3YZ/2AgEwgr27+lR37ABnr/CfVkD3vb6W8 xUP76yu/Iw29oPRRvJIfdeeADqzMI2QXR05S/2dp+jx7EkWEovKXOQPBNuNLxluG g1tzcI8vdwrNqbFOQk7qGLykuI6b7KbsiiYy1UsCCGz4dU2jUNwGTjsWgStufHd4 9iGsDmrsuKbjqBmaaFjPnPdiIbnIuWiZFhr0Y1ZpEo5ppehJOAz/JKtUzDgX5K4A == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C9EF110255; Thu, 21 Jun 2018 04:25:12 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: stable@dpdk.org, Shreyansh Jain , dev@dpdk.org, hemant.agrawal@nxp.com, bruce.richardson@intel.com Date: Thu, 21 Jun 2018 10:25:11 +0200 Message-ID: <1811028.V65RX0Btn7@xps> In-Reply-To: <8af66cf6-6059-424d-c6d7-1c2439204b9e@nxp.com> References: <20180604025246.25548-1-jerin.jacob@caviumnetworks.com> <8af66cf6-6059-424d-c6d7-1c2439204b9e@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] bus/dpaa: fix compilation issue with meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 08:25:15 -0000 05/06/2018 08:20, Shreyansh Jain: > On 6/4/2018 8:22 AM, Jerin Jacob wrote: > > ccache gcc -Idrivers/drivers@@tmp_rte_pmd_dpaa_sec@sta -Idrivers > > In file included from ../drivers/bus/dpaa/include/fsl_usd.h:11, > > from ../drivers/crypto/dpaa_sec/dpaa_sec.c:27: > > ../drivers/bus/dpaa/include/compat.h:53: > > error: "__packed" redefined [-Werror] > > #define __packed __rte_packed > > > > In file included from /usr/include/bsd/string.h:39, > > from ../lib/librte_eal/common/include/rte_string_fns.h:71, > > from ../drivers/crypto/dpaa_sec/dpaa_sec.c:25: > > /usr/include/bsd/sys/cdefs.h:120: note: this is the location > > of the previous definition > > # define __packed __attribute__((__packed__)) > > > > Cc: stable@dpdk.org > > Fixes: 39f373cf015a ("bus/dpaa: add compatibility and helper macros") > > > > Signed-off-by: Jerin Jacob > > --- > > Thanks Jerin. > Somehow, this didn't appear on my build environment (maybe because LIB > BSD is not enabled?). But, the change looks harmless. > > Acked-by: Shreyansh Jain I missed this patch and sent a more complete one recently: https://patches.dpdk.org/patch/41314/