From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 2FB522951
 for <dev@dpdk.org>; Fri, 12 Jan 2018 17:36:44 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 8D80621012;
 Fri, 12 Jan 2018 11:36:44 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Fri, 12 Jan 2018 11:36:44 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=xrgANoyAcZTNbjd85Sdr/340nB
 xib5eCEIMNqvDUdWc=; b=WxOVKnu3CiF0GQP8Xj7iCM3WLwHi8kc309FMBgH3jU
 fTGMX8PtyTajyx4tSlt6KiIvRqhz6ryu4KbQyvwFXVaWfPEX/x3dZ7dtzIUI6nEN
 q6ALi2ZVVzAuEMjS3OL88dBiaKwjU5K9dykG88ocsCRfWnjCymhbWqMUlEE5ZDoX
 8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=xrgANo
 yAcZTNbjd85Sdr/340nBxib5eCEIMNqvDUdWc=; b=M/nbRcAYKkIMu370Gc/5y9
 BYy+qWkWscEL73rn7CMd28L+mYDvzSLlLgJUvdCGd3miPIi7GB0brTGOdPUJ0GoX
 gYe/42sNLMkWssQb+jqKIFdb9Nj/+nApaUaiwZZy6nRDIlD3RUvl8t+mm7YvLrJn
 uc8PPT8bVnmfyCe9tTDleAyde/6nbbVXWk7gkyVLY/G4Fr2wSiHZG6lYPRwtbaGj
 MNYWV1zWHTPf49hMNw6tR6PjN0lPfCnSst0XFmnrMFPvTEDY1wLWfyZIyXLpknTi
 tuNx+aDD9veBNf1Gaw0Rs1ekLlChgi76EzwVTsUmYTORqEyP2nWTbIdgxJp1oJ9A
 ==
X-ME-Sender: <xms:HORYWk9LOaHuNo1STdNUg8TrNgmJ1CddmT2klghY1Niq6a3V8DuaAA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 452997E353;
 Fri, 12 Jan 2018 11:36:44 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Hemant Agrawal <hemant.agrawal@nxp.com>, anatoly.burakov@intel.com
Cc: dev@dpdk.org, shreyansh.jain@nxp.com
Date: Fri, 12 Jan 2018 17:36:14 +0100
Message-ID: <1811467.p4hthpzDLK@xps>
In-Reply-To: <1512642493-14609-1-git-send-email-hemant.agrawal@nxp.com>
References: <1512642493-14609-1-git-send-email-hemant.agrawal@nxp.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 01/2] vfio: expose clear group function for
	internal usages
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Jan 2018 16:36:45 -0000

07/12/2017 11:28, Hemant Agrawal:
> other vfio based module e.g. fslmc will also need to use
> the clear_group call.
> So, exposing it and renaming it to *rte_vfio_clear_group*
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> --- a/lib/librte_eal/linuxapp/eal/eal_vfio.h
> +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.h
> @@ -179,7 +179,7 @@ vfio_get_group_fd(int iommu_group_no);
>  
>  /* remove group fd from internal VFIO group fd array */
>  int
> -clear_group(int vfio_group_fd);
> +rte_vfio_clear_group(int vfio_group_fd);

The function should be moved to lib/librte_eal/common/include/rte_vfio.h
and an empty implementation must be added for BSD.

Related note: in drivers/bus/fslmc/fslmc_vfio.h there is
	#include "eal_vfio.h"
Can it be removed?