From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id EAF4D569E for ; Tue, 12 May 2015 15:07:56 +0200 (CEST) Received: by widdi4 with SMTP id di4so14691874wid.0 for ; Tue, 12 May 2015 06:07:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=I5HdbIbRSyClwYbwOW8+J0Y3PGahPoOy/lrRlPHOjyY=; b=ir4CJMsRkWV5Jlsh2R+ZSpl6SuUUsv8iq2Q7lQrfUjfpx68lItqaMvI+2cDWBnDHb5 rp3uGsudBX+iJUkFefPArwQbaVbEA5NbjSNtMw2TOTg5jp2QyTVOdjSCBgNgGXOv3MvK J8dnKAMhZyp8hJS34Iver4ls4j458wMOfhvzh+K11GYlnjp7FoqcUZsS/Wjgj2vWi9YH gYccpnZaOZkCW1RcYAXRV6hrmG5yoD0xU3vc9OnqsT0KalinDDDfE8pkwDfEwzCHHXEz VV+DZ7na00BQ+kpaEdj5YJVQX2Pjq5tBwzxKP5aP3fQ4mDIweSssfFSRKHhsEfyNF26M TcUg== X-Gm-Message-State: ALoCoQmppq64h9NWH67Y97LXXJbSfcxcQ4T81A9mOYGBNmPoE/qhrC0/Pn3jjk3CpLoVykqYvgLJ X-Received: by 10.194.121.68 with SMTP id li4mr30762441wjb.84.1431436076779; Tue, 12 May 2015 06:07:56 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id o5sm2979739wia.0.2015.05.12.06.07.55 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 May 2015 06:07:55 -0700 (PDT) From: Thomas Monjalon To: Keith Wiles Date: Tue, 12 May 2015 15:07:14 +0200 Message-ID: <18120312.yv66er7Y4a@xps13> Organization: 6WIND User-Agent: KMail/4.14.7 (Linux/4.0.1-1-ARCH; KDE/4.14.7; x86_64; ; ) In-Reply-To: <1430490587-6806-1-git-send-email-keith.wiles@intel.com> References: <1430490587-6806-1-git-send-email-keith.wiles@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Remove NO_AUTOLIBS option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2015 13:07:57 -0000 2015-05-01 09:29, Keith Wiles: > NO_AUTOLIBS is not required as it was not used or defined in the config files. > > Signed-off-by: Keith Wiles > --- > mk/rte.app.mk | 5 ----- > 1 file changed, 5 deletions(-) Thanks Keith for trying to clean it, but removing half of an obsolete feature is not a real clean-up ;) When running "git grep NO_AUTOLIBS", it will return results in doc/guides/prog_guide I fixed the doc and manually applied your patch based on your _LDLIBS-y patch. Maybe I'm too kind, I know people who whould refuse this patch :) Sorry for being long here, but I want to show the work done when applying patches and I want to ask: is it a good thing to manually fix patches in order to speed-up the process or should it be more strict?