From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 2DF6E36E for ; Thu, 15 May 2014 19:14:22 +0200 (CEST) Received: by mail-wi0-f172.google.com with SMTP id hi2so10190557wib.17 for ; Thu, 15 May 2014 10:14:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=dHVu8t4KtI8TA1/BfMJCllJdwqb4m91vdmivpwGFqe0=; b=CL5zehCgdPtdwAt/PCv++Y/pQIBxrQe2qqEYs9XZniWuBQBBZpeVRhhJrWz5TK+SBJ EtsoX6734WlJ6xqOBtSke3yrYLRLWqmqB0bCwvA1Leqwp6bVkzjE1NCXZe7HNubC+C4i zH2Pxn+UNmO2bIStBhXM0f/0rDbCJ3R96jXO5z7p4oZGU1D4iusd5LukG8PgosJF8PTI VtxvJbYRTGjvN3IhgwJdb0yJAAx4WGs9+GYivPHaPyMzWEYER8uNuoSKZwKSuNwPN9pK JuxRmD0FUAWhwexJguIERcbh4nKfDAo17dzKM4NuNYstQH9s+Se8s5Lse3nFUrZkEOpB eoOg== X-Gm-Message-State: ALoCoQlhLk84D4LVCQVJPuApX2HJgLHsWH03Uy5EaeFMwua8OAfAIRRN8gwZ5TmaWnN/4Fb19h5t X-Received: by 10.194.63.196 with SMTP id i4mr9643543wjs.50.1400174069998; Thu, 15 May 2014 10:14:29 -0700 (PDT) Received: from xps13.localnet (2.17.90.92.rev.sfr.net. [92.90.17.2]) by mx.google.com with ESMTPSA id ch16sm7534097wjb.43.2014.05.15.10.14.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 May 2014 10:14:28 -0700 (PDT) From: Thomas Monjalon To: Stephen Hemminger Date: Thu, 15 May 2014 19:14:20 +0200 Message-ID: <1812257.SL2iW8YYEL@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <20140514185752.176396147@networkplumber.org> References: <20140514185527.771828962@networkplumber.org> <20140514185752.176396147@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Stephen Hemminger Subject: Re: [dpdk-dev] [PATCH 6/6] vmxnet3: replace Intel driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 May 2014 17:14:22 -0000 Hi Stephen, 2014-05-14 11:55, Stephen Hemminger: > Replace the Intel VMXNET3 driver with the one developed by Brocade. > The Intel code was a missing features, and had style and other issues. > > Major changes: > - supports multi-segment > - supports vlan offload > - per queue stats > > Fixes: > - link update reports link change correctly > - allows reconfiguration of # of queues > (original code would have too small memzone). > > Signed-off-by: Stephen Hemminger We cannot replace a driver by another one without comparing performances. Actually there is no good reason to remove an implementation if some people are willing to maintain it. Please send a patch to import your vmxnet3 PMD as extension in a separated repository like these ones: http://dpdk.org/browse This way, we can have a first integration step and discuss/test this implementation during the next release cycle. Thank you for contributing -- Thomas