From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org,
Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>,
Aaron Conole <aconole@redhat.com>,
Ruifeng Wang <ruifeng.wang@arm.com>,
David Marchand <david.marchand@redhat.com>,
Gavin Hu <gavin.hu@arm.com>
Subject: Re: [dpdk-dev] [PATCH v3] test: remove meson dependency on /proc file
Date: Fri, 10 Apr 2020 14:27:30 +0200 [thread overview]
Message-ID: <1813726.1xdlsreqCQ@thomas> (raw)
In-Reply-To: <20200410104219.GE625@bricha3-MOBL.ger.corp.intel.com>
10/04/2020 12:42, Bruce Richardson:
> On Fri, Apr 10, 2020 at 12:29:50PM +0200, Thomas Monjalon wrote:
> > --- a/app/test/meson.build
> > +++ b/app/test/meson.build
> > has_hugepage = true
> > if is_linux
>
> Since you check for linux in the script, you can drop these two lines,
The issue is for Windows.
I am not sure how we will skip shell scripts
when adding Windows support for this application.
So there are two options now:
a) remove Linux check before calling the script and ignore Windows support for now
b) keep Linux check without knowing whether it will be useful for Windows support
We vote a?
next prev parent reply other threads:[~2020-04-10 12:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200409180425eucas1p207746156e52ec225d173466de7bee9f4@eucas1p2.samsung.com>
2020-04-09 18:03 ` [dpdk-dev] [PATCH] " Thomas Monjalon
2020-04-09 18:10 ` Lukasz Wojciechowski
2020-04-09 19:24 ` Thomas Monjalon
2020-04-09 18:58 ` Lukasz Wojciechowski
2020-04-09 19:34 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2020-04-09 19:52 ` Lukasz Wojciechowski
2020-04-09 19:57 ` Aaron Conole
2020-04-10 1:14 ` Ruifeng Wang
2020-04-10 10:29 ` [dpdk-dev] [PATCH v3] " Thomas Monjalon
2020-04-10 10:42 ` Bruce Richardson
2020-04-10 12:27 ` Thomas Monjalon [this message]
2020-04-10 13:25 ` Bruce Richardson
2020-04-10 14:41 ` Thomas Monjalon
2020-04-10 20:47 ` Lukasz Wojciechowski
2020-04-10 22:22 ` Stephen Hemminger
2020-04-15 13:14 ` Thomas Monjalon
2020-04-10 14:05 ` Aaron Conole
2020-04-15 13:19 ` [dpdk-dev] [PATCH v4] " Thomas Monjalon
2020-04-15 13:28 ` Richardson, Bruce
2020-04-15 13:30 ` Thomas Monjalon
2020-04-15 13:36 ` David Marchand
2020-04-15 13:40 ` Thomas Monjalon
2020-04-15 13:49 ` David Marchand
2020-04-15 13:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1813726.1xdlsreqCQ@thomas \
--to=thomas@monjalon.net \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=l.wojciechow@partner.samsung.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).