From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D89BDA052A; Sat, 11 Jul 2020 00:30:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B84881D9FD; Sat, 11 Jul 2020 00:30:18 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 131AB1D9FC for ; Sat, 11 Jul 2020 00:30:17 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id C7F851615; Fri, 10 Jul 2020 18:30:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 10 Jul 2020 18:30:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= Fm7Q1jk/E3PJ8U1rBACaBaS9ufIlkMFi0D6OK7k3nhI=; b=f4AhI1KOnkSn6G7J +qOOXcPt8/dQ8Wzv+WcCB+fvuUiMHwLzyu0fKigrCWS0tklF3xFrmM3epQdI4syU V+PAhiGSWy5XOvFfWXf6Zl9zEbuNdBtMGfx+XVB9rO86r8YJum4FpYK3hnC1YmFQ w7H7ptRiWOWc3OQuHeptduzYIrx7bQhdXePVZsuDK48lXNQ8FD/AYP3UJxZhDODc jWlp00umPbBiCMBtcvS8ouQ7ladmAYpKSA3DMyOV7yTnvrIt3M+pQaPxTw589xEn +SwEAY6xQkxSHJ4U2YHokMpHWZqqz4CVipYo6bH6L/WWp1VX/PrtKJXF0ntDE4ZS 6Yo6pw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Fm7Q1jk/E3PJ8U1rBACaBaS9ufIlkMFi0D6OK7k3n hI=; b=tWlv7NO6sHgkJv+gn4OW/rU/LuuCF2b8LFQQC2uZWnkFhjgqnEpT8wYpX d9XWNdH/h+oTpsywU0jyOwMHoHPAn7QzBWlPn/1CpKifIo7WAnRojIWOqbgzdLiG yDhV0TUDCEwpjlwgZZbcM0wnh/4mD/to+/NI0VNykfcSAY8u/ETmtYvSPZKgjX5a G+LslDnqfPUmQ91GVmbuFNWMYXuEhE0vZN77Xl5/r1eY/fr7MXJImpHO4rhQIT0N CAEJkjPICHv4p/ivWGn9tzvlGZmfZdK3EGPzocdnfRg8H+h0QtMy4dy0o1yEWyT/ yOYYN6Z2X/35+JYfZoqToZGQwVzCA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvddvgddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5E55C3280063; Fri, 10 Jul 2020 18:30:14 -0400 (EDT) From: Thomas Monjalon To: Hemant Agrawal Cc: dev@dpdk.org, Stephen Hemminger Date: Sat, 11 Jul 2020 00:30:12 +0200 Message-ID: <1814150.q2JAx3WZxH@thomas> In-Reply-To: <20200519081936.6d188c99@hermes.lan> References: <20200513113822.8681-1-hemant.agrawal@nxp.com> <20200514093001.12007-1-hemant.agrawal@nxp.com> <20200519081936.6d188c99@hermes.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCHv2 1/2] bitratestats: add support for free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/05/2020 17:19, Stephen Hemminger: > On Thu, 14 May 2020 15:00:00 +0530 > Hemant Agrawal wrote: > > > > +int > > +rte_stats_bitrate_free(struct rte_stats_bitrates *bitrate_data) > > +{ > > + if (bitrate_data) > > + rte_free(bitrate_data); > > + return 0; > > +} > > rte_free of NULL is allowed, the test is not needed. > > Should be void not int function. Ping, why no answer? Can we expect a v3?