From: Thomas Monjalon <thomas@monjalon.net>
To: Ophir Munk <ophirmu@mellanox.com>
Cc: dev@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Pascal Mazon <pascal.mazon@6wind.com>,
Jan Viktorin <viktorin@rehivetech.com>,
Jianbo Liu <jianbo.liu@arm.com>
Subject: Re: [dpdk-dev] [PATCH] net/tap: fix build issue with ARM32
Date: Wed, 31 Jan 2018 12:19:06 +0100 [thread overview]
Message-ID: <1814250.kpiQluYUny@xps> (raw)
In-Reply-To: <AM0PR0502MB3875A2B143A6D122471D431BD1FB0@AM0PR0502MB3875.eurprd05.prod.outlook.com>
31/01/2018 11:38, Ophir Munk:
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > > arm architecture is missing is file drivers/tap/tap_bpf.h I suggest
> > > adding it, for example
> > >
> > > # elif defined(__arm__)
> > > # define __NR_bpf 386
[...]
> > I am not sure, Is eBPF support available for arm32 support?
>
> TAP eBPF has a graceful approach: it must successfully compile on all Linux
> distributions. If a specific kernel cannot support eBPF it will gracefully
> refuse the eBPF netlink message sent to it.
> Thus, there is no harm even if there is no eBPF support available for arm32.
>
> You should enable TAP compilation for cases where you only need TAP without eBPF.
Ophir, please send a patch.
next prev parent reply other threads:[~2018-01-31 11:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 5:14 Jerin Jacob
2018-01-31 9:59 ` Ophir Munk
2018-01-31 10:23 ` Jerin Jacob
2018-01-31 10:38 ` Ophir Munk
2018-01-31 11:19 ` Thomas Monjalon [this message]
2018-01-31 11:30 ` Jerin Jacob
2018-01-31 11:57 ` Ophir Munk
2018-01-31 12:40 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1814250.kpiQluYUny@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jianbo.liu@arm.com \
--cc=ophirmu@mellanox.com \
--cc=pascal.mazon@6wind.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).