From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 763FB1B759
 for <dev@dpdk.org>; Wed, 31 Jan 2018 12:19:53 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 164F120D2D;
 Wed, 31 Jan 2018 06:19:53 -0500 (EST)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Wed, 31 Jan 2018 06:19:53 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=aBcDHIrtKGJBjziG4A7UCVK1Zt
 XQVLVR3lBqg4hx0JA=; b=FMdPqpFMBRShVuVjv7EUS7lvWoyyMR3GeNZvXl3Aq+
 DHsJB4qnz4srqAhLIF2zLZsoB3LyKOQdHvy6t7RskocmMbE6mOCcHqV/0PwhdNus
 Bh4frSlV8DExBJTiDMHC44k9XNrRxKQHTT6wiY6c9CGK8vP+VOi558yOqgc3xG2y
 U=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=aBcDHI
 rtKGJBjziG4A7UCVK1ZtXQVLVR3lBqg4hx0JA=; b=XpZQ7W0lGgWfMoyNJl+CpL
 ZkwkYOUkR+mMrImQWEAx6wrOuvn3H9SY4BaDc0tz5ybUPeHJwRLR/xjcCOJYh1Nr
 Kb17jd16iiPaounKhPgvMRSkwEbPbY/0K8o6V2RkawhfeC2GYiPUB06d15soez+K
 1ik1E85B3+Z18wGGlzG1Q6k7gfF0Lwo7MR11JpivNLxz+qcGOHUd0w00GcefyQ1v
 87tqkkHAtcomy4buLwOZ9NDlEbS6t+Xyt2yNk8jGJD0q1O5FSm7B3jixz/jiFIoC
 1Sb5JiEVoGCBS/4Etx3SpmJWugE+UyrYsVaP1hxsM+X82ZOKoyJ1P/e5UpCTGJ3A
 ==
X-ME-Sender: <xms:WKZxWhxAfFe9EP7xH8LBIMr6Z8sZ1SZ-lpi8BxCIzUdIOUKkIo86xQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id B54A6247A1;
 Wed, 31 Jan 2018 06:19:52 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ophir Munk <ophirmu@mellanox.com>
Cc: dev@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Pascal Mazon <pascal.mazon@6wind.com>, Jan Viktorin <viktorin@rehivetech.com>,
 Jianbo Liu <jianbo.liu@arm.com>
Date: Wed, 31 Jan 2018 12:19:06 +0100
Message-ID: <1814250.kpiQluYUny@xps>
In-Reply-To: <AM0PR0502MB3875A2B143A6D122471D431BD1FB0@AM0PR0502MB3875.eurprd05.prod.outlook.com>
References: <20180131051408.3652-1-jerin.jacob@caviumnetworks.com>
 <20180131102352.GA24477@jerin>
 <AM0PR0502MB3875A2B143A6D122471D431BD1FB0@AM0PR0502MB3875.eurprd05.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] net/tap: fix build issue with ARM32
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Jan 2018 11:19:53 -0000

31/01/2018 11:38, Ophir Munk:
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > > arm architecture is missing is file drivers/tap/tap_bpf.h I suggest
> > > adding it, for example
> > >
> > > # elif defined(__arm__)
> > > #  define __NR_bpf 386
[...]
> > I am not sure, Is eBPF support available for arm32 support?
> 
> TAP eBPF has a graceful approach: it must successfully compile on all Linux
> distributions. If a specific kernel cannot support eBPF it will gracefully
> refuse the eBPF netlink message sent to it. 
> Thus, there is no harm even if there is no eBPF support available for arm32.
> 
> You should enable TAP compilation for cases where you only need TAP without eBPF.

Ophir, please send a patch.