From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA101A04DD; Wed, 21 Oct 2020 09:54:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 400EAACC7; Wed, 21 Oct 2020 09:53:58 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id B0A46ACC1 for ; Wed, 21 Oct 2020 09:53:55 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id BEEEA763; Wed, 21 Oct 2020 03:53:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 21 Oct 2020 03:53:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 6dG0n1iSo7aj/mtw9H8gL4GFuSZSLd4wwTd+ynl7heo=; b=AGS7xScxJUZS98R5 +USlH6F9CuvqwfP9EskdSwGg0EANkQVK1lPqum5X7en8D6NSw5XmnAUEltq1h0is jg2yjh996XEmSva0aORBpe6SZEqrZASfODsMZno53Fm7j6cVZw2PFy/H+PyIFzDV e1Ec/67xpxTIAq1HRelpCKnS7JwTibQ0sIO7AHHoxP3XCYP1h50353o8VAC9OKGa /Xnwi+IvGonD8XJDh+ZZlpUC0BBlCvCsHPnoMubqNp4+/oSFy4++/wXmoKu2+HP8 ELO2dXIIBAZmdcUioWKU/+EalEN6nTjAWx+fZ3CS4PXvY4GXqyG/OpkDNazDUNpT Cof6CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=6dG0n1iSo7aj/mtw9H8gL4GFuSZSLd4wwTd+ynl7h eo=; b=gEtzdkD30dloLeYxDPjq6hT/7eCxmLLL07kk8awEbIcUO4c+xykuOXbXa 57JRJkasq4mckEI/BZtCPKmM71pzaZKiyr6Ui4dAm1CN58PhjOwQsNtJ4gGeRZN4 FR0/gi0nGxoDAhkFPfvafHnxRP1fZwoLFxmjqm0UVw6P/H/Ozo7G6wYKTalefJ3E uSEcw65ivgq+U0BXxlWPUjWdC8HlMyb92/6bU1asCHu8PMJ7FRYSy0xRHxr4Zf4Q xxDS43ks3mkPp22wCGMi0YWrUv2NXNH0G1QCikhJrlNbJyA/X3LsXLFI43oMNOF1 4yMNzBdo5tUoVU9TfHHsUeZEDyK/Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjeeggdduvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7CBC53280059; Wed, 21 Oct 2020 03:53:49 -0400 (EDT) From: Thomas Monjalon To: Ori Kam , Guy Kaneti Cc: "dev@dpdk.org" , Smadar Fuks , Dovrat Zifroni , Jerin Jacob Kollanukkaran Date: Wed, 21 Oct 2020 09:53:48 +0200 Message-ID: <1814836.qjuG4n952W@thomas> In-Reply-To: References: <20201020081624.25210-1-guyk@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v1] regexdev: add OOS capability definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/10/2020 09:39, Guy Kaneti: > From: Ori Kam > > From: Guy Kaneti > > > From: Thomas Monjalon > > > > 20/10/2020 10:16, guyk@marvell.com: > > > > > From: Guy Kaneti > > > > > > > > > > Add out of order scan capability to check PMD support for OOS. > > > > > > > > > > Signed-off-by: Guy Kaneti > > > > > --- > > > > > --- a/lib/librte_regexdev/rte_regexdev.h > > > > > +++ b/lib/librte_regexdev/rte_regexdev.h > > > > > +#define RTE_REGEXDEV_CAPA_QUEUE_PAIR_OOS_F (1ULL << 22) > > /**< > > > > RegEx > > > > > +device support out of order scan, this means the scan can be > > > > > +retired > > > > > > > > s/support/supports/ > > > > > > I followed the other RTE_REGEXDEV_CAPA_ definitions I can fix it here > > > > > > > > > > > What means "retired"? > > > > > > This was the original description in the rte_regexdev.h: > > > > > > #define RTE_REGEX_QUEUE_PAIR_CFG_OOS_F (1ULL << 0) /**< Out of > > order > > > scan, If not set, a scan must retire after previously issued > > > * in-order scans to this queue pair. If set, this scan can be retired > > > as soon > > > * as device returns completion. Application should not set out of > > > order scan > > > * flag if it needs to maintain the ingress order of scan request. > > > > > I agree with Thomas, it is not very clear, The idea was to show that a scan can > > return a result From newer job/search on a specific queue before a previous > > job on the same queue is completed. > > How about this description: > > /**< RegEx device supports out of order scan. > * Out of order scan means the response of a specific job can be returned as > * soon as it is ready even if previous jobs on the same queue didn't complete. A lot better :) Thanks