* [dpdk-dev] [PATCH] devtools: skip ABI check in static builds
@ 2020-04-21 1:33 Thomas Monjalon
2020-04-21 6:11 ` Ray Kinsella
2020-04-21 8:02 ` David Marchand
0 siblings, 2 replies; 5+ messages in thread
From: Thomas Monjalon @ 2020-04-21 1:33 UTC (permalink / raw)
To: dev; +Cc: david.marchand, mdr
When running make with CONFIG_RTE_BUILD_SHARED_LIB=n,
no shared library is built.
In this case, no need to run ABI check.
With meson, both shared and static libraries are always built.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
devtools/test-build.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index a298115002..6e53f86fc8 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -262,6 +262,7 @@ for conf in $configs ; do
EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
O=$(readlink -f $dir)/examples
unset RTE_TARGET
+ grep -q 'SHARED_LIB=n' $dir/.config || # skip ABI check with static libs
if [ -n "$DPDK_ABI_REF_VERSION" ]; then
abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION
if [ ! -d $abirefdir/$conf ]; then
--
2.26.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] devtools: skip ABI check in static builds
2020-04-21 1:33 [dpdk-dev] [PATCH] devtools: skip ABI check in static builds Thomas Monjalon
@ 2020-04-21 6:11 ` Ray Kinsella
2020-04-21 9:15 ` Thomas Monjalon
2020-04-21 8:02 ` David Marchand
1 sibling, 1 reply; 5+ messages in thread
From: Ray Kinsella @ 2020-04-21 6:11 UTC (permalink / raw)
To: Thomas Monjalon, dev; +Cc: david.marchand
On 21/04/2020 02:33, Thomas Monjalon wrote:
> When running make with CONFIG_RTE_BUILD_SHARED_LIB=n,
> no shared library is built.
> In this case, no need to run ABI check.
>
> With meson, both shared and static libraries are always built.
You can easily do the same thing for meson, by checking the 3rd parameter to build() in test-meson-build.sh,
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> devtools/test-build.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> index a298115002..6e53f86fc8 100755
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -262,6 +262,7 @@ for conf in $configs ; do
> EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> O=$(readlink -f $dir)/examples
> unset RTE_TARGET
> + grep -q 'SHARED_LIB=n' $dir/.config || # skip ABI check with static libs
> if [ -n "$DPDK_ABI_REF_VERSION" ]; then
> abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION
> if [ ! -d $abirefdir/$conf ]; then
>
Reviewed-by: Ray Kinsella <mdr@ashroe.eu>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] devtools: skip ABI check in static builds
2020-04-21 6:11 ` Ray Kinsella
@ 2020-04-21 9:15 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2020-04-21 9:15 UTC (permalink / raw)
To: Ray Kinsella; +Cc: dev, david.marchand
21/04/2020 08:11, Ray Kinsella:
>
> On 21/04/2020 02:33, Thomas Monjalon wrote:
> > When running make with CONFIG_RTE_BUILD_SHARED_LIB=n,
> > no shared library is built.
> > In this case, no need to run ABI check.
> >
> > With meson, both shared and static libraries are always built.
>
> You can easily do the same thing for meson, by checking the 3rd parameter to build() in test-meson-build.sh,
No, both library types are always compiled.
The only option is to choose which library to link in built-in apps.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: skip ABI check in static builds
2020-04-21 1:33 [dpdk-dev] [PATCH] devtools: skip ABI check in static builds Thomas Monjalon
2020-04-21 6:11 ` Ray Kinsella
@ 2020-04-21 8:02 ` David Marchand
2020-04-21 9:20 ` Thomas Monjalon
1 sibling, 1 reply; 5+ messages in thread
From: David Marchand @ 2020-04-21 8:02 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Ray Kinsella
On Tue, Apr 21, 2020 at 3:33 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> When running make with CONFIG_RTE_BUILD_SHARED_LIB=n,
> no shared library is built.
> In this case, no need to run ABI check.
>
> With meson, both shared and static libraries are always built.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] devtools: skip ABI check in static builds
2020-04-21 8:02 ` David Marchand
@ 2020-04-21 9:20 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2020-04-21 9:20 UTC (permalink / raw)
To: dev; +Cc: Ray Kinsella, David Marchand
21/04/2020 10:02, David Marchand:
> On Tue, Apr 21, 2020 at 3:33 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > When running make with CONFIG_RTE_BUILD_SHARED_LIB=n,
> > no shared library is built.
> > In this case, no need to run ABI check.
> >
> > With meson, both shared and static libraries are always built.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Acked-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Ray Kinsella <mdr@ashroe.eu>
Applied
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-21 9:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-21 1:33 [dpdk-dev] [PATCH] devtools: skip ABI check in static builds Thomas Monjalon
2020-04-21 6:11 ` Ray Kinsella
2020-04-21 9:15 ` Thomas Monjalon
2020-04-21 8:02 ` David Marchand
2020-04-21 9:20 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).