From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id CC0E2239 for ; Mon, 15 Oct 2018 12:43:31 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5D05821D03; Mon, 15 Oct 2018 06:43:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 15 Oct 2018 06:43:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=PXcv79Eu7Pz4uzEtdr0AZDPoPwN8v69ehvDfY0A1iSE=; b=UvANBli1nkBm NU9ZJ366tLBgDjmbbFPEG+GdCRj0BceMrcEg9MIPMZuMI97eUCXRoBUNTarxRjeq ySJZU0EhfWIFYZiFElVP8WWPb2PIraCLfFFdWZ2fyKdiLZWGmDBmRksQ3Cqjsn5A jkYg9qDXFXkL1AIwT0GOGGaFt103FIU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=PXcv79Eu7Pz4uzEtdr0AZDPoPwN8v69ehvDfY0A1i SE=; b=onhXcsILPWsVZwUm9BpjlCkIsQBqkJNU3492HfmvKKquHSrqC4WydQFEK BK6kR7HlyC8G+esZZXQ0qiB10c7AIjQo6Sa3ZAYLBWKm6biAhRD/30i4EWdUE4vD 5R7kmlmZejdLrjQ3FCeYvyi2uDCz2gIrfmkmlsuBxcj7j8OT2GQwLHKY5I8ZX7Gt SlCu8i6xbgCiMO6GBmuK6QSypuIzgHY6IyY023PwXOMB0K2E/oEqwA+uUJZxS/hP NpjukknYRX9Eb47iBMKwq7FsUcWrPzLzvQl/58wwH0Q+JAltaDlctm7F/Aba84dI lDCNXX27o/WX8q0SzUSX9q+b2w0eQ== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EEBEA102DD; Mon, 15 Oct 2018 06:43:27 -0400 (EDT) From: Thomas Monjalon To: Jeff Guo Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com, arybchenko@solarflare.com, wenzhuo.lu@intel.com, anatoly.burakov@intel.com, jerin.jacob@caviumnetworks.com, jblunck@infradead.org, shreyansh.jain@nxp.com, helin.zhang@intel.com Date: Mon, 15 Oct 2018 12:43:27 +0200 Message-ID: <1818158.EDcYVnFPix@xps> In-Reply-To: <1538664375-22967-7-git-send-email-jia.guo@intel.com> References: <1498711073-42917-1-git-send-email-jia.guo@intel.com> <1538664375-22967-1-git-send-email-jia.guo@intel.com> <1538664375-22967-7-git-send-email-jia.guo@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v14 6/7] eal: add failure handle mechanism for hot-unplug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Oct 2018 10:43:32 -0000 04/10/2018 16:46, Jeff Guo: > --- a/doc/guides/rel_notes/release_18_08.rst > +++ b/doc/guides/rel_notes/release_18_08.rst > @@ -117,6 +117,11 @@ New Features > > Added support for chained mbufs (input and output). > > +* **Added hot-unplug handle mechanism.** > + > + ``rte_dev_hotplug_handle_enable`` and ``rte_dev_hotplug_handle_disable`` are > + for enabling or disabling hotplug handle mechanism. EAL features should be inserted before mbuf features. And more importantly, it should be inserted in 18.11 release notes ;) > --- a/lib/librte_eal/common/eal_private.h > +++ b/lib/librte_eal/common/eal_private.h > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice No need of experimental mark for internal functions. > + * > + * Register the sigbus handler. > + * > + * @return > + * - On success, zero. > + * - On failure, a negative value. > + */ > +int > +rte_dev_sigbus_handler_register(void); > + > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice > + * > + * Unregister the sigbus handler. > + * > + * @return > + * - On success, zero. > + * - On failure, a negative value. > + */ > +int > +rte_dev_sigbus_handler_unregister(void); Why are you using rte_ prefix for private functions?