From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A29DA0548; Thu, 2 Jun 2022 22:52:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E5E740691; Thu, 2 Jun 2022 22:52:32 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 38CA44021E for ; Thu, 2 Jun 2022 22:52:31 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 3092B32007E8; Thu, 2 Jun 2022 16:52:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 02 Jun 2022 16:52:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1654203148; x= 1654289548; bh=NiN+HHhJD/tj+TVWy+sn/8dP7RDnpbmEDT2Br2fJKpM=; b=A r5pQK9mI1HcKoQGjm8h1SPyPKiy+QaMxG2dmQxzWjvqfKBZxBOCVEEt1NbM3DwfO duXLDdF0vpbJVlcT1dDXRnCED9P2pU0ljfb+64hGcJcdThO/v+llyplgFk+YWFOF CEvr47OuxT2R+EDDH8bf8Bojhm+mRyej2xpdAE9bDb2ziByIRmTssiKeo+NNyEgk SL7xnTjQEc4YZT9bKRNbKMqEMwKaOgEnO8O260G1NNdOsMfZK81ABtd8lRWqXYLX XNz/eL76ku4GGRe64hxko29BXf9psNp8PqXoVEcGfID1EqLzLnRgNFJJJS/kiQN6 nNVCYYOX8dSWpt983ukWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1654203148; x= 1654289548; bh=NiN+HHhJD/tj+TVWy+sn/8dP7RDnpbmEDT2Br2fJKpM=; b=h OAr2YPFJfJuwK48r3KM7YOQgyDDxOa4AHSiWulaxbvMna3P4Iz6fufNDCmP14Ata hMZrEexCPM58sx263QU69V7CXKLlTv6vm1/Y7Q5sfr/Y7JSPfo6ly7iBzIC5AukX c6+b6tsyiPLkxYiVRtl1KWLj2R+qb/r84eh128addZhrbfhb5fk2uR00BcBBWb5g E1FRcGBGjDGQxqCNWvHXAjZwNHlr9ICHyux1Ep62HKesu7iJXFEWsvFwPETjYIxx IQnr+wkm0jmlDhRTs/DYzJBsiJd1mC2z3CjErWyJbBQoABXJJZW2jfrKb6jGvHoy vG+B9JPFSNoViFcIsitvg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrleeggddvgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Jun 2022 16:52:27 -0400 (EDT) From: Thomas Monjalon To: Stanislaw Kardach , Stephen Hemminger Cc: Vladimir Medvedkin , dev@dpdk.org, dev@dpdk.org, Frank Zhao , Sam Grove , upstream@semihalf.com Subject: Re: [PATCH v4 1/2] lpm: add const to lpm arg of rte_lpm_lookup Date: Thu, 02 Jun 2022 22:52:25 +0200 Message-ID: <1821120.CQOukoFCf9@thomas> In-Reply-To: <20220601111542.401360-1-kda@semihalf.com> References: <20220601111542.401360-1-kda@semihalf.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 01/06/2022 13:15, Stanislaw Kardach: > All other rte_lpm_lookup* functions take lpm argument as a const. As the > basic rte_lpm_lookup() performs the same function, it should also do > that. > > As this function is inline, no API/ABI change happens. It is an API change and should be noted in the release notes. > static inline int > -rte_lpm_lookup(struct rte_lpm *lpm, uint32_t ip, uint32_t *next_hop) > +rte_lpm_lookup(const struct rte_lpm *lpm, uint32_t ip, uint32_t *next_hop)