From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 0F30F8D86;
 Wed, 25 Apr 2018 18:47:54 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 84F4021C30;
 Wed, 25 Apr 2018 12:47:53 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Wed, 25 Apr 2018 12:47:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=Z74260RhATR4GLuiHGVfn2rG0u
 jL8O+DPhIqAIqO0YQ=; b=r9TvtplYYPoIfdbsBCFWkQMAap/F+B7Mpe6vDsfaXD
 uxX2+lIGeribcyOHDxVY1MbfXze3KzW/tXYR2hwcNxzqbFazTo87kSPh8jpdkY1A
 y02v14irS758i65z4+Mdd5AurrXhtk4HTae7BL2YIHq9raOSSvaZq0V5RY1M8NhM
 k=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Z74260
 RhATR4GLuiHGVfn2rG0ujL8O+DPhIqAIqO0YQ=; b=expEiANGzgghb8pGGkocnQ
 xfz4iHQMLR9cdupDNKhsV1vVGRimL8h3ntuRN0yvLSIVfoketirTu0m/T6VPLHi3
 iXhDSkhrDsh8D5koH1Nz/XYuK1j65XkRyYzPOyuVsFh678h7DFnQopvfl3S2tS1o
 jXawUiJWXoqBG8nEY2gVwh4WFGi4AttAYSKpr6IPVv2Tswo8mQPzjZ1BTidwxkJC
 DlhUqnS0opOOJ4snq9U4SUuRpE7ZLsZXfSa3/ngBfl8q8fhT89Dad8x18YxqdM2n
 64FSYzljbkiGcovXXcKL9KLk6oGpfRSZ8KAV2U+akTNwNa0aKpz0vRzbgAwwInAA
 ==
X-ME-Sender: <xms:ObHgWl_iQpu5N7Fmac4U2Hw1TBEqRiycqUU5Bd5UJ9POHV6QrMU08g>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 959D9E4488;
 Wed, 25 Apr 2018 12:47:52 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ophir Munk <ophirmu@mellanox.com>, Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Pascal Mazon <pascal.mazon@6wind.com>,
 Olga Shern <olgas@mellanox.com>, stable@dpdk.org
Date: Wed, 25 Apr 2018 18:47:51 +0200
Message-ID: <1822119.1fBLbGrzlv@xps>
In-Reply-To: <1524672957-4018-1-git-send-email-ophirmu@mellanox.com>
References: <1524672957-4018-1-git-send-email-ophirmu@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v1] net/tap: return empty port offload
	capabilities
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Apr 2018 16:47:54 -0000

25/04/2018 18:15, Ophir Munk:
> Fix report on port offload capabilities to be 0 (no capabilities).
> Before this commit port capabilities were a clone of queue
> capabilities, however the current TAP offload capabilities (e.g.
> checksum calculation) are per queue and are not specific per port.

I did not follow what is the problem exactly.
But this change looks wrong to me.
Please look at the thread
	"Survey for final decision about per-port offload API"
	http://dpdk.org/ml/archives/dev/2018-March/094459.html
It says:
	"every queue capabilities must be reported as port capabilities"