From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id ED4DD7D34 for ; Wed, 17 Oct 2018 10:18:08 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 94AD721F23; Wed, 17 Oct 2018 04:18:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 17 Oct 2018 04:18:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=J1zVM4Cc01qAT+0vuP2SzAuFWIIr5nnxPXXiMZ5SiM0=; b=fm7hS2Uai8YE 9MUayxJtPtWss2SItjtgHjICppRMwHZ4y8B4VQpxYbR42uugOpJzxiyrpq41/zoN BVSbp5ackxHzFc0EYmLcX3GVlr/ayx+CqdMfCnkX0XwAwTX5QHHPEC5Jr4lyXFkh cqETw3UzwrDD2wwLN/nAWS4xpgPm38k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=J1zVM4Cc01qAT+0vuP2SzAuFWIIr5nnxPXXiMZ5Si M0=; b=ePgUvLfoTLYPy6sahWdKhasWaPbS0KnWLP5bE+2MYk11oABvIuImwtgCD L9yeoYcS+9rZRezDMuQ8zKXi4xFEFqpxlvbx5zV2xk5PjpGp24MulTBw3oT62xQz JqZcjo3uxGFnx5ZCNnX6viFASotK9tA5UkMuJVQV3MIF5oeEQnIzxAK2sFuWd7WE EtlDb0zBGHco/ooEEPqn2n21n0YAsg0kfJ4ly5tUJd11xZFKFssHb8WVTXFL+mQ7 l4Qy1gk7/juqE7QKollomlRUqtSQXb1JojXrfyIFoVeHsZWdKFLG+/zwvlwlKGAx D/Xy/wPGWdytS/OUBV4e2xU28kNOA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 01EF2E4071; Wed, 17 Oct 2018 04:18:06 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org, "ferruh.yigit@intel.com" , "jia.guo@intel.com" , "Jacob, Jerin" , "Bhagavatula, Pavan" Date: Wed, 17 Oct 2018 10:18:09 +0200 Message-ID: <1822592.kQGmlEvfPa@xps> In-Reply-To: <20181017052950.29078-1-jerin.jacob@caviumnetworks.com> References: <20181017052950.29078-1-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] vfio: fix missing header inclusion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 08:18:09 -0000 17/10/2018 07:30, Jerin Jacob: > The following change set introduces HAVE_VFIO_DEV_REQ_INTERFACE > and used in the below files. > > drivers/bus/pci/linux/pci_vfio.c > drivers/bus/pci/pci_common.c > lib/librte_eal/linuxapp/eal/eal_interrupts.c > > However, Except the first file, the change missed to include > where HAVE_VFIO_DEV_REQ_INTERFACE defined. > This creates runtime following error on vfio-pci mode and > kernel >= 4.0.0 combination. > > EAL: [rte_intr_enable] Unknown handle type of fd 95 > EAL: [pci_vfio_enable_notifier]Fail to enable req notifier. > EAL: Fail to unregister req notifier handler. > EAL: Error setting up notifier! > EAL: Requested device 0000:07:00.1 cannot be used > > Fixes: cda94419964f ("vfio: fix build with Linux < 4.0") > > Signed-off-by: Jerin Jacob > Signed-off-by: Pavan Nikhilesh Applied, thanks