From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0081.outbound.protection.outlook.com [104.47.42.81]) by dpdk.org (Postfix) with ESMTP id 5AD10374E for ; Tue, 4 Oct 2016 08:16:03 +0200 (CEST) Received: from DM2PR03CA0005.namprd03.prod.outlook.com (10.141.96.15) by BN6PR03MB2436.namprd03.prod.outlook.com (10.168.223.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.649.16; Tue, 4 Oct 2016 06:16:01 +0000 Received: from BL2FFO11FD046.protection.gbl (2a01:111:f400:7c09::113) by DM2PR03CA0005.outlook.office365.com (2a01:111:e400:2428::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.649.16 via Frontend Transport; Tue, 4 Oct 2016 06:16:01 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD046.mail.protection.outlook.com (10.173.161.208) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.629.5 via Frontend Transport; Tue, 4 Oct 2016 06:16:00 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u946FvJ2009918; Mon, 3 Oct 2016 23:15:57 -0700 To: Thomas Monjalon References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1474375296-26078-1-git-send-email-shreyansh.jain@nxp.com> <1474375296-26078-8-git-send-email-shreyansh.jain@nxp.com> <1868462.9szsyjFR7X@xps13> CC: , , David Marchand , From: Shreyansh Jain Message-ID: <18246d11-46f6-e207-5750-21a1ae289050@nxp.com> Date: Tue, 4 Oct 2016 11:46:54 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1868462.9szsyjFR7X@xps13> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131200353613911755; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(377454003)(199003)(189002)(24454002)(377424004)(8666005)(86362001)(50986999)(76176999)(54356999)(8676002)(189998001)(81166006)(97736004)(31696002)(31686004)(106466001)(81156014)(87936001)(65826007)(11100500001)(305945005)(5660300001)(64126003)(33646002)(626004)(4001350100001)(110136003)(105606002)(356003)(93886004)(2950100002)(23746002)(83506001)(5890100001)(85426001)(36756003)(77096005)(230700001)(104016004)(586003)(68736007)(4326007)(47776003)(92566002)(8936002)(6666003)(65956001)(65806001)(6916009)(50466002)(7846002)(2906002)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2436; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD046; 1:bwjsScR4snf6hQZ8mesX4mjPtgsQFkc4H0Ag/OHZ4FlxGwpL636VZUyDrvVYhbESiGqaeNxJQMPRHKmzHTYN1X9eyss0k+/qS8t7LN9vfAVq6Ix6EN9P75g/6LY/3zsnAUCaUNZjAMypGuB7UunajjTouhd1BNqYt57Vrde48lQrlYT8fbI65fk3wqlDRrnxjDV/vpp+A6+W8HlCjEThAvpV2u9RxdjSMbpeWRZWwEMJNlHXWNtt1DtkjtkyYt2ZFG30lh3jeWpASC1jocizxahPZ7cK1yunLu95BFpMz9EZqKokLVvZ4Izs5JW5XS/HLvX+aFPMAT7GJxacEc61oI42dwiEUnFgtYTvlGddIMXXRnoRNzLCW+K/givgGb7JQ4cDhqixG8q6akuZIjbQ930LIy3YqyT8m9aGAVmmZWI6H3GWIqlAlMj6/nYHzhBergVTzYPOxqetfaBWma5d/W7M11cMIT6TkWPT2hJ/hki5ujMI7HL3/pvWIQMgG5aTBZTORGy4MH27ng9/o9fBFQgdq9tQbkm0saOVhTpt6cSpeAUQtW3daxeZ3kjRrXAMMijUdGPCy3T6/mLjDONz6A== X-MS-Office365-Filtering-Correlation-Id: ac132042-105d-4ce7-b56c-08d3ec1dea04 X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2436; 2:buSPXz0BkFdMhCtn4ujKdazdFKxw38G6W8hXL4Bl0SnAzxVNofRkqAgfeSjT4N8RuPi7cfCQAcvbg7Hs3VY+eKkrMjktoxXbc+s3NSKNi583yCdh0xgCU36zUpQJTTiWPyzcuA5LxgL4tVufNjLEbyqSL/2BU8xi/PtuQX+r/hRXsQsfHUX4fnVFWxeE4DU9KHmMJTyArvxJSeAFXZwjAg==; 3:ZFJLmZY2aK3J5dB4uLtTl/c9xzWnUYjSu8R+Jwihw7zAIrZswhffcwbYxRtHOqudwGWOpY8x1fOgdBfGbM87p6uTNywDZcvyF07sIVzVnoV7SbG3Sb0LQnePl3sD6jx9URzUueLF5oGkPE53lgZ5wlcM8tseUWdi2j09daPDfhH+lzc+XXzVPz54QA7oml6sCd277EJ12QM6QqIuFLEQxbxC1w7uXlvZp6stSClchKHAmro0owxgDwG/55f7oE2z X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR03MB2436; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2436; 25:248Wc+ijFTpRO54H9CBjMY5ugaJKgaH2Tlj58/fYZxNqo27yRCWJebth8f15DvKrZQcEdysCGwr2hcK/oX5YLn9c9YtDWPL45gF7Nn0NYarHy+LsRJGafoa8uZKQrSidN+r7jx4uq15HSFzWCY1tviGPJZAYUzl06jTV+2dccr/mktX3DEbUGLXUlLqXL7fmdh4lyu7VjcSZYWjQY3gCfm4lRSv9CeckDr63a+pS6trRS9GGRPJRMxv0yuUcbxRSogVgC5WbFoOZuaJP8TgjtwlayJLQEWzOXWCaqfzhLIzzYOhOd7KeG1zdvKlPJJRPfyJWBCvVdcB7Qv9oHeEMi1QbRLghC2293rZY7X7qT4VhjEdRxwnNphHauHLQi5WfywEI4OVufCr2upbK8ccpXhf8m4/SIhVjJUu7651D7GC+shUBINHL9VkK4tFR6r+0Pivdtp5PX9FTHXAx3XJw7sxYRE6OjjbH0MpqFTV3Vd2+I69s8hKCXbKdKBTm2+T9nSsC4c/lB9MYt+HUbiWNUrenhoG0//m7hKVqye/zeumAuIkC4bJTAYnY6TScuOtdFTavfb2UunCfIoTOdgUIJyAB+I3N5bggcFgZqyJfRwKrbHhlKTkOipcGAkKKAbrx24V4DYdt6HlGVp53XE3wUmTM9p58h098zGufUkE1s0WxvpKEkNfXWPax5HurB976t3zrehOR2JmjZ+OZ97QRF7JusdwzqfMwvMU03QR2FkT8vDcc59I5vJD3VgcBa7+YvGjBoqx622ZGE5TW8PXoLA== X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2436; 31:xk8vtVicv3TPjvpQ7NKaUc0kbQ74MCvnWXI3gKgwV288mG9K5DiTyxCGT4pbe7W3gIHBXBK+huoOsDHGWU9s83DflOQ47kaWcaeE4si1l4N1FXkSPzrs0xaXmQ2AP53c6KclS1f6SnHnosVW11pwGtR9gJbMXOBoZLxED1YVu5NsQQF7GDXbyO3SEvxCGFH+/Z/hX4jb5fx/h/gXnk+Iar9fVKT2StO5D1I10KCqKdH6JKfKd5Ho5OO5Ld5gAcwt; 4:x6epOR4CtMjwGi66wPLbk3c1akrpiWmm6Ryp/EwUTHkhryfLlRkzwZ4iSifr3T37NmLnCMStU97/OqxCgrZp8LGAGdHbnM0w0QSAo+cgMQcnoU9+2V8zV754b9s+TGigpXonG8TEOYOoO1Td7XOq7cmSRAgt8vyLqHDMQtra2JYaOPoHGTIlxTYEF8HnC9UVFLEuJQk5l8An4z/X2Gdp1UV/atZtIfQCyTr9xkRxCfINj3WsZGa2WkuFPYs/lAN36owW6XE4Mxyi8U2g3qE8FDSg6UB+cu1UD9g0BPevoMdaHKlYYhHNx7J//W+ZrxpbSuwX5eaewnPS9yQVMtWCHBI1TKEVPpxgX8YL/QRlJ+/kmSRJx/pnpkuXxJDIQR7iT1nSO37MyUO4PdweDJCHoDHl2ZoT2dyFWgg6jefJE3ACsvAnZf6er8IBnPvqieL+CSxpjbf/6kKBmwncvJFVO7W0vGO2mIMXhsg1JSl7bt+JrCdYIcPesOtyqroOx0PwlemuNpBV0+izDM+7zL55BQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(13024025)(13017025)(13015025)(13018025)(13023025)(8121501046)(10201501046)(3002001)(6055026); SRVR:BN6PR03MB2436; BCL:0; PCL:0; RULEID:(400006); SRVR:BN6PR03MB2436; X-Forefront-PRVS: 00851CA28B X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN6PR03MB2436; 23:msRQAo7SmIGpSv9kmJSfize5OczGRffXz3sTc?= =?Windows-1252?Q?fbd8T6+HfYLnWIG0+twlttjocSf/Y7Tg+uUnr+EjRK1KND4TLP9edDut?= =?Windows-1252?Q?06u8cmrTC2VoRUM8T8fER0YkH53eHVAFPUKctkQUEQVsN/AZDKfRo66b?= =?Windows-1252?Q?7vlxaC6LEMW04QMUEZwKVdTRuckoYnyYRMPWEhmhGMMOO10aaVlPdBy4?= =?Windows-1252?Q?BF9yW/F+prQ8NY5Q1cdA9sdCAbK1zlVcJHYDrjXKPRoOiPU3/AUO2znJ?= =?Windows-1252?Q?i9SntVwxNl679cTYO0plPi5/FU0JJUdl6gHhA89XIN6zqYUp5+kV/Av7?= =?Windows-1252?Q?HClk5RwytIO/syDubCeI/wJxwLTN+PhbCLjXrJMwa0i3EQpOGoi3V9l2?= =?Windows-1252?Q?kJJGa+T3EazHKq0ZLpE1N1GE585XiNtP6ziAc6mMke6a+iXv7kpF6XaV?= =?Windows-1252?Q?U+cw3w6chDIRPRByFAeqoVBAiQN+ci1PM7rsc7hhi3UJ2uuHYkqKBaeq?= =?Windows-1252?Q?QEGjacFh93TtNCiVA67ysCEERgmO4BC0gWKL0YkptdnWdt+m+ua5/Hfe?= =?Windows-1252?Q?RL+aABqpWYL3VQZd04yPntyxVan7Q6mQJsOPQ6g+CcobIb0NEz7TLjgl?= =?Windows-1252?Q?xJGvw9qdSTNdwFEjmdEes4TeJjU3fOh1KZcVqGFf3PU1p4ZnJ4dOJ4EM?= =?Windows-1252?Q?zFnM9Wu+voL8yU43XSzHPXN2WrZXFFiMgusyP7MlZtEsV+WumsNHAy+G?= =?Windows-1252?Q?jnMCsFKQyx0hoNcuwbdKGA0Tckty7/vYWksyInJAzMbVgPpOEeo8fRF+?= =?Windows-1252?Q?LSnp2hJ2gaUFFKGUSSrCaVmf6Kl5Tnb38mOVbDyijEnvHpdJKfC5D6b1?= =?Windows-1252?Q?YxLuy8YfIG3tqouQxx4pk9sI+UZFxd64Y6seBtEJfiMNnFLDMgBKdE9L?= =?Windows-1252?Q?iT+A8GbdtlbGStDApDKkCFvKxrpgNSg045EYys/lYIdyTwhe5YWKzcTD?= =?Windows-1252?Q?J2uzpkqRMzBXDPAmCdeqT0G6Xk7tIOXL8h0yFevB31p2N7CcsN5spH8I?= =?Windows-1252?Q?wBI9mIQY10uHW/xnBF3OYpQVvZVL7v3MXn3mv/xPGjn8QcNLPwkL8H9o?= =?Windows-1252?Q?zNVInaJ7ODbXt6/XldBbMCx5aNRpg8ZKWlmEaKooLyv+qZdVFjSn24C4?= =?Windows-1252?Q?t8CEgwYOEcY1IrDtHniKgbd9Lj45IOvBZvTR05EovGVkGfT+Z1mbCzRk?= =?Windows-1252?Q?qQxSRvPvfsroLVQa7mzLGdpQOormttc8crMaq9gnkEZ9yFjJM+orE2/U?= =?Windows-1252?Q?alR3mKt/8/gyCUzdb8b88Qu3hyweiUDGhlmnkInhDQgorlHaDz5Lp9qb?= =?Windows-1252?Q?FsujQ+QWYYDeKqMerna5IQQBwolQMmdxmOxny8/wl9pTfRObjYrHIGyh?= =?Windows-1252?Q?JTIpxQ5kW62mQEsUA/9H1k4PTsPPXOmCSnuyNJzw/uy7vzA3kLLPnqVI?= =?Windows-1252?Q?Z0r5UVa3fpMw25KAo2s3R+hgEexjL0M4THEpOXP5GfXDHGsAg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2436; 6:NYxJazFrvHEHofTQmIHUVDFDubUJBq+sbmD6bAHau9IOjQFfjjgEyrKC0WhrpVFtJkw3hTyix6DX1e52WqOdT+hes+fzpRLMwvRAM5d92jDmcniHo2AeY2TuJ75TlqNV2XRwIQ5pl8jXZuQP6bgg+5PUT2NqfWOUOkWODKUH74fDmQb8ebMlm3aLLH+D2PL0qStP6wkhQg41PuxIsHhaB7fgFRa7/CjhxqJY3GYDwdZ/h2bMHKikznTBbrB1/hZDvdDg24haPUMm3AxvaPHhO40YP3LUYNEdjcOazIxrBLwjmBJzuAqqEppfg/pexCEC; 5:vzJekzKXTlRj1zX2kF8sK4o43pwdbojtGTqSC9Js/h1sq7Rp5nQPfm0t1/2n7U2LgMMpCYn4eZgyOimjNxp6WVj3aBB9kGps6Sopf4GCnRh/Z4mO0RQ0aB/eVlgpHpDCxlvc1/FZ/QA2dKeLGB99dBU/GSGylw7NMmsGRgrEo6KrRP9rVi8Ork17KALUb0tA; 24:miAZS2xdWRWuq2EaHxp/jU1GsSlCDsRJ9JdgIsOlTPQzL8T7IeYFG6erI1K2xoWGSJes5EN8Yo/PkLYyEy3rMCRnUXU0PX0TI5muvcSk/0M=; 7:lTsZ8wm/gWTZjBXJOnT6SI1lwu590pA90QflgFmsrZnmsM7U6k/51QwUiIRjdlZYvcqh2XopU7falOKPmBp+PUHdKy1xl70eZF45H+f2PLTcyOEXvSZFxs27xNL+pq5OoD0U2QS+fOEClKHE9ds4OsjmAuUTNlxnRAtE2ysEGzvjhb8rtZGqjbg1r1BNaSNdDJd329SupWXoMStTv3lD21bBf0jL78R+jyUZlvCPJuZvuj6by8CQsY8CFgOO4XZf2QsXXZN+ROZs8Y9+hFV2Qjl9cgO6/zXiNifP9wMKDvbAzsjbOaGhBXhaucPb72FtCPH2xx+Dg0wNCFLop2bx0Q== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2016 06:16:00.9543 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2436 Subject: Re: [dpdk-dev] [PATCH v11 07/24] driver: probe/remove common wrappers for PCI drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Oct 2016 06:16:04 -0000 On Monday 03 October 2016 07:51 PM, Thomas Monjalon wrote: > 2016-09-20 18:11, Shreyansh Jain: >> --- a/lib/librte_ether/rte_ethdev.h >> +++ b/lib/librte_ether/rte_ethdev.h >> @@ -4372,6 +4372,19 @@ rte_eth_dev_get_port_by_name(const char *name, uint8_t *port_id); >> int >> rte_eth_dev_get_name_by_port(uint8_t port_id, char *name); >> >> +/** >> + * Wrapper for use by pci drivers as a .probe function to attach to a ethdev >> + * interface. >> + */ >> +int rte_eth_dev_pci_probe(struct rte_pci_driver *pci_drv, >> + struct rte_pci_device *pci_dev); >> + >> +/** >> + * Wrapper for use by pci drivers as a .remove function to detach a ethdev >> + * interface. >> + */ >> +int rte_eth_dev_pci_remove(struct rte_pci_device *pci_dev); > > These functions are used by the drivers only (as helpers). > So they should be marked @internal (added after applying the patch). > Ok. Thanks! - Shreyansh