From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17F74A04DC; Mon, 19 Oct 2020 16:50:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DD06BE241; Mon, 19 Oct 2020 16:50:37 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5C77DBE39 for ; Mon, 19 Oct 2020 16:50:36 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 08C885C01C7; Mon, 19 Oct 2020 10:50:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 19 Oct 2020 10:50:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 4sUQVv7FNEIqnXJyhajF224g+QcBKZTvep65AYHFzbk=; b=GSz9LsdOzVNxW6QL LaDCqKHSKzidW2KDrcsT0m9NB+RnqJJjQ2gw66/CzBj/YpNM7pGtQhkQyrLmJN0J JTffQay1xKG87snx6kVTvopt/cheiuAIoNzG4NeGHa/fXu23E0ssoO4UuiT+Ba5f XTqwaNJze5iOZ+BCsxRZN582vL8t7V7rLIvXZhpVDavvelTh11nIyvRhjDPfea2W iMj/TzpgG7iJju/SfEIgL0qnhr6C2hM12LAEEnYuHP28z4TVCunEZaiDRc0z6KJZ IOGnJxpxc1EdJD/KLvb6A+tGFgw5O4RQs6p1SF5ZpfnkwU6cIw5qOayrqD+6phos WXSh4Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=4sUQVv7FNEIqnXJyhajF224g+QcBKZTvep65AYHFz bk=; b=iQAmcOiUw8CkD6IuGrpu8x5jrNE4pNuWPrFC/zcQGdrFNFXdAkCm0m2T1 e77jQpC0gp1oXZ1hTwTGG1LIclRPzjHNbmh0U0KdsDKuQOsyMulgL3igYTnukuuq PCpxdz/juxBJRgr7YSuRs0syh1DjyKjRWoXqWQv+uAZfLpmmz90WEWchVzitr80V /LXuDyRBiW3oes/PkN8BtZoUP2cD+TPD46QuJnwlntJBf59hLPhto3J2vOIt7hIs +MWA9hV152b9jlpflIJJO3oJ7QSETwZy3R0f7VObDGwdNlVx77Y9ibeSvKrIdymR nrjlE1S7jGgnuZBMd5w/kr9PruA/w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjedugdekvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 04BB53064684; Mon, 19 Oct 2020 10:50:33 -0400 (EDT) From: Thomas Monjalon To: Kevin Laatz Cc: Ciara Power , dev@dpdk.org, Bruce Richardson Date: Mon, 19 Oct 2020 16:50:32 +0200 Message-ID: <1824984.ILIrlWUcKt@thomas> In-Reply-To: <20201013164539.GH1496@bricha3-MOBL.ger.corp.intel.com> References: <20201013162820.6544-1-ciara.power@intel.com> <20201013164539.GH1496@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] test/telemetry: fix error handling for socket X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/10/2020 18:45, Bruce Richardson: > On Tue, Oct 13, 2020 at 05:28:20PM +0100, Ciara Power wrote: > > When the socket connection failed, an error was printed to screen but > > the function did not return an error, and continued to try read from the > > socket. This is now corrected to close the socket and return -1 when the > > connection fails. > > > > Fixes: bd78cf693ebd ("test/telemetry: add unit tests for data to JSON") > > > > Signed-off-by: Ciara Power > > --- > Acked-by: Bruce Richardson Applied, thanks