From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id CE03A493D;
 Mon,  5 Nov 2018 14:17:32 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 589EE22A63;
 Mon,  5 Nov 2018 08:17:31 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Mon, 05 Nov 2018 08:17:31 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=vv9+/F/COKD5lpdAXEWImpfK9sgbSQreEXeEK3Y0viU=; b=sWKPpuZKFA6W
 dCWX8jJEcuWAjeG6TFFEerXP/l7oxqQzFzKYgi8IIuFp7VS4yo2P7swgYekKh7wz
 mJAsuHnQ995IHQ90NjqjzibzoaSQ9+gw7cq/r1BYjg5IViaYBn0o9jVjkoMKe9nq
 QS59sAEu/y5arFW4O/JwEJxWHYHYL/U=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=vv9+/F/COKD5lpdAXEWImpfK9sgbSQreEXeEK3Y0v
 iU=; b=qfr7qPuBBltcI4I/y+zyOi1gPdF7tr0Wfk8iqJ/lA25LxcRgXc8mCKZZW
 pSDkMhSlrvQR6955VFxIpjbiJzC5q1B6b8J6y7u3GwXHKUA8t7Rfmf0q3trIdGMO
 +CcyW8FE3EWZmWZcwd9PcT18lfXex6jwtDmNJ8zO6NHk/ePxFAZzXZ2fi0hGEvS6
 TxBszwkNPqYthSITBqi4p0QfR2htquJwyEkbCeb2ujsTy0hxUP/tHeH8AWOxlFUJ
 IYejyUjdt7ZOEOniDqZ48vxUeir0YHFW3pzopneefDb/+9RwdZeFlISptMhzJ2ss
 oEKUwhhOGKUyh293fazcp2q87N5Vw==
X-ME-Sender: <xms:6ULgWxd8uKHXG3T83BotCzYnTV-2_X0rJupH_3amzPRprB4dPthUzw>
X-ME-Proxy: <xmx:6kLgW7rtdYzMB2j5XE_F5cTrf6ew-8jov2MJ3WRjODBXyaeP0w-tvQ>
 <xmx:6kLgWxf0CeJJ5_A5A4wXwzvRntF8jDFs1McixSQT0b9I4Mvnlt7eQA>
 <xmx:6kLgW-q7JEIfNmaX5D3JN0caiX3U0tQ8bYXAVZTc8-lKqGNy9lRdDg>
 <xmx:6kLgW7lDW-bWbm0r1D95w7RFqLFYYU2EO-hfjv6O2m_F77mmn1tsbg>
 <xmx:6kLgW_R-6iNhvc-TohJS5bTrzf4f3KNgmykuxFmhdxoS1ne1mU8HmA>
 <xmx:60LgW2n4wMw0BidqF0eIi7MloU09Cgb8ZO6dYrjaRO0VxiwkJ80w5Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 88B0EE49C8;
 Mon,  5 Nov 2018 08:17:28 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Cc: stable@dpdk.org, "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
 Bruce Richardson <bruce.richardson@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>,
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
 "chaozhu@linux.vnet.ibm.com" <chaozhu@linux.vnet.ibm.com>,
 "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
 "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
 nd <nd@arm.com>, hemant.agrawal@nxp.com, shreyansh.jain@nxp.com
Date: Mon, 05 Nov 2018 14:17:27 +0100
Message-ID: <1825633.NNxUzH26Cz@xps>
In-Reply-To: <AM6PR08MB3672943D7FBAB69C5B84EF8398C80@AM6PR08MB3672.eurprd08.prod.outlook.com>
References: <1541066031-29125-1-git-send-email-gavin.hu@arm.com>
 <VI1PR08MB316746F49E356F622E703BB18FC80@VI1PR08MB3167.eurprd08.prod.outlook.com>
 <AM6PR08MB3672943D7FBAB69C5B84EF8398C80@AM6PR08MB3672.eurprd08.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v5 2/2] ring: move the atomic
	load of head above the loop
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Nov 2018 13:17:33 -0000

03/11/2018 10:34, Honnappa Nagarahalli:
> > > > ---
> > > >  doc/guides/rel_notes/release_18_11.rst |  7 +++++++
> > > >  lib/librte_ring/rte_ring_c11_mem.h     | 10 ++++------
> > > >  2 files changed, 11 insertions(+), 6 deletions(-)
> > > >
> > > > diff --git a/doc/guides/rel_notes/release_18_11.rst
> > > > b/doc/guides/rel_notes/release_18_11.rst
> > > > index 376128f..b68afab 100644
> > > > --- a/doc/guides/rel_notes/release_18_11.rst
> > > > +++ b/doc/guides/rel_notes/release_18_11.rst
> > > > @@ -69,6 +69,13 @@ New Features
> > > >    checked out against that dma mask and rejected if out of range.
> > > > If more
> > > than
> > > >    one device has addressing limitations, the dma mask is the more
> > > restricted one.
> > > >
> > > > +* **Updated the ring library with C11 memory model.**
> > > > +
> > > > +  Updated the ring library with C11 memory model, in our tests the
> > > > + changes  decreased latency by 27~29% and 3~15% for MPMC and SPSC
> > > cases respectively.
> > > > +  The real improvements may vary with the number of contending
> > > > + lcores and the  size of ring.
> > > > +
> > > Is this a little misleading, and will users expect massive performance
> > > improvements generally? The C11 model seems to be used only on some,
> > > but not all, arm platforms, and then only with "make" builds.
> > >
> > > config/arm/meson.build: ['RTE_USE_C11_MEM_MODEL', false]]
> This is an error. There is already an agreement that on Arm based platforms, C11 memory model would be used by default. Specific platforms can override it if required.
> Would this be ab acceptable change for RC2 or RC3?

If NXP and Cavium agrees, I think it can go in RC2.
For RC3, not sure.