From: Thomas Monjalon <thomas@monjalon.net>
To: Pallavi Kadam <pallavi.kadam@intel.com>
Cc: dev@dpdk.org, ranjit.menon@intel.com,
Harini.Ramakrishnan@microsoft.com, Narcisa.Vasile@microsoft.com,
dmitry.kozliuk@gmail.com, tbashar@mellanox.com
Subject: Re: [dpdk-dev] [PATCH 2/2] eal: add fnmatch implementation on Windows
Date: Thu, 30 Apr 2020 08:52:35 +0200 [thread overview]
Message-ID: <1826663.L1bRAqqpGC@thomas> (raw)
In-Reply-To: <20200429232427.7112-3-pallavi.kadam@intel.com>
30/04/2020 01:24, Pallavi Kadam:
> Added fnmatch implementation on Windows to support
> log level arguments.
> The source file is with BSD-3-Clause license.
> https://github.com/lattera/freebsd/blob/master/usr.bin/csup/fnmatch.c
Sorry for the naive question, I don't know Windows programming.
Do we really need this external code?
Why RtlIsNameInExpression from Windows cannot be used?
https://docs.microsoft.com/en-us/windows/win32/devnotes/rtlisnameinexpression
next prev parent reply other threads:[~2020-04-30 6:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 23:24 [dpdk-dev] [PATCH 0/2] Windows logging Pallavi Kadam
2020-04-29 23:24 ` [dpdk-dev] [PATCH 1/2] eal: initialize eal logging on Windows Pallavi Kadam
2020-04-29 23:24 ` [dpdk-dev] [PATCH 2/2] eal: add fnmatch implementation " Pallavi Kadam
2020-04-30 6:52 ` Thomas Monjalon [this message]
2020-04-30 7:30 ` Dmitry Kozlyuk
2020-05-01 1:08 ` Ranjit Menon
2020-05-04 16:51 ` Thomas Monjalon
2020-04-30 6:48 ` [dpdk-dev] [PATCH 0/2] Windows logging Thomas Monjalon
2020-04-30 22:18 ` Kadam, Pallavi
2020-05-06 1:30 ` [dpdk-dev] [PATCH v2 " Pallavi Kadam
2020-05-06 1:30 ` [dpdk-dev] [PATCH v2 1/2] eal: add fnmatch implementation Pallavi Kadam
2020-05-06 2:24 ` Narcisa Ana Maria Vasile
2020-05-06 1:30 ` [dpdk-dev] [PATCH v2 2/2] eal: add log support on Windows Pallavi Kadam
2020-05-06 2:20 ` Narcisa Ana Maria Vasile
2020-05-07 10:17 ` Thomas Monjalon
2020-05-07 10:19 ` [dpdk-dev] [PATCH v2 0/2] Windows logging Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1826663.L1bRAqqpGC@thomas \
--to=thomas@monjalon.net \
--cc=Harini.Ramakrishnan@microsoft.com \
--cc=Narcisa.Vasile@microsoft.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=tbashar@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).