From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal devargs: don't call rte_log when not initialized
Date: Mon, 20 Jul 2015 02:59:11 +0200 [thread overview]
Message-ID: <1826981.UI2aTg6Y3s@xps13> (raw)
In-Reply-To: <55630D4B.40708@6wind.com>
> > This problem was discovered when passing invalid PCI id to the
> > blacklist API in devargs.
> >
> > Any failures in rte_devargs_add would cause a core dump because
> > it would call rte_log() before the the EAL log environment was
> > initailized. Rather than try and log just remove the messages
> > and leave it up to the caller to check the return value.
> >
> > Most of the other failure possibilities are when malloc() fails, and if
> > that happens any logging that used malloc() would also fail.
> >
> > This failure was not caught by the standalone tests to devargs
> > because the tests are run after calling rte_eal_init (which is not
> > how devargs is intended to be used).
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
prev parent reply other threads:[~2015-07-20 1:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 16:37 Stephen Hemminger
2015-05-25 11:53 ` Olivier MATZ
2015-07-20 0:59 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1826981.UI2aTg6Y3s@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).