From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id A3C85C35C for ; Mon, 20 Jul 2015 03:00:23 +0200 (CEST) Received: by wibud3 with SMTP id ud3so83734340wib.0 for ; Sun, 19 Jul 2015 18:00:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=C4SO3EUe021JyJMZ7n4PFyDJZHo8OfZDEj+fWG2QGwc=; b=Ha/bJlAEHJDHfHAVT2s6GZCxpNdaoovuS/ze/BEwN3ZPIW5NCSVCAsVos/FPOXX3KI 6dz+yrd/8o/zQ1kTlcNx6MAIiQqp1hePouxadu2aRVMD10Te1Y1kDKN/CcTephspeLyD PSD21Rj8tMQYpkPJtQG5DmWX407KbJqm8/pL8DjgIzTTGW3peq5tw3+WoakU28dTM+hN ynYFBodmu1nAe0iBeamAgtJ5KB5F9pbB+g2haWfjbMbqqL01Nhi4VHDtX2grsSMBYhsF ejS2awUI/Ys+O3YwGZiV5J+i1foMJeWAOZTLATmsz4iJN1M9odbxl1RF8pL3DTWukcU4 3Alw== X-Gm-Message-State: ALoCoQna5tJsrW2foca8lvfizcFxyvqQ2WsL/Wr91aoi1KGLcjd4Ah+fpdjDuHFFONJOdYnn6QN/ X-Received: by 10.180.77.68 with SMTP id q4mr15762543wiw.22.1437354023522; Sun, 19 Jul 2015 18:00:23 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id k2sm9266698wif.4.2015.07.19.18.00.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Jul 2015 18:00:22 -0700 (PDT) From: Thomas Monjalon To: Stephen Hemminger Date: Mon, 20 Jul 2015 02:59:11 +0200 Message-ID: <1826981.UI2aTg6Y3s@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <55630D4B.40708@6wind.com> References: <1431707860-19562-1-git-send-email-stephen@networkplumber.org> <55630D4B.40708@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal devargs: don't call rte_log when not initialized X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2015 01:00:23 -0000 > > This problem was discovered when passing invalid PCI id to the > > blacklist API in devargs. > > > > Any failures in rte_devargs_add would cause a core dump because > > it would call rte_log() before the the EAL log environment was > > initailized. Rather than try and log just remove the messages > > and leave it up to the caller to check the return value. > > > > Most of the other failure possibilities are when malloc() fails, and if > > that happens any logging that used malloc() would also fail. > > > > This failure was not caught by the standalone tests to devargs > > because the tests are run after calling rte_eal_init (which is not > > how devargs is intended to be used). > > > > Signed-off-by: Stephen Hemminger > > Acked-by: Olivier Matz Applied, thanks